From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AD31C433E0 for ; Wed, 27 Jan 2021 23:52:15 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E15A464DD2 for ; Wed, 27 Jan 2021 23:52:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E15A464DD2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4DR0l11DdszDqs8 for ; Thu, 28 Jan 2021 10:52:13 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::52a; helo=mail-pg1-x52a.google.com; envelope-from=npiggin@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20161025 header.b=fGLqz9Us; dkim-atps=neutral Received: from mail-pg1-x52a.google.com (mail-pg1-x52a.google.com [IPv6:2607:f8b0:4864:20::52a]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4DR0hv62rMzDqD1 for ; Thu, 28 Jan 2021 10:50:22 +1100 (AEDT) Received: by mail-pg1-x52a.google.com with SMTP id o16so2896313pgg.5 for ; Wed, 27 Jan 2021 15:50:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:subject:to:cc:references:in-reply-to:mime-version :message-id:content-transfer-encoding; bh=XsErl/cimO7wftOceCRiamL1P72e2kHrMeV9MFjW27g=; b=fGLqz9UsgK9Cr9me5mJkGUUHZ/ke2usuBxuSHXBCSgMAeh8tHZ4FMurwWB5rlSQeDo bemL1e/oAsER36IcSonYKQfzwXrATmHWRNnVyLXNVunMnwmQ/6UkWKx24BjgWPbcs+Sz PRCJ5rJ8HRVTkKeKmnYynuL7P0Z9wyQg0yKdq4ezgecbXb5C18uMVENT0iSAOVQ8DT5e 7sZTGp9nvfjpfwxGqQZbfXbzQLm68F0h7BpVi1d4byqSVDCCP9ahAQXe/AJ7YibeAlkz fhmRVpGnoTfaFtXnX3r7ZaMuY2o56WzZTKzZ3XZOvcNFf1MP+q4xLghbJpi5QIHQfGvS uzZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:subject:to:cc:references:in-reply-to :mime-version:message-id:content-transfer-encoding; bh=XsErl/cimO7wftOceCRiamL1P72e2kHrMeV9MFjW27g=; b=OdNBmYbTFnyJsQ4Hobd89fNn4VEvoZGS7zCc88e4RJf8Q+8J/U3Qk/SQ01XNBXxXpk LzQu3Us8AuBn/yEM1qfCln1TcKAgu7GjBoH9vugl1nn6DuA53gKZC41Y8PFfKJjtfz6i KkPojCI4xWfsR7PnJGabfdWYDxeKray2xSFavjPne/sOrt71R1cuI2XZ+t+puwSdPbJu BvZ1bvYu0FACPF5RnMR9vGqVPCVt+vvD7qsyPup53RYjXKDWA9fEj/J9qxZ496NkOzu8 bjcg3e+6Fi7IgFV0no8KaiDzHiU6/La6juex3nBBdQ+RDhJ/W+21W8Q0/IUaMolLkuKR 42GQ== X-Gm-Message-State: AOAM533rvwwS42s7T3yFJPmD2Bo5oeKUCSQWX/JNcU8sA3M721oVNQrs d7XWK5En3HqsOnKzW/Ba48Q= X-Google-Smtp-Source: ABdhPJzPxvfNcOGRxVoxGRJhNJzeeR6LVj1ni1YjcQZl5ymQxjDeLCfX6QUO6JSQd/lT4PTM1qPt3g== X-Received: by 2002:a63:4764:: with SMTP id w36mr13533232pgk.127.1611791419066; Wed, 27 Jan 2021 15:50:19 -0800 (PST) Received: from localhost (192.156.221.203.dial.dynamic.acc50-nort-cbr.comindico.com.au. [203.221.156.192]) by smtp.gmail.com with ESMTPSA id g22sm3455973pfu.200.2021.01.27.15.50.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Jan 2021 15:50:18 -0800 (PST) Date: Thu, 28 Jan 2021 09:50:12 +1000 From: Nicholas Piggin Subject: RE: [PATCH v4 11/23] powerpc/syscall: Rename syscall_64.c into syscall.c To: Benjamin Herrenschmidt , Christophe Leroy , David Laight , Michael Ellerman , "msuchanek@suse.de" , Paul Mackerras References: <1611656343.yaxha7r2q4.astroid@bobo.none> In-Reply-To: MIME-Version: 1.0 Message-Id: <1611791083.sqnnh21vv0.astroid@bobo.none> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linuxppc-dev@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Excerpts from David Laight's message of January 26, 2021 8:28 pm: > From: Nicholas Piggin >> Sent: 26 January 2021 10:21 >>=20 >> Excerpts from Christophe Leroy's message of January 26, 2021 12:48 am: >> > syscall_64.c will be reused almost as is for PPC32. >> > >> > Rename it syscall.c >>=20 >> Could you rename it to interrupt.c instead? A system call is an >> interrupt, and the file now also has code to return from other >> interrupts as well, and it matches the new asm/interrupt.h from >> the interrupts series. >=20 > Hmmm.... >=20 > That might make it harder for someone looking for the system call > entry code to find it. It's very grep'able. > In some sense interrupts are the simpler case. >=20 > Especially when comparing with other architectures which have > special instructions for syscall entry. powerpc does have a special instruction for syscall, and it causes a system call interrupt. I'm not sure about other architectures, but for powerpc its more=20 sensible to call it interrupt.c than syscall.c. Thanks, Nick From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 519DBC433DB for ; Wed, 27 Jan 2021 23:51:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1C9A364DD2 for ; Wed, 27 Jan 2021 23:51:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232332AbhA0XvF (ORCPT ); Wed, 27 Jan 2021 18:51:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52474 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231959AbhA0Xu7 (ORCPT ); Wed, 27 Jan 2021 18:50:59 -0500 Received: from mail-pg1-x52f.google.com (mail-pg1-x52f.google.com [IPv6:2607:f8b0:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D7FAC061574 for ; Wed, 27 Jan 2021 15:50:19 -0800 (PST) Received: by mail-pg1-x52f.google.com with SMTP id j2so1232806pgl.0 for ; Wed, 27 Jan 2021 15:50:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:subject:to:cc:references:in-reply-to:mime-version :message-id:content-transfer-encoding; bh=XsErl/cimO7wftOceCRiamL1P72e2kHrMeV9MFjW27g=; b=fGLqz9UsgK9Cr9me5mJkGUUHZ/ke2usuBxuSHXBCSgMAeh8tHZ4FMurwWB5rlSQeDo bemL1e/oAsER36IcSonYKQfzwXrATmHWRNnVyLXNVunMnwmQ/6UkWKx24BjgWPbcs+Sz PRCJ5rJ8HRVTkKeKmnYynuL7P0Z9wyQg0yKdq4ezgecbXb5C18uMVENT0iSAOVQ8DT5e 7sZTGp9nvfjpfwxGqQZbfXbzQLm68F0h7BpVi1d4byqSVDCCP9ahAQXe/AJ7YibeAlkz fhmRVpGnoTfaFtXnX3r7ZaMuY2o56WzZTKzZ3XZOvcNFf1MP+q4xLghbJpi5QIHQfGvS uzZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:subject:to:cc:references:in-reply-to :mime-version:message-id:content-transfer-encoding; bh=XsErl/cimO7wftOceCRiamL1P72e2kHrMeV9MFjW27g=; b=BFuesJ863OOAKUXLkdOZ3afQXQqZG+lKkYJdhQGZs8ozFm0bAmGdW6K/JmVSzZCVO7 jAVbnqQ8VkMDh6Qd6QTzKdL5Dyp17AkBlvRus15TKjfADuv/6ZlV8MgEMNyAUTy8+HXG TpLey9P1nOk0YndcXupPaLzl7KScd3bXm+DFTH+LDSKqF9KtS8JLMvG0HUIG5s1OsqRi 9i/xKxrM5Q8EUjZKgX1LZQmqHoA5YUxAFXaS68Jh8asA0OEVMkW5h/fSLC86mGKKI+fz eKektNHf+4d5e9kb5JbG3y0Noa0tQgyn7vqqD4Azuo5EtAPgZ/r9MrIFVNJg3JSbZQS8 FGkQ== X-Gm-Message-State: AOAM530uwdfSOhjnydCnjhgm0tsZJpNwiUforV2RjS3Lb7U58YCn92uO mjb+81LJOzq5avUqlvz1Kx+7ryrHr1Q= X-Google-Smtp-Source: ABdhPJzPxvfNcOGRxVoxGRJhNJzeeR6LVj1ni1YjcQZl5ymQxjDeLCfX6QUO6JSQd/lT4PTM1qPt3g== X-Received: by 2002:a63:4764:: with SMTP id w36mr13533232pgk.127.1611791419066; Wed, 27 Jan 2021 15:50:19 -0800 (PST) Received: from localhost (192.156.221.203.dial.dynamic.acc50-nort-cbr.comindico.com.au. [203.221.156.192]) by smtp.gmail.com with ESMTPSA id g22sm3455973pfu.200.2021.01.27.15.50.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 27 Jan 2021 15:50:18 -0800 (PST) Date: Thu, 28 Jan 2021 09:50:12 +1000 From: Nicholas Piggin Subject: RE: [PATCH v4 11/23] powerpc/syscall: Rename syscall_64.c into syscall.c To: Benjamin Herrenschmidt , Christophe Leroy , David Laight , Michael Ellerman , "msuchanek@suse.de" , Paul Mackerras Cc: "linux-kernel@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" References: <1611656343.yaxha7r2q4.astroid@bobo.none> In-Reply-To: MIME-Version: 1.0 Message-Id: <1611791083.sqnnh21vv0.astroid@bobo.none> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Excerpts from David Laight's message of January 26, 2021 8:28 pm: > From: Nicholas Piggin >> Sent: 26 January 2021 10:21 >>=20 >> Excerpts from Christophe Leroy's message of January 26, 2021 12:48 am: >> > syscall_64.c will be reused almost as is for PPC32. >> > >> > Rename it syscall.c >>=20 >> Could you rename it to interrupt.c instead? A system call is an >> interrupt, and the file now also has code to return from other >> interrupts as well, and it matches the new asm/interrupt.h from >> the interrupts series. >=20 > Hmmm.... >=20 > That might make it harder for someone looking for the system call > entry code to find it. It's very grep'able. > In some sense interrupts are the simpler case. >=20 > Especially when comparing with other architectures which have > special instructions for syscall entry. powerpc does have a special instruction for syscall, and it causes a system call interrupt. I'm not sure about other architectures, but for powerpc its more=20 sensible to call it interrupt.c than syscall.c. Thanks, Nick