From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D7B6C433E0 for ; Thu, 28 Jan 2021 02:44:38 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1E68E64DCE for ; Thu, 28 Jan 2021 02:44:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1E68E64DCE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=9CKb0Gwdh2IEjzfSCJEx0mQre+VOjDK6kkCpa7HwoFs=; b=CtwRsd+WUM3PDR0jE40VEobuy 8HT2jHxtk0kJkPF+KCbGdDGfoHbgv0ZWaNqixeYuz6E/1lneUJBDr2GtbmeHpv/f9HwdTPRd9n7tA JEEF55s4zFby+swmy41jcJyK3CGhjRU6upM7XflA0zWS+UEy3/fUEZlLnTp9F64KRH3ZmQYGZGAL3 1rP56p7pon6lb+zPzb5VNfo3/ZszBgiQhp3XSEx/2QWw6TFMoQ7F+vlAMCGx6F7Lb5WophJGdAPnf 5sgX6AGchlmP+0L/ImWwmytCzZtDftMNjwUPZCNwSL4W7f6OdkDiATD8g/j6RLAkPAS2Hws7J2VaS bkptXsSvA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l4xII-0003MW-Jy; Thu, 28 Jan 2021 02:44:26 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l4xIF-0003M6-1S; Thu, 28 Jan 2021 02:44:24 +0000 X-UUID: a5b7128da6a447ad95dbbbf22ecf5141-20210127 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=Hrx/nCYJR5WH3Pl6k+3Q+wORPFTkAO5RTq4P99NgrxA=; b=lbvhmfrrFtQKFmlept3aAnauUE4S4gw7dCapQBDBkvUU6dl95Ki/2T2oUvCC+YA2q8TrTRkjSEV3qSHLO1EtK8jQq8qJ3w6kiYiTW1iBQlxv0DWYpZ/P5d5Iwv0hRD+Lh9JeJOWXuQeq3LZiHF/+2jgXoFeE4IBbdULCsAO2w/I=; X-UUID: a5b7128da6a447ad95dbbbf22ecf5141-20210127 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1293957535; Wed, 27 Jan 2021 18:44:18 -0800 Received: from MTKMBS07N2.mediatek.inc (172.21.101.141) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 27 Jan 2021 18:44:16 -0800 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 28 Jan 2021 10:44:15 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 28 Jan 2021 10:44:15 +0800 Message-ID: <1611801855.30880.2.camel@mtksdaap41> Subject: Re: [PATCH v4 1/2] dt-bindings: Add DT schema for Arm Mali Valhall GPU From: Nick Fan To: Rob Herring Date: Thu, 28 Jan 2021 10:44:15 +0800 In-Reply-To: <20210114201441.GA3509434@robh.at.kernel.org> References: <20210112064933.12951-1-Nick.Fan@mediatek.com> <20210114201441.GA3509434@robh.at.kernel.org> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210127_214423_381336_5E771B1F X-CRM114-Status: GOOD ( 22.51 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, srv_heupstream@mediatek.com, David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Project_Global_Chrome_Upstream_Group@mediatek.com, linux-mediatek@lists.infradead.org, Daniel Vetter , Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Thanks for your review. These are fixed in v5 as following link. https://lore.kernel.org/patchwork/patch/1372271/ Nick Fan On Thu, 2021-01-14 at 14:14 -0600, Rob Herring wrote: > On Tue, Jan 12, 2021 at 02:49:32PM +0800, Nick Fan wrote: > > Add devicetree schema for Arm Mali Valhall GPU > > > > Define a compatible string for the Mali Valhall GPU > > for Mediatek's SoC platform. > > > > Signed-off-by: Nick Fan > > --- > > .../bindings/gpu/arm,mali-valhall.yaml | 252 ++++++++++++++++++ > > 1 file changed, 252 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/gpu/arm,mali-valhall.yaml > > > > diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-valhall.yaml b/Documentation/devicetree/bindings/gpu/arm,mali-valhall.yaml > > new file mode 100644 > > index 000000000000..ecf249a58435 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/gpu/arm,mali-valhall.yaml > > @@ -0,0 +1,252 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +# Copyright (c) 2020 MediaTek Inc. > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/gpu/arm,mali-valhall.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: ARM Mali Valhall GPU > > + > > +maintainers: > > + - Rob Herring > > + > > +properties: > > + $nodename: > > + pattern: '^gpu@[a-f0-9]+$' > > + > > + compatible: > > + items: > > + - enum: > > + - mediatek,mt8192-mali > > + - const: arm,mali-valhall > > + > > + reg: > > + maxItems: 1 > > + > > + interrupts: > > + items: > > + - description: GPU interrupt > > + - description: MMU interrupt > > + - description: Job interrupt > > + > > + interrupt-names: > > + items: > > + - const: gpu > > + - const: mmu > > + - const: job > > + > > + clocks: > > + minItems: 1 > > + > > + power-domains: > > + minItems: 1 > > + maxItems: 5 > > + > > + mali-supply: true > > + sram-supply: true > > + > > + operating-points-v2: true > > + > > + "#cooling-cells": > > + const: 2 > > + > > +required: > > + - compatible > > + - reg > > + - interrupts > > + - interrupt-names > > + - clocks > > + > > +additionalProperties: false > > + > > +allOf: > > + - if: > > + properties: > > + compatible: > > + contains: > > + const: mediatek,mt8192-mali > > + then: > > + properties: > > + sram-supply: true > > + power-domains: > > + description: > > + List of phandle and PM domain specifier as documented in > > + Documentation/devicetree/bindings/power/power_domain.txt > > + minItems: 5 > > + maxItems: 5 > > + power-domain-names: > > + items: > > + - const: core0 > > + - const: core1 > > + - const: core2 > > + - const: core3 > > + - const: core4 > > + > > + required: > > + - sram-supply > > + - power-domains > > + > > +examples: > > + - | > > + #include > > + #include > > + > > + gpu@13000000 { > > + compatible = "mediatek,mt8192-mali", "arm,mali-valhall"; > > + reg = <0x13000000 0x4000>; > > + interrupts = > > + , > > + , > > + ; > > + interrupt-names = > > + "gpu", > > + "mmu", > > + "job"; > > + > > + clocks = <&mfgcfg 0>; > > + > > + power-domains = > > + <&spm 4>, > > + <&spm 5>, > > + <&spm 6>, > > + <&spm 7>, > > + <&spm 8>; > > + > > + operating-points-v2 = <&gpu_opp_table>; > > + mali-supply = <&mt6315_7_vbuck1>; > > + sram-supply = <&mt6359_vsram_others_ldo_reg>; > > + }; > > + > > + gpu_opp_table: opp_table0 { > > Make this a child node of the gpu node. > > > + compatible = "operating-points-v2"; > > + opp-shared; > > + > > + opp-358000000 { > > + opp-hz = /bits/ 64 <358000000>; > > + opp-hz-real = /bits/ 64 <358000000>, > > + /bits/ 64 <358000000>; > > This is not part of the OPP binding. It's not clear what it's purpose > would be given the values are always the same as opp-hz. > > > > + opp-microvolt = <606250>, > > + <750000>; > > + }; > > + > > + opp-399000000 { > > + opp-hz = /bits/ 64 <399000000>; > > + opp-hz-real = /bits/ 64 <399000000>, > > + /bits/ 64 <399000000>; > > + opp-microvolt = <618750>, > > + <750000>; > > + }; > > + > > + opp-440000000 { > > + opp-hz = /bits/ 64 <440000000>; > > + opp-hz-real = /bits/ 64 <440000000>, > > + /bits/ 64 <440000000>; > > + opp-microvolt = <631250>, > > + <750000>; > > + }; > > + > > + opp-482000000 { > > + opp-hz = /bits/ 64 <482000000>; > > + opp-hz-real = /bits/ 64 <482000000>, > > + /bits/ 64 <482000000>; > > + opp-microvolt = <643750>, > > + <750000>; > > + }; > > + > > + opp-523000000 { > > + opp-hz = /bits/ 64 <523000000>; > > + opp-hz-real = /bits/ 64 <523000000>, > > + /bits/ 64 <523000000>; > > + opp-microvolt = <656250>, > > + <750000>; > > + }; > > + > > + opp-564000000 { > > + opp-hz = /bits/ 64 <564000000>; > > + opp-hz-real = /bits/ 64 <564000000>, > > + /bits/ 64 <564000000>; > > + opp-microvolt = <668750>, > > + <750000>; > > + }; > > + > > + opp-605000000 { > > + opp-hz = /bits/ 64 <605000000>; > > + opp-hz-real = /bits/ 64 <605000000>, > > + /bits/ 64 <605000000>; > > + opp-microvolt = <681250>, > > + <750000>; > > + }; > > + > > + opp-647000000 { > > + opp-hz = /bits/ 64 <647000000>; > > + opp-hz-real = /bits/ 64 <647000000>, > > + /bits/ 64 <647000000>; > > + opp-microvolt = <693750>, > > + <750000>; > > + }; > > + > > + opp-688000000 { > > + opp-hz = /bits/ 64 <688000000>; > > + opp-hz-real = /bits/ 64 <688000000>, > > + /bits/ 64 <688000000>; > > + opp-microvolt = <706250>, > > + <750000>; > > + }; > > + > > + opp-724000000 { > > + opp-hz = /bits/ 64 <724000000>; > > + opp-hz-real = /bits/ 64 <724000000>, > > + /bits/ 64 <724000000>; > > + opp-microvolt = <725000>, > > + <750000>; > > + }; > > + > > + opp-760000000 { > > + opp-hz = /bits/ 64 <760000000>; > > + opp-hz-real = /bits/ 64 <760000000>, > > + /bits/ 64 <760000000>; > > + opp-microvolt = <743750>, > > + <750000>; > > + }; > > + > > + opp-795000000 { > > + opp-hz = /bits/ 64 <795000000>; > > + opp-hz-real = /bits/ 64 <795000000>, > > + /bits/ 64 <795000000>; > > + opp-microvolt = <762500>, > > + <762500>; > > + }; > > + > > + opp-831000000 { > > + opp-hz = /bits/ 64 <831000000>; > > + opp-hz-real = /bits/ 64 <831000000>, > > + /bits/ 64 <831000000>; > > + opp-microvolt = <781250>, > > + <781250>; > > + }; > > + > > + opp-855000000 { > > + opp-hz = /bits/ 64 <855000000>; > > + opp-hz-real = /bits/ 64 <855000000>, > > + /bits/ 64 <855000000>; > > + opp-microvolt = <793750>, > > + <793750>; > > + }; > > + > > + opp-902000000 { > > + opp-hz = /bits/ 64 <902000000>; > > + opp-hz-real = /bits/ 64 <902000000>, > > + /bits/ 64 <902000000>; > > + opp-microvolt = <818750>, > > + <818750>; > > + }; > > + > > + opp-950000000 { > > + opp-hz = /bits/ 64 <950000000>; > > + opp-hz-real = /bits/ 64 <950000000>, > > + /bits/ 64 <950000000>; > > + opp-microvolt = <843750>, > > + <843750>; > > + }; > > + }; > > +... > > -- > > 2.18.0 > > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00805C433DB for ; Thu, 28 Jan 2021 02:45:48 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A723D64DCD for ; Thu, 28 Jan 2021 02:45:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A723D64DCD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5XrZqkKx934QZtuJBmZ1+MDNMnbUbMOhjkPXUYoEANg=; b=RoAN/UUemd9jYr9BWWUAaSJ+4 kjFgHzXddCu+HayIdZImkgP/tIQh48vd6AimDePoipYNeFt2mr5rA388GTFuremrNuLEREpA43aPM k6/N//Cv0Swvaa8o3vTg/jnreYQ4z77Oj96z004IzHJL4mgySxkvLttOd53bU5OV6ktkQWFPphIO7 p7KBTpXAg3cj98wxwiJRHRkiQM3epO9x2AsfouWClWFN9BN4faQ8tql39lj0ntM3R3ypA5dNO2nc3 8PHHB/gT2aJZ8RrkOpO9OP44y8KSMfxvh64D6mVy9FCTpobN0WqSzJ+7SJi7UNbvAzyAmP9LUtgVL 5QJ6dCSag==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l4xIJ-0003Mg-Mj; Thu, 28 Jan 2021 02:44:27 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l4xIF-0003M6-1S; Thu, 28 Jan 2021 02:44:24 +0000 X-UUID: a5b7128da6a447ad95dbbbf22ecf5141-20210127 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=Hrx/nCYJR5WH3Pl6k+3Q+wORPFTkAO5RTq4P99NgrxA=; b=lbvhmfrrFtQKFmlept3aAnauUE4S4gw7dCapQBDBkvUU6dl95Ki/2T2oUvCC+YA2q8TrTRkjSEV3qSHLO1EtK8jQq8qJ3w6kiYiTW1iBQlxv0DWYpZ/P5d5Iwv0hRD+Lh9JeJOWXuQeq3LZiHF/+2jgXoFeE4IBbdULCsAO2w/I=; X-UUID: a5b7128da6a447ad95dbbbf22ecf5141-20210127 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1293957535; Wed, 27 Jan 2021 18:44:18 -0800 Received: from MTKMBS07N2.mediatek.inc (172.21.101.141) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 27 Jan 2021 18:44:16 -0800 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 28 Jan 2021 10:44:15 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 28 Jan 2021 10:44:15 +0800 Message-ID: <1611801855.30880.2.camel@mtksdaap41> Subject: Re: [PATCH v4 1/2] dt-bindings: Add DT schema for Arm Mali Valhall GPU From: Nick Fan To: Rob Herring Date: Thu, 28 Jan 2021 10:44:15 +0800 In-Reply-To: <20210114201441.GA3509434@robh.at.kernel.org> References: <20210112064933.12951-1-Nick.Fan@mediatek.com> <20210114201441.GA3509434@robh.at.kernel.org> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210127_214423_381336_5E771B1F X-CRM114-Status: GOOD ( 22.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, srv_heupstream@mediatek.com, David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Project_Global_Chrome_Upstream_Group@mediatek.com, linux-mediatek@lists.infradead.org, Daniel Vetter , Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Thanks for your review. These are fixed in v5 as following link. https://lore.kernel.org/patchwork/patch/1372271/ Nick Fan On Thu, 2021-01-14 at 14:14 -0600, Rob Herring wrote: > On Tue, Jan 12, 2021 at 02:49:32PM +0800, Nick Fan wrote: > > Add devicetree schema for Arm Mali Valhall GPU > > > > Define a compatible string for the Mali Valhall GPU > > for Mediatek's SoC platform. > > > > Signed-off-by: Nick Fan > > --- > > .../bindings/gpu/arm,mali-valhall.yaml | 252 ++++++++++++++++++ > > 1 file changed, 252 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/gpu/arm,mali-valhall.yaml > > > > diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-valhall.yaml b/Documentation/devicetree/bindings/gpu/arm,mali-valhall.yaml > > new file mode 100644 > > index 000000000000..ecf249a58435 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/gpu/arm,mali-valhall.yaml > > @@ -0,0 +1,252 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +# Copyright (c) 2020 MediaTek Inc. > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/gpu/arm,mali-valhall.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: ARM Mali Valhall GPU > > + > > +maintainers: > > + - Rob Herring > > + > > +properties: > > + $nodename: > > + pattern: '^gpu@[a-f0-9]+$' > > + > > + compatible: > > + items: > > + - enum: > > + - mediatek,mt8192-mali > > + - const: arm,mali-valhall > > + > > + reg: > > + maxItems: 1 > > + > > + interrupts: > > + items: > > + - description: GPU interrupt > > + - description: MMU interrupt > > + - description: Job interrupt > > + > > + interrupt-names: > > + items: > > + - const: gpu > > + - const: mmu > > + - const: job > > + > > + clocks: > > + minItems: 1 > > + > > + power-domains: > > + minItems: 1 > > + maxItems: 5 > > + > > + mali-supply: true > > + sram-supply: true > > + > > + operating-points-v2: true > > + > > + "#cooling-cells": > > + const: 2 > > + > > +required: > > + - compatible > > + - reg > > + - interrupts > > + - interrupt-names > > + - clocks > > + > > +additionalProperties: false > > + > > +allOf: > > + - if: > > + properties: > > + compatible: > > + contains: > > + const: mediatek,mt8192-mali > > + then: > > + properties: > > + sram-supply: true > > + power-domains: > > + description: > > + List of phandle and PM domain specifier as documented in > > + Documentation/devicetree/bindings/power/power_domain.txt > > + minItems: 5 > > + maxItems: 5 > > + power-domain-names: > > + items: > > + - const: core0 > > + - const: core1 > > + - const: core2 > > + - const: core3 > > + - const: core4 > > + > > + required: > > + - sram-supply > > + - power-domains > > + > > +examples: > > + - | > > + #include > > + #include > > + > > + gpu@13000000 { > > + compatible = "mediatek,mt8192-mali", "arm,mali-valhall"; > > + reg = <0x13000000 0x4000>; > > + interrupts = > > + , > > + , > > + ; > > + interrupt-names = > > + "gpu", > > + "mmu", > > + "job"; > > + > > + clocks = <&mfgcfg 0>; > > + > > + power-domains = > > + <&spm 4>, > > + <&spm 5>, > > + <&spm 6>, > > + <&spm 7>, > > + <&spm 8>; > > + > > + operating-points-v2 = <&gpu_opp_table>; > > + mali-supply = <&mt6315_7_vbuck1>; > > + sram-supply = <&mt6359_vsram_others_ldo_reg>; > > + }; > > + > > + gpu_opp_table: opp_table0 { > > Make this a child node of the gpu node. > > > + compatible = "operating-points-v2"; > > + opp-shared; > > + > > + opp-358000000 { > > + opp-hz = /bits/ 64 <358000000>; > > + opp-hz-real = /bits/ 64 <358000000>, > > + /bits/ 64 <358000000>; > > This is not part of the OPP binding. It's not clear what it's purpose > would be given the values are always the same as opp-hz. > > > > + opp-microvolt = <606250>, > > + <750000>; > > + }; > > + > > + opp-399000000 { > > + opp-hz = /bits/ 64 <399000000>; > > + opp-hz-real = /bits/ 64 <399000000>, > > + /bits/ 64 <399000000>; > > + opp-microvolt = <618750>, > > + <750000>; > > + }; > > + > > + opp-440000000 { > > + opp-hz = /bits/ 64 <440000000>; > > + opp-hz-real = /bits/ 64 <440000000>, > > + /bits/ 64 <440000000>; > > + opp-microvolt = <631250>, > > + <750000>; > > + }; > > + > > + opp-482000000 { > > + opp-hz = /bits/ 64 <482000000>; > > + opp-hz-real = /bits/ 64 <482000000>, > > + /bits/ 64 <482000000>; > > + opp-microvolt = <643750>, > > + <750000>; > > + }; > > + > > + opp-523000000 { > > + opp-hz = /bits/ 64 <523000000>; > > + opp-hz-real = /bits/ 64 <523000000>, > > + /bits/ 64 <523000000>; > > + opp-microvolt = <656250>, > > + <750000>; > > + }; > > + > > + opp-564000000 { > > + opp-hz = /bits/ 64 <564000000>; > > + opp-hz-real = /bits/ 64 <564000000>, > > + /bits/ 64 <564000000>; > > + opp-microvolt = <668750>, > > + <750000>; > > + }; > > + > > + opp-605000000 { > > + opp-hz = /bits/ 64 <605000000>; > > + opp-hz-real = /bits/ 64 <605000000>, > > + /bits/ 64 <605000000>; > > + opp-microvolt = <681250>, > > + <750000>; > > + }; > > + > > + opp-647000000 { > > + opp-hz = /bits/ 64 <647000000>; > > + opp-hz-real = /bits/ 64 <647000000>, > > + /bits/ 64 <647000000>; > > + opp-microvolt = <693750>, > > + <750000>; > > + }; > > + > > + opp-688000000 { > > + opp-hz = /bits/ 64 <688000000>; > > + opp-hz-real = /bits/ 64 <688000000>, > > + /bits/ 64 <688000000>; > > + opp-microvolt = <706250>, > > + <750000>; > > + }; > > + > > + opp-724000000 { > > + opp-hz = /bits/ 64 <724000000>; > > + opp-hz-real = /bits/ 64 <724000000>, > > + /bits/ 64 <724000000>; > > + opp-microvolt = <725000>, > > + <750000>; > > + }; > > + > > + opp-760000000 { > > + opp-hz = /bits/ 64 <760000000>; > > + opp-hz-real = /bits/ 64 <760000000>, > > + /bits/ 64 <760000000>; > > + opp-microvolt = <743750>, > > + <750000>; > > + }; > > + > > + opp-795000000 { > > + opp-hz = /bits/ 64 <795000000>; > > + opp-hz-real = /bits/ 64 <795000000>, > > + /bits/ 64 <795000000>; > > + opp-microvolt = <762500>, > > + <762500>; > > + }; > > + > > + opp-831000000 { > > + opp-hz = /bits/ 64 <831000000>; > > + opp-hz-real = /bits/ 64 <831000000>, > > + /bits/ 64 <831000000>; > > + opp-microvolt = <781250>, > > + <781250>; > > + }; > > + > > + opp-855000000 { > > + opp-hz = /bits/ 64 <855000000>; > > + opp-hz-real = /bits/ 64 <855000000>, > > + /bits/ 64 <855000000>; > > + opp-microvolt = <793750>, > > + <793750>; > > + }; > > + > > + opp-902000000 { > > + opp-hz = /bits/ 64 <902000000>; > > + opp-hz-real = /bits/ 64 <902000000>, > > + /bits/ 64 <902000000>; > > + opp-microvolt = <818750>, > > + <818750>; > > + }; > > + > > + opp-950000000 { > > + opp-hz = /bits/ 64 <950000000>; > > + opp-hz-real = /bits/ 64 <950000000>, > > + /bits/ 64 <950000000>; > > + opp-microvolt = <843750>, > > + <843750>; > > + }; > > + }; > > +... > > -- > > 2.18.0 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96C64C433E0 for ; Thu, 28 Jan 2021 02:45:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 561BF64DCE for ; Thu, 28 Jan 2021 02:45:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229692AbhA1CpG (ORCPT ); Wed, 27 Jan 2021 21:45:06 -0500 Received: from mailgw01.mediatek.com ([210.61.82.183]:59865 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S229494AbhA1CpE (ORCPT ); Wed, 27 Jan 2021 21:45:04 -0500 X-UUID: 35c448ea7c614bcba3317a4cc8782bb6-20210128 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=Hrx/nCYJR5WH3Pl6k+3Q+wORPFTkAO5RTq4P99NgrxA=; b=lbvhmfrrFtQKFmlept3aAnauUE4S4gw7dCapQBDBkvUU6dl95Ki/2T2oUvCC+YA2q8TrTRkjSEV3qSHLO1EtK8jQq8qJ3w6kiYiTW1iBQlxv0DWYpZ/P5d5Iwv0hRD+Lh9JeJOWXuQeq3LZiHF/+2jgXoFeE4IBbdULCsAO2w/I=; X-UUID: 35c448ea7c614bcba3317a4cc8782bb6-20210128 Received: from mtkexhb01.mediatek.inc [(172.21.101.102)] by mailgw01.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.14 Build 0819 with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1148803710; Thu, 28 Jan 2021 10:44:16 +0800 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 28 Jan 2021 10:44:15 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 28 Jan 2021 10:44:15 +0800 Message-ID: <1611801855.30880.2.camel@mtksdaap41> Subject: Re: [PATCH v4 1/2] dt-bindings: Add DT schema for Arm Mali Valhall GPU From: Nick Fan To: Rob Herring CC: Matthias Brugger , David Airlie , Daniel Vetter , , , , , , , Date: Thu, 28 Jan 2021 10:44:15 +0800 In-Reply-To: <20210114201441.GA3509434@robh.at.kernel.org> References: <20210112064933.12951-1-Nick.Fan@mediatek.com> <20210114201441.GA3509434@robh.at.kernel.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N Content-Transfer-Encoding: base64 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org VGhhbmtzIGZvciB5b3VyIHJldmlldy4NClRoZXNlIGFyZSBmaXhlZCBpbiB2NSBhcyBmb2xsb3dp bmcgbGluay4NCmh0dHBzOi8vbG9yZS5rZXJuZWwub3JnL3BhdGNod29yay9wYXRjaC8xMzcyMjcx Lw0KDQpOaWNrIEZhbg0KDQpPbiBUaHUsIDIwMjEtMDEtMTQgYXQgMTQ6MTQgLTA2MDAsIFJvYiBI ZXJyaW5nIHdyb3RlOg0KPiBPbiBUdWUsIEphbiAxMiwgMjAyMSBhdCAwMjo0OTozMlBNICswODAw LCBOaWNrIEZhbiB3cm90ZToNCj4gPiBBZGQgZGV2aWNldHJlZSBzY2hlbWEgZm9yIEFybSBNYWxp IFZhbGhhbGwgR1BVDQo+ID4gDQo+ID4gRGVmaW5lIGEgY29tcGF0aWJsZSBzdHJpbmcgZm9yIHRo ZSBNYWxpIFZhbGhhbGwgR1BVDQo+ID4gZm9yIE1lZGlhdGVrJ3MgU29DIHBsYXRmb3JtLg0KPiA+ IA0KPiA+IFNpZ25lZC1vZmYtYnk6IE5pY2sgRmFuIDxOaWNrLkZhbkBtZWRpYXRlay5jb20+DQo+ ID4gLS0tDQo+ID4gIC4uLi9iaW5kaW5ncy9ncHUvYXJtLG1hbGktdmFsaGFsbC55YW1sICAgICAg ICB8IDI1MiArKysrKysrKysrKysrKysrKysNCj4gPiAgMSBmaWxlIGNoYW5nZWQsIDI1MiBpbnNl cnRpb25zKCspDQo+ID4gIGNyZWF0ZSBtb2RlIDEwMDY0NCBEb2N1bWVudGF0aW9uL2RldmljZXRy ZWUvYmluZGluZ3MvZ3B1L2FybSxtYWxpLXZhbGhhbGwueWFtbA0KPiA+IA0KPiA+IGRpZmYgLS1n aXQgYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvZ3B1L2FybSxtYWxpLXZhbGhh bGwueWFtbCBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9ncHUvYXJtLG1hbGkt dmFsaGFsbC55YW1sDQo+ID4gbmV3IGZpbGUgbW9kZSAxMDA2NDQNCj4gPiBpbmRleCAwMDAwMDAw MDAwMDAuLmVjZjI0OWE1ODQzNQ0KPiA+IC0tLSAvZGV2L251bGwNCj4gPiArKysgYi9Eb2N1bWVu dGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvZ3B1L2FybSxtYWxpLXZhbGhhbGwueWFtbA0KPiA+ IEBAIC0wLDAgKzEsMjUyIEBADQo+ID4gKyMgU1BEWC1MaWNlbnNlLUlkZW50aWZpZXI6IChHUEwt Mi4wLW9ubHkgT1IgQlNELTItQ2xhdXNlKQ0KPiA+ICsjIENvcHlyaWdodCAoYykgMjAyMCBNZWRp YVRlayBJbmMuDQo+ID4gKyVZQU1MIDEuMg0KPiA+ICstLS0NCj4gPiArJGlkOiBodHRwOi8vZGV2 aWNldHJlZS5vcmcvc2NoZW1hcy9ncHUvYXJtLG1hbGktdmFsaGFsbC55YW1sIw0KPiA+ICskc2No ZW1hOiBodHRwOi8vZGV2aWNldHJlZS5vcmcvbWV0YS1zY2hlbWFzL2NvcmUueWFtbCMNCj4gPiAr DQo+ID4gK3RpdGxlOiBBUk0gTWFsaSBWYWxoYWxsIEdQVQ0KPiA+ICsNCj4gPiArbWFpbnRhaW5l cnM6DQo+ID4gKyAgLSBSb2IgSGVycmluZyA8cm9iaEBrZXJuZWwub3JnPg0KPiA+ICsNCj4gPiAr cHJvcGVydGllczoNCj4gPiArICAkbm9kZW5hbWU6DQo+ID4gKyAgICBwYXR0ZXJuOiAnXmdwdUBb YS1mMC05XSskJw0KPiA+ICsNCj4gPiArICBjb21wYXRpYmxlOg0KPiA+ICsgICAgaXRlbXM6DQo+ ID4gKyAgICAgIC0gZW51bToNCj4gPiArICAgICAgICAgIC0gbWVkaWF0ZWssbXQ4MTkyLW1hbGkN Cj4gPiArICAgICAgLSBjb25zdDogYXJtLG1hbGktdmFsaGFsbA0KPiA+ICsNCj4gPiArICByZWc6 DQo+ID4gKyAgICBtYXhJdGVtczogMQ0KPiA+ICsNCj4gPiArICBpbnRlcnJ1cHRzOg0KPiA+ICsg ICAgaXRlbXM6DQo+ID4gKyAgICAgIC0gZGVzY3JpcHRpb246IEdQVSBpbnRlcnJ1cHQNCj4gPiAr ICAgICAgLSBkZXNjcmlwdGlvbjogTU1VIGludGVycnVwdA0KPiA+ICsgICAgICAtIGRlc2NyaXB0 aW9uOiBKb2IgaW50ZXJydXB0DQo+ID4gKw0KPiA+ICsgIGludGVycnVwdC1uYW1lczoNCj4gPiAr ICAgIGl0ZW1zOg0KPiA+ICsgICAgICAtIGNvbnN0OiBncHUNCj4gPiArICAgICAgLSBjb25zdDog bW11DQo+ID4gKyAgICAgIC0gY29uc3Q6IGpvYg0KPiA+ICsNCj4gPiArICBjbG9ja3M6DQo+ID4g KyAgICBtaW5JdGVtczogMQ0KPiA+ICsNCj4gPiArICBwb3dlci1kb21haW5zOg0KPiA+ICsgICAg bWluSXRlbXM6IDENCj4gPiArICAgIG1heEl0ZW1zOiA1DQo+ID4gKw0KPiA+ICsgIG1hbGktc3Vw cGx5OiB0cnVlDQo+ID4gKyAgc3JhbS1zdXBwbHk6IHRydWUNCj4gPiArDQo+ID4gKyAgb3BlcmF0 aW5nLXBvaW50cy12MjogdHJ1ZQ0KPiA+ICsNCj4gPiArICAiI2Nvb2xpbmctY2VsbHMiOg0KPiA+ ICsgICAgY29uc3Q6IDINCj4gPiArDQo+ID4gK3JlcXVpcmVkOg0KPiA+ICsgIC0gY29tcGF0aWJs ZQ0KPiA+ICsgIC0gcmVnDQo+ID4gKyAgLSBpbnRlcnJ1cHRzDQo+ID4gKyAgLSBpbnRlcnJ1cHQt bmFtZXMNCj4gPiArICAtIGNsb2Nrcw0KPiA+ICsNCj4gPiArYWRkaXRpb25hbFByb3BlcnRpZXM6 IGZhbHNlDQo+ID4gKw0KPiA+ICthbGxPZjoNCj4gPiArICAtIGlmOg0KPiA+ICsgICAgICBwcm9w ZXJ0aWVzOg0KPiA+ICsgICAgICAgIGNvbXBhdGlibGU6DQo+ID4gKyAgICAgICAgICBjb250YWlu czoNCj4gPiArICAgICAgICAgICAgY29uc3Q6IG1lZGlhdGVrLG10ODE5Mi1tYWxpDQo+ID4gKyAg ICB0aGVuOg0KPiA+ICsgICAgICBwcm9wZXJ0aWVzOg0KPiA+ICsgICAgICAgIHNyYW0tc3VwcGx5 OiB0cnVlDQo+ID4gKyAgICAgICAgcG93ZXItZG9tYWluczoNCj4gPiArICAgICAgICAgIGRlc2Ny aXB0aW9uOg0KPiA+ICsgICAgICAgICAgICBMaXN0IG9mIHBoYW5kbGUgYW5kIFBNIGRvbWFpbiBz cGVjaWZpZXIgYXMgZG9jdW1lbnRlZCBpbg0KPiA+ICsgICAgICAgICAgICBEb2N1bWVudGF0aW9u L2RldmljZXRyZWUvYmluZGluZ3MvcG93ZXIvcG93ZXJfZG9tYWluLnR4dA0KPiA+ICsgICAgICAg ICAgbWluSXRlbXM6IDUNCj4gPiArICAgICAgICAgIG1heEl0ZW1zOiA1DQo+ID4gKyAgICAgICAg cG93ZXItZG9tYWluLW5hbWVzOg0KPiA+ICsgICAgICAgICAgaXRlbXM6DQo+ID4gKyAgICAgICAg ICAgIC0gY29uc3Q6IGNvcmUwDQo+ID4gKyAgICAgICAgICAgIC0gY29uc3Q6IGNvcmUxDQo+ID4g KyAgICAgICAgICAgIC0gY29uc3Q6IGNvcmUyDQo+ID4gKyAgICAgICAgICAgIC0gY29uc3Q6IGNv cmUzDQo+ID4gKyAgICAgICAgICAgIC0gY29uc3Q6IGNvcmU0DQo+ID4gKw0KPiA+ICsgICAgICBy ZXF1aXJlZDoNCj4gPiArICAgICAgICAtIHNyYW0tc3VwcGx5DQo+ID4gKyAgICAgICAgLSBwb3dl ci1kb21haW5zDQo+ID4gKw0KPiA+ICtleGFtcGxlczoNCj4gPiArICAtIHwNCj4gPiArICAgICNp bmNsdWRlIDxkdC1iaW5kaW5ncy9pbnRlcnJ1cHQtY29udHJvbGxlci9pcnEuaD4NCj4gPiArICAg ICNpbmNsdWRlIDxkdC1iaW5kaW5ncy9pbnRlcnJ1cHQtY29udHJvbGxlci9hcm0tZ2ljLmg+DQo+ ID4gKw0KPiA+ICsgICAgZ3B1QDEzMDAwMDAwIHsNCj4gPiArICAgICAgICAgICBjb21wYXRpYmxl ID0gIm1lZGlhdGVrLG10ODE5Mi1tYWxpIiwgImFybSxtYWxpLXZhbGhhbGwiOw0KPiA+ICsgICAg ICAgICAgIHJlZyA9IDwweDEzMDAwMDAwIDB4NDAwMD47DQo+ID4gKyAgICAgICAgICAgaW50ZXJy dXB0cyA9DQo+ID4gKyAgICAgICAgICAgICAgICAgICA8R0lDX1NQSSAzNjMgSVJRX1RZUEVfTEVW RUxfSElHSCAwPiwNCj4gPiArICAgICAgICAgICAgICAgICAgIDxHSUNfU1BJIDM2NCBJUlFfVFlQ RV9MRVZFTF9ISUdIIDA+LA0KPiA+ICsgICAgICAgICAgICAgICAgICAgPEdJQ19TUEkgMzY1IElS UV9UWVBFX0xFVkVMX0hJR0ggMD47DQo+ID4gKyAgICAgICAgICAgaW50ZXJydXB0LW5hbWVzID0N Cj4gPiArICAgICAgICAgICAgICAgICAgICJncHUiLA0KPiA+ICsgICAgICAgICAgICAgICAgICAg Im1tdSIsDQo+ID4gKyAgICAgICAgICAgICAgICAgICAiam9iIjsNCj4gPiArDQo+ID4gKyAgICAg ICAgICAgY2xvY2tzID0gPCZtZmdjZmcgMD47DQo+ID4gKw0KPiA+ICsgICAgICAgICAgIHBvd2Vy LWRvbWFpbnMgPQ0KPiA+ICsgICAgICAgICAgICAgICAgICAgPCZzcG0gND4sDQo+ID4gKyAgICAg ICAgICAgICAgICAgICA8JnNwbSA1PiwNCj4gPiArICAgICAgICAgICAgICAgICAgIDwmc3BtIDY+ LA0KPiA+ICsgICAgICAgICAgICAgICAgICAgPCZzcG0gNz4sDQo+ID4gKyAgICAgICAgICAgICAg ICAgICA8JnNwbSA4PjsNCj4gPiArDQo+ID4gKyAgICAgICAgICAgb3BlcmF0aW5nLXBvaW50cy12 MiA9IDwmZ3B1X29wcF90YWJsZT47DQo+ID4gKyAgICAgICAgICAgbWFsaS1zdXBwbHkgPSA8Jm10 NjMxNV83X3ZidWNrMT47DQo+ID4gKyAgICAgICAgICAgc3JhbS1zdXBwbHkgPSA8Jm10NjM1OV92 c3JhbV9vdGhlcnNfbGRvX3JlZz47DQo+ID4gKyAgICB9Ow0KPiA+ICsNCj4gPiArICAgIGdwdV9v cHBfdGFibGU6IG9wcF90YWJsZTAgew0KPiANCj4gTWFrZSB0aGlzIGEgY2hpbGQgbm9kZSBvZiB0 aGUgZ3B1IG5vZGUuDQo+IA0KPiA+ICsgICAgICBjb21wYXRpYmxlID0gIm9wZXJhdGluZy1wb2lu dHMtdjIiOw0KPiA+ICsgICAgICBvcHAtc2hhcmVkOw0KPiA+ICsNCj4gPiArICAgICAgb3BwLTM1 ODAwMDAwMCB7DQo+ID4gKyAgICAgICAgICAgICAgb3BwLWh6ID0gL2JpdHMvIDY0IDwzNTgwMDAw MDA+Ow0KPiA+ICsgICAgICAgICAgICAgIG9wcC1oei1yZWFsID0gL2JpdHMvIDY0IDwzNTgwMDAw MDA+LA0KPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgL2JpdHMvIDY0IDwzNTgwMDAw MDA+Ow0KPiANCj4gVGhpcyBpcyBub3QgcGFydCBvZiB0aGUgT1BQIGJpbmRpbmcuIEl0J3Mgbm90 IGNsZWFyIHdoYXQgaXQncyBwdXJwb3NlIA0KPiB3b3VsZCBiZSBnaXZlbiB0aGUgdmFsdWVzIGFy ZSBhbHdheXMgdGhlIHNhbWUgYXMgb3BwLWh6Lg0KPiANCj4gDQo+ID4gKyAgICAgICAgICAgICAg b3BwLW1pY3Jvdm9sdCA9IDw2MDYyNTA+LA0KPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICA8NzUwMDAwPjsNCj4gPiArICAgICAgfTsNCj4gPiArDQo+ID4gKyAgICAgIG9wcC0zOTkw MDAwMDAgew0KPiA+ICsgICAgICAgICAgICAgIG9wcC1oeiA9IC9iaXRzLyA2NCA8Mzk5MDAwMDAw PjsNCj4gPiArICAgICAgICAgICAgICBvcHAtaHotcmVhbCA9IC9iaXRzLyA2NCA8Mzk5MDAwMDAw PiwNCj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgIC9iaXRzLyA2NCA8Mzk5MDAwMDAw PjsNCj4gPiArICAgICAgICAgICAgICBvcHAtbWljcm92b2x0ID0gPDYxODc1MD4sDQo+ID4gKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIDw3NTAwMDA+Ow0KPiA+ICsgICAgICB9Ow0KPiA+ ICsNCj4gPiArICAgICAgb3BwLTQ0MDAwMDAwMCB7DQo+ID4gKyAgICAgICAgICAgICAgb3BwLWh6 ID0gL2JpdHMvIDY0IDw0NDAwMDAwMDA+Ow0KPiA+ICsgICAgICAgICAgICAgIG9wcC1oei1yZWFs ID0gL2JpdHMvIDY0IDw0NDAwMDAwMDA+LA0KPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAg ICAgL2JpdHMvIDY0IDw0NDAwMDAwMDA+Ow0KPiA+ICsgICAgICAgICAgICAgIG9wcC1taWNyb3Zv bHQgPSA8NjMxMjUwPiwNCj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgPDc1MDAw MD47DQo+ID4gKyAgICAgIH07DQo+ID4gKw0KPiA+ICsgICAgICBvcHAtNDgyMDAwMDAwIHsNCj4g PiArICAgICAgICAgICAgICBvcHAtaHogPSAvYml0cy8gNjQgPDQ4MjAwMDAwMD47DQo+ID4gKyAg ICAgICAgICAgICAgb3BwLWh6LXJlYWwgPSAvYml0cy8gNjQgPDQ4MjAwMDAwMD4sDQo+ID4gKyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAvYml0cy8gNjQgPDQ4MjAwMDAwMD47DQo+ID4gKyAg ICAgICAgICAgICAgb3BwLW1pY3Jvdm9sdCA9IDw2NDM3NTA+LA0KPiA+ICsgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICA8NzUwMDAwPjsNCj4gPiArICAgICAgfTsNCj4gPiArDQo+ID4gKyAg ICAgIG9wcC01MjMwMDAwMDAgew0KPiA+ICsgICAgICAgICAgICAgIG9wcC1oeiA9IC9iaXRzLyA2 NCA8NTIzMDAwMDAwPjsNCj4gPiArICAgICAgICAgICAgICBvcHAtaHotcmVhbCA9IC9iaXRzLyA2 NCA8NTIzMDAwMDAwPiwNCj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgIC9iaXRzLyA2 NCA8NTIzMDAwMDAwPjsNCj4gPiArICAgICAgICAgICAgICBvcHAtbWljcm92b2x0ID0gPDY1NjI1 MD4sDQo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDw3NTAwMDA+Ow0KPiA+ICsg ICAgICB9Ow0KPiA+ICsNCj4gPiArICAgICAgb3BwLTU2NDAwMDAwMCB7DQo+ID4gKyAgICAgICAg ICAgICAgb3BwLWh6ID0gL2JpdHMvIDY0IDw1NjQwMDAwMDA+Ow0KPiA+ICsgICAgICAgICAgICAg IG9wcC1oei1yZWFsID0gL2JpdHMvIDY0IDw1NjQwMDAwMDA+LA0KPiA+ICsgICAgICAgICAgICAg ICAgICAgICAgICAgICAgL2JpdHMvIDY0IDw1NjQwMDAwMDA+Ow0KPiA+ICsgICAgICAgICAgICAg IG9wcC1taWNyb3ZvbHQgPSA8NjY4NzUwPiwNCj4gPiArICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgPDc1MDAwMD47DQo+ID4gKyAgICAgIH07DQo+ID4gKw0KPiA+ICsgICAgICBvcHAtNjA1 MDAwMDAwIHsNCj4gPiArICAgICAgICAgICAgICBvcHAtaHogPSAvYml0cy8gNjQgPDYwNTAwMDAw MD47DQo+ID4gKyAgICAgICAgICAgICAgb3BwLWh6LXJlYWwgPSAvYml0cy8gNjQgPDYwNTAwMDAw MD4sDQo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAvYml0cy8gNjQgPDYwNTAwMDAw MD47DQo+ID4gKyAgICAgICAgICAgICAgb3BwLW1pY3Jvdm9sdCA9IDw2ODEyNTA+LA0KPiA+ICsg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICA8NzUwMDAwPjsNCj4gPiArICAgICAgfTsNCj4g PiArDQo+ID4gKyAgICAgIG9wcC02NDcwMDAwMDAgew0KPiA+ICsgICAgICAgICAgICAgIG9wcC1o eiA9IC9iaXRzLyA2NCA8NjQ3MDAwMDAwPjsNCj4gPiArICAgICAgICAgICAgICBvcHAtaHotcmVh bCA9IC9iaXRzLyA2NCA8NjQ3MDAwMDAwPiwNCj4gPiArICAgICAgICAgICAgICAgICAgICAgICAg ICAgIC9iaXRzLyA2NCA8NjQ3MDAwMDAwPjsNCj4gPiArICAgICAgICAgICAgICBvcHAtbWljcm92 b2x0ID0gPDY5Mzc1MD4sDQo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIDw3NTAw MDA+Ow0KPiA+ICsgICAgICB9Ow0KPiA+ICsNCj4gPiArICAgICAgb3BwLTY4ODAwMDAwMCB7DQo+ ID4gKyAgICAgICAgICAgICAgb3BwLWh6ID0gL2JpdHMvIDY0IDw2ODgwMDAwMDA+Ow0KPiA+ICsg ICAgICAgICAgICAgIG9wcC1oei1yZWFsID0gL2JpdHMvIDY0IDw2ODgwMDAwMDA+LA0KPiA+ICsg ICAgICAgICAgICAgICAgICAgICAgICAgICAgL2JpdHMvIDY0IDw2ODgwMDAwMDA+Ow0KPiA+ICsg ICAgICAgICAgICAgIG9wcC1taWNyb3ZvbHQgPSA8NzA2MjUwPiwNCj4gPiArICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgPDc1MDAwMD47DQo+ID4gKyAgICAgIH07DQo+ID4gKw0KPiA+ICsg ICAgICBvcHAtNzI0MDAwMDAwIHsNCj4gPiArICAgICAgICAgICAgICBvcHAtaHogPSAvYml0cy8g NjQgPDcyNDAwMDAwMD47DQo+ID4gKyAgICAgICAgICAgICAgb3BwLWh6LXJlYWwgPSAvYml0cy8g NjQgPDcyNDAwMDAwMD4sDQo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAvYml0cy8g NjQgPDcyNDAwMDAwMD47DQo+ID4gKyAgICAgICAgICAgICAgb3BwLW1pY3Jvdm9sdCA9IDw3MjUw MDA+LA0KPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICA8NzUwMDAwPjsNCj4gPiAr ICAgICAgfTsNCj4gPiArDQo+ID4gKyAgICAgIG9wcC03NjAwMDAwMDAgew0KPiA+ICsgICAgICAg ICAgICAgIG9wcC1oeiA9IC9iaXRzLyA2NCA8NzYwMDAwMDAwPjsNCj4gPiArICAgICAgICAgICAg ICBvcHAtaHotcmVhbCA9IC9iaXRzLyA2NCA8NzYwMDAwMDAwPiwNCj4gPiArICAgICAgICAgICAg ICAgICAgICAgICAgICAgIC9iaXRzLyA2NCA8NzYwMDAwMDAwPjsNCj4gPiArICAgICAgICAgICAg ICBvcHAtbWljcm92b2x0ID0gPDc0Mzc1MD4sDQo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIDw3NTAwMDA+Ow0KPiA+ICsgICAgICB9Ow0KPiA+ICsNCj4gPiArICAgICAgb3BwLTc5 NTAwMDAwMCB7DQo+ID4gKyAgICAgICAgICAgICAgb3BwLWh6ID0gL2JpdHMvIDY0IDw3OTUwMDAw MDA+Ow0KPiA+ICsgICAgICAgICAgICAgIG9wcC1oei1yZWFsID0gL2JpdHMvIDY0IDw3OTUwMDAw MDA+LA0KPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgL2JpdHMvIDY0IDw3OTUwMDAw MDA+Ow0KPiA+ICsgICAgICAgICAgICAgIG9wcC1taWNyb3ZvbHQgPSA8NzYyNTAwPiwNCj4gPiAr ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgPDc2MjUwMD47DQo+ID4gKyAgICAgIH07DQo+ ID4gKw0KPiA+ICsgICAgICBvcHAtODMxMDAwMDAwIHsNCj4gPiArICAgICAgICAgICAgICBvcHAt aHogPSAvYml0cy8gNjQgPDgzMTAwMDAwMD47DQo+ID4gKyAgICAgICAgICAgICAgb3BwLWh6LXJl YWwgPSAvYml0cy8gNjQgPDgzMTAwMDAwMD4sDQo+ID4gKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAvYml0cy8gNjQgPDgzMTAwMDAwMD47DQo+ID4gKyAgICAgICAgICAgICAgb3BwLW1pY3Jv dm9sdCA9IDw3ODEyNTA+LA0KPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgICA8Nzgx MjUwPjsNCj4gPiArICAgICAgfTsNCj4gPiArDQo+ID4gKyAgICAgIG9wcC04NTUwMDAwMDAgew0K PiA+ICsgICAgICAgICAgICAgIG9wcC1oeiA9IC9iaXRzLyA2NCA8ODU1MDAwMDAwPjsNCj4gPiAr ICAgICAgICAgICAgICBvcHAtaHotcmVhbCA9IC9iaXRzLyA2NCA8ODU1MDAwMDAwPiwNCj4gPiAr ICAgICAgICAgICAgICAgICAgICAgICAgICAgIC9iaXRzLyA2NCA8ODU1MDAwMDAwPjsNCj4gPiAr ICAgICAgICAgICAgICBvcHAtbWljcm92b2x0ID0gPDc5Mzc1MD4sDQo+ID4gKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIDw3OTM3NTA+Ow0KPiA+ICsgICAgICB9Ow0KPiA+ICsNCj4gPiAr ICAgICAgb3BwLTkwMjAwMDAwMCB7DQo+ID4gKyAgICAgICAgICAgICAgb3BwLWh6ID0gL2JpdHMv IDY0IDw5MDIwMDAwMDA+Ow0KPiA+ICsgICAgICAgICAgICAgIG9wcC1oei1yZWFsID0gL2JpdHMv IDY0IDw5MDIwMDAwMDA+LA0KPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAgL2JpdHMv IDY0IDw5MDIwMDAwMDA+Ow0KPiA+ICsgICAgICAgICAgICAgIG9wcC1taWNyb3ZvbHQgPSA8ODE4 NzUwPiwNCj4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgPDgxODc1MD47DQo+ID4g KyAgICAgIH07DQo+ID4gKw0KPiA+ICsgICAgICBvcHAtOTUwMDAwMDAwIHsNCj4gPiArICAgICAg ICAgICAgICBvcHAtaHogPSAvYml0cy8gNjQgPDk1MDAwMDAwMD47DQo+ID4gKyAgICAgICAgICAg ICAgb3BwLWh6LXJlYWwgPSAvYml0cy8gNjQgPDk1MDAwMDAwMD4sDQo+ID4gKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAvYml0cy8gNjQgPDk1MDAwMDAwMD47DQo+ID4gKyAgICAgICAgICAg ICAgb3BwLW1pY3Jvdm9sdCA9IDw4NDM3NTA+LA0KPiA+ICsgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICA8ODQzNzUwPjsNCj4gPiArICAgICAgfTsNCj4gPiArICAgIH07DQo+ID4gKy4uLg0K PiA+IC0tIA0KPiA+IDIuMTguMA0KPiA+IA0KDQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29183C433E0 for ; Thu, 28 Jan 2021 08:18:17 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CDF5264D9D for ; Thu, 28 Jan 2021 08:18:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CDF5264D9D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 984526E95A; Thu, 28 Jan 2021 08:16:52 +0000 (UTC) Received: from mailgw01.mediatek.com (unknown [210.61.82.183]) by gabe.freedesktop.org (Postfix) with ESMTP id C43E66E32F for ; Thu, 28 Jan 2021 02:44:21 +0000 (UTC) X-UUID: 35c448ea7c614bcba3317a4cc8782bb6-20210128 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=Hrx/nCYJR5WH3Pl6k+3Q+wORPFTkAO5RTq4P99NgrxA=; b=lbvhmfrrFtQKFmlept3aAnauUE4S4gw7dCapQBDBkvUU6dl95Ki/2T2oUvCC+YA2q8TrTRkjSEV3qSHLO1EtK8jQq8qJ3w6kiYiTW1iBQlxv0DWYpZ/P5d5Iwv0hRD+Lh9JeJOWXuQeq3LZiHF/+2jgXoFeE4IBbdULCsAO2w/I=; X-UUID: 35c448ea7c614bcba3317a4cc8782bb6-20210128 Received: from mtkexhb01.mediatek.inc [(172.21.101.102)] by mailgw01.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.14 Build 0819 with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1148803710; Thu, 28 Jan 2021 10:44:16 +0800 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 28 Jan 2021 10:44:15 +0800 Received: from [172.21.77.4] (172.21.77.4) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 28 Jan 2021 10:44:15 +0800 Message-ID: <1611801855.30880.2.camel@mtksdaap41> Subject: Re: [PATCH v4 1/2] dt-bindings: Add DT schema for Arm Mali Valhall GPU From: Nick Fan To: Rob Herring Date: Thu, 28 Jan 2021 10:44:15 +0800 In-Reply-To: <20210114201441.GA3509434@robh.at.kernel.org> References: <20210112064933.12951-1-Nick.Fan@mediatek.com> <20210114201441.GA3509434@robh.at.kernel.org> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-Mailman-Approved-At: Thu, 28 Jan 2021 08:15:36 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, srv_heupstream@mediatek.com, David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Project_Global_Chrome_Upstream_Group@mediatek.com, linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Thanks for your review. These are fixed in v5 as following link. https://lore.kernel.org/patchwork/patch/1372271/ Nick Fan On Thu, 2021-01-14 at 14:14 -0600, Rob Herring wrote: > On Tue, Jan 12, 2021 at 02:49:32PM +0800, Nick Fan wrote: > > Add devicetree schema for Arm Mali Valhall GPU > > > > Define a compatible string for the Mali Valhall GPU > > for Mediatek's SoC platform. > > > > Signed-off-by: Nick Fan > > --- > > .../bindings/gpu/arm,mali-valhall.yaml | 252 ++++++++++++++++++ > > 1 file changed, 252 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/gpu/arm,mali-valhall.yaml > > > > diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-valhall.yaml b/Documentation/devicetree/bindings/gpu/arm,mali-valhall.yaml > > new file mode 100644 > > index 000000000000..ecf249a58435 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/gpu/arm,mali-valhall.yaml > > @@ -0,0 +1,252 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +# Copyright (c) 2020 MediaTek Inc. > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/gpu/arm,mali-valhall.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: ARM Mali Valhall GPU > > + > > +maintainers: > > + - Rob Herring > > + > > +properties: > > + $nodename: > > + pattern: '^gpu@[a-f0-9]+$' > > + > > + compatible: > > + items: > > + - enum: > > + - mediatek,mt8192-mali > > + - const: arm,mali-valhall > > + > > + reg: > > + maxItems: 1 > > + > > + interrupts: > > + items: > > + - description: GPU interrupt > > + - description: MMU interrupt > > + - description: Job interrupt > > + > > + interrupt-names: > > + items: > > + - const: gpu > > + - const: mmu > > + - const: job > > + > > + clocks: > > + minItems: 1 > > + > > + power-domains: > > + minItems: 1 > > + maxItems: 5 > > + > > + mali-supply: true > > + sram-supply: true > > + > > + operating-points-v2: true > > + > > + "#cooling-cells": > > + const: 2 > > + > > +required: > > + - compatible > > + - reg > > + - interrupts > > + - interrupt-names > > + - clocks > > + > > +additionalProperties: false > > + > > +allOf: > > + - if: > > + properties: > > + compatible: > > + contains: > > + const: mediatek,mt8192-mali > > + then: > > + properties: > > + sram-supply: true > > + power-domains: > > + description: > > + List of phandle and PM domain specifier as documented in > > + Documentation/devicetree/bindings/power/power_domain.txt > > + minItems: 5 > > + maxItems: 5 > > + power-domain-names: > > + items: > > + - const: core0 > > + - const: core1 > > + - const: core2 > > + - const: core3 > > + - const: core4 > > + > > + required: > > + - sram-supply > > + - power-domains > > + > > +examples: > > + - | > > + #include > > + #include > > + > > + gpu@13000000 { > > + compatible = "mediatek,mt8192-mali", "arm,mali-valhall"; > > + reg = <0x13000000 0x4000>; > > + interrupts = > > + , > > + , > > + ; > > + interrupt-names = > > + "gpu", > > + "mmu", > > + "job"; > > + > > + clocks = <&mfgcfg 0>; > > + > > + power-domains = > > + <&spm 4>, > > + <&spm 5>, > > + <&spm 6>, > > + <&spm 7>, > > + <&spm 8>; > > + > > + operating-points-v2 = <&gpu_opp_table>; > > + mali-supply = <&mt6315_7_vbuck1>; > > + sram-supply = <&mt6359_vsram_others_ldo_reg>; > > + }; > > + > > + gpu_opp_table: opp_table0 { > > Make this a child node of the gpu node. > > > + compatible = "operating-points-v2"; > > + opp-shared; > > + > > + opp-358000000 { > > + opp-hz = /bits/ 64 <358000000>; > > + opp-hz-real = /bits/ 64 <358000000>, > > + /bits/ 64 <358000000>; > > This is not part of the OPP binding. It's not clear what it's purpose > would be given the values are always the same as opp-hz. > > > > + opp-microvolt = <606250>, > > + <750000>; > > + }; > > + > > + opp-399000000 { > > + opp-hz = /bits/ 64 <399000000>; > > + opp-hz-real = /bits/ 64 <399000000>, > > + /bits/ 64 <399000000>; > > + opp-microvolt = <618750>, > > + <750000>; > > + }; > > + > > + opp-440000000 { > > + opp-hz = /bits/ 64 <440000000>; > > + opp-hz-real = /bits/ 64 <440000000>, > > + /bits/ 64 <440000000>; > > + opp-microvolt = <631250>, > > + <750000>; > > + }; > > + > > + opp-482000000 { > > + opp-hz = /bits/ 64 <482000000>; > > + opp-hz-real = /bits/ 64 <482000000>, > > + /bits/ 64 <482000000>; > > + opp-microvolt = <643750>, > > + <750000>; > > + }; > > + > > + opp-523000000 { > > + opp-hz = /bits/ 64 <523000000>; > > + opp-hz-real = /bits/ 64 <523000000>, > > + /bits/ 64 <523000000>; > > + opp-microvolt = <656250>, > > + <750000>; > > + }; > > + > > + opp-564000000 { > > + opp-hz = /bits/ 64 <564000000>; > > + opp-hz-real = /bits/ 64 <564000000>, > > + /bits/ 64 <564000000>; > > + opp-microvolt = <668750>, > > + <750000>; > > + }; > > + > > + opp-605000000 { > > + opp-hz = /bits/ 64 <605000000>; > > + opp-hz-real = /bits/ 64 <605000000>, > > + /bits/ 64 <605000000>; > > + opp-microvolt = <681250>, > > + <750000>; > > + }; > > + > > + opp-647000000 { > > + opp-hz = /bits/ 64 <647000000>; > > + opp-hz-real = /bits/ 64 <647000000>, > > + /bits/ 64 <647000000>; > > + opp-microvolt = <693750>, > > + <750000>; > > + }; > > + > > + opp-688000000 { > > + opp-hz = /bits/ 64 <688000000>; > > + opp-hz-real = /bits/ 64 <688000000>, > > + /bits/ 64 <688000000>; > > + opp-microvolt = <706250>, > > + <750000>; > > + }; > > + > > + opp-724000000 { > > + opp-hz = /bits/ 64 <724000000>; > > + opp-hz-real = /bits/ 64 <724000000>, > > + /bits/ 64 <724000000>; > > + opp-microvolt = <725000>, > > + <750000>; > > + }; > > + > > + opp-760000000 { > > + opp-hz = /bits/ 64 <760000000>; > > + opp-hz-real = /bits/ 64 <760000000>, > > + /bits/ 64 <760000000>; > > + opp-microvolt = <743750>, > > + <750000>; > > + }; > > + > > + opp-795000000 { > > + opp-hz = /bits/ 64 <795000000>; > > + opp-hz-real = /bits/ 64 <795000000>, > > + /bits/ 64 <795000000>; > > + opp-microvolt = <762500>, > > + <762500>; > > + }; > > + > > + opp-831000000 { > > + opp-hz = /bits/ 64 <831000000>; > > + opp-hz-real = /bits/ 64 <831000000>, > > + /bits/ 64 <831000000>; > > + opp-microvolt = <781250>, > > + <781250>; > > + }; > > + > > + opp-855000000 { > > + opp-hz = /bits/ 64 <855000000>; > > + opp-hz-real = /bits/ 64 <855000000>, > > + /bits/ 64 <855000000>; > > + opp-microvolt = <793750>, > > + <793750>; > > + }; > > + > > + opp-902000000 { > > + opp-hz = /bits/ 64 <902000000>; > > + opp-hz-real = /bits/ 64 <902000000>, > > + /bits/ 64 <902000000>; > > + opp-microvolt = <818750>, > > + <818750>; > > + }; > > + > > + opp-950000000 { > > + opp-hz = /bits/ 64 <950000000>; > > + opp-hz-real = /bits/ 64 <950000000>, > > + /bits/ 64 <950000000>; > > + opp-microvolt = <843750>, > > + <843750>; > > + }; > > + }; > > +... > > -- > > 2.18.0 > > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel