From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31323C433DB for ; Mon, 1 Feb 2021 02:15:06 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DD47664E09 for ; Mon, 1 Feb 2021 02:15:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DD47664E09 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=aVjKBGcjsifRuAzcoFHkzoKVuEQYMBJJQSEfEY6vX+M=; b=EG15bhsWrQiuIEVtbFqSMaZRy Mih+XCFBOmgz5ywh5Vy+2Y7m1fdLl533iNFNTGGXuDmpnjiNLyLQS4v/rT2xDfjM84ZG0gdpcH8sh rhwTWR6rV38bddL/g/Xd2K/GONy9bht4jMhP5yDTxr1lxHaXLAI6KXV7Xnm20wa9TXNbJeWt4VpEJ BpSoLoGydYqLvHCImZayGj06DdVBE2sr6JVpfIhFKYZBqzrd/vbIPeuh6yBUYMG1494SDgkBhVsjs CXoDwZgJi/EGyevrdbUAuJ54NMyeAux6fkWmbI5m8mHzBn7xVVsTHQvOWHppyMhvBX+RV8MCFUSC2 fC52vtfWw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l6Ojw-0005rx-TN; Mon, 01 Feb 2021 02:14:56 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l6Ojt-0005rH-AL; Mon, 01 Feb 2021 02:14:54 +0000 X-UUID: 351e5c4f924d4cd5b2f1793367917246-20210131 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=OSHhhm/W19Y6B56K3//3peDiPN/C9u9TXy7oxQkRT3c=; b=NLcOR43LRgHA4JMi7vPCuN7nzGT6rSZwyFu02vUSY3v0tn1AsILr1d8gm3qp7wEBCHGxANODFtU19dCCLRv06OXJQY9E8CORwl0H0KJW8FdSWD2ibecpqPsmbWpyqrxKF8fP1HmBKJYwnZ+8KLD70xXBbolstipvaskAV0A9ewk=; X-UUID: 351e5c4f924d4cd5b2f1793367917246-20210131 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 941223478; Sun, 31 Jan 2021 18:14:47 -0800 Received: from MTKMBS31N1.mediatek.inc (172.27.4.69) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sun, 31 Jan 2021 18:04:39 -0800 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS31N1.mediatek.inc (172.27.4.69) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 1 Feb 2021 10:04:35 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 1 Feb 2021 10:04:34 +0800 Message-ID: <1612145075.25113.7.camel@mhfsdcap03> Subject: Re: [PATCH v7] usb: xhci-mtk: fix unreleased bandwidth data From: Chunfeng Yun To: Greg Kroah-Hartman Date: Mon, 1 Feb 2021 10:04:35 +0800 In-Reply-To: References: <1611913099-25805-1-git-send-email-chunfeng.yun@mediatek.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 306A99247371E3F7DA2B90EE49997CA49BA06C6C3336BD45278E03C3B49E59BC2000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210131_211453_771023_17533E25 X-CRM114-Status: GOOD ( 20.09 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Zhanyong Wang , Mathias Nyman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Tianping Fang , linux-mediatek@lists.infradead.org, Matthias Brugger , Ikjoon Jang , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Fri, 2021-01-29 at 11:27 +0100, Greg Kroah-Hartman wrote: > On Fri, Jan 29, 2021 at 05:38:19PM +0800, Chunfeng Yun wrote: > > From: Ikjoon Jang > > > > xhci-mtk needs XHCI_MTK_HOST quirk functions in add_endpoint() and > > drop_endpoint() to handle its own sw bandwidth management. > > > > It stores bandwidth data into an internal table every time > > add_endpoint() is called, and drops those in drop_endpoint(). > > But when bandwidth allocation fails at one endpoint, all earlier > > allocation from the same interface could still remain at the table. > > > > This patch moves bandwidth management codes to check_bandwidth() and > > reset_bandwidth() path. To do so, this patch also adds those functions > > to xhci_driver_overrides and lets mtk-xhci to release all failed > > endpoints in reset_bandwidth() path. > > > > Fixes: 08e469de87a2 ("usb: xhci-mtk: supports bandwidth scheduling with multi-TT") > > Signed-off-by: Ikjoon Jang > > Signed-off-by: Chunfeng Yun > > --- > > Changes in v7 from Chunfeng: > > - rename xhci_mtk_droop_ep() as destroy_sch_ep(), and include parameters > > - add member @allocated in mu3h_sch_ep_info struct > > used to skip endpoint not allocated bandwidth > > - use xhci_dbg() instead of dev_dbg() > > - rename bw_ep_list_new as bw_ep_chk_list > > As a previous version of this patch is already in my public tree, just > send a follow-on patch that resolves the issues in the previous one, as > I can not apply this one. Bonus is that you get the credit for fixing > these issues :) Ok, thanks > > thanks, > > greg k-h _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAFE1C433DB for ; Mon, 1 Feb 2021 02:06:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A6CE061492 for ; Mon, 1 Feb 2021 02:06:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231251AbhBACFZ (ORCPT ); Sun, 31 Jan 2021 21:05:25 -0500 Received: from Mailgw01.mediatek.com ([1.203.163.78]:44024 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S231136AbhBACFX (ORCPT ); Sun, 31 Jan 2021 21:05:23 -0500 X-UUID: 711aee05963a44df9965c41cfaf1ebac-20210201 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=OSHhhm/W19Y6B56K3//3peDiPN/C9u9TXy7oxQkRT3c=; b=Y3nSgT7MbMlfgRyVFchUbxD5T5BW8J2m1devVqk39MPyT0/YTKuSQVLZqMgN7+3MEbdLFpSo82J17QvQ7Bl5xavwIQ5MY/kc24VgAI3lOtlKfAFGcA3lwXsLMXTBRNlBz5NIVXN1g/D3rtGNIXKOD9ssFxgzE109jNUUGIB+pIM=; X-UUID: 711aee05963a44df9965c41cfaf1ebac-20210201 Received: from mtkcas32.mediatek.inc [(172.27.4.253)] by mailgw01.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1282575189; Mon, 01 Feb 2021 10:04:39 +0800 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS31N1.mediatek.inc (172.27.4.69) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 1 Feb 2021 10:04:35 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 1 Feb 2021 10:04:34 +0800 Message-ID: <1612145075.25113.7.camel@mhfsdcap03> Subject: Re: [PATCH v7] usb: xhci-mtk: fix unreleased bandwidth data From: Chunfeng Yun To: Greg Kroah-Hartman CC: Mathias Nyman , Ikjoon Jang , Matthias Brugger , , , , , "Zhanyong Wang" , Tianping Fang Date: Mon, 1 Feb 2021 10:04:35 +0800 In-Reply-To: References: <1611913099-25805-1-git-send-email-chunfeng.yun@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 306A99247371E3F7DA2B90EE49997CA49BA06C6C3336BD45278E03C3B49E59BC2000:8 X-MTK: N Content-Transfer-Encoding: base64 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org T24gRnJpLCAyMDIxLTAxLTI5IGF0IDExOjI3ICswMTAwLCBHcmVnIEtyb2FoLUhhcnRtYW4gd3Jv dGU6DQo+IE9uIEZyaSwgSmFuIDI5LCAyMDIxIGF0IDA1OjM4OjE5UE0gKzA4MDAsIENodW5mZW5n IFl1biB3cm90ZToNCj4gPiBGcm9tOiBJa2pvb24gSmFuZyA8aWtqbkBjaHJvbWl1bS5vcmc+DQo+ ID4gDQo+ID4geGhjaS1tdGsgbmVlZHMgWEhDSV9NVEtfSE9TVCBxdWlyayBmdW5jdGlvbnMgaW4g YWRkX2VuZHBvaW50KCkgYW5kDQo+ID4gZHJvcF9lbmRwb2ludCgpIHRvIGhhbmRsZSBpdHMgb3du IHN3IGJhbmR3aWR0aCBtYW5hZ2VtZW50Lg0KPiA+IA0KPiA+IEl0IHN0b3JlcyBiYW5kd2lkdGgg ZGF0YSBpbnRvIGFuIGludGVybmFsIHRhYmxlIGV2ZXJ5IHRpbWUNCj4gPiBhZGRfZW5kcG9pbnQo KSBpcyBjYWxsZWQsIGFuZCBkcm9wcyB0aG9zZSBpbiBkcm9wX2VuZHBvaW50KCkuDQo+ID4gQnV0 IHdoZW4gYmFuZHdpZHRoIGFsbG9jYXRpb24gZmFpbHMgYXQgb25lIGVuZHBvaW50LCBhbGwgZWFy bGllcg0KPiA+IGFsbG9jYXRpb24gZnJvbSB0aGUgc2FtZSBpbnRlcmZhY2UgY291bGQgc3RpbGwg cmVtYWluIGF0IHRoZSB0YWJsZS4NCj4gPiANCj4gPiBUaGlzIHBhdGNoIG1vdmVzIGJhbmR3aWR0 aCBtYW5hZ2VtZW50IGNvZGVzIHRvIGNoZWNrX2JhbmR3aWR0aCgpIGFuZA0KPiA+IHJlc2V0X2Jh bmR3aWR0aCgpIHBhdGguIFRvIGRvIHNvLCB0aGlzIHBhdGNoIGFsc28gYWRkcyB0aG9zZSBmdW5j dGlvbnMNCj4gPiB0byB4aGNpX2RyaXZlcl9vdmVycmlkZXMgYW5kIGxldHMgbXRrLXhoY2kgdG8g cmVsZWFzZSBhbGwgZmFpbGVkDQo+ID4gZW5kcG9pbnRzIGluIHJlc2V0X2JhbmR3aWR0aCgpIHBh dGguDQo+ID4gDQo+ID4gRml4ZXM6IDA4ZTQ2OWRlODdhMiAoInVzYjogeGhjaS1tdGs6IHN1cHBv cnRzIGJhbmR3aWR0aCBzY2hlZHVsaW5nIHdpdGggbXVsdGktVFQiKQ0KPiA+IFNpZ25lZC1vZmYt Ynk6IElram9vbiBKYW5nIDxpa2puQGNocm9taXVtLm9yZz4NCj4gPiBTaWduZWQtb2ZmLWJ5OiBD aHVuZmVuZyBZdW4gPGNodW5mZW5nLnl1bkBtZWRpYXRlay5jb20+DQo+ID4gLS0tDQo+ID4gQ2hh bmdlcyBpbiB2NyBmcm9tIENodW5mZW5nOg0KPiA+IC0gcmVuYW1lIHhoY2lfbXRrX2Ryb29wX2Vw KCkgYXMgZGVzdHJveV9zY2hfZXAoKSwgYW5kIGluY2x1ZGUgcGFyYW1ldGVycw0KPiA+IC0gYWRk IG1lbWJlciBAYWxsb2NhdGVkIGluIG11M2hfc2NoX2VwX2luZm8gc3RydWN0DQo+ID4gICB1c2Vk IHRvIHNraXAgZW5kcG9pbnQgbm90IGFsbG9jYXRlZCBiYW5kd2lkdGgNCj4gPiAtIHVzZSB4aGNp X2RiZygpIGluc3RlYWQgb2YgZGV2X2RiZygpDQo+ID4gLSByZW5hbWUgYndfZXBfbGlzdF9uZXcg YXMgYndfZXBfY2hrX2xpc3QNCj4gDQo+IEFzIGEgcHJldmlvdXMgdmVyc2lvbiBvZiB0aGlzIHBh dGNoIGlzIGFscmVhZHkgaW4gbXkgcHVibGljIHRyZWUsIGp1c3QNCj4gc2VuZCBhIGZvbGxvdy1v biBwYXRjaCB0aGF0IHJlc29sdmVzIHRoZSBpc3N1ZXMgaW4gdGhlIHByZXZpb3VzIG9uZSwgYXMN Cj4gSSBjYW4gbm90IGFwcGx5IHRoaXMgb25lLiAgQm9udXMgaXMgdGhhdCB5b3UgZ2V0IHRoZSBj cmVkaXQgZm9yIGZpeGluZw0KPiB0aGVzZSBpc3N1ZXMgOikNCk9rLCB0aGFua3MNCg0KPiANCj4g dGhhbmtzLA0KPiANCj4gZ3JlZyBrLWgNCg0K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3581C433DB for ; Mon, 1 Feb 2021 02:16:18 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9461D64DE7 for ; Mon, 1 Feb 2021 02:16:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9461D64DE7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=E/+/E4M9cAK17aZQQFp4ALf0+/8uZoVVgeYYLC0x/YM=; b=ZBC5eSbmt9Y2kO+vwifjDrqfR wFcOB0nKQXHYX9+iHfwXNX5l49fxUmOTpR+wOT3t5GDZBgmV+RccrDackvTiaVX6FRt4N/V0bfECv Wk+Mp+35pWdINeeVpTtjKTLPyv2357HUHx2DcOvTfCn9rX8Z8iGY0z4oc1Mfnqjkn7qQ0LD6I+y+j etfgaP9vh99FsCY7XyT8f2M/VzUFZcQuJ11yP932e7gAQ9fw93I47A9E/F9fj+4DDp+vv6c5ATN+D YU2WjP/ualLecgO/4Gl3QZBWpQ5D7+nTXoZFE1GDBWV/OAJUU/7k1HPB6eQ+qsyNKLeoqv82gE2ui M+YVvtwvA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l6Ojv-0005rm-Un; Mon, 01 Feb 2021 02:14:55 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l6Ojt-0005rH-AL; Mon, 01 Feb 2021 02:14:54 +0000 X-UUID: 351e5c4f924d4cd5b2f1793367917246-20210131 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=OSHhhm/W19Y6B56K3//3peDiPN/C9u9TXy7oxQkRT3c=; b=NLcOR43LRgHA4JMi7vPCuN7nzGT6rSZwyFu02vUSY3v0tn1AsILr1d8gm3qp7wEBCHGxANODFtU19dCCLRv06OXJQY9E8CORwl0H0KJW8FdSWD2ibecpqPsmbWpyqrxKF8fP1HmBKJYwnZ+8KLD70xXBbolstipvaskAV0A9ewk=; X-UUID: 351e5c4f924d4cd5b2f1793367917246-20210131 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 941223478; Sun, 31 Jan 2021 18:14:47 -0800 Received: from MTKMBS31N1.mediatek.inc (172.27.4.69) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sun, 31 Jan 2021 18:04:39 -0800 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS31N1.mediatek.inc (172.27.4.69) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 1 Feb 2021 10:04:35 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 1 Feb 2021 10:04:34 +0800 Message-ID: <1612145075.25113.7.camel@mhfsdcap03> Subject: Re: [PATCH v7] usb: xhci-mtk: fix unreleased bandwidth data From: Chunfeng Yun To: Greg Kroah-Hartman Date: Mon, 1 Feb 2021 10:04:35 +0800 In-Reply-To: References: <1611913099-25805-1-git-send-email-chunfeng.yun@mediatek.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 306A99247371E3F7DA2B90EE49997CA49BA06C6C3336BD45278E03C3B49E59BC2000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210131_211453_771023_17533E25 X-CRM114-Status: GOOD ( 20.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Zhanyong Wang , Mathias Nyman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Tianping Fang , linux-mediatek@lists.infradead.org, Matthias Brugger , Ikjoon Jang , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 2021-01-29 at 11:27 +0100, Greg Kroah-Hartman wrote: > On Fri, Jan 29, 2021 at 05:38:19PM +0800, Chunfeng Yun wrote: > > From: Ikjoon Jang > > > > xhci-mtk needs XHCI_MTK_HOST quirk functions in add_endpoint() and > > drop_endpoint() to handle its own sw bandwidth management. > > > > It stores bandwidth data into an internal table every time > > add_endpoint() is called, and drops those in drop_endpoint(). > > But when bandwidth allocation fails at one endpoint, all earlier > > allocation from the same interface could still remain at the table. > > > > This patch moves bandwidth management codes to check_bandwidth() and > > reset_bandwidth() path. To do so, this patch also adds those functions > > to xhci_driver_overrides and lets mtk-xhci to release all failed > > endpoints in reset_bandwidth() path. > > > > Fixes: 08e469de87a2 ("usb: xhci-mtk: supports bandwidth scheduling with multi-TT") > > Signed-off-by: Ikjoon Jang > > Signed-off-by: Chunfeng Yun > > --- > > Changes in v7 from Chunfeng: > > - rename xhci_mtk_droop_ep() as destroy_sch_ep(), and include parameters > > - add member @allocated in mu3h_sch_ep_info struct > > used to skip endpoint not allocated bandwidth > > - use xhci_dbg() instead of dev_dbg() > > - rename bw_ep_list_new as bw_ep_chk_list > > As a previous version of this patch is already in my public tree, just > send a follow-on patch that resolves the issues in the previous one, as > I can not apply this one. Bonus is that you get the credit for fixing > these issues :) Ok, thanks > > thanks, > > greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel