From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B12B5C433DB for ; Sat, 20 Feb 2021 06:27:27 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 462E764E92 for ; Sat, 20 Feb 2021 06:27:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 462E764E92 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=VgLRM9eJKdwv7lRFLDqhhHV848M9jONwjN+usTraYTQ=; b=rXFFpP0u0qQtFxqYfTazXzuJS Vo4C4wNO2AFZ0jGmTE0lVAGvZsfS3Yp1l7O+r98SMBMOFJY0q6NeaLhvf2mLAdslGwRGNyW9wY1Vl 5t5k1t7cX5maqDAu2uImrlNwXJmV2XYFw1ROlRbPqlXzT2ZgGtxO3yUKn0l4XUOqpoAIhP3a+c2Yy in+m/OldJqPP3XSR30JNNYYbRdUHA5VUkMqgShP81ZYaAYNNRFfwMg1w1iy1r/sTAM2+in0ZFdVXO vPGjkxPYUStSwkdQsBuy5MV/lHbfH2R9OgO8un+Wo15WmB+vsZUHvKN3jNT20rdLoFLtEyEhukTPu f63+DaVcQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lDLjQ-0005kL-3D; Sat, 20 Feb 2021 06:27:08 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lDLjN-0005jP-Dx; Sat, 20 Feb 2021 06:27:06 +0000 X-UUID: 4ab33aacd5444e20abc0cb42abee142a-20210219 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=Hs3QMCbKs3lYerCS7naNEnRZUcwiVA4lX5e20BGW6G4=; b=kkNvoaBCDAk2lPtMISb+oAm+4P/2+giys+pBzVdfsU16+zJn2IDbm333XAFK0V359Zln7eVFkLiyyZ9yRtopYW9/E91qBXgV6yPrVRs/049HFmYyn/rAn/dZVqWnkdp3lMYRE8pB5zFTg4HB1W0GEzS/CzOkemqDYDyEboUMvZI=; X-UUID: 4ab33aacd5444e20abc0cb42abee142a-20210219 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 372304601; Fri, 19 Feb 2021 22:26:58 -0800 Received: from MTKMBS31N1.mediatek.inc (172.27.4.69) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 19 Feb 2021 22:26:56 -0800 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS31N1.mediatek.inc (172.27.4.69) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sat, 20 Feb 2021 14:26:44 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Sat, 20 Feb 2021 14:26:43 +0800 Message-ID: <1613802403.896.3.camel@mhfsdcap03> Subject: Re: [PATCH 1/3] dt-bindings: media: mtk-vcodec: Separating mtk vcodec encoder node From: Irui Wang To: Alexandre Courbot Date: Sat, 20 Feb 2021 14:26:43 +0800 In-Reply-To: References: <20210121061804.26423-1-irui.wang@mediatek.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 720A18DC9132338BE8BA18B4DE8632099806799CD4E7EA48D9B032C45BD5ADD62000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210220_012705_628267_EF893355 X-CRM114-Status: GOOD ( 26.89 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Maoguang Meng , Andrew-CT Chen , Tiffany Lin , srv_heupstream@mediatek.com, Tomasz Figa , Yunfei Dong , Longfei Wang , LKML , Matthias Brugger , devicetree , Rob Herring , "moderated list:ARM/Mediatek SoC support" , Hsin-Yi Wang , Hans Verkuil , Mauro Carvalho Chehab , "moderated list:ARM/Mediatek SoC support" , Linux Media Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Wed, 2021-02-03 at 19:44 +0900, Alexandre Courbot wrote: > On Thu, Jan 21, 2021 at 3:18 PM Irui Wang wrote: > > > > Updates binding document since the avc and vp8 hardware encoder in > > MT8173 are now separated. Separate "mediatek,mt8173-vcodec-enc" to > > "mediatek,mt8173-vcodec-vp8-enc" and "mediatek,mt8173-vcodec-avc-enc". > > > > Signed-off-by: Hsin-Yi Wang > > Signed-off-by: Maoguang Meng > > Signed-off-by: Irui Wang > > > > --- > > .../bindings/media/mediatek-vcodec.txt | 58 ++++++++++--------- > > 1 file changed, 31 insertions(+), 27 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/media/mediatek-vcodec.txt b/Documentation/devicetree/bindings/media/mediatek-vcodec.txt > > index 8217424fd4bd..f85276e629bf 100644 > > --- a/Documentation/devicetree/bindings/media/mediatek-vcodec.txt > > +++ b/Documentation/devicetree/bindings/media/mediatek-vcodec.txt > > @@ -4,7 +4,9 @@ Mediatek Video Codec is the video codec hw present in Mediatek SoCs which > > supports high resolution encoding and decoding functionalities. > > > > Required properties: > > -- compatible : "mediatek,mt8173-vcodec-enc" for MT8173 encoder > > +- compatible : must be one of the following string: > > + "mediatek,mt8173-vcodec-vp8-enc" for mt8173 vp8 encoder. > > + "mediatek,mt8173-vcodec-avc-enc" for mt8173 avc encoder. > > IMHO "mediatek,mt8173-vcodec-enc-vp8" and > "mediatek,mt8173-vcodec-enc-avc" would be more logical. Also to keep a > bit of backward compatibility, shall we also allow > "mediatek,mt8173-vcodec-enc" to be an alias for > "mediatek,mt8173-vcodec-enc-avc"? The line above would become > > "mediatek,mt8173-vcodec-enc-avc" or "mediatek,mt8173-vcodec-enc" for > mt8173 avc encoder. > will be updated in the next version. > > "mediatek,mt8183-vcodec-enc" for MT8183 encoder. > > "mediatek,mt8173-vcodec-dec" for MT8173 decoder. > > - reg : Physical base address of the video codec registers and length of > > @@ -13,10 +15,11 @@ Required properties: > > - mediatek,larb : must contain the local arbiters in the current Socs. > > - clocks : list of clock specifiers, corresponding to entries in > > the clock-names property. > > -- clock-names: encoder must contain "venc_sel_src", "venc_sel",, > > - "venc_lt_sel_src", "venc_lt_sel", decoder must contain "vcodecpll", > > - "univpll_d2", "clk_cci400_sel", "vdec_sel", "vdecpll", "vencpll", > > - "venc_lt_sel", "vdec_bus_clk_src". > > +- clock-names: > > + avc venc must contain "venc_sel"; > > + vp8 venc must contain "venc_lt_sel"; > > Can't we use "venc_sel" for both avc and vp8, since they are different > nodes now? That way we can just say > > encoder must contain "venc_sel" > > which is clearer and also simpler on the code side. > ditto > > + decoder must contain "vcodecpll", "univpll_d2", "clk_cci400_sel", > > + "vdec_sel", "vdecpll", "vencpll", "venc_lt_sel", "vdec_bus_clk_src". > > - iommus : should point to the respective IOMMU block with master port as > > argument, see Documentation/devicetree/bindings/iommu/mediatek,iommu.txt > > for details. > > @@ -80,14 +83,10 @@ vcodec_dec: vcodec@16000000 { > > assigned-clock-rates = <0>, <0>, <0>, <1482000000>, <800000000>; > > }; > > > > - vcodec_enc: vcodec@18002000 { > > - compatible = "mediatek,mt8173-vcodec-enc"; > > - reg = <0 0x18002000 0 0x1000>, /*VENC_SYS*/ > > - <0 0x19002000 0 0x1000>; /*VENC_LT_SYS*/ > > - interrupts = , > > - ; > > - mediatek,larb = <&larb3>, > > - <&larb5>; > > +vcodec_enc: vcodec@18002000 { > > Let's use vcodec_enc_avc as a label? ditto > > > + compatible = "mediatek,mt8173-vcodec-avc-enc"; > > + reg = <0 0x18002000 0 0x1000>; > > + interrupts = ; > > iommus = <&iommu M4U_PORT_VENC_RCPU>, > > <&iommu M4U_PORT_VENC_REC>, > > <&iommu M4U_PORT_VENC_BSDMA>, > > @@ -98,8 +97,20 @@ vcodec_dec: vcodec@16000000 { > > <&iommu M4U_PORT_VENC_REF_LUMA>, > > <&iommu M4U_PORT_VENC_REF_CHROMA>, > > <&iommu M4U_PORT_VENC_NBM_RDMA>, > > - <&iommu M4U_PORT_VENC_NBM_WDMA>, > > - <&iommu M4U_PORT_VENC_RCPU_SET2>, > > + <&iommu M4U_PORT_VENC_NBM_WDMA>; > > + mediatek,larb = <&larb3>; > > + mediatek,vpu = <&vpu>; > > + clocks = <&topckgen CLK_TOP_VENC_SEL>; > > + clock-names = "venc_sel"; > > + assigned-clocks = <&topckgen CLK_TOP_VENC_SEL>; > > + assigned-clock-parents = <&topckgen CLK_TOP_VCODECPLL>; > > + }; > > + > > +vcodec_enc_lt: vcodec@19002000 { > > And here the label should probably be "vcodec_enc_vp8" for consistency. ditto > > > > > + compatible = "mediatek,mt8173-vcodec-vp8-enc"; > > + reg = <0 0x19002000 0 0x1000>; /* VENC_LT_SYS */ > > + interrupts = ; > > + iommus = <&iommu M4U_PORT_VENC_RCPU_SET2>, > > <&iommu M4U_PORT_VENC_REC_FRM_SET2>, > > <&iommu M4U_PORT_VENC_BSDMA_SET2>, > > <&iommu M4U_PORT_VENC_SV_COMA_SET2>, > > @@ -108,17 +119,10 @@ vcodec_dec: vcodec@16000000 { > > <&iommu M4U_PORT_VENC_CUR_CHROMA_SET2>, > > <&iommu M4U_PORT_VENC_REF_LUMA_SET2>, > > <&iommu M4U_PORT_VENC_REC_CHROMA_SET2>; > > + mediatek,larb = <&larb5>; > > mediatek,vpu = <&vpu>; > > - clocks = <&topckgen CLK_TOP_VENCPLL_D2>, > > - <&topckgen CLK_TOP_VENC_SEL>, > > - <&topckgen CLK_TOP_UNIVPLL1_D2>, > > - <&topckgen CLK_TOP_VENC_LT_SEL>; > > - clock-names = "venc_sel_src", > > - "venc_sel", > > - "venc_lt_sel_src", > > - "venc_lt_sel"; > > - assigned-clocks = <&topckgen CLK_TOP_VENC_SEL>, > > - <&topckgen CLK_TOP_VENC_LT_SEL>; > > - assigned-clock-parents = <&topckgen CLK_TOP_VENCPLL_D2>, > > - <&topckgen CLK_TOP_UNIVPLL1_D2>; > > + clocks = <&topckgen CLK_TOP_VENC_LT_SEL>; > > + clock-names = "venc_lt_sel"; > > + assigned-clocks = <&topckgen CLK_TOP_VENC_LT_SEL>; > > + assigned-clock-parents = <&topckgen CLK_TOP_VCODECPLL_370P5>; > > }; > > -- > > 2.18.0 > > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20B7CC433E0 for ; Sat, 20 Feb 2021 06:29:08 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AB8F064E92 for ; Sat, 20 Feb 2021 06:29:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AB8F064E92 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zaHPXREz8K8gmXPOdmT9cz9CrUYHOpRtc1KchXlxz1A=; b=TdNQgNYmK07UHNnwIqjKXfI6x Y/lxIIhbur0fZrYxw5kE+oWkBzU/JrmqrNPxPdoF+P8amHZoRp3IiNHUQBktjqoZxVfJsXAJGmEne bxO6CJNvdjwtwqQFQfWguucAtG8qVrktzg/JfNAuMeyfI9Q4ITPD5deqh/TEs5N70mPpOZF7B4D/9 GDZ4mzkhb5w9kJ6SISr09nlVcH3U5SEFgGBtId9k+j0rkeFPVPgpAWLAPjq/T99eQ++xBMXUeZY35 rhLzm/GgXYsyhI0RXHi7FyrKh4x2koKPd1TNLfLPwHN8HRr4AxhVOVKH63lgT8QLCa7E1h0BTcwDU PUc8K2kAQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lDLjR-0005kR-1s; Sat, 20 Feb 2021 06:27:09 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lDLjN-0005jP-Dx; Sat, 20 Feb 2021 06:27:06 +0000 X-UUID: 4ab33aacd5444e20abc0cb42abee142a-20210219 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=Hs3QMCbKs3lYerCS7naNEnRZUcwiVA4lX5e20BGW6G4=; b=kkNvoaBCDAk2lPtMISb+oAm+4P/2+giys+pBzVdfsU16+zJn2IDbm333XAFK0V359Zln7eVFkLiyyZ9yRtopYW9/E91qBXgV6yPrVRs/049HFmYyn/rAn/dZVqWnkdp3lMYRE8pB5zFTg4HB1W0GEzS/CzOkemqDYDyEboUMvZI=; X-UUID: 4ab33aacd5444e20abc0cb42abee142a-20210219 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 372304601; Fri, 19 Feb 2021 22:26:58 -0800 Received: from MTKMBS31N1.mediatek.inc (172.27.4.69) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 19 Feb 2021 22:26:56 -0800 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS31N1.mediatek.inc (172.27.4.69) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sat, 20 Feb 2021 14:26:44 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Sat, 20 Feb 2021 14:26:43 +0800 Message-ID: <1613802403.896.3.camel@mhfsdcap03> Subject: Re: [PATCH 1/3] dt-bindings: media: mtk-vcodec: Separating mtk vcodec encoder node From: Irui Wang To: Alexandre Courbot Date: Sat, 20 Feb 2021 14:26:43 +0800 In-Reply-To: References: <20210121061804.26423-1-irui.wang@mediatek.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 720A18DC9132338BE8BA18B4DE8632099806799CD4E7EA48D9B032C45BD5ADD62000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210220_012705_628267_EF893355 X-CRM114-Status: GOOD ( 26.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Maoguang Meng , Andrew-CT Chen , Tiffany Lin , srv_heupstream@mediatek.com, Tomasz Figa , Yunfei Dong , Longfei Wang , LKML , Matthias Brugger , devicetree , Rob Herring , "moderated list:ARM/Mediatek SoC support" , Hsin-Yi Wang , Hans Verkuil , Mauro Carvalho Chehab , "moderated list:ARM/Mediatek SoC support" , Linux Media Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 2021-02-03 at 19:44 +0900, Alexandre Courbot wrote: > On Thu, Jan 21, 2021 at 3:18 PM Irui Wang wrote: > > > > Updates binding document since the avc and vp8 hardware encoder in > > MT8173 are now separated. Separate "mediatek,mt8173-vcodec-enc" to > > "mediatek,mt8173-vcodec-vp8-enc" and "mediatek,mt8173-vcodec-avc-enc". > > > > Signed-off-by: Hsin-Yi Wang > > Signed-off-by: Maoguang Meng > > Signed-off-by: Irui Wang > > > > --- > > .../bindings/media/mediatek-vcodec.txt | 58 ++++++++++--------- > > 1 file changed, 31 insertions(+), 27 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/media/mediatek-vcodec.txt b/Documentation/devicetree/bindings/media/mediatek-vcodec.txt > > index 8217424fd4bd..f85276e629bf 100644 > > --- a/Documentation/devicetree/bindings/media/mediatek-vcodec.txt > > +++ b/Documentation/devicetree/bindings/media/mediatek-vcodec.txt > > @@ -4,7 +4,9 @@ Mediatek Video Codec is the video codec hw present in Mediatek SoCs which > > supports high resolution encoding and decoding functionalities. > > > > Required properties: > > -- compatible : "mediatek,mt8173-vcodec-enc" for MT8173 encoder > > +- compatible : must be one of the following string: > > + "mediatek,mt8173-vcodec-vp8-enc" for mt8173 vp8 encoder. > > + "mediatek,mt8173-vcodec-avc-enc" for mt8173 avc encoder. > > IMHO "mediatek,mt8173-vcodec-enc-vp8" and > "mediatek,mt8173-vcodec-enc-avc" would be more logical. Also to keep a > bit of backward compatibility, shall we also allow > "mediatek,mt8173-vcodec-enc" to be an alias for > "mediatek,mt8173-vcodec-enc-avc"? The line above would become > > "mediatek,mt8173-vcodec-enc-avc" or "mediatek,mt8173-vcodec-enc" for > mt8173 avc encoder. > will be updated in the next version. > > "mediatek,mt8183-vcodec-enc" for MT8183 encoder. > > "mediatek,mt8173-vcodec-dec" for MT8173 decoder. > > - reg : Physical base address of the video codec registers and length of > > @@ -13,10 +15,11 @@ Required properties: > > - mediatek,larb : must contain the local arbiters in the current Socs. > > - clocks : list of clock specifiers, corresponding to entries in > > the clock-names property. > > -- clock-names: encoder must contain "venc_sel_src", "venc_sel",, > > - "venc_lt_sel_src", "venc_lt_sel", decoder must contain "vcodecpll", > > - "univpll_d2", "clk_cci400_sel", "vdec_sel", "vdecpll", "vencpll", > > - "venc_lt_sel", "vdec_bus_clk_src". > > +- clock-names: > > + avc venc must contain "venc_sel"; > > + vp8 venc must contain "venc_lt_sel"; > > Can't we use "venc_sel" for both avc and vp8, since they are different > nodes now? That way we can just say > > encoder must contain "venc_sel" > > which is clearer and also simpler on the code side. > ditto > > + decoder must contain "vcodecpll", "univpll_d2", "clk_cci400_sel", > > + "vdec_sel", "vdecpll", "vencpll", "venc_lt_sel", "vdec_bus_clk_src". > > - iommus : should point to the respective IOMMU block with master port as > > argument, see Documentation/devicetree/bindings/iommu/mediatek,iommu.txt > > for details. > > @@ -80,14 +83,10 @@ vcodec_dec: vcodec@16000000 { > > assigned-clock-rates = <0>, <0>, <0>, <1482000000>, <800000000>; > > }; > > > > - vcodec_enc: vcodec@18002000 { > > - compatible = "mediatek,mt8173-vcodec-enc"; > > - reg = <0 0x18002000 0 0x1000>, /*VENC_SYS*/ > > - <0 0x19002000 0 0x1000>; /*VENC_LT_SYS*/ > > - interrupts = , > > - ; > > - mediatek,larb = <&larb3>, > > - <&larb5>; > > +vcodec_enc: vcodec@18002000 { > > Let's use vcodec_enc_avc as a label? ditto > > > + compatible = "mediatek,mt8173-vcodec-avc-enc"; > > + reg = <0 0x18002000 0 0x1000>; > > + interrupts = ; > > iommus = <&iommu M4U_PORT_VENC_RCPU>, > > <&iommu M4U_PORT_VENC_REC>, > > <&iommu M4U_PORT_VENC_BSDMA>, > > @@ -98,8 +97,20 @@ vcodec_dec: vcodec@16000000 { > > <&iommu M4U_PORT_VENC_REF_LUMA>, > > <&iommu M4U_PORT_VENC_REF_CHROMA>, > > <&iommu M4U_PORT_VENC_NBM_RDMA>, > > - <&iommu M4U_PORT_VENC_NBM_WDMA>, > > - <&iommu M4U_PORT_VENC_RCPU_SET2>, > > + <&iommu M4U_PORT_VENC_NBM_WDMA>; > > + mediatek,larb = <&larb3>; > > + mediatek,vpu = <&vpu>; > > + clocks = <&topckgen CLK_TOP_VENC_SEL>; > > + clock-names = "venc_sel"; > > + assigned-clocks = <&topckgen CLK_TOP_VENC_SEL>; > > + assigned-clock-parents = <&topckgen CLK_TOP_VCODECPLL>; > > + }; > > + > > +vcodec_enc_lt: vcodec@19002000 { > > And here the label should probably be "vcodec_enc_vp8" for consistency. ditto > > > > > + compatible = "mediatek,mt8173-vcodec-vp8-enc"; > > + reg = <0 0x19002000 0 0x1000>; /* VENC_LT_SYS */ > > + interrupts = ; > > + iommus = <&iommu M4U_PORT_VENC_RCPU_SET2>, > > <&iommu M4U_PORT_VENC_REC_FRM_SET2>, > > <&iommu M4U_PORT_VENC_BSDMA_SET2>, > > <&iommu M4U_PORT_VENC_SV_COMA_SET2>, > > @@ -108,17 +119,10 @@ vcodec_dec: vcodec@16000000 { > > <&iommu M4U_PORT_VENC_CUR_CHROMA_SET2>, > > <&iommu M4U_PORT_VENC_REF_LUMA_SET2>, > > <&iommu M4U_PORT_VENC_REC_CHROMA_SET2>; > > + mediatek,larb = <&larb5>; > > mediatek,vpu = <&vpu>; > > - clocks = <&topckgen CLK_TOP_VENCPLL_D2>, > > - <&topckgen CLK_TOP_VENC_SEL>, > > - <&topckgen CLK_TOP_UNIVPLL1_D2>, > > - <&topckgen CLK_TOP_VENC_LT_SEL>; > > - clock-names = "venc_sel_src", > > - "venc_sel", > > - "venc_lt_sel_src", > > - "venc_lt_sel"; > > - assigned-clocks = <&topckgen CLK_TOP_VENC_SEL>, > > - <&topckgen CLK_TOP_VENC_LT_SEL>; > > - assigned-clock-parents = <&topckgen CLK_TOP_VENCPLL_D2>, > > - <&topckgen CLK_TOP_UNIVPLL1_D2>; > > + clocks = <&topckgen CLK_TOP_VENC_LT_SEL>; > > + clock-names = "venc_lt_sel"; > > + assigned-clocks = <&topckgen CLK_TOP_VENC_LT_SEL>; > > + assigned-clock-parents = <&topckgen CLK_TOP_VCODECPLL_370P5>; > > }; > > -- > > 2.18.0 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73C2CC433E0 for ; Sat, 20 Feb 2021 06:28:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 39E3D60238 for ; Sat, 20 Feb 2021 06:28:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229470AbhBTG1t (ORCPT ); Sat, 20 Feb 2021 01:27:49 -0500 Received: from Mailgw01.mediatek.com ([1.203.163.78]:56595 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S229476AbhBTG1r (ORCPT ); Sat, 20 Feb 2021 01:27:47 -0500 X-UUID: 6913ec8675734ebd8ae5df903db36b8d-20210220 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=Hs3QMCbKs3lYerCS7naNEnRZUcwiVA4lX5e20BGW6G4=; b=D9sbBcx6upyvqZ6c0uEvkenIRL+wAfTtkt7mqXz9pr1xeVjc2939LFyy5DBsMoxqKoearuTqnOVNKKXVL7KmfXmXD+mz1Pihfuvnv3XujE35RtRlLko1w+Jci62bQwk63OHHZioBg8pxem1PLJjZxFoD6rjfQ0wvUvutioArC0E=; X-UUID: 6913ec8675734ebd8ae5df903db36b8d-20210220 Received: from mtkcas36.mediatek.inc [(172.27.4.253)] by mailgw01.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 803049463; Sat, 20 Feb 2021 14:26:56 +0800 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by MTKMBS31N1.mediatek.inc (172.27.4.69) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sat, 20 Feb 2021 14:26:44 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Sat, 20 Feb 2021 14:26:43 +0800 Message-ID: <1613802403.896.3.camel@mhfsdcap03> Subject: Re: [PATCH 1/3] dt-bindings: media: mtk-vcodec: Separating mtk vcodec encoder node From: Irui Wang To: Alexandre Courbot CC: Hans Verkuil , Tiffany Lin , Andrew-CT Chen , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , "Tomasz Figa" , Hsin-Yi Wang , Maoguang Meng , Longfei Wang , Yunfei Dong , Linux Media Mailing List , devicetree , LKML , "moderated list:ARM/Mediatek SoC support" , , "moderated list:ARM/Mediatek SoC support" Date: Sat, 20 Feb 2021 14:26:43 +0800 In-Reply-To: References: <20210121061804.26423-1-irui.wang@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: 720A18DC9132338BE8BA18B4DE8632099806799CD4E7EA48D9B032C45BD5ADD62000:8 X-MTK: N Content-Transfer-Encoding: base64 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org T24gV2VkLCAyMDIxLTAyLTAzIGF0IDE5OjQ0ICswOTAwLCBBbGV4YW5kcmUgQ291cmJvdCB3cm90 ZToNCj4gT24gVGh1LCBKYW4gMjEsIDIwMjEgYXQgMzoxOCBQTSBJcnVpIFdhbmcgPGlydWkud2Fu Z0BtZWRpYXRlay5jb20+IHdyb3RlOg0KPiA+DQo+ID4gVXBkYXRlcyBiaW5kaW5nIGRvY3VtZW50 IHNpbmNlIHRoZSBhdmMgYW5kIHZwOCBoYXJkd2FyZSBlbmNvZGVyIGluDQo+ID4gTVQ4MTczIGFy ZSBub3cgc2VwYXJhdGVkLiBTZXBhcmF0ZSAibWVkaWF0ZWssbXQ4MTczLXZjb2RlYy1lbmMiIHRv DQo+ID4gIm1lZGlhdGVrLG10ODE3My12Y29kZWMtdnA4LWVuYyIgYW5kICJtZWRpYXRlayxtdDgx NzMtdmNvZGVjLWF2Yy1lbmMiLg0KPiA+DQo+ID4gU2lnbmVkLW9mZi1ieTogSHNpbi1ZaSBXYW5n IDxoc2lueWlAY2hyb21pdW0ub3JnPg0KPiA+IFNpZ25lZC1vZmYtYnk6IE1hb2d1YW5nIE1lbmcg PG1hb2d1YW5nLm1lbmdAbWVkaWF0ZWsuY29tPg0KPiA+IFNpZ25lZC1vZmYtYnk6IElydWkgV2Fu ZyA8aXJ1aS53YW5nQG1lZGlhdGVrLmNvbT4NCj4gPg0KPiA+IC0tLQ0KPiA+ICAuLi4vYmluZGlu Z3MvbWVkaWEvbWVkaWF0ZWstdmNvZGVjLnR4dCAgICAgICAgfCA1OCArKysrKysrKysrLS0tLS0t LS0tDQo+ID4gIDEgZmlsZSBjaGFuZ2VkLCAzMSBpbnNlcnRpb25zKCspLCAyNyBkZWxldGlvbnMo LSkNCj4gPg0KPiA+IGRpZmYgLS1naXQgYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGlu Z3MvbWVkaWEvbWVkaWF0ZWstdmNvZGVjLnR4dCBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9i aW5kaW5ncy9tZWRpYS9tZWRpYXRlay12Y29kZWMudHh0DQo+ID4gaW5kZXggODIxNzQyNGZkNGJk Li5mODUyNzZlNjI5YmYgMTAwNjQ0DQo+ID4gLS0tIGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVl L2JpbmRpbmdzL21lZGlhL21lZGlhdGVrLXZjb2RlYy50eHQNCj4gPiArKysgYi9Eb2N1bWVudGF0 aW9uL2RldmljZXRyZWUvYmluZGluZ3MvbWVkaWEvbWVkaWF0ZWstdmNvZGVjLnR4dA0KPiA+IEBA IC00LDcgKzQsOSBAQCBNZWRpYXRlayBWaWRlbyBDb2RlYyBpcyB0aGUgdmlkZW8gY29kZWMgaHcg cHJlc2VudCBpbiBNZWRpYXRlayBTb0NzIHdoaWNoDQo+ID4gIHN1cHBvcnRzIGhpZ2ggcmVzb2x1 dGlvbiBlbmNvZGluZyBhbmQgZGVjb2RpbmcgZnVuY3Rpb25hbGl0aWVzLg0KPiA+DQo+ID4gIFJl cXVpcmVkIHByb3BlcnRpZXM6DQo+ID4gLS0gY29tcGF0aWJsZSA6ICJtZWRpYXRlayxtdDgxNzMt dmNvZGVjLWVuYyIgZm9yIE1UODE3MyBlbmNvZGVyDQo+ID4gKy0gY29tcGF0aWJsZSA6IG11c3Qg YmUgb25lIG9mIHRoZSBmb2xsb3dpbmcgc3RyaW5nOg0KPiA+ICsgICJtZWRpYXRlayxtdDgxNzMt dmNvZGVjLXZwOC1lbmMiIGZvciBtdDgxNzMgdnA4IGVuY29kZXIuDQo+ID4gKyAgIm1lZGlhdGVr LG10ODE3My12Y29kZWMtYXZjLWVuYyIgZm9yIG10ODE3MyBhdmMgZW5jb2Rlci4NCj4gDQo+IElN SE8gIm1lZGlhdGVrLG10ODE3My12Y29kZWMtZW5jLXZwOCIgYW5kDQo+ICJtZWRpYXRlayxtdDgx NzMtdmNvZGVjLWVuYy1hdmMiIHdvdWxkIGJlIG1vcmUgbG9naWNhbC4gQWxzbyB0byBrZWVwIGEN Cj4gYml0IG9mIGJhY2t3YXJkIGNvbXBhdGliaWxpdHksIHNoYWxsIHdlIGFsc28gYWxsb3cNCj4g Im1lZGlhdGVrLG10ODE3My12Y29kZWMtZW5jIiB0byBiZSBhbiBhbGlhcyBmb3INCj4gIm1lZGlh dGVrLG10ODE3My12Y29kZWMtZW5jLWF2YyI/IFRoZSBsaW5lIGFib3ZlIHdvdWxkIGJlY29tZQ0K PiANCj4gICAibWVkaWF0ZWssbXQ4MTczLXZjb2RlYy1lbmMtYXZjIiBvciAibWVkaWF0ZWssbXQ4 MTczLXZjb2RlYy1lbmMiIGZvcg0KPiBtdDgxNzMgYXZjIGVuY29kZXIuDQo+IA0KDQp3aWxsIGJl IHVwZGF0ZWQgaW4gdGhlIG5leHQgdmVyc2lvbi4NCg0KPiA+ICAgICJtZWRpYXRlayxtdDgxODMt dmNvZGVjLWVuYyIgZm9yIE1UODE4MyBlbmNvZGVyLg0KPiA+ICAgICJtZWRpYXRlayxtdDgxNzMt dmNvZGVjLWRlYyIgZm9yIE1UODE3MyBkZWNvZGVyLg0KPiA+ICAtIHJlZyA6IFBoeXNpY2FsIGJh c2UgYWRkcmVzcyBvZiB0aGUgdmlkZW8gY29kZWMgcmVnaXN0ZXJzIGFuZCBsZW5ndGggb2YNCj4g PiBAQCAtMTMsMTAgKzE1LDExIEBAIFJlcXVpcmVkIHByb3BlcnRpZXM6DQo+ID4gIC0gbWVkaWF0 ZWssbGFyYiA6IG11c3QgY29udGFpbiB0aGUgbG9jYWwgYXJiaXRlcnMgaW4gdGhlIGN1cnJlbnQg U29jcy4NCj4gPiAgLSBjbG9ja3MgOiBsaXN0IG9mIGNsb2NrIHNwZWNpZmllcnMsIGNvcnJlc3Bv bmRpbmcgdG8gZW50cmllcyBpbg0KPiA+ICAgIHRoZSBjbG9jay1uYW1lcyBwcm9wZXJ0eS4NCj4g PiAtLSBjbG9jay1uYW1lczogZW5jb2RlciBtdXN0IGNvbnRhaW4gInZlbmNfc2VsX3NyYyIsICJ2 ZW5jX3NlbCIsLA0KPiA+IC0gICJ2ZW5jX2x0X3NlbF9zcmMiLCAidmVuY19sdF9zZWwiLCBkZWNv ZGVyIG11c3QgY29udGFpbiAidmNvZGVjcGxsIiwNCj4gPiAtICAidW5pdnBsbF9kMiIsICJjbGtf Y2NpNDAwX3NlbCIsICJ2ZGVjX3NlbCIsICJ2ZGVjcGxsIiwgInZlbmNwbGwiLA0KPiA+IC0gICJ2 ZW5jX2x0X3NlbCIsICJ2ZGVjX2J1c19jbGtfc3JjIi4NCj4gPiArLSBjbG9jay1uYW1lczoNCj4g PiArICAgYXZjIHZlbmMgbXVzdCBjb250YWluICJ2ZW5jX3NlbCI7DQo+ID4gKyAgIHZwOCB2ZW5j IG11c3QgY29udGFpbiAidmVuY19sdF9zZWwiOw0KPiANCj4gQ2FuJ3Qgd2UgdXNlICJ2ZW5jX3Nl bCIgZm9yIGJvdGggYXZjIGFuZCB2cDgsIHNpbmNlIHRoZXkgYXJlIGRpZmZlcmVudA0KPiBub2Rl cyBub3c/IFRoYXQgd2F5IHdlIGNhbiBqdXN0IHNheQ0KPiANCj4gICBlbmNvZGVyIG11c3QgY29u dGFpbiAidmVuY19zZWwiDQo+IA0KPiB3aGljaCBpcyBjbGVhcmVyIGFuZCBhbHNvIHNpbXBsZXIg b24gdGhlIGNvZGUgc2lkZS4NCj4gDQoNCmRpdHRvDQoNCj4gPiArICAgZGVjb2RlciAgbXVzdCBj b250YWluICJ2Y29kZWNwbGwiLCAidW5pdnBsbF9kMiIsICJjbGtfY2NpNDAwX3NlbCIsDQo+ID4g KyAgICJ2ZGVjX3NlbCIsICJ2ZGVjcGxsIiwgInZlbmNwbGwiLCAidmVuY19sdF9zZWwiLCAidmRl Y19idXNfY2xrX3NyYyIuDQo+ID4gIC0gaW9tbXVzIDogc2hvdWxkIHBvaW50IHRvIHRoZSByZXNw ZWN0aXZlIElPTU1VIGJsb2NrIHdpdGggbWFzdGVyIHBvcnQgYXMNCj4gPiAgICBhcmd1bWVudCwg c2VlIERvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9pb21tdS9tZWRpYXRlayxpb21t dS50eHQNCj4gPiAgICBmb3IgZGV0YWlscy4NCj4gPiBAQCAtODAsMTQgKzgzLDEwIEBAIHZjb2Rl Y19kZWM6IHZjb2RlY0AxNjAwMDAwMCB7DQo+ID4gICAgICBhc3NpZ25lZC1jbG9jay1yYXRlcyA9 IDwwPiwgPDA+LCA8MD4sIDwxNDgyMDAwMDAwPiwgPDgwMDAwMDAwMD47DQo+ID4gICAgfTsNCj4g Pg0KPiA+IC0gIHZjb2RlY19lbmM6IHZjb2RlY0AxODAwMjAwMCB7DQo+ID4gLSAgICBjb21wYXRp YmxlID0gIm1lZGlhdGVrLG10ODE3My12Y29kZWMtZW5jIjsNCj4gPiAtICAgIHJlZyA9IDwwIDB4 MTgwMDIwMDAgMCAweDEwMDA+LCAgICAvKlZFTkNfU1lTKi8NCj4gPiAtICAgICAgICAgIDwwIDB4 MTkwMDIwMDAgMCAweDEwMDA+OyAgICAvKlZFTkNfTFRfU1lTKi8NCj4gPiAtICAgIGludGVycnVw dHMgPSA8R0lDX1NQSSAxOTggSVJRX1RZUEVfTEVWRUxfTE9XPiwNCj4gPiAtICAgICAgICAgICAg ICAgIDxHSUNfU1BJIDIwMiBJUlFfVFlQRV9MRVZFTF9MT1c+Ow0KPiA+IC0gICAgbWVkaWF0ZWss bGFyYiA9IDwmbGFyYjM+LA0KPiA+IC0gICAgICAgICAgICAgICAgICAgPCZsYXJiNT47DQo+ID4g K3Zjb2RlY19lbmM6IHZjb2RlY0AxODAwMjAwMCB7DQo+IA0KPiBMZXQncyB1c2UgdmNvZGVjX2Vu Y19hdmMgYXMgYSBsYWJlbD8NCg0KZGl0dG8NCg0KPiANCj4gPiArICAgIGNvbXBhdGlibGUgPSAi bWVkaWF0ZWssbXQ4MTczLXZjb2RlYy1hdmMtZW5jIjsNCj4gPiArICAgIHJlZyA9IDwwIDB4MTgw MDIwMDAgMCAweDEwMDA+Ow0KPiA+ICsgICAgaW50ZXJydXB0cyA9IDxHSUNfU1BJIDE5OCBJUlFf VFlQRV9MRVZFTF9MT1c+Ow0KPiA+ICAgICAgaW9tbXVzID0gPCZpb21tdSBNNFVfUE9SVF9WRU5D X1JDUFU+LA0KPiA+ICAgICAgICAgICAgICAgPCZpb21tdSBNNFVfUE9SVF9WRU5DX1JFQz4sDQo+ ID4gICAgICAgICAgICAgICA8JmlvbW11IE00VV9QT1JUX1ZFTkNfQlNETUE+LA0KPiA+IEBAIC05 OCw4ICs5NywyMCBAQCB2Y29kZWNfZGVjOiB2Y29kZWNAMTYwMDAwMDAgew0KPiA+ICAgICAgICAg ICAgICAgPCZpb21tdSBNNFVfUE9SVF9WRU5DX1JFRl9MVU1BPiwNCj4gPiAgICAgICAgICAgICAg IDwmaW9tbXUgTTRVX1BPUlRfVkVOQ19SRUZfQ0hST01BPiwNCj4gPiAgICAgICAgICAgICAgIDwm aW9tbXUgTTRVX1BPUlRfVkVOQ19OQk1fUkRNQT4sDQo+ID4gLSAgICAgICAgICAgICA8JmlvbW11 IE00VV9QT1JUX1ZFTkNfTkJNX1dETUE+LA0KPiA+IC0gICAgICAgICAgICAgPCZpb21tdSBNNFVf UE9SVF9WRU5DX1JDUFVfU0VUMj4sDQo+ID4gKyAgICAgICAgICAgICA8JmlvbW11IE00VV9QT1JU X1ZFTkNfTkJNX1dETUE+Ow0KPiA+ICsgICAgbWVkaWF0ZWssbGFyYiA9IDwmbGFyYjM+Ow0KPiA+ ICsgICAgbWVkaWF0ZWssdnB1ID0gPCZ2cHU+Ow0KPiA+ICsgICAgY2xvY2tzID0gPCZ0b3Bja2dl biBDTEtfVE9QX1ZFTkNfU0VMPjsNCj4gPiArICAgIGNsb2NrLW5hbWVzID0gInZlbmNfc2VsIjsN Cj4gPiArICAgIGFzc2lnbmVkLWNsb2NrcyA9IDwmdG9wY2tnZW4gQ0xLX1RPUF9WRU5DX1NFTD47 DQo+ID4gKyAgICBhc3NpZ25lZC1jbG9jay1wYXJlbnRzID0gPCZ0b3Bja2dlbiBDTEtfVE9QX1ZD T0RFQ1BMTD47DQo+ID4gKyAgfTsNCj4gPiArDQo+ID4gK3Zjb2RlY19lbmNfbHQ6IHZjb2RlY0Ax OTAwMjAwMCB7DQo+IA0KPiBBbmQgaGVyZSB0aGUgbGFiZWwgc2hvdWxkIHByb2JhYmx5IGJlICJ2 Y29kZWNfZW5jX3ZwOCIgZm9yIGNvbnNpc3RlbmN5Lg0KDQpkaXR0bw0KDQo+IA0KPiANCj4gDQo+ ID4gKyAgICBjb21wYXRpYmxlID0gIm1lZGlhdGVrLG10ODE3My12Y29kZWMtdnA4LWVuYyI7DQo+ ID4gKyAgICByZWcgPSAgPDAgMHgxOTAwMjAwMCAwIDB4MTAwMD47ICAgIC8qIFZFTkNfTFRfU1lT ICovDQo+ID4gKyAgICBpbnRlcnJ1cHRzID0gPEdJQ19TUEkgMjAyIElSUV9UWVBFX0xFVkVMX0xP Vz47DQo+ID4gKyAgICBpb21tdXMgPSA8JmlvbW11IE00VV9QT1JUX1ZFTkNfUkNQVV9TRVQyPiwN Cj4gPiAgICAgICAgICAgICAgIDwmaW9tbXUgTTRVX1BPUlRfVkVOQ19SRUNfRlJNX1NFVDI+LA0K PiA+ICAgICAgICAgICAgICAgPCZpb21tdSBNNFVfUE9SVF9WRU5DX0JTRE1BX1NFVDI+LA0KPiA+ ICAgICAgICAgICAgICAgPCZpb21tdSBNNFVfUE9SVF9WRU5DX1NWX0NPTUFfU0VUMj4sDQo+ID4g QEAgLTEwOCwxNyArMTE5LDEwIEBAIHZjb2RlY19kZWM6IHZjb2RlY0AxNjAwMDAwMCB7DQo+ID4g ICAgICAgICAgICAgICA8JmlvbW11IE00VV9QT1JUX1ZFTkNfQ1VSX0NIUk9NQV9TRVQyPiwNCj4g PiAgICAgICAgICAgICAgIDwmaW9tbXUgTTRVX1BPUlRfVkVOQ19SRUZfTFVNQV9TRVQyPiwNCj4g PiAgICAgICAgICAgICAgIDwmaW9tbXUgTTRVX1BPUlRfVkVOQ19SRUNfQ0hST01BX1NFVDI+Ow0K PiA+ICsgICAgbWVkaWF0ZWssbGFyYiA9IDwmbGFyYjU+Ow0KPiA+ICAgICAgbWVkaWF0ZWssdnB1 ID0gPCZ2cHU+Ow0KPiA+IC0gICAgY2xvY2tzID0gPCZ0b3Bja2dlbiBDTEtfVE9QX1ZFTkNQTExf RDI+LA0KPiA+IC0gICAgICAgICAgICAgPCZ0b3Bja2dlbiBDTEtfVE9QX1ZFTkNfU0VMPiwNCj4g PiAtICAgICAgICAgICAgIDwmdG9wY2tnZW4gQ0xLX1RPUF9VTklWUExMMV9EMj4sDQo+ID4gLSAg ICAgICAgICAgICA8JnRvcGNrZ2VuIENMS19UT1BfVkVOQ19MVF9TRUw+Ow0KPiA+IC0gICAgY2xv Y2stbmFtZXMgPSAidmVuY19zZWxfc3JjIiwNCj4gPiAtICAgICAgICAgICAgICAgICAgInZlbmNf c2VsIiwNCj4gPiAtICAgICAgICAgICAgICAgICAgInZlbmNfbHRfc2VsX3NyYyIsDQo+ID4gLSAg ICAgICAgICAgICAgICAgICJ2ZW5jX2x0X3NlbCI7DQo+ID4gLSAgICBhc3NpZ25lZC1jbG9ja3Mg PSA8JnRvcGNrZ2VuIENMS19UT1BfVkVOQ19TRUw+LA0KPiA+IC0gICAgICAgICAgICAgICAgICAg ICAgPCZ0b3Bja2dlbiBDTEtfVE9QX1ZFTkNfTFRfU0VMPjsNCj4gPiAtICAgIGFzc2lnbmVkLWNs b2NrLXBhcmVudHMgPSA8JnRvcGNrZ2VuIENMS19UT1BfVkVOQ1BMTF9EMj4sDQo+ID4gLSAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgPCZ0b3Bja2dlbiBDTEtfVE9QX1VOSVZQTEwxX0QyPjsN Cj4gPiArICAgIGNsb2NrcyA9IDwmdG9wY2tnZW4gQ0xLX1RPUF9WRU5DX0xUX1NFTD47DQo+ID4g KyAgICBjbG9jay1uYW1lcyA9ICJ2ZW5jX2x0X3NlbCI7DQo+ID4gKyAgICBhc3NpZ25lZC1jbG9j a3MgPSA8JnRvcGNrZ2VuIENMS19UT1BfVkVOQ19MVF9TRUw+Ow0KPiA+ICsgICAgYXNzaWduZWQt Y2xvY2stcGFyZW50cyA9IDwmdG9wY2tnZW4gQ0xLX1RPUF9WQ09ERUNQTExfMzcwUDU+Ow0KPiA+ ICAgIH07DQo+ID4gLS0NCj4gPiAyLjE4LjANCj4gPg0KDQo=