From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Stuebner Subject: Re: [PATCH] drm/rockchip: Convert drm_atomic_helper_suspend/resume() Date: Wed, 01 Aug 2018 14:33:36 +0200 Message-ID: <16141309.kTfAWOe8rM@phil> References: <20180731203430.GA30136@jordon-HP-15-Notebook-PC> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180731203430.GA30136@jordon-HP-15-Notebook-PC> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Souptick Joarder Cc: ajitn.linux@gmail.com, airlied@linux.ie, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org List-Id: linux-rockchip.vger.kernel.org SGkgU291cHRpY2ssCgpBbSBEaWVuc3RhZywgMzEuIEp1bGkgMjAxOCwgMjI6MzQ6MzAgQ0VTVCBz Y2hyaWViIFNvdXB0aWNrIEpvYXJkZXI6Cj4gY29udmVydCBkcm1fYXRvbWljX2hlbHBlcl9zdXNw ZW5kL3Jlc3VtZSgpIHRvIHVzZQo+IGRybV9tb2RlX2NvbmZpZ19oZWxwZXJfc3VzcGVuZC9yZXN1 bWUoKS4KPiAKPiBXaXRoIHRoaXMgY29udmVyc2lvbiwgcm9ja2NoaXBfZHJtX2ZiX3Jlc3VtZSgp IGFuZAo+IHJvY2tjaGlwX2RybV9mYl9zdXNwZW5kKCkgd2lsbCBub3QgYmUgdXNlZCBhbnltb3Jl Lgo+IEJvdGggb2YgdGhlc2UgZnVuY3Rpb25zIGNhbiBiZSByZW1vdmVkLgo+IAo+IEFsc28sIGlu IHN0cnVjdCByb2NrY2hpcF9kcm1fcHJpdmF0ZSBzdGF0ZSB3aWxsIG5vdCBiZQo+IHVzZWQgYW55 bW9yZS4gU28gdGhpcyBjYW4gYmUgcmVtb3ZlZCBmb3JldmVyLgo+IAo+IFNpZ25lZC1vZmYtYnk6 IFNvdXB0aWNrIEpvYXJkZXIgPGpyZHIubGludXhAZ21haWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6 IEFqaXQgTmVnaSA8YWppdG4ubGludXhAZ21haWwuY29tPgoKdGhlIHBhdGNoIGl0c2VsZiBsb29r cyBncmVhdCwganVzdCBhIHNpbXBsZSBib29ra2VlcGluZyBxdWVzdGlvbi4KCldoYXQgcm9sZSBk aWQgQWppdCBwbGF5IGluIGNyZWF0aW5nIHRoZSBwYXRjaD8gSWYgSSByZW1lbWJlciBjb3JyZWN0 bHkKaXQgaXMgbWVhbnQgdG8gYmUKLSAxc3QgU2lnbmVkLW9mZjogUGF0Y2gtQXV0aG9yCi0gMm5k IFNpZ25lZC1vZmY6IEUtTWFpbCBzZW5kZXIgKyBwYXRjaCBwb3NzaWJseSBwYXRjaCBjaGFuZ2Vz CihvcHRpb25hbCBvZiBjb3Vyc2UgaWYgdGhlIHNhbWUpCgpTbyB3YXMgdGhpcyBtZWFudCB0byBi ZSBhIFJldmlld2VkLWJ5IGZyb20gQWppdD8KCgpUaGFua3MKSGVpa28KCgpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0 CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: heiko@sntech.de (Heiko Stuebner) Date: Wed, 01 Aug 2018 14:33:36 +0200 Subject: [PATCH] drm/rockchip: Convert drm_atomic_helper_suspend/resume() In-Reply-To: <20180731203430.GA30136@jordon-HP-15-Notebook-PC> References: <20180731203430.GA30136@jordon-HP-15-Notebook-PC> Message-ID: <16141309.kTfAWOe8rM@phil> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Souptick, Am Dienstag, 31. Juli 2018, 22:34:30 CEST schrieb Souptick Joarder: > convert drm_atomic_helper_suspend/resume() to use > drm_mode_config_helper_suspend/resume(). > > With this conversion, rockchip_drm_fb_resume() and > rockchip_drm_fb_suspend() will not be used anymore. > Both of these functions can be removed. > > Also, in struct rockchip_drm_private state will not be > used anymore. So this can be removed forever. > > Signed-off-by: Souptick Joarder > Signed-off-by: Ajit Negi the patch itself looks great, just a simple bookkeeping question. What role did Ajit play in creating the patch? If I remember correctly it is meant to be - 1st Signed-off: Patch-Author - 2nd Signed-off: E-Mail sender + patch possibly patch changes (optional of course if the same) So was this meant to be a Reviewed-by from Ajit? Thanks Heiko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18809C46463 for ; Wed, 1 Aug 2018 12:33:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B0DDD208A6 for ; Wed, 1 Aug 2018 12:33:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B0DDD208A6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389142AbeHAOTS (ORCPT ); Wed, 1 Aug 2018 10:19:18 -0400 Received: from gloria.sntech.de ([185.11.138.130]:33638 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387673AbeHAOTS (ORCPT ); Wed, 1 Aug 2018 10:19:18 -0400 Received: from wd0970.dip.tu-dresden.de ([141.76.111.202] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1fkqJt-00057G-Nd; Wed, 01 Aug 2018 14:33:37 +0200 From: Heiko Stuebner To: Souptick Joarder Cc: hjc@rock-chips.com, airlied@linux.ie, ajitn.linux@gmail.com, daniel@ffwll.ch, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/rockchip: Convert drm_atomic_helper_suspend/resume() Date: Wed, 01 Aug 2018 14:33:36 +0200 Message-ID: <16141309.kTfAWOe8rM@phil> In-Reply-To: <20180731203430.GA30136@jordon-HP-15-Notebook-PC> References: <20180731203430.GA30136@jordon-HP-15-Notebook-PC> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Souptick, Am Dienstag, 31. Juli 2018, 22:34:30 CEST schrieb Souptick Joarder: > convert drm_atomic_helper_suspend/resume() to use > drm_mode_config_helper_suspend/resume(). > > With this conversion, rockchip_drm_fb_resume() and > rockchip_drm_fb_suspend() will not be used anymore. > Both of these functions can be removed. > > Also, in struct rockchip_drm_private state will not be > used anymore. So this can be removed forever. > > Signed-off-by: Souptick Joarder > Signed-off-by: Ajit Negi the patch itself looks great, just a simple bookkeeping question. What role did Ajit play in creating the patch? If I remember correctly it is meant to be - 1st Signed-off: Patch-Author - 2nd Signed-off: E-Mail sender + patch possibly patch changes (optional of course if the same) So was this meant to be a Reviewed-by from Ajit? Thanks Heiko