From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from galahad.ideasonboard.com ([185.26.127.97]:42715 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751688AbeBVWVc (ORCPT ); Thu, 22 Feb 2018 17:21:32 -0500 From: Laurent Pinchart To: Frank Rowand Cc: Laurent Pinchart , dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, Rob Herring , devicetree@vger.kernel.org Subject: Re: [PATCH v6 3/4] drm: rcar-du: Fix legacy DT to create LVDS encoder nodes Date: Fri, 23 Feb 2018 00:22:16 +0200 Message-ID: <1614965.g7Hy4FaxWG@avalon> In-Reply-To: <06d3fb91-961d-a053-df22-cddf3419b159@gmail.com> References: <20180222131336.7712-1-laurent.pinchart+renesas@ideasonboard.com> <20180222131336.7712-4-laurent.pinchart+renesas@ideasonboard.com> <06d3fb91-961d-a053-df22-cddf3419b159@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Frank, On Friday, 23 February 2018 00:10:17 EET Frank Rowand wrote: > Hi Laurent, Rob, > > Thanks for the prompt spin to address my concerns. There are some small > technical issues. > > I did not read the v3 patch until today. v3 through v6 are still using the > old overlay apply method which uses an expanded device tree as input. > > Rob, I don't see my overlay patches in you for-next branch, and I have > not seen an "Applied" message from you. What is the status of the > overlay patches? > > Comments in the patch below. > > On 02/22/18 05:13, Laurent Pinchart wrote: > > The internal LVDS encoders now have their own DT bindings. Before > > switching the driver infrastructure to those new bindings, implement > > backward-compatibility through live DT patching. > > > > Patching is disabled and will be enabled along with support for the new > > DT bindings in the DU driver. > > > > Signed-off-by: Laurent Pinchart > > > > --- > > Changes since v5: > > > > - Use a private copy of rcar_du_of_changeset_add_property() > > > > Changes since v3: > > > > - Use the OF changeset API > > - Use of_graph_get_endpoint_by_regs() > > - Replace hardcoded constants by sizeof() > > > > Changes since v2: > > > > - Update the SPDX headers to use C-style comments in header files > > - Removed the manually created __local_fixups__ node > > - Perform manual fixups on live DT instead of overlay > > > > Changes since v1: > > > > - Select OF_FLATTREE > > - Compile LVDS DT bindings patch code when DRM_RCAR_LVDS is selected > > - Update the SPDX headers to use GPL-2.0 instead of GPL-2.0-only > > - Turn __dtb_rcar_du_of_lvds_(begin|end) from u8 to char > > - Pass void begin and end pointers to rcar_du_of_get_overlay() > > - Use of_get_parent() instead of accessing the parent pointer directly > > - Find the LVDS endpoints nodes based on the LVDS node instead of the > > > > root of the overlay > > > > - Update to the -lvds compatible string format > > --- > > > > drivers/gpu/drm/rcar-du/Kconfig | 2 + > > drivers/gpu/drm/rcar-du/Makefile | 7 +- > > drivers/gpu/drm/rcar-du/rcar_du_of.c | 342 ++++++++++++++++ > > drivers/gpu/drm/rcar-du/rcar_du_of.h | 20 ++ > > .../gpu/drm/rcar-du/rcar_du_of_lvds_r8a7790.dts | 79 +++++ > > .../gpu/drm/rcar-du/rcar_du_of_lvds_r8a7791.dts | 53 ++++ > > .../gpu/drm/rcar-du/rcar_du_of_lvds_r8a7793.dts | 53 ++++ > > .../gpu/drm/rcar-du/rcar_du_of_lvds_r8a7795.dts | 53 ++++ > > .../gpu/drm/rcar-du/rcar_du_of_lvds_r8a7796.dts | 53 ++++ > > 9 files changed, 661 insertions(+), 1 deletion(-) > > create mode 100644 drivers/gpu/drm/rcar-du/rcar_du_of.c > > create mode 100644 drivers/gpu/drm/rcar-du/rcar_du_of.h > > create mode 100644 drivers/gpu/drm/rcar-du/rcar_du_of_lvds_r8a7790.dts > > create mode 100644 drivers/gpu/drm/rcar-du/rcar_du_of_lvds_r8a7791.dts > > create mode 100644 drivers/gpu/drm/rcar-du/rcar_du_of_lvds_r8a7793.dts > > create mode 100644 drivers/gpu/drm/rcar-du/rcar_du_of_lvds_r8a7795.dts > > create mode 100644 drivers/gpu/drm/rcar-du/rcar_du_of_lvds_r8a7796.dts [snip] > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_of.c > > b/drivers/gpu/drm/rcar-du/rcar_du_of.c new file mode 100644 > > index 000000000000..ac442ddfed16 > > --- /dev/null > > +++ b/drivers/gpu/drm/rcar-du/rcar_du_of.c [snip] > > +static int __init rcar_du_of_apply_overlay(const struct > > rcar_du_of_overlay *dtbs, > > + const char *compatible) > > +{ > > + const struct rcar_du_of_overlay *dtb = NULL; > > + struct device_node *node = NULL; > > + unsigned int i; > > + int ovcs_id; > > + void *data; > > + void *mem; > > + int ret; > > + > > + for (i = 0; dtbs[i].compatible; ++i) { > > + if (!strcmp(dtbs[i].compatible, compatible)) { > > + dtb = &dtbs[i]; > > + break; > > + } > > + } > > + > > + if (!dtb) > > + return -ENODEV; > > __If__ my overlay patches are accepted, this block: > > > + > > + data = kmemdup(dtb->begin, dtb->end - dtb->begin, GFP_KERNEL); > > + if (!data) > > + return -ENOMEM; > > + > > + mem = of_fdt_unflatten_tree(data, NULL, &node); > > + if (!mem) { > > + ret = -ENOMEM; > > + goto done; > > + } > > + > > + ovcs_id = 0; > > + ret = of_overlay_apply(node, &ovcs_id); > > + > > +done: > > + of_node_put(node); > > + kfree(data); > > + kfree(mem); > > becomes: > > ret = of_overlay_fdt_apply(dtb->begin, &ovcs_id); I tried to rework this patch in a way that would make switching to FDT overlays easy, and I'm glad to hear I haven't done a too bad job :-) Are your patches scheduled for merge in v4.17 ? If so, is it possible to get apply them in a stable branch on top of v4.16-rc1 that can be merged as a dependency for this series ? There are changes to the Renesas DT queued for merge in v4.17 that would make delaying this patch series to v4.18 quite painful. > If my overlay patches do not exist, there are other small errors > in the code block above. I'll ignore them for the moment. > > A quick scan of the rest of the code looks OK. I'll read through it > more carefully, but wanted to get this reply out without further > delay. Thank you. > > + > > + return ret; > > +} [snip] -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v6 3/4] drm: rcar-du: Fix legacy DT to create LVDS encoder nodes Date: Fri, 23 Feb 2018 00:22:16 +0200 Message-ID: <1614965.g7Hy4FaxWG@avalon> References: <20180222131336.7712-1-laurent.pinchart+renesas@ideasonboard.com> <20180222131336.7712-4-laurent.pinchart+renesas@ideasonboard.com> <06d3fb91-961d-a053-df22-cddf3419b159@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <06d3fb91-961d-a053-df22-cddf3419b159@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Frank Rowand Cc: linux-renesas-soc@vger.kernel.org, Laurent Pinchart , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org List-Id: devicetree@vger.kernel.org SGkgRnJhbmssCgpPbiBGcmlkYXksIDIzIEZlYnJ1YXJ5IDIwMTggMDA6MTA6MTcgRUVUIEZyYW5r IFJvd2FuZCB3cm90ZToKPiBIaSBMYXVyZW50LCBSb2IsCj4gCj4gVGhhbmtzIGZvciB0aGUgcHJv bXB0IHNwaW4gdG8gYWRkcmVzcyBteSBjb25jZXJucy4gIFRoZXJlIGFyZSBzb21lIHNtYWxsCj4g dGVjaG5pY2FsIGlzc3Vlcy4KPiAKPiBJIGRpZCBub3QgcmVhZCB0aGUgdjMgcGF0Y2ggdW50aWwg dG9kYXkuICB2MyB0aHJvdWdoIHY2IGFyZSBzdGlsbCB1c2luZyB0aGUKPiBvbGQgb3ZlcmxheSBh cHBseSBtZXRob2Qgd2hpY2ggdXNlcyBhbiBleHBhbmRlZCBkZXZpY2UgdHJlZSBhcyBpbnB1dC4K PiAKPiBSb2IsIEkgZG9uJ3Qgc2VlIG15IG92ZXJsYXkgcGF0Y2hlcyBpbiB5b3UgZm9yLW5leHQg YnJhbmNoLCBhbmQgSSBoYXZlCj4gbm90IHNlZW4gYW4gIkFwcGxpZWQiIG1lc3NhZ2UgZnJvbSB5 b3UuICBXaGF0IGlzIHRoZSBzdGF0dXMgb2YgdGhlCj4gb3ZlcmxheSBwYXRjaGVzPwo+IAo+IENv bW1lbnRzIGluIHRoZSBwYXRjaCBiZWxvdy4KPiAKPiBPbiAwMi8yMi8xOCAwNToxMywgTGF1cmVu dCBQaW5jaGFydCB3cm90ZToKPiA+IFRoZSBpbnRlcm5hbCBMVkRTIGVuY29kZXJzIG5vdyBoYXZl IHRoZWlyIG93biBEVCBiaW5kaW5ncy4gQmVmb3JlCj4gPiBzd2l0Y2hpbmcgdGhlIGRyaXZlciBp bmZyYXN0cnVjdHVyZSB0byB0aG9zZSBuZXcgYmluZGluZ3MsIGltcGxlbWVudAo+ID4gYmFja3dh cmQtY29tcGF0aWJpbGl0eSB0aHJvdWdoIGxpdmUgRFQgcGF0Y2hpbmcuCj4gPiAKPiA+IFBhdGNo aW5nIGlzIGRpc2FibGVkIGFuZCB3aWxsIGJlIGVuYWJsZWQgYWxvbmcgd2l0aCBzdXBwb3J0IGZv ciB0aGUgbmV3Cj4gPiBEVCBiaW5kaW5ncyBpbiB0aGUgRFUgZHJpdmVyLgo+ID4gCj4gPiBTaWdu ZWQtb2ZmLWJ5OiBMYXVyZW50IFBpbmNoYXJ0Cj4gPiA8bGF1cmVudC5waW5jaGFydCtyZW5lc2Fz QGlkZWFzb25ib2FyZC5jb20+Cj4gPiAtLS0KPiA+IENoYW5nZXMgc2luY2UgdjU6Cj4gPiAKPiA+ IC0gVXNlIGEgcHJpdmF0ZSBjb3B5IG9mIHJjYXJfZHVfb2ZfY2hhbmdlc2V0X2FkZF9wcm9wZXJ0 eSgpCj4gPiAKPiA+IENoYW5nZXMgc2luY2UgdjM6Cj4gPiAKPiA+IC0gVXNlIHRoZSBPRiBjaGFu Z2VzZXQgQVBJCj4gPiAtIFVzZSBvZl9ncmFwaF9nZXRfZW5kcG9pbnRfYnlfcmVncygpCj4gPiAt IFJlcGxhY2UgaGFyZGNvZGVkIGNvbnN0YW50cyBieSBzaXplb2YoKQo+ID4gCj4gPiBDaGFuZ2Vz IHNpbmNlIHYyOgo+ID4gCj4gPiAtIFVwZGF0ZSB0aGUgU1BEWCBoZWFkZXJzIHRvIHVzZSBDLXN0 eWxlIGNvbW1lbnRzIGluIGhlYWRlciBmaWxlcwo+ID4gLSBSZW1vdmVkIHRoZSBtYW51YWxseSBj cmVhdGVkIF9fbG9jYWxfZml4dXBzX18gbm9kZQo+ID4gLSBQZXJmb3JtIG1hbnVhbCBmaXh1cHMg b24gbGl2ZSBEVCBpbnN0ZWFkIG9mIG92ZXJsYXkKPiA+IAo+ID4gQ2hhbmdlcyBzaW5jZSB2MToK PiA+IAo+ID4gLSBTZWxlY3QgT0ZfRkxBVFRSRUUKPiA+IC0gQ29tcGlsZSBMVkRTIERUIGJpbmRp bmdzIHBhdGNoIGNvZGUgd2hlbiBEUk1fUkNBUl9MVkRTIGlzIHNlbGVjdGVkCj4gPiAtIFVwZGF0 ZSB0aGUgU1BEWCBoZWFkZXJzIHRvIHVzZSBHUEwtMi4wIGluc3RlYWQgb2YgR1BMLTIuMC1vbmx5 Cj4gPiAtIFR1cm4gX19kdGJfcmNhcl9kdV9vZl9sdmRzXyhiZWdpbnxlbmQpIGZyb20gdTggdG8g Y2hhcgo+ID4gLSBQYXNzIHZvaWQgYmVnaW4gYW5kIGVuZCBwb2ludGVycyB0byByY2FyX2R1X29m X2dldF9vdmVybGF5KCkKPiA+IC0gVXNlIG9mX2dldF9wYXJlbnQoKSBpbnN0ZWFkIG9mIGFjY2Vz c2luZyB0aGUgcGFyZW50IHBvaW50ZXIgZGlyZWN0bHkKPiA+IC0gRmluZCB0aGUgTFZEUyBlbmRw b2ludHMgbm9kZXMgYmFzZWQgb24gdGhlIExWRFMgbm9kZSBpbnN0ZWFkIG9mIHRoZQo+ID4gCj4g PiAgIHJvb3Qgb2YgdGhlIG92ZXJsYXkKPiA+IAo+ID4gLSBVcGRhdGUgdG8gdGhlIDxzb2M+LWx2 ZHMgY29tcGF0aWJsZSBzdHJpbmcgZm9ybWF0Cj4gPiAtLS0KPiA+IAo+ID4gIGRyaXZlcnMvZ3B1 L2RybS9yY2FyLWR1L0tjb25maWcgICAgICAgICAgICAgICAgICAgIHwgICAyICsKPiA+ICBkcml2 ZXJzL2dwdS9kcm0vcmNhci1kdS9NYWtlZmlsZSAgICAgICAgICAgICAgICAgICB8ICAgNyArLQo+ ID4gIGRyaXZlcnMvZ3B1L2RybS9yY2FyLWR1L3JjYXJfZHVfb2YuYyAgICAgICAgICAgICAgIHwg MzQyICsrKysrKysrKysrKysrKysKPiA+ICBkcml2ZXJzL2dwdS9kcm0vcmNhci1kdS9yY2FyX2R1 X29mLmggICAgICAgICAgICAgICB8ICAyMCArKwo+ID4gIC4uLi9ncHUvZHJtL3JjYXItZHUvcmNh cl9kdV9vZl9sdmRzX3I4YTc3OTAuZHRzICAgIHwgIDc5ICsrKysrCj4gPiAgLi4uL2dwdS9kcm0v cmNhci1kdS9yY2FyX2R1X29mX2x2ZHNfcjhhNzc5MS5kdHMgICAgfCAgNTMgKysrKwo+ID4gIC4u Li9ncHUvZHJtL3JjYXItZHUvcmNhcl9kdV9vZl9sdmRzX3I4YTc3OTMuZHRzICAgIHwgIDUzICsr KysKPiA+ICAuLi4vZ3B1L2RybS9yY2FyLWR1L3JjYXJfZHVfb2ZfbHZkc19yOGE3Nzk1LmR0cyAg ICB8ICA1MyArKysrCj4gPiAgLi4uL2dwdS9kcm0vcmNhci1kdS9yY2FyX2R1X29mX2x2ZHNfcjhh Nzc5Ni5kdHMgICAgfCAgNTMgKysrKwo+ID4gIDkgZmlsZXMgY2hhbmdlZCwgNjYxIGluc2VydGlv bnMoKyksIDEgZGVsZXRpb24oLSkKPiA+ICBjcmVhdGUgbW9kZSAxMDA2NDQgZHJpdmVycy9ncHUv ZHJtL3JjYXItZHUvcmNhcl9kdV9vZi5jCj4gPiAgY3JlYXRlIG1vZGUgMTAwNjQ0IGRyaXZlcnMv Z3B1L2RybS9yY2FyLWR1L3JjYXJfZHVfb2YuaAo+ID4gIGNyZWF0ZSBtb2RlIDEwMDY0NCBkcml2 ZXJzL2dwdS9kcm0vcmNhci1kdS9yY2FyX2R1X29mX2x2ZHNfcjhhNzc5MC5kdHMKPiA+ICBjcmVh dGUgbW9kZSAxMDA2NDQgZHJpdmVycy9ncHUvZHJtL3JjYXItZHUvcmNhcl9kdV9vZl9sdmRzX3I4 YTc3OTEuZHRzCj4gPiAgY3JlYXRlIG1vZGUgMTAwNjQ0IGRyaXZlcnMvZ3B1L2RybS9yY2FyLWR1 L3JjYXJfZHVfb2ZfbHZkc19yOGE3NzkzLmR0cwo+ID4gIGNyZWF0ZSBtb2RlIDEwMDY0NCBkcml2 ZXJzL2dwdS9kcm0vcmNhci1kdS9yY2FyX2R1X29mX2x2ZHNfcjhhNzc5NS5kdHMKPiA+ICBjcmVh dGUgbW9kZSAxMDA2NDQgZHJpdmVycy9ncHUvZHJtL3JjYXItZHUvcmNhcl9kdV9vZl9sdmRzX3I4 YTc3OTYuZHRzCgpbc25pcF0KCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3JjYXIt ZHUvcmNhcl9kdV9vZi5jCj4gPiBiL2RyaXZlcnMvZ3B1L2RybS9yY2FyLWR1L3JjYXJfZHVfb2Yu YyBuZXcgZmlsZSBtb2RlIDEwMDY0NAo+ID4gaW5kZXggMDAwMDAwMDAwMDAwLi5hYzQ0MmRkZmVk MTYKPiA+IC0tLSAvZGV2L251bGwKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9yY2FyLWR1L3Jj YXJfZHVfb2YuYwoKW3NuaXBdCgo+ID4gK3N0YXRpYyBpbnQgX19pbml0IHJjYXJfZHVfb2ZfYXBw bHlfb3ZlcmxheShjb25zdCBzdHJ1Y3QKPiA+IHJjYXJfZHVfb2Zfb3ZlcmxheSAqZHRicywKPiA+ ICsJCQkJCSAgIGNvbnN0IGNoYXIgKmNvbXBhdGlibGUpCj4gPiArewo+ID4gKwljb25zdCBzdHJ1 Y3QgcmNhcl9kdV9vZl9vdmVybGF5ICpkdGIgPSBOVUxMOwo+ID4gKwlzdHJ1Y3QgZGV2aWNlX25v ZGUgKm5vZGUgPSBOVUxMOwo+ID4gKwl1bnNpZ25lZCBpbnQgaTsKPiA+ICsJaW50IG92Y3NfaWQ7 Cj4gPiArCXZvaWQgKmRhdGE7Cj4gPiArCXZvaWQgKm1lbTsKPiA+ICsJaW50IHJldDsKPiA+ICsK PiA+ICsJZm9yIChpID0gMDsgZHRic1tpXS5jb21wYXRpYmxlOyArK2kpIHsKPiA+ICsJCWlmICgh c3RyY21wKGR0YnNbaV0uY29tcGF0aWJsZSwgY29tcGF0aWJsZSkpIHsKPiA+ICsJCQlkdGIgPSAm ZHRic1tpXTsKPiA+ICsJCQlicmVhazsKPiA+ICsJCX0KPiA+ICsJfQo+ID4gKwo+ID4gKwlpZiAo IWR0YikKPiA+ICsJCXJldHVybiAtRU5PREVWOwo+IAo+IF9fSWZfXyBteSBvdmVybGF5IHBhdGNo ZXMgYXJlIGFjY2VwdGVkLCB0aGlzIGJsb2NrOgo+IAo+ID4gKwo+ID4gKwlkYXRhID0ga21lbWR1 cChkdGItPmJlZ2luLCBkdGItPmVuZCAtIGR0Yi0+YmVnaW4sIEdGUF9LRVJORUwpOwo+ID4gKwlp ZiAoIWRhdGEpCj4gPiArCQlyZXR1cm4gLUVOT01FTTsKPiA+ICsKPiA+ICsJbWVtID0gb2ZfZmR0 X3VuZmxhdHRlbl90cmVlKGRhdGEsIE5VTEwsICZub2RlKTsKPiA+ICsJaWYgKCFtZW0pIHsKPiA+ ICsJCXJldCA9IC1FTk9NRU07Cj4gPiArCQlnb3RvIGRvbmU7Cj4gPiArCX0KPiA+ICsKPiA+ICsJ b3Zjc19pZCA9IDA7Cj4gPiArCXJldCA9IG9mX292ZXJsYXlfYXBwbHkobm9kZSwgJm92Y3NfaWQp Owo+ID4gKwo+ID4gK2RvbmU6Cj4gPiArCW9mX25vZGVfcHV0KG5vZGUpOwo+ID4gKwlrZnJlZShk YXRhKTsKPiA+ICsJa2ZyZWUobWVtKTsKPiAKPiBiZWNvbWVzOgo+IAo+IAlyZXQgPSBvZl9vdmVy bGF5X2ZkdF9hcHBseShkdGItPmJlZ2luLCAmb3Zjc19pZCk7CgpJIHRyaWVkIHRvIHJld29yayB0 aGlzIHBhdGNoIGluIGEgd2F5IHRoYXQgd291bGQgbWFrZSBzd2l0Y2hpbmcgdG8gRkRUIApvdmVy bGF5cyBlYXN5LCBhbmQgSSdtIGdsYWQgdG8gaGVhciBJIGhhdmVuJ3QgZG9uZSBhIHRvbyBiYWQg am9iIDotKQoKQXJlIHlvdXIgcGF0Y2hlcyBzY2hlZHVsZWQgZm9yIG1lcmdlIGluIHY0LjE3ID8g SWYgc28sIGlzIGl0IHBvc3NpYmxlIHRvIGdldCAKYXBwbHkgdGhlbSBpbiBhIHN0YWJsZSBicmFu Y2ggb24gdG9wIG9mIHY0LjE2LXJjMSB0aGF0IGNhbiBiZSBtZXJnZWQgYXMgYSAKZGVwZW5kZW5j eSBmb3IgdGhpcyBzZXJpZXMgPyBUaGVyZSBhcmUgY2hhbmdlcyB0byB0aGUgUmVuZXNhcyBEVCBx dWV1ZWQgZm9yIAptZXJnZSBpbiB2NC4xNyB0aGF0IHdvdWxkIG1ha2UgZGVsYXlpbmcgdGhpcyBw YXRjaCBzZXJpZXMgdG8gdjQuMTggcXVpdGUgCnBhaW5mdWwuCgo+IElmIG15IG92ZXJsYXkgcGF0 Y2hlcyBkbyBub3QgZXhpc3QsIHRoZXJlIGFyZSBvdGhlciBzbWFsbCBlcnJvcnMKPiBpbiB0aGUg Y29kZSBibG9jayBhYm92ZS4gIEknbGwgaWdub3JlIHRoZW0gZm9yIHRoZSBtb21lbnQuCj4gCj4g QSBxdWljayBzY2FuIG9mIHRoZSByZXN0IG9mIHRoZSBjb2RlIGxvb2tzIE9LLiAgSSdsbCByZWFk IHRocm91Z2ggaXQKPiBtb3JlIGNhcmVmdWxseSwgYnV0IHdhbnRlZCB0byBnZXQgdGhpcyByZXBs eSBvdXQgd2l0aG91dCBmdXJ0aGVyCj4gZGVsYXkuCgpUaGFuayB5b3UuCgo+ID4gKwo+ID4gKwly ZXR1cm4gcmV0Owo+ID4gK30KCltzbmlwXQoKLS0gClJlZ2FyZHMsCgpMYXVyZW50IFBpbmNoYXJ0 CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2 ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK