From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33984)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1bXQhB-00007d-5U
	for qemu-devel@nongnu.org; Wed, 10 Aug 2016 06:25:10 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1bXQh7-0001gD-5G
	for qemu-devel@nongnu.org; Wed, 10 Aug 2016 06:25:09 -0400
Received: from mx4-phx2.redhat.com ([209.132.183.25]:51353)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1bXQh6-0001fx-Rx
	for qemu-devel@nongnu.org; Wed, 10 Aug 2016 06:25:05 -0400
Date: Wed, 10 Aug 2016 06:25:02 -0400 (EDT)
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <1615109044.796866.1470824702137.JavaMail.zimbra@redhat.com>
In-Reply-To: <d3bf866c-88a4-5101-fbac-95b49f6bbbe6@redhat.com>
References: <1470817370-145190-1-git-send-email-pbonzini@redhat.com>
	<1470817370-145190-5-git-send-email-pbonzini@redhat.com>
	<d3bf866c-88a4-5101-fbac-95b49f6bbbe6@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 4/5] checkpatch: bump most warnings to
 errors
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Thomas Huth <thuth@redhat.com>
Cc: qemu-devel@nongnu.org, armbru@redhat.com, famz@redhat.com, cornelia huck <cornelia.huck@de.ibm.com>


> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> > index 714a000..ab08ca2 100755
> > --- a/scripts/checkpatch.pl
> > +++ b/scripts/checkpatch.pl
> > @@ -1289,11 +1289,11 @@ sub process {
> >  			# This is a signoff, if ugly, so do not double report.
> >  			$signoff++;
> >  			if (!($line =~ /^\s*Signed-off-by:/)) {
> > -				WARN("Signed-off-by: is the preferred form\n" .
> > +				ERROR("Signed-off-by: is the preferred form\n" .
> >  					$herecurr);
> >  			}
> 
> If you turn this into an ERROR, it's not the "preferred form" anymore,
> but the "mandated form". So I'd suggest to either keep it as WARN or to
> rephrase the message.

What about:

                                ERROR("Signed-off-by: is spelled with uppercase \"s\"\n" .
                                        $herecurr);

Paolo