From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D97A7C433DB for ; Mon, 8 Mar 2021 02:01:20 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 754FC6514A for ; Mon, 8 Mar 2021 02:01:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 754FC6514A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:CC:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=WDVQqfkOQWCumUQSXc0XxwO+9smARpt/79xfNefMNy4=; b=ViLjIZBepp1c2GzrEwM2uFXQU G/KTo1YLqc0WD+kiI3os2s4sc/V7KryTakxcsGaVHI5g4FQximZxkeSBNw1pxseTr/B2qpfV7AXr/ IvuL4YPuEhVyEDa1kl2ESbQa7akUg6wBuMFM8cf/XT9Xmr4B/fZhbMH+0ksqd4e9sosViZ4ag5xfd K8ZfDyOKy+WsTWV5WbLP2J9HKLdyLBUokL9LQzYrE4cm8TOw3YkO7lOxkP9ZbTZuKRK9y05MgHqaX kUFZYUXpLQCb0AcHfwuzP4/Y2u8GerCIjxJSRywAJ0r9VWM5YOBGGbb+MaXxDTqNSKdliP590TceP yWYu/u9mQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lJ5Cg-00EUJC-TV; Mon, 08 Mar 2021 02:01:03 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lJ5CJ-00EUC9-CE; Mon, 08 Mar 2021 02:00:44 +0000 X-UUID: 98f7d3afff8c415c86ed8798dcc1e105-20210307 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=6qYg+DJBSG1Du8y4MYkkOeqRrd9rwS5CN17jsGP6xzU=; b=WA6IpcBHguky+rMLAFcyeVeWfUfnqQYsRTb61ouCgT1I0ZyCZePG80OX9mfkEuH61webF2JR7kblsyqAwLYBVgnRR6TuJQkIfPfOXB4TsBGTJ/4vYovdhyD7mruRBO+S5rJJBhN+k4ZwSNlS88y6kVXiEGZMfT45EsTO46FcwVY=; X-UUID: 98f7d3afff8c415c86ed8798dcc1e105-20210307 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 2017903374; Sun, 07 Mar 2021 18:00:30 -0800 Received: from MTKMBS06N2.mediatek.inc (172.21.101.130) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sun, 7 Mar 2021 17:59:05 -0800 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by mtkmbs06n2.mediatek.inc (172.21.101.130) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 8 Mar 2021 09:58:37 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 8 Mar 2021 09:58:36 +0800 Message-ID: <1615168716.32109.6.camel@mhfsdcap03> Subject: Re: [PATCH 16/17] usb: common: add function to get interval expressed in us unit From: Chunfeng Yun To: Alan Stern CC: Mathias Nyman , Greg Kroah-Hartman , Ikjoon Jang , "Matthias Brugger" , , , , , Nicolas Boichat , Eddie Hung Date: Mon, 8 Mar 2021 09:58:36 +0800 In-Reply-To: <20210305153312.GA38200@rowland.harvard.edu> References: <1614934975-15188-1-git-send-email-chunfeng.yun@mediatek.com> <1614934975-15188-16-git-send-email-chunfeng.yun@mediatek.com> <20210305153312.GA38200@rowland.harvard.edu> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: AA76056FEB5929E229E6F99F439BC3A0267241E9DCA4D6CBEACABBBCC2768C852000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210308_020040_653665_61FA62BD X-CRM114-Status: GOOD ( 19.07 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Fri, 2021-03-05 at 10:33 -0500, Alan Stern wrote: > On Fri, Mar 05, 2021 at 05:02:54PM +0800, Chunfeng Yun wrote: > > Add a new function to convert bInterval into the time expressed > > in 1us unit. > > > > Signed-off-by: Chunfeng Yun > > --- > > > --- a/drivers/usb/common/common.c > > +++ b/drivers/usb/common/common.c > > @@ -165,6 +165,39 @@ enum usb_dr_mode usb_get_dr_mode(struct device *dev) > > } > > EXPORT_SYMBOL_GPL(usb_get_dr_mode); > > > > +unsigned int usb_decode_interval(const struct usb_endpoint_descriptor *epd, > > + enum usb_device_speed speed) > > +{ > > + unsigned int interval = 0; > > + > > + switch (usb_endpoint_type(epd)) { > > + case USB_ENDPOINT_XFER_CONTROL: > > + /* uframes per NAK */ > > + if (speed == USB_SPEED_HIGH) > > + interval = epd->bInterval; > > + break; > > + case USB_ENDPOINT_XFER_ISOC: > > + interval = 1 << (epd->bInterval - 1); > > + break; > > + case USB_ENDPOINT_XFER_BULK: > > + /* uframes per NAK */ > > + if (speed == USB_SPEED_HIGH && usb_endpoint_dir_out(epd)) > > + interval = epd->bInterval; > > + break; > > + case USB_ENDPOINT_XFER_INT: > > + if (speed >= USB_SPEED_HIGH) > > + interval = 1 << (epd->bInterval - 1); > > + else > > + interval = epd->bInterval; > > + break; > > + } > > + > > + interval *= (speed >= USB_SPEED_HIGH) ? 125 : 1000; > > + > > + return interval; > > +} > > +EXPORT_SYMBOL_GPL(usb_decode_interval); > > > --- a/include/linux/usb/ch9.h > > +++ b/include/linux/usb/ch9.h > > @@ -90,6 +90,17 @@ extern enum usb_ssp_rate usb_get_maximum_ssp_rate(struct device *dev); > > */ > > extern const char *usb_state_string(enum usb_device_state state); > > > > +/** > > + * usb_decode_interval - Decode bInterval into the time expressed in 1us unit > > + * @epd: The descriptor of the endpoint > > + * @speed: The speed that the endpoint works as > > + * > > + * Function returns the interval expressed in 1us unit for servicing > > + * endpoint for data transfers. > > + */ > > +unsigned int usb_decode_interval(const struct usb_endpoint_descriptor *epd, > > + enum usb_device_speed speed); > > As a general rule, I believe people expect to find the kerneldoc for a > function next to the function's definition, not next to the declaration > in a header file. Got it, thanks > > Alan Stern _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A7C8C433E0 for ; Mon, 8 Mar 2021 02:00:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5F75065142 for ; Mon, 8 Mar 2021 02:00:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233590AbhCHB77 (ORCPT ); Sun, 7 Mar 2021 20:59:59 -0500 Received: from mailgw02.mediatek.com ([210.61.82.184]:56212 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S233588AbhCHB7t (ORCPT ); Sun, 7 Mar 2021 20:59:49 -0500 X-UUID: 5829353be91c45ce80dc07f32882201d-20210308 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=6qYg+DJBSG1Du8y4MYkkOeqRrd9rwS5CN17jsGP6xzU=; b=WA6IpcBHguky+rMLAFcyeVeWfUfnqQYsRTb61ouCgT1I0ZyCZePG80OX9mfkEuH61webF2JR7kblsyqAwLYBVgnRR6TuJQkIfPfOXB4TsBGTJ/4vYovdhyD7mruRBO+S5rJJBhN+k4ZwSNlS88y6kVXiEGZMfT45EsTO46FcwVY=; X-UUID: 5829353be91c45ce80dc07f32882201d-20210308 Received: from mtkexhb01.mediatek.inc [(172.21.101.102)] by mailgw02.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.14 Build 0819 with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1233242520; Mon, 08 Mar 2021 09:59:34 +0800 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by mtkmbs06n2.mediatek.inc (172.21.101.130) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 8 Mar 2021 09:58:37 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 8 Mar 2021 09:58:36 +0800 Message-ID: <1615168716.32109.6.camel@mhfsdcap03> Subject: Re: [PATCH 16/17] usb: common: add function to get interval expressed in us unit From: Chunfeng Yun To: Alan Stern CC: Mathias Nyman , Greg Kroah-Hartman , Ikjoon Jang , "Matthias Brugger" , , , , , Nicolas Boichat , Eddie Hung Date: Mon, 8 Mar 2021 09:58:36 +0800 In-Reply-To: <20210305153312.GA38200@rowland.harvard.edu> References: <1614934975-15188-1-git-send-email-chunfeng.yun@mediatek.com> <1614934975-15188-16-git-send-email-chunfeng.yun@mediatek.com> <20210305153312.GA38200@rowland.harvard.edu> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: AA76056FEB5929E229E6F99F439BC3A0267241E9DCA4D6CBEACABBBCC2768C852000:8 X-MTK: N Content-Transfer-Encoding: base64 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org T24gRnJpLCAyMDIxLTAzLTA1IGF0IDEwOjMzIC0wNTAwLCBBbGFuIFN0ZXJuIHdyb3RlOg0KPiBP biBGcmksIE1hciAwNSwgMjAyMSBhdCAwNTowMjo1NFBNICswODAwLCBDaHVuZmVuZyBZdW4gd3Jv dGU6DQo+ID4gQWRkIGEgbmV3IGZ1bmN0aW9uIHRvIGNvbnZlcnQgYkludGVydmFsIGludG8gdGhl IHRpbWUgZXhwcmVzc2VkDQo+ID4gaW4gMXVzIHVuaXQuDQo+ID4gDQo+ID4gU2lnbmVkLW9mZi1i eTogQ2h1bmZlbmcgWXVuIDxjaHVuZmVuZy55dW5AbWVkaWF0ZWsuY29tPg0KPiA+IC0tLQ0KPiAN Cj4gPiAtLS0gYS9kcml2ZXJzL3VzYi9jb21tb24vY29tbW9uLmMNCj4gPiArKysgYi9kcml2ZXJz L3VzYi9jb21tb24vY29tbW9uLmMNCj4gPiBAQCAtMTY1LDYgKzE2NSwzOSBAQCBlbnVtIHVzYl9k cl9tb2RlIHVzYl9nZXRfZHJfbW9kZShzdHJ1Y3QgZGV2aWNlICpkZXYpDQo+ID4gIH0NCj4gPiAg RVhQT1JUX1NZTUJPTF9HUEwodXNiX2dldF9kcl9tb2RlKTsNCj4gPiAgDQo+ID4gK3Vuc2lnbmVk IGludCB1c2JfZGVjb2RlX2ludGVydmFsKGNvbnN0IHN0cnVjdCB1c2JfZW5kcG9pbnRfZGVzY3Jp cHRvciAqZXBkLA0KPiA+ICsJCQkJIGVudW0gdXNiX2RldmljZV9zcGVlZCBzcGVlZCkNCj4gPiAr ew0KPiA+ICsJdW5zaWduZWQgaW50IGludGVydmFsID0gMDsNCj4gPiArDQo+ID4gKwlzd2l0Y2gg KHVzYl9lbmRwb2ludF90eXBlKGVwZCkpIHsNCj4gPiArCWNhc2UgVVNCX0VORFBPSU5UX1hGRVJf Q09OVFJPTDoNCj4gPiArCQkvKiB1ZnJhbWVzIHBlciBOQUsgKi8NCj4gPiArCQlpZiAoc3BlZWQg PT0gVVNCX1NQRUVEX0hJR0gpDQo+ID4gKwkJCWludGVydmFsID0gZXBkLT5iSW50ZXJ2YWw7DQo+ ID4gKwkJYnJlYWs7DQo+ID4gKwljYXNlIFVTQl9FTkRQT0lOVF9YRkVSX0lTT0M6DQo+ID4gKwkJ aW50ZXJ2YWwgPSAxIDw8IChlcGQtPmJJbnRlcnZhbCAtIDEpOw0KPiA+ICsJCWJyZWFrOw0KPiA+ ICsJY2FzZSBVU0JfRU5EUE9JTlRfWEZFUl9CVUxLOg0KPiA+ICsJCS8qIHVmcmFtZXMgcGVyIE5B SyAqLw0KPiA+ICsJCWlmIChzcGVlZCA9PSBVU0JfU1BFRURfSElHSCAmJiB1c2JfZW5kcG9pbnRf ZGlyX291dChlcGQpKQ0KPiA+ICsJCQlpbnRlcnZhbCA9IGVwZC0+YkludGVydmFsOw0KPiA+ICsJ CWJyZWFrOw0KPiA+ICsJY2FzZSBVU0JfRU5EUE9JTlRfWEZFUl9JTlQ6DQo+ID4gKwkJaWYgKHNw ZWVkID49IFVTQl9TUEVFRF9ISUdIKQ0KPiA+ICsJCQlpbnRlcnZhbCA9IDEgPDwgKGVwZC0+Yklu dGVydmFsIC0gMSk7DQo+ID4gKwkJZWxzZQ0KPiA+ICsJCQlpbnRlcnZhbCA9IGVwZC0+YkludGVy dmFsOw0KPiA+ICsJCWJyZWFrOw0KPiA+ICsJfQ0KPiA+ICsNCj4gPiArCWludGVydmFsICo9IChz cGVlZCA+PSBVU0JfU1BFRURfSElHSCkgPyAxMjUgOiAxMDAwOw0KPiA+ICsNCj4gPiArCXJldHVy biBpbnRlcnZhbDsNCj4gPiArfQ0KPiA+ICtFWFBPUlRfU1lNQk9MX0dQTCh1c2JfZGVjb2RlX2lu dGVydmFsKTsNCj4gDQo+ID4gLS0tIGEvaW5jbHVkZS9saW51eC91c2IvY2g5LmgNCj4gPiArKysg Yi9pbmNsdWRlL2xpbnV4L3VzYi9jaDkuaA0KPiA+IEBAIC05MCw2ICs5MCwxNyBAQCBleHRlcm4g ZW51bSB1c2Jfc3NwX3JhdGUgdXNiX2dldF9tYXhpbXVtX3NzcF9yYXRlKHN0cnVjdCBkZXZpY2Ug KmRldik7DQo+ID4gICAqLw0KPiA+ICBleHRlcm4gY29uc3QgY2hhciAqdXNiX3N0YXRlX3N0cmlu ZyhlbnVtIHVzYl9kZXZpY2Vfc3RhdGUgc3RhdGUpOw0KPiA+ICANCj4gPiArLyoqDQo+ID4gKyAq IHVzYl9kZWNvZGVfaW50ZXJ2YWwgLSBEZWNvZGUgYkludGVydmFsIGludG8gdGhlIHRpbWUgZXhw cmVzc2VkIGluIDF1cyB1bml0DQo+ID4gKyAqIEBlcGQ6IFRoZSBkZXNjcmlwdG9yIG9mIHRoZSBl bmRwb2ludA0KPiA+ICsgKiBAc3BlZWQ6IFRoZSBzcGVlZCB0aGF0IHRoZSBlbmRwb2ludCB3b3Jr cyBhcw0KPiA+ICsgKg0KPiA+ICsgKiBGdW5jdGlvbiByZXR1cm5zIHRoZSBpbnRlcnZhbCBleHBy ZXNzZWQgaW4gMXVzIHVuaXQgZm9yIHNlcnZpY2luZw0KPiA+ICsgKiBlbmRwb2ludCBmb3IgZGF0 YSB0cmFuc2ZlcnMuDQo+ID4gKyAqLw0KPiA+ICt1bnNpZ25lZCBpbnQgdXNiX2RlY29kZV9pbnRl cnZhbChjb25zdCBzdHJ1Y3QgdXNiX2VuZHBvaW50X2Rlc2NyaXB0b3IgKmVwZCwNCj4gPiArCQkJ CSBlbnVtIHVzYl9kZXZpY2Vfc3BlZWQgc3BlZWQpOw0KPiANCj4gQXMgYSBnZW5lcmFsIHJ1bGUs IEkgYmVsaWV2ZSBwZW9wbGUgZXhwZWN0IHRvIGZpbmQgdGhlIGtlcm5lbGRvYyBmb3IgYSANCj4g ZnVuY3Rpb24gbmV4dCB0byB0aGUgZnVuY3Rpb24ncyBkZWZpbml0aW9uLCBub3QgbmV4dCB0byB0 aGUgZGVjbGFyYXRpb24gDQo+IGluIGEgaGVhZGVyIGZpbGUuDQpHb3QgaXQsIHRoYW5rcw0KDQo+ IA0KPiBBbGFuIFN0ZXJuDQoNCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 862FDC433DB for ; Mon, 8 Mar 2021 02:02:24 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 17DE26513A for ; Mon, 8 Mar 2021 02:02:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 17DE26513A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:CC:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=llCt4TJTn9Y0F+Uuu40OORm6/03LHI4BZ0GCoYxgi3Y=; b=SJLzyxDVpFcnffBPGgdwwvRCa SVU+vv+liR/DJq299xYMpBqEssVEKlom1LfWGnok1R4ChcyE/KiQc0JnmEHVx3bnimg+4L/wuFlsz LcUXUVXyWtEyA2+N/ftA531kVUd6+g0bbiSx0EERAZSX7Y2ZEP4TBpZA2UopFKd3EXjAZK3AEDPTR ELFLLJ9SkxU68qQAz72Kty3AOTbqUrM2SZyZGmAmyWjcXpm318zF/fnjBk5fKmlPBqf4yeZHBe4tQ 0X3lO91J/165mFeT9mtVGdVly9HoZ9LDxpgMCJogUangjYZzbxM8X2r8wcDZscSXA7c/rm4vD81rK 8wa/Iig3Q==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lJ5CT-00EUFY-6E; Mon, 08 Mar 2021 02:00:49 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lJ5CJ-00EUC9-CE; Mon, 08 Mar 2021 02:00:44 +0000 X-UUID: 98f7d3afff8c415c86ed8798dcc1e105-20210307 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=6qYg+DJBSG1Du8y4MYkkOeqRrd9rwS5CN17jsGP6xzU=; b=WA6IpcBHguky+rMLAFcyeVeWfUfnqQYsRTb61ouCgT1I0ZyCZePG80OX9mfkEuH61webF2JR7kblsyqAwLYBVgnRR6TuJQkIfPfOXB4TsBGTJ/4vYovdhyD7mruRBO+S5rJJBhN+k4ZwSNlS88y6kVXiEGZMfT45EsTO46FcwVY=; X-UUID: 98f7d3afff8c415c86ed8798dcc1e105-20210307 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 2017903374; Sun, 07 Mar 2021 18:00:30 -0800 Received: from MTKMBS06N2.mediatek.inc (172.21.101.130) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sun, 7 Mar 2021 17:59:05 -0800 Received: from MTKCAS32.mediatek.inc (172.27.4.184) by mtkmbs06n2.mediatek.inc (172.21.101.130) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 8 Mar 2021 09:58:37 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS32.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 8 Mar 2021 09:58:36 +0800 Message-ID: <1615168716.32109.6.camel@mhfsdcap03> Subject: Re: [PATCH 16/17] usb: common: add function to get interval expressed in us unit From: Chunfeng Yun To: Alan Stern CC: Mathias Nyman , Greg Kroah-Hartman , Ikjoon Jang , "Matthias Brugger" , , , , , Nicolas Boichat , Eddie Hung Date: Mon, 8 Mar 2021 09:58:36 +0800 In-Reply-To: <20210305153312.GA38200@rowland.harvard.edu> References: <1614934975-15188-1-git-send-email-chunfeng.yun@mediatek.com> <1614934975-15188-16-git-send-email-chunfeng.yun@mediatek.com> <20210305153312.GA38200@rowland.harvard.edu> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: AA76056FEB5929E229E6F99F439BC3A0267241E9DCA4D6CBEACABBBCC2768C852000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210308_020040_653665_61FA62BD X-CRM114-Status: GOOD ( 19.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 2021-03-05 at 10:33 -0500, Alan Stern wrote: > On Fri, Mar 05, 2021 at 05:02:54PM +0800, Chunfeng Yun wrote: > > Add a new function to convert bInterval into the time expressed > > in 1us unit. > > > > Signed-off-by: Chunfeng Yun > > --- > > > --- a/drivers/usb/common/common.c > > +++ b/drivers/usb/common/common.c > > @@ -165,6 +165,39 @@ enum usb_dr_mode usb_get_dr_mode(struct device *dev) > > } > > EXPORT_SYMBOL_GPL(usb_get_dr_mode); > > > > +unsigned int usb_decode_interval(const struct usb_endpoint_descriptor *epd, > > + enum usb_device_speed speed) > > +{ > > + unsigned int interval = 0; > > + > > + switch (usb_endpoint_type(epd)) { > > + case USB_ENDPOINT_XFER_CONTROL: > > + /* uframes per NAK */ > > + if (speed == USB_SPEED_HIGH) > > + interval = epd->bInterval; > > + break; > > + case USB_ENDPOINT_XFER_ISOC: > > + interval = 1 << (epd->bInterval - 1); > > + break; > > + case USB_ENDPOINT_XFER_BULK: > > + /* uframes per NAK */ > > + if (speed == USB_SPEED_HIGH && usb_endpoint_dir_out(epd)) > > + interval = epd->bInterval; > > + break; > > + case USB_ENDPOINT_XFER_INT: > > + if (speed >= USB_SPEED_HIGH) > > + interval = 1 << (epd->bInterval - 1); > > + else > > + interval = epd->bInterval; > > + break; > > + } > > + > > + interval *= (speed >= USB_SPEED_HIGH) ? 125 : 1000; > > + > > + return interval; > > +} > > +EXPORT_SYMBOL_GPL(usb_decode_interval); > > > --- a/include/linux/usb/ch9.h > > +++ b/include/linux/usb/ch9.h > > @@ -90,6 +90,17 @@ extern enum usb_ssp_rate usb_get_maximum_ssp_rate(struct device *dev); > > */ > > extern const char *usb_state_string(enum usb_device_state state); > > > > +/** > > + * usb_decode_interval - Decode bInterval into the time expressed in 1us unit > > + * @epd: The descriptor of the endpoint > > + * @speed: The speed that the endpoint works as > > + * > > + * Function returns the interval expressed in 1us unit for servicing > > + * endpoint for data transfers. > > + */ > > +unsigned int usb_decode_interval(const struct usb_endpoint_descriptor *epd, > > + enum usb_device_speed speed); > > As a general rule, I believe people expect to find the kerneldoc for a > function next to the function's definition, not next to the declaration > in a header file. Got it, thanks > > Alan Stern _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel