RE: [PATCH 1/2] drm/stm: dsi: Avoid printing errors for -EPROBE_DEFER

[Philippe CORNU - foss <philippe.cornu@foss.st.com>]

[-- Attachment #1.1: Type: text/plain, Size: 2940 bytes --]

Applied on drm-misc-next.
Many thanks Raphaël & Yannick for your patch.
Note: I have updated the "From:" field to yannick.fertre@foss.st.com for more consistency.
Philippe :-)


________________________________
De : Yannick FERTRE - foss
Envoyé : lundi 8 mars 2021 10:10
À : Raphael GALLAIS-POU - foss; Yannick FERTRE; Philippe CORNU; Benjamin Gaignard; Vincent ABRIOU; Sam Ravnborg; Joe Perches
Cc : David Airlie; Daniel Vetter; Maxime Coquelin; Alexandre TORGUE; dri-devel@lists.freedesktop.org; linux-stm32@st-md-mailman.stormreply.com; linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org; Philippe CORNU - foss; Raphael GALLAIS-POU; Alexandre TORGUE - foss
Objet : Re: [PATCH 1/2] drm/stm: dsi: Avoid printing errors for -EPROBE_DEFER

Tested-by: Yannick Fertre <yannick.fertre@foss.st.com>

On 2/22/21 10:22 AM, Raphael GALLAIS-POU - foss wrote:
> From: Yannick Fertre <yannick.fertre@st.com>
>
> Don't print error when probe deferred error is returned.
>
> Signed-off-by: Raphael Gallais-Pou <raphael.gallais-pou@foss.st.com>
> Signed-off-by: Yannick Fertre <yannick.fertre@foss.st.com>
> ---
>   drivers/gpu/drm/stm/dw_mipi_dsi-stm.c | 9 +++------
>   1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c b/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
> index 2e1f2664495d..8399d337589d 100644
> --- a/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
> +++ b/drivers/gpu/drm/stm/dw_mipi_dsi-stm.c
> @@ -363,8 +363,7 @@ static int dw_mipi_dsi_stm_probe(struct platform_device *pdev)
>        dsi->vdd_supply = devm_regulator_get(dev, "phy-dsi");
>        if (IS_ERR(dsi->vdd_supply)) {
>                ret = PTR_ERR(dsi->vdd_supply);
> -             if (ret != -EPROBE_DEFER)
> -                     DRM_ERROR("Failed to request regulator: %d\n", ret);
> +             dev_err_probe(dev, ret, "Failed to request regulator\n");
>                return ret;
>        }
>
> @@ -377,9 +376,7 @@ static int dw_mipi_dsi_stm_probe(struct platform_device *pdev)
>        dsi->pllref_clk = devm_clk_get(dev, "ref");
>        if (IS_ERR(dsi->pllref_clk)) {
>                ret = PTR_ERR(dsi->pllref_clk);
> -             if (ret != -EPROBE_DEFER)
> -                     DRM_ERROR("Unable to get pll reference clock: %d\n",
> -                               ret);
> +             dev_err_probe(dev, ret, "Unable to get pll reference clock\n");
>                goto err_clk_get;
>        }
>
> @@ -419,7 +416,7 @@ static int dw_mipi_dsi_stm_probe(struct platform_device *pdev)
>        dsi->dsi = dw_mipi_dsi_probe(pdev, &dw_mipi_dsi_stm_plat_data);
>        if (IS_ERR(dsi->dsi)) {
>                ret = PTR_ERR(dsi->dsi);
> -             DRM_ERROR("Failed to initialize mipi dsi host: %d\n", ret);
> +             dev_err_probe(dev, ret, "Failed to initialize mipi dsi host\n");
>                goto err_dsi_probe;
>        }
>
>

[-- Attachment #1.2: Type: text/html, Size: 5968 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel