From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3388AC433E0 for ; Wed, 10 Mar 2021 09:04:42 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 943FE64F2D for ; Wed, 10 Mar 2021 09:04:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 943FE64F2D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:CC:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Uv+XkugVjj0q6/CiEhA4e2uLTHhpwn/50i7gpr7Euuw=; b=jWCXhXZgEe4J9QojC1z2nms1u NiBdmZh5s2CANQ9cp0s7pd8RnkR1u8OGeNYXQV1HwF1TmNpZ7Qkh2xGCWDEXY3+nzxQAufISqMRvl n4U6uOH1nRl5q8exf1ckYiFM6G6/Dsjv5cw+S+7bCmodgY8Dm4XmuECoN2Vf3WcaV6N9B3ZCic9Wc 31fn9cN9wficgOEEmeDNmJJzTnYbHTNPYoutqA7QZPOU7/BVxvTnNDjyQ7Zq9uF1iA5uv7tAs93P8 KfZpagBgM7KCz0RZc0L8WTt9F7AjYEwoGKE4pvPsiXPrR9kJOrH2gIfMpPEo6OgBS0mExdJ5c8YTS yjPHSnlEA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lJulb-006OZD-6s; Wed, 10 Mar 2021 09:04:31 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lJulT-006OXX-Vb for linux-mediatek@lists.infradead.org; Wed, 10 Mar 2021 09:04:29 +0000 X-UUID: 9de2fb2e02874fb18ea8450fa10f1e5e-20210310 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=SdbKNEFQj6KE5ljqlY4DgijhePB6jeycIgwGj26hkrs=; b=OSypZczU+tVQt1VjGZtF8rB8AFyU2t1M2SSJcQDC/huBrk1njRnSQNXl762m2zu3yS9jgExy49Tvf6h+WmYQWsyqc2SNb6paCpR6FoWsS8x181ISwTZ4sdxM63RGbCGKo27DRIrt6aW13yB2RNPt+SSMvU7Ru4IsRRl6eAs0xJ4=; X-UUID: 9de2fb2e02874fb18ea8450fa10f1e5e-20210310 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1987712512; Wed, 10 Mar 2021 01:04:13 -0800 Received: from MTKMBS06N2.mediatek.inc (172.21.101.130) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 10 Mar 2021 00:54:53 -0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs06n2.mediatek.inc (172.21.101.130) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 10 Mar 2021 16:54:50 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 10 Mar 2021 16:54:50 +0800 Message-ID: <1615366490.10387.0.camel@mtkswgap22> Subject: Re: [kbuild] Re: [PATCH v2 1/2] mt76: mt7915: add missing capabilities for DBDC From: Ryder Lee To: Dan Carpenter CC: , Felix Fietkau , Lorenzo Bianconi , , , Shayne Chen , , Date: Wed, 10 Mar 2021 16:54:50 +0800 In-Reply-To: <20210310083018.GH21246@kadam> References: <20210310083018.GH21246@kadam> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-TM-SNTS-SMTP: 52A78F482FCA1BF0DDF7F8DA1A1595CE86E8C0FD9664E8A8406C51CE7AFA5D132000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210310_090425_469984_FFF523BD X-CRM114-Status: UNSURE ( 9.73 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Wed, 2021-03-10 at 11:30 +0300, Dan Carpenter wrote: > Hi Ryder, > > url: https://github.com/0day-ci/linux/commits/Ryder-Lee/mt76-mt7915-add-missing-capabilities-for-DBDC/20210225-230323 > base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master > config: x86_64-randconfig-m001-20210309 (attached as .config) > compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > Reported-by: Dan Carpenter > > smatch warnings: > drivers/net/wireless/mediatek/mt76/mt7915/init.c:353 mt7915_set_stream_vht_txbf_caps() error: potentially dereferencing uninitialized 'cap'. > > vim +/cap +353 drivers/net/wireless/mediatek/mt76/mt7915/init.c > > 00b2e16e006390 Ryder Lee 2020-05-12 344 void mt7915_set_stream_vht_txbf_caps(struct mt7915_phy *phy) > 00b2e16e006390 Ryder Lee 2020-05-12 345 { > 50a6fe79623e22 Ryder Lee 2021-02-25 346 int nss; > 50a6fe79623e22 Ryder Lee 2021-02-25 347 u32 *cap; > 50a6fe79623e22 Ryder Lee 2021-02-25 348 > 50a6fe79623e22 Ryder Lee 2021-02-25 349 if (!phy->mt76->cap.has_5ghz) > 50a6fe79623e22 Ryder Lee 2021-02-25 350 return; > 50a6fe79623e22 Ryder Lee 2021-02-25 351 > 50a6fe79623e22 Ryder Lee 2021-02-25 352 nss = hweight8(phy->mt76->chainmask); > 50a6fe79623e22 Ryder Lee 2021-02-25 @353 *cap = &phy->mt76->sband_5g.sband.vht_cap.cap; > ^^^^ > "cap" isn't initialized. This has been fixed in v3 https://patchwork.kernel.org/project/linux-mediatek/patch/427ab5a2a79b8bbfa05225cfe4cfb55b3f143c8c.1614357346.git.ryder.lee@mediatek.com/ Ryder _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD9A4C433E0 for ; Wed, 10 Mar 2021 08:55:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6984B64FEE for ; Wed, 10 Mar 2021 08:55:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229643AbhCJIzO (ORCPT ); Wed, 10 Mar 2021 03:55:14 -0500 Received: from mailgw02.mediatek.com ([210.61.82.184]:43030 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S232523AbhCJIyy (ORCPT ); Wed, 10 Mar 2021 03:54:54 -0500 X-UUID: 3d8355c8defd4eeda4875086578c8b15-20210310 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=SdbKNEFQj6KE5ljqlY4DgijhePB6jeycIgwGj26hkrs=; b=OSypZczU+tVQt1VjGZtF8rB8AFyU2t1M2SSJcQDC/huBrk1njRnSQNXl762m2zu3yS9jgExy49Tvf6h+WmYQWsyqc2SNb6paCpR6FoWsS8x181ISwTZ4sdxM63RGbCGKo27DRIrt6aW13yB2RNPt+SSMvU7Ru4IsRRl6eAs0xJ4=; X-UUID: 3d8355c8defd4eeda4875086578c8b15-20210310 Received: from mtkexhb01.mediatek.inc [(172.21.101.102)] by mailgw02.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.14 Build 0819 with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 711503969; Wed, 10 Mar 2021 16:54:52 +0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs06n2.mediatek.inc (172.21.101.130) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 10 Mar 2021 16:54:50 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 10 Mar 2021 16:54:50 +0800 Message-ID: <1615366490.10387.0.camel@mtkswgap22> Subject: Re: [kbuild] Re: [PATCH v2 1/2] mt76: mt7915: add missing capabilities for DBDC From: Ryder Lee To: Dan Carpenter CC: , Felix Fietkau , Lorenzo Bianconi , , , Shayne Chen , , Date: Wed, 10 Mar 2021 16:54:50 +0800 In-Reply-To: <20210310083018.GH21246@kadam> References: <20210310083018.GH21246@kadam> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-TM-SNTS-SMTP: 52A78F482FCA1BF0DDF7F8DA1A1595CE86E8C0FD9664E8A8406C51CE7AFA5D132000:8 X-MTK: N Content-Transfer-Encoding: base64 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org T24gV2VkLCAyMDIxLTAzLTEwIGF0IDExOjMwICswMzAwLCBEYW4gQ2FycGVudGVyIHdyb3RlOg0K PiBIaSBSeWRlciwNCj4gDQo+IHVybDogICAgaHR0cHM6Ly9naXRodWIuY29tLzBkYXktY2kvbGlu dXgvY29tbWl0cy9SeWRlci1MZWUvbXQ3Ni1tdDc5MTUtYWRkLW1pc3NpbmctY2FwYWJpbGl0aWVz LWZvci1EQkRDLzIwMjEwMjI1LTIzMDMyMyANCj4gYmFzZTogICBodHRwczovL2dpdC5rZXJuZWwu b3JnL3B1Yi9zY20vbGludXgva2VybmVsL2dpdC9rdmFsby93aXJlbGVzcy1kcml2ZXJzLW5leHQu Z2l0ICBtYXN0ZXINCj4gY29uZmlnOiB4ODZfNjQtcmFuZGNvbmZpZy1tMDAxLTIwMjEwMzA5IChh dHRhY2hlZCBhcyAuY29uZmlnKQ0KPiBjb21waWxlcjogZ2NjLTkgKERlYmlhbiA5LjMuMC0yMikg OS4zLjANCj4gDQo+IElmIHlvdSBmaXggdGhlIGlzc3VlLCBraW5kbHkgYWRkIGZvbGxvd2luZyB0 YWcgYXMgYXBwcm9wcmlhdGUNCj4gUmVwb3J0ZWQtYnk6IGtlcm5lbCB0ZXN0IHJvYm90IDxsa3BA aW50ZWwuY29tPg0KPiBSZXBvcnRlZC1ieTogRGFuIENhcnBlbnRlciA8ZGFuLmNhcnBlbnRlckBv cmFjbGUuY29tPg0KPiANCj4gc21hdGNoIHdhcm5pbmdzOg0KPiBkcml2ZXJzL25ldC93aXJlbGVz cy9tZWRpYXRlay9tdDc2L210NzkxNS9pbml0LmM6MzUzIG10NzkxNV9zZXRfc3RyZWFtX3ZodF90 eGJmX2NhcHMoKSBlcnJvcjogcG90ZW50aWFsbHkgZGVyZWZlcmVuY2luZyB1bmluaXRpYWxpemVk ICdjYXAnLg0KPiANCj4gdmltICsvY2FwICszNTMgZHJpdmVycy9uZXQvd2lyZWxlc3MvbWVkaWF0 ZWsvbXQ3Ni9tdDc5MTUvaW5pdC5jDQo+IA0KPiAwMGIyZTE2ZTAwNjM5MCBSeWRlciBMZWUgMjAy MC0wNS0xMiAgMzQ0ICB2b2lkIG10NzkxNV9zZXRfc3RyZWFtX3ZodF90eGJmX2NhcHMoc3RydWN0 IG10NzkxNV9waHkgKnBoeSkNCj4gMDBiMmUxNmUwMDYzOTAgUnlkZXIgTGVlIDIwMjAtMDUtMTIg IDM0NSAgew0KPiA1MGE2ZmU3OTYyM2UyMiBSeWRlciBMZWUgMjAyMS0wMi0yNSAgMzQ2ICAJaW50 IG5zczsNCj4gNTBhNmZlNzk2MjNlMjIgUnlkZXIgTGVlIDIwMjEtMDItMjUgIDM0NyAgCXUzMiAq Y2FwOw0KPiA1MGE2ZmU3OTYyM2UyMiBSeWRlciBMZWUgMjAyMS0wMi0yNSAgMzQ4ICANCj4gNTBh NmZlNzk2MjNlMjIgUnlkZXIgTGVlIDIwMjEtMDItMjUgIDM0OSAgCWlmICghcGh5LT5tdDc2LT5j YXAuaGFzXzVnaHopDQo+IDUwYTZmZTc5NjIzZTIyIFJ5ZGVyIExlZSAyMDIxLTAyLTI1ICAzNTAg IAkJcmV0dXJuOw0KPiA1MGE2ZmU3OTYyM2UyMiBSeWRlciBMZWUgMjAyMS0wMi0yNSAgMzUxICAN Cj4gNTBhNmZlNzk2MjNlMjIgUnlkZXIgTGVlIDIwMjEtMDItMjUgIDM1MiAgCW5zcyA9IGh3ZWln aHQ4KHBoeS0+bXQ3Ni0+Y2hhaW5tYXNrKTsNCj4gNTBhNmZlNzk2MjNlMjIgUnlkZXIgTGVlIDIw MjEtMDItMjUgQDM1MyAgCSpjYXAgPSAmcGh5LT5tdDc2LT5zYmFuZF81Zy5zYmFuZC52aHRfY2Fw LmNhcDsNCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg Xl5eXg0KPiAiY2FwIiBpc24ndCBpbml0aWFsaXplZC4NCg0KVGhpcyBoYXMgYmVlbiBmaXhlZCBp biB2Mw0KaHR0cHM6Ly9wYXRjaHdvcmsua2VybmVsLm9yZy9wcm9qZWN0L2xpbnV4LW1lZGlhdGVr L3BhdGNoLzQyN2FiNWEyYTc5YjhiYmZhMDUyMjVjZmU0Y2ZiNTViM2YxNDNjOGMuMTYxNDM1NzM0 Ni5naXQucnlkZXIubGVlQG1lZGlhdGVrLmNvbS8NCg0KUnlkZXINCg0K From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============2861837927786674646==" MIME-Version: 1.0 From: Ryder Lee To: kbuild-all@lists.01.org Subject: Re: [kbuild] Re: [PATCH v2 1/2] mt76: mt7915: add missing capabilities for DBDC Date: Wed, 10 Mar 2021 16:54:50 +0800 Message-ID: <1615366490.10387.0.camel@mtkswgap22> In-Reply-To: <20210310083018.GH21246@kadam> List-Id: --===============2861837927786674646== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Wed, 2021-03-10 at 11:30 +0300, Dan Carpenter wrote: > Hi Ryder, > = > url: https://github.com/0day-ci/linux/commits/Ryder-Lee/mt76-mt7915-ad= d-missing-capabilities-for-DBDC/20210225-230323 = > base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-dr= ivers-next.git master > config: x86_64-randconfig-m001-20210309 (attached as .config) > compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 > = > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > Reported-by: Dan Carpenter > = > smatch warnings: > drivers/net/wireless/mediatek/mt76/mt7915/init.c:353 mt7915_set_stream_vh= t_txbf_caps() error: potentially dereferencing uninitialized 'cap'. > = > vim +/cap +353 drivers/net/wireless/mediatek/mt76/mt7915/init.c > = > 00b2e16e006390 Ryder Lee 2020-05-12 344 void mt7915_set_stream_vht_txbf= _caps(struct mt7915_phy *phy) > 00b2e16e006390 Ryder Lee 2020-05-12 345 { > 50a6fe79623e22 Ryder Lee 2021-02-25 346 int nss; > 50a6fe79623e22 Ryder Lee 2021-02-25 347 u32 *cap; > 50a6fe79623e22 Ryder Lee 2021-02-25 348 = > 50a6fe79623e22 Ryder Lee 2021-02-25 349 if (!phy->mt76->cap.has_5ghz) > 50a6fe79623e22 Ryder Lee 2021-02-25 350 return; > 50a6fe79623e22 Ryder Lee 2021-02-25 351 = > 50a6fe79623e22 Ryder Lee 2021-02-25 352 nss =3D hweight8(phy->mt76->ch= ainmask); > 50a6fe79623e22 Ryder Lee 2021-02-25 @353 *cap =3D &phy->mt76->sband_5g.= sband.vht_cap.cap; > ^^^^ > "cap" isn't initialized. This has been fixed in v3 https://patchwork.kernel.org/project/linux-mediatek/patch/427ab5a2a79b8bbfa= 05225cfe4cfb55b3f143c8c.1614357346.git.ryder.lee(a)mediatek.com/ Ryder --===============2861837927786674646==--