From: Wei Huang <wei.huang@intel.com>
To: dev@dpdk.org, rosen.xu@intel.com, qi.z.zhang@intel.com
Cc: stable@dpdk.org, tianfei.zhang@intel.com,
Wei Huang <wei.huang@intel.com>
Subject: [dpdk-dev] [PATCH v1 1/2] raw/ifpga/base: use untained variable as argument
Date: Wed, 17 Mar 2021 04:23:36 -0400 [thread overview]
Message-ID: <1615969417-17118-2-git-send-email-wei.huang@intel.com> (raw)
In-Reply-To: <1615969417-17118-1-git-send-email-wei.huang@intel.com>
In fme_spi_init(), passing tainted expression "fme->max10_dev"
to function "intel_max10_device_remove" has risk. Untainted
variable "max10" should be used.
Coverity issue: 367480
Fixes: 96ebfcf8125c ("raw/ifpga/base: add SPI and MAX10 device driver")
Signed-off-by: Wei Huang <wei.huang@intel.com>
---
drivers/raw/ifpga/base/ifpga_fme.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/raw/ifpga/base/ifpga_fme.c b/drivers/raw/ifpga/base/ifpga_fme.c
index 43c7b9c3dc..a63f90331f 100644
--- a/drivers/raw/ifpga/base/ifpga_fme.c
+++ b/drivers/raw/ifpga/base/ifpga_fme.c
@@ -1001,7 +1001,7 @@ static int fme_spi_init(struct ifpga_feature *feature)
return ret;
max10_fail:
- intel_max10_device_remove(fme->max10_dev);
+ intel_max10_device_remove(max10);
spi_fail:
altera_spi_release(spi_master);
return ret;
--
2.29.2
next prev parent reply other threads:[~2021-03-17 8:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-17 8:23 [dpdk-dev] [PATCH v1 0/2] Fix coverity issues reported in DPDK-26381 Wei Huang
2021-03-17 8:23 ` Wei Huang [this message]
2021-04-01 7:48 ` [dpdk-dev] [PATCH v1 1/2] raw/ifpga/base: use untained variable as argument Zhang, Tianfei
2021-04-01 8:48 ` Xu, Rosen
2021-04-07 14:57 ` Ferruh Yigit
2021-03-17 8:23 ` [dpdk-dev] [PATCH v1 2/2] raw/ifpga/base: add argument to use untained variable Wei Huang
2021-04-01 7:48 ` Zhang, Tianfei
2021-04-01 8:48 ` Xu, Rosen
2021-04-01 12:17 ` [dpdk-dev] [PATCH v1 0/2] Fix coverity issues reported in DPDK-26381 Zhang, Qi Z
2021-04-20 8:09 ` Ferruh Yigit
2021-04-20 9:12 ` Zhang, Qi Z
2021-04-20 9:29 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1615969417-17118-2-git-send-email-wei.huang@intel.com \
--to=wei.huang@intel.com \
--cc=dev@dpdk.org \
--cc=qi.z.zhang@intel.com \
--cc=rosen.xu@intel.com \
--cc=stable@dpdk.org \
--cc=tianfei.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.