From: Ravik Hasija <rahasij@linux.microsoft.com>
To: u-boot@lists.denx.de
Subject: [PATCH] cmd: gpt: remove redundant print messages
Date: Tue, 30 Mar 2021 14:34:40 -0700 [thread overview]
Message-ID: <1617140080-24756-1-git-send-email-rahasij@linux.microsoft.com> (raw)
Removing printfs from do_gpt API as the messages are generic and does not
specify error codes for failure cases.
Signed-off-by: Ravik Hasija <rahasij@linux.microsoft.com>
---
cmd/gpt.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/cmd/gpt.c b/cmd/gpt.c
index 76a95ade6c..2c516745b0 100644
--- a/cmd/gpt.c
+++ b/cmd/gpt.c
@@ -992,11 +992,9 @@ static int do_gpt(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[])
}
if (ret) {
- printf("error!\n");
return CMD_RET_FAILURE;
}
- printf("success!\n");
return CMD_RET_SUCCESS;
}
--
2.17.1
next reply other threads:[~2021-03-30 21:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-30 21:34 Ravik Hasija [this message]
2021-03-31 8:46 ` [PATCH] cmd: gpt: remove redundant print messages Patrick DELAUNAY
2021-03-31 18:15 ` [PATCH v2] " Ravik Hasija
2021-04-19 15:10 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1617140080-24756-1-git-send-email-rahasij@linux.microsoft.com \
--to=rahasij@linux.microsoft.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.