From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v2 1/2] dt-bindings/display/bridge: sii902x: add optional power supplies Date: Mon, 14 May 2018 20:06:38 +0300 Message-ID: <1617167.qDJKxXFJBi@avalon> References: <20180425075314.19137-1-philippe.cornu@st.com> <3518575.OAoTTXDygq@avalon> <7fe8e766-56f5-38a3-b4dd-b44d4a5bdcf8@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <7fe8e766-56f5-38a3-b4dd-b44d4a5bdcf8@st.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Philippe CORNU Cc: Mark Rutland , Alexandre TORGUE , "devicetree@vger.kernel.org" , David Airlie , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , Yannick FERTRE List-Id: devicetree@vger.kernel.org SGkgUGhpbGlwcGUsCgpPbiBNb25kYXksIDE0IE1heSAyMDE4IDEyOjIyOjE2IEVFU1QgUGhpbGlw cGUgQ09STlUgd3JvdGU6Cj4gT24gMDQvMjYvMjAxOCAxMjowNSBBTSwgTGF1cmVudCBQaW5jaGFy dCB3cm90ZToKPiA+IE9uIFdlZG5lc2RheSwgMjUgQXByaWwgMjAxOCAyMDoxMToyMyBFRVNUIFJv YiBIZXJyaW5nIHdyb3RlOgo+ID4+IE9uIFdlZCwgQXByIDI1LCAyMDE4IGF0IDA0OjE3OjI1UE0g KzAzMDAsIExhdXJlbnQgUGluY2hhcnQgd3JvdGU6Cj4gPj4+IE9uIFdlZG5lc2RheSwgMjUgQXBy aWwgMjAxOCAxNToyMDowNCBFRVNUIFBoaWxpcHBlIENPUk5VIHdyb3RlOgo+ID4+Pj4gT24gMDQv MjUvMjAxOCAxMTowMSBBTSwgTGF1cmVudCBQaW5jaGFydCB3cm90ZToKPiA+Pj4+PiBPbiBXZWRu ZXNkYXksIDI1IEFwcmlsIDIwMTggMTA6NTM6MTMgRUVTVCBQaGlsaXBwZSBDb3JudSB3cm90ZToK PiA+Pj4+Pj4gQWRkIG9wdGlvbmFsIHBvd2VyIHN1cHBsaWVzIHVzaW5nIHRoZSBkZXNjcmlwdGlv biBmb3VuZCBpbgo+ID4+Pj4+PiAiU2lJOTAyMkEvU2lJOTAyNEEgSERNSSBUcmFuc21pdHRlciBE YXRhIFNoZWV0IChBdWd1c3QgMjAxNikiLgo+ID4+Pj4+Pgo+ID4+Pj4+PiBUaGVyZSBpcyBhIHNp bmdsZSAxdjIgc3VwcGx5IHZvbHRhZ2UgbmFtZWQgdmNjMTIgZnJvbSB3aGljaCBjdmNjMTIKPiA+ Pj4+Pj4gKGRpZ2l0YWwgY29yZSkgYW5kIGF2Y2MxMiAoVE1EUyBhbmFsb2cpIGFyZSBkZXJpdmVk IGJlY2F1c2UKPiA+Pj4+Pj4gYWNjb3JkaW5nIHRvIHRoaXMgZGF0YSBzaGVldDoKPiA+Pj4+Pj4g ImN2Y2MxMiBhbmQgYXZjYzEyIGNhbiBiZSBkZXJpdmVkIGZyb20gdGhlIHNhbWUgcG93ZXIgc291 cmNlIgo+ID4+Pj4+Cj4gPj4+Pj4gU2hvdWxkbid0IHRoZSBwb3dlciBzdXBwbGllcyBiZSBtYW5k YXRvcnksIGFzIGV4cGxhaW5lZCBieSBNYXJrIGluCj4gPj4+Pj4gaHR0cHM6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvYXJjaGl2ZXMvZHJpLWRldmVsLzIwMTgtQXByaWwvCj4gPj4+Pj4gMTcyNDAw Lmh0bWwgPwo+ID4+Pj4KPiA+Pj4+IExhdXJlbnQsCj4gPj4+PiBNYW55IHRoYW5rcyBMYXVyZW50 IGZvciB5b3VyIGNvbW1lbnQsIEkgdW5kZXJzdG9vZCB0aGUgbWVyZ2Ugb2YgdGhlCj4gPj4+PiB0 d28gMXYyIHBvd2VyIHN1cHBsaWVzIGJ1dCBtaXNzZWQgdGhlICJtYW5kYXRvcnkiIHBhcnQuLi4g bWF5YmUgYmVjYXVzZQo+ID4+Pj4gdGhpcyBwYXRjaCAod2l0aCBvcHRpb25hbCBwb3dlciBzdXBw bGllcykgYWxyZWFkeSBnb3QgdGhlIHJldmlld2VkLWJ5Cj4gPj4+PiBmcm9tIFJvYiwgSSB0aG91 Z2h0IHRoZSBkaXNjdXNzaW9uIHRocmVhZCB5b3UgcG9pbnRlZCBvdXQgd2FzCj4gPj4+PiBhcHBs aWNhYmxlICJvbmx5IiB0byB0b3RhbGx5IG5ldyBkcml2ZXIgZG9jdW1lbnRhdGlvbi4KPiA+Pj4+ Cj4gPj4+PiBTbywgb24gbXkgc2lkZSwgYXMgYSAibmV3IHVzZXIiIG9mIHNpaTkwMnggSUMsIG5v IHByb2JsZW0gdG8gcHV0IHRoZXNlCj4gPj4+PiBwb3dlciBzdXBwbGllcyBhcyBtYW5kYXRvcnkg aW5zdGVhZCBvZiBvcHRpb25hbCBwcm9wZXJ0aWVzIGJ1dCBJIHdvdWxkCj4gPj4+PiBsaWtlIHRv IGJlIHN1cmUgdGhpcyBpcyBhcHBsaWNhYmxlIHRvIGJvdGggb2xkIGFuZCBuZXcgYmluZGluZ3Mg ZG9jIDoKPiA+Pj4+ICkKPiA+Pj4KPiA+Pj4gV2Ugb2J2aW91c2x5IG5lZWQgdG8gcmV0YWluIGJh Y2t3YXJkIGNvbXBhdGliaWxpdHksIHNvIG9uIHRoZSBkcml2ZXIKPiA+Pj4gc2lkZSB5b3UgbmVl ZCB0byB0cmVhdCB0aG9zZSBwb3dlciBzdXBwbGllcyBhcyBvcHRpb25hbC4gRnJvbSBhIERUCj4g Pj4+IGJpbmRpbmdzIHBvaW50IG9mIHZpZXcsIGhvd2V2ZXIsIEkgdGhpbmsgdGhleSBzaG91bGQg YmUgbWFuZGF0b3J5IGZvcgo+ID4+PiBuZXcgRFQuCj4gPj4KPiA+PiBXZSBkb24ndCByZWFsbHkg aGF2ZSBhIHdheSB0byBkZXNjcmliZSB0aGVzZSAzIGNvbmRpdGlvbnMgKHJlcXVpcmVkIGZvcgo+ ID4+IGFsbCwgb3B0aW9uYWwgZm9yIGFsbCwgYW5kIHJlcXVpcmVkIGZvciBuZXcpLiBTbyBnZW5l cmFsbHkgd2UgbWFrZQo+ID4+IGFkZGl0aW9ucyBvcHRpb25hbC4gVGhlIGV4Y2VwdGlvbiBzb21l dGltZXMgaXMgaWYgd2UgdXBkYXRlIGFsbCB0aGUgZHRzCj4gPj4gZmlsZXMuCj4gPiAKPiA+IENh bid0IHdlIGp1c3QgbWFrZSBpdCBtYW5kYXRvcnkgaW4gdGhlIGJpbmRpbmdzLCBhcyBsb25nIGFz IHdlIHRyZWF0IGl0Cj4gPiBhcyBvcHRpb25hbCBpbiBkcml2ZXJzID8KPiAKPiBIb3cgdG8gcHJv Z3Jlc3Mgb24gdGhpcyBwYXRjaD8gRG8geW91IGhhdmUgYW55IHN1Z2dlc3Rpb25zPwoKQnkgc2Vl aW5nIHdoYXQgUm9iIHRoaW5rcyBhYm91dCBteSBwcm9wb3NhbCBhYm92ZSA/IDotKQoKPiA+Pj4+ IFJvYiwKPiA+Pj4+IGNvdWxkIHlvdSBwbGVhc2UgY29uZmlybSB0aGVzZSBwb3dlciBzdXBwbHkg cHJvcGVydGllcyBzaG91bGQgYmUKPiA+Pj4+ICJtYW5kYXRvcnkiPyBpZiB5ZXMsIHNob3VsZCB3 ZSB0aGVuIG1vZGlmeSBvdGhlciBvcHRpb25hbCBwcm9wZXJ0aWVzCj4gPj4+PiBsaWtlIHRoZSBy ZXNldC1ncGlvcyB0b28gaW4gdGhlIGZ1dHVyZT8KPiA+Pj4KPiA+Pj4gVGhlIEdQSU9zIHByb3Bl cnRpZXMgYXJlIGRpZmZlcmVudCBpbiBteSBvcGluaW9uLCBhcyB0aGVyZSdzIG5vCj4gPj4+IHJl cXVpcmVtZW50IHRvIGNvbm5lY3QgZm9yIGluc3RhbmNlIHRoZSByZXNldCBwaW4gdG8gYSBHUElP IGNvbnRyb2xsYWJsZQo+ID4+PiBieSB0aGUgU29DLiBUaGUgcGluIGNvdWxkIGJlIGhhcmR3aXJl ZCB0byBWQ0MsIG9yIGNvbm5lY3RlZCB0byBhIHN5c3RlbQo+ID4+PiByZXNldCB0aGF0IGlzIGF1 dG9tYXRpY2FsbHkgbWFuYWdlZCB3aXRob3V0IFNvQyBpbnRlcnZlbnRpb24uIFRoZSBwb3dlcgo+ ID4+PiBzdXBwbGllcywgaG93ZXZlciwgYXJlIG1hbmRhdG9yeSwgaW4gdGhlIHNlbnNlIHRoYXQg dGhlIGNoaXAgd2lsbCBub3QKPiA+Pj4gd29yayBpZiB5b3UgbGVhdmUgdGhlIHBvd2VyIHN1cHBs aWVzIHVuY29ubmVjdGVkLgo+ID4+Cj4gPj4gRFQgb25seSBuZWVkcyB0byBkZXNjcmliZSB3aGF0 IG1hdHRlcnMgdG8gcy93LiBJZiBhIHJlZ3VsYXRvciBpcwo+ID4+IGZpeGVkIGFuZCB5b3UgZG9u J3QgbmVlZCB0byBrbm93IGl0cyB2b2x0YWdlIChvciBvdGhlciByZWFkLW9ubHkKPiA+PiBwYXJh bWV0ZXJzKSwgdGhlbiB0aGVyZSdzIG5vdCBtdWNoIHBvaW50IGluIHB1dHRpbmcgaXQgaW4gRFQu Cj4gPj4KPiA+PiBJJ2QgcHJvYmFibHkgYmFzZSB0aGlzIG1vcmUgYXQgYSBwbGF0Zm9ybSBsZXZl bCBhbmQgeW91IGVpdGhlciB1c2UKPiA+PiByZWd1bGF0b3IgYmluZGluZyBvciB5b3UgZG9uJ3Qu IEl0J3MgcGVyZmVjdGx5IHZhbGlkIHRoYXQgeW91IHdhbnQgdG8gZG8KPiA+PiB0aGluZ3MgbGlr ZSByZWd1bGF0b3Igc2V0dXAsIHBpbiBjdHJsIGFuZCBtdXhpbmcgc2V0dXAsIGV0Yy4gYWxsIGlu Cj4gPj4gZmlybXdhcmUgYW5kIHRoZSBPUyBkb2Vzbid0IHRvdWNoIGFueSBvZiB0aGF0Lgo+ID4+ Cj4gPj4gVGhhdCdzIGFsbCBhIGJpZyBjYW4gb2Ygd29ybXMgd2hpY2ggd2Ugc2hvdWxkbid0IHNv bHZlIG9uIHRoaXMgMiBsaW5lCj4gPj4gY2hhbmdlLiBJIHRoaW5rIHRoaXMgY2hhbmdlIGlzIGZp bmUgYXMtaXMsIHNvOgo+ID4+Cj4gPj4gUmV2aWV3ZWQtYnk6IFJvYiBIZXJyaW5nIDxyb2JoQGtl cm5lbC5vcmc+CgotLSAKUmVnYXJkcywKCkxhdXJlbnQgUGluY2hhcnQKCgoKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlz dApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0 b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752697AbeENRGZ (ORCPT ); Mon, 14 May 2018 13:06:25 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:41658 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751596AbeENRGW (ORCPT ); Mon, 14 May 2018 13:06:22 -0400 From: Laurent Pinchart To: Philippe CORNU Cc: Rob Herring , Archit Taneja , Andrzej Hajda , David Airlie , Mark Rutland , "dri-devel@lists.freedesktop.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Yannick FERTRE , Benjamin Gaignard , Alexandre TORGUE Subject: Re: [PATCH v2 1/2] dt-bindings/display/bridge: sii902x: add optional power supplies Date: Mon, 14 May 2018 20:06:38 +0300 Message-ID: <1617167.qDJKxXFJBi@avalon> Organization: Ideas on Board Oy In-Reply-To: <7fe8e766-56f5-38a3-b4dd-b44d4a5bdcf8@st.com> References: <20180425075314.19137-1-philippe.cornu@st.com> <3518575.OAoTTXDygq@avalon> <7fe8e766-56f5-38a3-b4dd-b44d4a5bdcf8@st.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Philippe, On Monday, 14 May 2018 12:22:16 EEST Philippe CORNU wrote: > On 04/26/2018 12:05 AM, Laurent Pinchart wrote: > > On Wednesday, 25 April 2018 20:11:23 EEST Rob Herring wrote: > >> On Wed, Apr 25, 2018 at 04:17:25PM +0300, Laurent Pinchart wrote: > >>> On Wednesday, 25 April 2018 15:20:04 EEST Philippe CORNU wrote: > >>>> On 04/25/2018 11:01 AM, Laurent Pinchart wrote: > >>>>> On Wednesday, 25 April 2018 10:53:13 EEST Philippe Cornu wrote: > >>>>>> Add optional power supplies using the description found in > >>>>>> "SiI9022A/SiI9024A HDMI Transmitter Data Sheet (August 2016)". > >>>>>> > >>>>>> There is a single 1v2 supply voltage named vcc12 from which cvcc12 > >>>>>> (digital core) and avcc12 (TMDS analog) are derived because > >>>>>> according to this data sheet: > >>>>>> "cvcc12 and avcc12 can be derived from the same power source" > >>>>> > >>>>> Shouldn't the power supplies be mandatory, as explained by Mark in > >>>>> https://lists.freedesktop.org/archives/dri-devel/2018-April/ > >>>>> 172400.html ? > >>>> > >>>> Laurent, > >>>> Many thanks Laurent for your comment, I understood the merge of the > >>>> two 1v2 power supplies but missed the "mandatory" part... maybe because > >>>> this patch (with optional power supplies) already got the reviewed-by > >>>> from Rob, I thought the discussion thread you pointed out was > >>>> applicable "only" to totally new driver documentation. > >>>> > >>>> So, on my side, as a "new user" of sii902x IC, no problem to put these > >>>> power supplies as mandatory instead of optional properties but I would > >>>> like to be sure this is applicable to both old and new bindings doc : > >>>> ) > >>> > >>> We obviously need to retain backward compatibility, so on the driver > >>> side you need to treat those power supplies as optional. From a DT > >>> bindings point of view, however, I think they should be mandatory for > >>> new DT. > >> > >> We don't really have a way to describe these 3 conditions (required for > >> all, optional for all, and required for new). So generally we make > >> additions optional. The exception sometimes is if we update all the dts > >> files. > > > > Can't we just make it mandatory in the bindings, as long as we treat it > > as optional in drivers ? > > How to progress on this patch? Do you have any suggestions? By seeing what Rob thinks about my proposal above ? :-) > >>>> Rob, > >>>> could you please confirm these power supply properties should be > >>>> "mandatory"? if yes, should we then modify other optional properties > >>>> like the reset-gpios too in the future? > >>> > >>> The GPIOs properties are different in my opinion, as there's no > >>> requirement to connect for instance the reset pin to a GPIO controllable > >>> by the SoC. The pin could be hardwired to VCC, or connected to a system > >>> reset that is automatically managed without SoC intervention. The power > >>> supplies, however, are mandatory, in the sense that the chip will not > >>> work if you leave the power supplies unconnected. > >> > >> DT only needs to describe what matters to s/w. If a regulator is > >> fixed and you don't need to know its voltage (or other read-only > >> parameters), then there's not much point in putting it in DT. > >> > >> I'd probably base this more at a platform level and you either use > >> regulator binding or you don't. It's perfectly valid that you want to do > >> things like regulator setup, pin ctrl and muxing setup, etc. all in > >> firmware and the OS doesn't touch any of that. > >> > >> That's all a big can of worms which we shouldn't solve on this 2 line > >> change. I think this change is fine as-is, so: > >> > >> Reviewed-by: Rob Herring -- Regards, Laurent Pinchart