From: Paul Mackerras <paulus@samba.org>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Franz Sirl <Franz.Sirl-ppc@lauterbach.com>,
Miles Lane <miles.lane@comcast.net>,
linuxppc-dev@lists.linuxppc.org, Vojtech Pavlik <vojtech@suse.cz>
Subject: Re: linuxppc-2.5 (rsync mvista) -- drivers/input/evdev.c:243: error: invalid lvalue in asm statement
Date: Mon, 4 Aug 2003 21:24:54 +1000 [thread overview]
Message-ID: <16174.17030.820826.915675@cargo.ozlabs.ibm.com> (raw)
In-Reply-To: <1059990141.3232.1.camel@gaston>
Benjamin Herrenschmidt writes:
> It's still totally wrong to access userland with a variable sized
> data since my understanding is that userland doesn't know what size
> the kernel will use for access here, thus it works for little endian
> but not big endian (well... afaik).
The userland data isn't variable-sized; it's an int, and it is
accessed as an int because the pointer given to get_user is int *.
The problem is (as Franz pointed out) the use of (a? b: c) as an
lvalue.
Incidentally there is a bug in the INPUT_KEYCODE macro: the second
(dev->keycodesize == 1) should be == 2 instead (the condition for the
u16 case).
Paul.
** Sent via the linuxppc-dev mail list. See http://lists.linuxppc.org/
prev parent reply other threads:[~2003-08-04 11:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-03 1:23 linuxppc-2.5 (rsync mvista) -- drivers/input/evdev.c:243: error: invalid lvalue in asm statement Miles Lane
2003-08-03 9:13 ` Benjamin Herrenschmidt
2003-08-03 11:23 ` Paul Mackerras
2003-08-03 11:31 ` Benjamin Herrenschmidt
2003-08-04 8:49 ` Franz Sirl
2003-08-04 9:42 ` Benjamin Herrenschmidt
2003-08-04 11:24 ` Paul Mackerras [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16174.17030.820826.915675@cargo.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=Franz.Sirl-ppc@lauterbach.com \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@lists.linuxppc.org \
--cc=miles.lane@comcast.net \
--cc=vojtech@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.