From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko =?ISO-8859-1?Q?St=FCbner?= Subject: Re: [PATCH] drm/rockchip: vop: remove hardware cursor window Date: Wed, 01 Jul 2015 13:52:22 +0200 Message-ID: <1617606.rtBNOYcypX@diego> References: <1435744173-23112-1-git-send-email-mark.yao@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1435744173-23112-1-git-send-email-mark.yao@rock-chips.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Mark Yao Cc: zwl@rock-chips.com, linux-kernel@vger.kernel.org, tfiga@chromium.org, linux-rockchip@lists.infradead.org, dri-devel@lists.freedesktop.org, xw@rock-chips.com, dkm@rock-chips.com, sandy.huang@rock-chips.com, linux-arm-kernel@lists.infradead.org List-Id: linux-rockchip.vger.kernel.org SGkgTWFyaywKCkFtIE1pdHR3b2NoLCAxLiBKdWxpIDIwMTUsIDE3OjQ5OjMzIHNjaHJpZWIgTWFy ayBZYW86Cj4gaGFyZHdhcmUgY3Vyc29yIHdpbmRvd3Mgb25seSBoYXZlIHNvbWUgZml4ZWQgc2l6 ZSwgYW5kIG5vdCBzdXBwb3J0Cj4gd2lkdGggdmlydHVhbCwgd2hlbiBtb3ZlIGhhcmR3YXJlIGN1 cnNvciB3aW5kb3dzIG91dHNpZGUgb2YgbGVmdCwKPiB0aGUgZGlzcGxheSB3b3VsZCBiZSB3cm9u Zywgc28gdGhpcyB3aW5kb3cgY2FuJ3QgZm9yIGN1cnNvciBub3cuCj4gCj4gQW5kIFRhZyBoYXJk d2FyZSBjdXJzb3Igd2luZG93IGFzIGEgb3ZlcmxheSBpcyB3cm9uZywgd2lsbCBtYWtlCj4gdXNl cnNwYWNlIHdyb25nIGJlaGF2aW91ci4KPiAKPiBTbyBqdXN0IHJlbW92ZSB0aGUgaGFyZHdhcmUg Y3Vyc29yIHdpbmRvdwo+IAo+IFNpZ25lZC1vZmYtYnk6IE1hcmsgWWFvIDxtYXJrLnlhb0Byb2Nr LWNoaXBzLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlwL3JvY2tjaGlwX2Ry bV92b3AuYyB8ICAgIDEgLQo+ICAxIGZpbGUgY2hhbmdlZCwgMSBkZWxldGlvbigtKQo+IAo+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAvcm9ja2NoaXBfZHJtX3ZvcC5jCj4g Yi9kcml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAvcm9ja2NoaXBfZHJtX3ZvcC5jIGluZGV4IDQ2MDM0 MTIuLjczNzNiYTEgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlwL3JvY2tj aGlwX2RybV92b3AuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9yb2NrY2hpcF9k cm1fdm9wLmMKPiBAQCAtMzY4LDcgKzM2OCw2IEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3Qgdm9wX3dp bl9kYXRhIHJrMzI4OF92b3Bfd2luX2RhdGFbXSA9Cj4geyB7IC5iYXNlID0gMHg0MCwgLnBoeSA9 ICZ3aW4wMV9kYXRhLCAudHlwZSA9IERSTV9QTEFORV9UWVBFX09WRVJMQVkgfSwgewo+IC5iYXNl ID0gMHgwMCwgLnBoeSA9ICZ3aW4yM19kYXRhLCAudHlwZSA9IERSTV9QTEFORV9UWVBFX09WRVJM QVkgfSwgeyAuYmFzZQo+ID0gMHg1MCwgLnBoeSA9ICZ3aW4yM19kYXRhLCAudHlwZSA9IERSTV9Q TEFORV9UWVBFX0NVUlNPUiB9LCAtCXsgLmJhc2UgPQo+IDB4MDAsIC5waHkgPSAmY3Vyc29yX2Rh dGEsIC50eXBlID0gRFJNX1BMQU5FX1RZUEVfT1ZFUkxBWSB9LCB9Owo+IAo+ICBzdGF0aWMgY29u c3Qgc3RydWN0IHZvcF9kYXRhIHJrMzI4OF92b3AgPSB7Cgp5b3Ugc2hvdWxkIHByb2JhYmx5IGFs c28gcmVtb3ZlIHRoZQoKCXN0YXRpYyBjb25zdCBzdHJ1Y3Qgdm9wX3dpbl9waHkgY3Vyc29yX2Rh dGEKCmNvbXBsZXRlbHkgdGhlbiwgYXMgaXQgaXMgbm93IHVudXNlZD8KCgpIZWlrbwpfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGlu ZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVk ZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: heiko@sntech.de (Heiko =?ISO-8859-1?Q?St=FCbner?=) Date: Wed, 01 Jul 2015 13:52:22 +0200 Subject: [PATCH] drm/rockchip: vop: remove hardware cursor window In-Reply-To: <1435744173-23112-1-git-send-email-mark.yao@rock-chips.com> References: <1435744173-23112-1-git-send-email-mark.yao@rock-chips.com> Message-ID: <1617606.rtBNOYcypX@diego> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Mark, Am Mittwoch, 1. Juli 2015, 17:49:33 schrieb Mark Yao: > hardware cursor windows only have some fixed size, and not support > width virtual, when move hardware cursor windows outside of left, > the display would be wrong, so this window can't for cursor now. > > And Tag hardware cursor window as a overlay is wrong, will make > userspace wrong behaviour. > > So just remove the hardware cursor window > > Signed-off-by: Mark Yao > --- > drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c index 4603412..7373ba1 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > @@ -368,7 +368,6 @@ static const struct vop_win_data rk3288_vop_win_data[] = > { { .base = 0x40, .phy = &win01_data, .type = DRM_PLANE_TYPE_OVERLAY }, { > .base = 0x00, .phy = &win23_data, .type = DRM_PLANE_TYPE_OVERLAY }, { .base > = 0x50, .phy = &win23_data, .type = DRM_PLANE_TYPE_CURSOR }, - { .base = > 0x00, .phy = &cursor_data, .type = DRM_PLANE_TYPE_OVERLAY }, }; > > static const struct vop_data rk3288_vop = { you should probably also remove the static const struct vop_win_phy cursor_data completely then, as it is now unused? Heiko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753291AbbGALwk (ORCPT ); Wed, 1 Jul 2015 07:52:40 -0400 Received: from gloria.sntech.de ([95.129.55.99]:40353 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752430AbbGALwd (ORCPT ); Wed, 1 Jul 2015 07:52:33 -0400 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Mark Yao Cc: dri-devel@lists.freedesktop.org, David Airlie , Daniel Kurtz , Philipp Zabel , Daniel Vetter , Rob Clark , tfiga@chromium.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, sandy.huang@rock-chips.com, dkm@rock-chips.com, zwl@rock-chips.com, xw@rock-chips.com Subject: Re: [PATCH] drm/rockchip: vop: remove hardware cursor window Date: Wed, 01 Jul 2015 13:52:22 +0200 Message-ID: <1617606.rtBNOYcypX@diego> User-Agent: KMail/4.14.1 (Linux/3.16.0-4-amd64; KDE/4.14.2; x86_64; ; ) In-Reply-To: <1435744173-23112-1-git-send-email-mark.yao@rock-chips.com> References: <1435744173-23112-1-git-send-email-mark.yao@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mark, Am Mittwoch, 1. Juli 2015, 17:49:33 schrieb Mark Yao: > hardware cursor windows only have some fixed size, and not support > width virtual, when move hardware cursor windows outside of left, > the display would be wrong, so this window can't for cursor now. > > And Tag hardware cursor window as a overlay is wrong, will make > userspace wrong behaviour. > > So just remove the hardware cursor window > > Signed-off-by: Mark Yao > --- > drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c index 4603412..7373ba1 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > @@ -368,7 +368,6 @@ static const struct vop_win_data rk3288_vop_win_data[] = > { { .base = 0x40, .phy = &win01_data, .type = DRM_PLANE_TYPE_OVERLAY }, { > .base = 0x00, .phy = &win23_data, .type = DRM_PLANE_TYPE_OVERLAY }, { .base > = 0x50, .phy = &win23_data, .type = DRM_PLANE_TYPE_CURSOR }, - { .base = > 0x00, .phy = &cursor_data, .type = DRM_PLANE_TYPE_OVERLAY }, }; > > static const struct vop_data rk3288_vop = { you should probably also remove the static const struct vop_win_phy cursor_data completely then, as it is now unused? Heiko