From: patchwork-bot+netdevbpf@kernel.org
To: Colin King <colin.king@canonical.com>
Cc: dchickles@marvell.com, sburla@marvell.com, fmanlunas@marvell.com,
davem@davemloft.net, kuba@kernel.org,
rvatsavayi@caviumnetworks.com, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] liquidio: Fix unintented sign extension of a left shift of a u16
Date: Wed, 07 Apr 2021 22:10:11 +0000 [thread overview]
Message-ID: <161783341195.5631.6736576843347914096.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20210407101248.485307-1-colin.king@canonical.com>
Hello:
This patch was applied to netdev/net-next.git (refs/heads/master):
On Wed, 7 Apr 2021 11:12:48 +0100 you wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The macro CN23XX_PEM_BAR1_INDEX_REG is being used to shift oct->pcie_port
> (a u16) left 24 places. There are two subtle issues here, first the
> shift gets promoted to an signed int and then sign extended to a u64.
> If oct->pcie_port is 0x80 or more then the upper bits get sign extended
> to 1. Secondly shfiting a u16 24 bits will lead to an overflow so it
> needs to be cast to a u64 for all the bits to not overflow.
>
> [...]
Here is the summary with links:
- liquidio: Fix unintented sign extension of a left shift of a u16
https://git.kernel.org/netdev/net-next/c/298b58f00c0f
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2021-04-07 22:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 10:12 [PATCH] liquidio: Fix unintented sign extension of a left shift of a u16 Colin King
2021-04-07 22:10 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=161783341195.5631.6736576843347914096.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=colin.king@canonical.com \
--cc=davem@davemloft.net \
--cc=dchickles@marvell.com \
--cc=fmanlunas@marvell.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rvatsavayi@caviumnetworks.com \
--cc=sburla@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.