All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pierre Morel <pmorel@linux.ibm.com>
To: qemu-devel@nongnu.org
Cc: thuth@redhat.com, frankja@linux.ibm.com, david@redhat.com,
	cohuck@redhat.com, richard.henderson@linaro.org,
	pasic@linux.ibm.com, borntraeger@de.ibm.com,
	qemu-s390x@nongnu.org, mst@redhat.com, pbonzini@redhat.com,
	marcandre.lureau@redhat.com, imbrenda@linux.ibm.com
Subject: [PATCH v2 0/1] s390x: css: report errors from ccw_dstream_read/write
Date: Thu,  8 Apr 2021 18:32:08 +0200	[thread overview]
Message-ID: <1617899529-9329-1-git-send-email-pmorel@linux.ibm.com> (raw)

By checking the results of errors on SSCH in the kvm-unit-tests
We noticed that no error was reported when a SSCH is started
to access addresses not existing in the guest.
For exemple accessing 3G on a guest with 1G memory.

If we look at QEMU ccw_dstream_write/write functions we see that they
are often not checked for error in various places.

It follows that accessing an invalid address does not trigger a
subchannel status program check to the guest as it should.

Regards,
Pierre


Pierre Morel (1):
  s390x: css: report errors from ccw_dstream_read/write

 hw/char/terminal3270.c | 11 +++++--
 hw/s390x/3270-ccw.c    |  5 +++-
 hw/s390x/css.c         | 14 +++++----
 hw/s390x/virtio-ccw.c  | 66 ++++++++++++++++++++++++++++++------------
 4 files changed, 69 insertions(+), 27 deletions(-)

-- 
2.17.1

changelog:

from v1:

- handle_payload_3270_read, return CSS error on CSS access errors
  keep returning -EIO for other 3270 internal errors.
  (Connie)

- css_interpret_ccw, let CSS handle the residual count even on errors
  it is supposed to do it right.
  (Connie)



             reply	other threads:[~2021-04-08 16:42 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-08 16:32 Pierre Morel [this message]
2021-04-08 16:32 ` [PATCH v2 1/1] s390x: css: report errors from ccw_dstream_read/write Pierre Morel
2021-04-09  8:38   ` Halil Pasic
2021-04-09  8:49     ` Cornelia Huck
2021-04-09  9:55       ` Pierre Morel
2021-04-09 10:11         ` Cornelia Huck
2021-04-09 10:27   ` Cornelia Huck
2021-04-09 10:32     ` Pierre Morel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1617899529-9329-1-git-send-email-pmorel@linux.ibm.com \
    --to=pmorel@linux.ibm.com \
    --cc=borntraeger@de.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=david@redhat.com \
    --cc=frankja@linux.ibm.com \
    --cc=imbrenda@linux.ibm.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=mst@redhat.com \
    --cc=pasic@linux.ibm.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.