All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christian Schoenebeck <qemu_oss@crudebyte.com>
To: qemu-devel@nongnu.org
Cc: "Dan Robertson" <dan@dlrobertson.com>,
	"Greg Kurz" <groug@kaod.org>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: Re: [PATCH 1/1] 9pfs: include linux/limits.h for XATTR_SIZE_MAX
Date: Sat, 16 May 2020 12:28:16 +0200	[thread overview]
Message-ID: <1618865.Jf4vGVxVId@silver> (raw)
In-Reply-To: <20200515203015.7090-2-dan@dlrobertson.com>

On Freitag, 15. Mai 2020 22:30:15 CEST Dan Robertson wrote:
> linux/limits.h should be included for the XATTR_SIZE_MAX definition used
> by v9fs_xattrcreate.
> 
> Signed-off-by: Dan Robertson <dan@dlrobertson.com>
> ---
>  hw/9pfs/9p.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c
> index a2a14b5979..68c2df7333 100644
> --- a/hw/9pfs/9p.c
> +++ b/hw/9pfs/9p.c
> @@ -28,6 +28,7 @@
>  #include "sysemu/qtest.h"
>  #include "qemu/xxhash.h"
>  #include <math.h>
> +#include <linux/limits.h>
> 
>  int open_fd_hw;
>  int total_open_fd;

Usually I would say that should be wrapped in some OS conditional way, but as 
usage of XATTR_SIZE_MAX is currently not in 9p code either, it's Ok for now.

Reviewed-by: Christian Schoenebeck <qemu_oss@crudebyte.com>

Best regards,
Christian Schoenebeck




  parent reply	other threads:[~2020-05-16 10:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-15 20:30 [PATCH 0/1] 9pfs: include linux/limits.h for XATTR_SIZE_MAX Dan Robertson
2020-05-15 20:30 ` [PATCH 1/1] " Dan Robertson
2020-05-16  5:22   ` Philippe Mathieu-Daudé
2020-05-16 10:28   ` Christian Schoenebeck [this message]
2020-05-16 11:30   ` Greg Kurz
2020-05-16 14:41     ` Dan Robertson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1618865.Jf4vGVxVId@silver \
    --to=qemu_oss@crudebyte.com \
    --cc=dan@dlrobertson.com \
    --cc=groug@kaod.org \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.