From: patchwork-bot+netdevbpf@kernel.org
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: michael.chan@broadcom.com, edwin.peer@broadcom.com,
davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net] bnxt_en: fix ternary sign extension bug in bnxt_show_temp()
Date: Thu, 22 Apr 2021 22:00:09 +0000 [thread overview]
Message-ID: <161912880923.31492.17385488154517518202.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <YIE9hEhXpdfffKg1@mwanda>
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Thu, 22 Apr 2021 12:10:28 +0300 you wrote:
> The problem is that bnxt_show_temp() returns long but "rc" is an int
> and "len" is a u32. With ternary operations the type promotion is quite
> tricky. The negative "rc" is first promoted to u32 and then to long so
> it ends up being a high positive value instead of a a negative as we
> intended.
>
> Fix this by removing the ternary.
>
> [...]
Here is the summary with links:
- [net] bnxt_en: fix ternary sign extension bug in bnxt_show_temp()
https://git.kernel.org/netdev/net/c/27537929f30d
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2021-04-22 22:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-22 9:10 [PATCH net] bnxt_en: fix ternary sign extension bug in bnxt_show_temp() Dan Carpenter
2021-04-22 22:00 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=161912880923.31492.17385488154517518202.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=edwin.peer@broadcom.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.