From mboxrd@z Thu Jan 1 00:00:00 1970 From: laurent.pinchart@ideasonboard.com (Laurent Pinchart) Date: Wed, 07 Dec 2016 16:25:25 +0200 Subject: [PATCH v5 3/4] ARM: dts: da850-lcdk: add the vga-bridge node In-Reply-To: <1481107365-24839-4-git-send-email-bgolaszewski@baylibre.com> References: <1481107365-24839-1-git-send-email-bgolaszewski@baylibre.com> <1481107365-24839-4-git-send-email-bgolaszewski@baylibre.com> Message-ID: <1620991.lLXgDihv8c@avalon> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Bartosz, Thank you for the patch. On Wednesday 07 Dec 2016 11:42:44 Bartosz Golaszewski wrote: > Add the vga-bridge node to the board DT together with corresponding > ports and vga connector. This allows to retrieve the edid info from > the display automatically. > > Signed-off-by: Bartosz Golaszewski > --- > arch/arm/boot/dts/da850-lcdk.dts | 67 ++++++++++++++++++++++++++++++++++++ > 1 file changed, 67 insertions(+) > > diff --git a/arch/arm/boot/dts/da850-lcdk.dts > b/arch/arm/boot/dts/da850-lcdk.dts index afcb482..39602eb 100644 > --- a/arch/arm/boot/dts/da850-lcdk.dts > +++ b/arch/arm/boot/dts/da850-lcdk.dts > @@ -51,6 +51,51 @@ > system-clock-frequency = <24576000>; > }; > }; > + > + vga-bridge { > + compatible = "ti,ths8135"; > + #address-cells = <1>; > + #size-cells = <0>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port at 0 { > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <0>; > + > + vga_bridge_in: endpoint at 0 { > + reg = <0>; > + remote-endpoint = <&lcdc_out_vga>; > + }; > + }; > + > + port at 1 { > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <1>; > + > + vga_bridge_out: endpoint at 0 { > + reg = <0>; > + remote-endpoint = <&vga_con_in>; > + }; > + }; > + }; > + }; > + > + vga { > + compatible = "vga-connector"; > + > + ddc-i2c-bus = <&i2c0>; > + > + port { > + vga_con_in: endpoint { > + remote-endpoint = <&vga_bridge_out>; > + }; > + }; > + }; > }; > > &pmx_core { > @@ -236,3 +281,25 @@ > &memctrl { > status = "okay"; > }; > + > +&lcdc { > + status = "okay"; > + pinctrl-names = "default"; > + pinctrl-0 = <&lcd_pins>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + lcdc_out: port at 1 { > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <1>; > + > + lcdc_out_vga: endpoint at 0 { > + reg = <0>; > + remote-endpoint = <&vga_bridge_in>; > + }; > + }; Just to make sure you're aware, when there's a single endpoint you can simplify the DT by omitting the endpoint number. This would become lcdc_out: port at 1 { reg = <1>; lcdc_out_vga: endpoint { remote-endpoint = <&vga_bridge_in>; }; }; It's entirely up to you, both get my Reviewed-by: Laurent Pinchart > + }; > +}; -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v5 3/4] ARM: dts: da850-lcdk: add the vga-bridge node Date: Wed, 07 Dec 2016 16:25:25 +0200 Message-ID: <1620991.lLXgDihv8c@avalon> References: <1481107365-24839-1-git-send-email-bgolaszewski@baylibre.com> <1481107365-24839-4-git-send-email-bgolaszewski@baylibre.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1481107365-24839-4-git-send-email-bgolaszewski@baylibre.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Bartosz Golaszewski Cc: Mark Rutland , linux-devicetree , Kevin Hilman , Michael Turquette , Sekhar Nori , Russell King , Jyri Sarha , LKML , Peter Ujfalusi , Rob Herring , Tomi Valkeinen , linux-drm , Frank Rowand , arm-soc List-Id: devicetree@vger.kernel.org SGkgQmFydG9zeiwKClRoYW5rIHlvdSBmb3IgdGhlIHBhdGNoLgoKT24gV2VkbmVzZGF5IDA3IERl YyAyMDE2IDExOjQyOjQ0IEJhcnRvc3ogR29sYXN6ZXdza2kgd3JvdGU6Cj4gQWRkIHRoZSB2Z2Et YnJpZGdlIG5vZGUgdG8gdGhlIGJvYXJkIERUIHRvZ2V0aGVyIHdpdGggY29ycmVzcG9uZGluZwo+ IHBvcnRzIGFuZCB2Z2EgY29ubmVjdG9yLiBUaGlzIGFsbG93cyB0byByZXRyaWV2ZSB0aGUgZWRp ZCBpbmZvIGZyb20KPiB0aGUgZGlzcGxheSBhdXRvbWF0aWNhbGx5Lgo+IAo+IFNpZ25lZC1vZmYt Ynk6IEJhcnRvc3ogR29sYXN6ZXdza2kgPGJnb2xhc3pld3NraUBiYXlsaWJyZS5jb20+Cj4gLS0t Cj4gIGFyY2gvYXJtL2Jvb3QvZHRzL2RhODUwLWxjZGsuZHRzIHwgNjcgKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrCj4gIDEgZmlsZSBjaGFuZ2VkLCA2NyBpbnNlcnRpb25zKCsp Cj4gCj4gZGlmZiAtLWdpdCBhL2FyY2gvYXJtL2Jvb3QvZHRzL2RhODUwLWxjZGsuZHRzCj4gYi9h cmNoL2FybS9ib290L2R0cy9kYTg1MC1sY2RrLmR0cyBpbmRleCBhZmNiNDgyLi4zOTYwMmViIDEw MDY0NAo+IC0tLSBhL2FyY2gvYXJtL2Jvb3QvZHRzL2RhODUwLWxjZGsuZHRzCj4gKysrIGIvYXJj aC9hcm0vYm9vdC9kdHMvZGE4NTAtbGNkay5kdHMKPiBAQCAtNTEsNiArNTEsNTEgQEAKPiAgCQkJ c3lzdGVtLWNsb2NrLWZyZXF1ZW5jeSA9IDwyNDU3NjAwMD47Cj4gIAkJfTsKPiAgCX07Cj4gKwo+ ICsJdmdhLWJyaWRnZSB7Cj4gKwkJY29tcGF0aWJsZSA9ICJ0aSx0aHM4MTM1IjsKPiArCQkjYWRk cmVzcy1jZWxscyA9IDwxPjsKPiArCQkjc2l6ZS1jZWxscyA9IDwwPjsKPiArCj4gKwkJcG9ydHMg ewo+ICsJCQkjYWRkcmVzcy1jZWxscyA9IDwxPjsKPiArCQkJI3NpemUtY2VsbHMgPSA8MD47Cj4g Kwo+ICsJCQlwb3J0QDAgewo+ICsJCQkJI2FkZHJlc3MtY2VsbHMgPSA8MT47Cj4gKwkJCQkjc2l6 ZS1jZWxscyA9IDwwPjsKPiArCQkJCXJlZyA9IDwwPjsKPiArCj4gKwkJCQl2Z2FfYnJpZGdlX2lu OiBlbmRwb2ludEAwIHsKPiArCQkJCQlyZWcgPSA8MD47Cj4gKwkJCQkJcmVtb3RlLWVuZHBvaW50 ID0gPCZsY2RjX291dF92Z2E+Owo+ICsJCQkJfTsKPiArCQkJfTsKPiArCj4gKwkJCXBvcnRAMSB7 Cj4gKwkJCQkjYWRkcmVzcy1jZWxscyA9IDwxPjsKPiArCQkJCSNzaXplLWNlbGxzID0gPDA+Owo+ ICsJCQkJcmVnID0gPDE+Owo+ICsKPiArCQkJCXZnYV9icmlkZ2Vfb3V0OiBlbmRwb2ludEAwIHsK PiArCQkJCQlyZWcgPSA8MD47Cj4gKwkJCQkJcmVtb3RlLWVuZHBvaW50ID0gPCZ2Z2FfY29uX2lu PjsKPiArCQkJCX07Cj4gKwkJCX07Cj4gKwkJfTsKPiArCX07Cj4gKwo+ICsJdmdhIHsKPiArCQlj b21wYXRpYmxlID0gInZnYS1jb25uZWN0b3IiOwo+ICsKPiArCQlkZGMtaTJjLWJ1cyA9IDwmaTJj MD47Cj4gKwo+ICsJCXBvcnQgewo+ICsJCQl2Z2FfY29uX2luOiBlbmRwb2ludCB7Cj4gKwkJCQly ZW1vdGUtZW5kcG9pbnQgPSA8JnZnYV9icmlkZ2Vfb3V0PjsKPiArCQkJfTsKPiArCQl9Owo+ICsJ fTsKPiAgfTsKPiAKPiAgJnBteF9jb3JlIHsKPiBAQCAtMjM2LDMgKzI4MSwyNSBAQAo+ICAmbWVt Y3RybCB7Cj4gIAlzdGF0dXMgPSAib2theSI7Cj4gIH07Cj4gKwo+ICsmbGNkYyB7Cj4gKwlzdGF0 dXMgPSAib2theSI7Cj4gKwlwaW5jdHJsLW5hbWVzID0gImRlZmF1bHQiOwo+ICsJcGluY3RybC0w ID0gPCZsY2RfcGlucz47Cj4gKwo+ICsJcG9ydHMgewo+ICsJCSNhZGRyZXNzLWNlbGxzID0gPDE+ Owo+ICsJCSNzaXplLWNlbGxzID0gPDA+Owo+ICsKPiArCQlsY2RjX291dDogcG9ydEAxIHsKPiAr CQkJI2FkZHJlc3MtY2VsbHMgPSA8MT47Cj4gKwkJCSNzaXplLWNlbGxzID0gPDA+Owo+ICsJCQly ZWcgPSA8MT47Cj4gKwo+ICsJCQlsY2RjX291dF92Z2E6IGVuZHBvaW50QDAgewo+ICsJCQkJcmVn ID0gPDA+Owo+ICsJCQkJcmVtb3RlLWVuZHBvaW50ID0gPCZ2Z2FfYnJpZGdlX2luPjsKPiArCQkJ fTsKPiArCQl9OwoKSnVzdCB0byBtYWtlIHN1cmUgeW91J3JlIGF3YXJlLCB3aGVuIHRoZXJlJ3Mg YSBzaW5nbGUgZW5kcG9pbnQgeW91IGNhbiAKc2ltcGxpZnkgdGhlIERUIGJ5IG9taXR0aW5nIHRo ZSBlbmRwb2ludCBudW1iZXIuIFRoaXMgd291bGQgYmVjb21lCgoJCWxjZGNfb3V0OiBwb3J0QDEg ewoJCQlyZWcgPSA8MT47CgoJCQlsY2RjX291dF92Z2E6IGVuZHBvaW50IHsKCQkJCXJlbW90ZS1l bmRwb2ludCA9IDwmdmdhX2JyaWRnZV9pbj47CgkJCX07CgkJfTsKCkl0J3MgZW50aXJlbHkgdXAg dG8geW91LCBib3RoIGdldCBteQoKUmV2aWV3ZWQtYnk6IExhdXJlbnQgUGluY2hhcnQgPGxhdXJl bnQucGluY2hhcnRAaWRlYXNvbmJvYXJkLmNvbT4KCj4gKwl9Owo+ICt9OwoKLS0gClJlZ2FyZHMs CgpMYXVyZW50IFBpbmNoYXJ0CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9k cmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932400AbcLGOZE (ORCPT ); Wed, 7 Dec 2016 09:25:04 -0500 Received: from galahad.ideasonboard.com ([185.26.127.97]:39705 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932124AbcLGOZD (ORCPT ); Wed, 7 Dec 2016 09:25:03 -0500 From: Laurent Pinchart To: Bartosz Golaszewski Cc: Jyri Sarha , Tomi Valkeinen , David Airlie , Kevin Hilman , Michael Turquette , Sekhar Nori , Rob Herring , Frank Rowand , Mark Rutland , Peter Ujfalusi , Russell King , LKML , arm-soc , linux-drm , linux-devicetree Subject: Re: [PATCH v5 3/4] ARM: dts: da850-lcdk: add the vga-bridge node Date: Wed, 07 Dec 2016 16:25:25 +0200 Message-ID: <1620991.lLXgDihv8c@avalon> User-Agent: KMail/4.14.10 (Linux/4.8.6-gentoo; KDE/4.14.24; x86_64; ; ) In-Reply-To: <1481107365-24839-4-git-send-email-bgolaszewski@baylibre.com> References: <1481107365-24839-1-git-send-email-bgolaszewski@baylibre.com> <1481107365-24839-4-git-send-email-bgolaszewski@baylibre.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Bartosz, Thank you for the patch. On Wednesday 07 Dec 2016 11:42:44 Bartosz Golaszewski wrote: > Add the vga-bridge node to the board DT together with corresponding > ports and vga connector. This allows to retrieve the edid info from > the display automatically. > > Signed-off-by: Bartosz Golaszewski > --- > arch/arm/boot/dts/da850-lcdk.dts | 67 ++++++++++++++++++++++++++++++++++++ > 1 file changed, 67 insertions(+) > > diff --git a/arch/arm/boot/dts/da850-lcdk.dts > b/arch/arm/boot/dts/da850-lcdk.dts index afcb482..39602eb 100644 > --- a/arch/arm/boot/dts/da850-lcdk.dts > +++ b/arch/arm/boot/dts/da850-lcdk.dts > @@ -51,6 +51,51 @@ > system-clock-frequency = <24576000>; > }; > }; > + > + vga-bridge { > + compatible = "ti,ths8135"; > + #address-cells = <1>; > + #size-cells = <0>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <0>; > + > + vga_bridge_in: endpoint@0 { > + reg = <0>; > + remote-endpoint = <&lcdc_out_vga>; > + }; > + }; > + > + port@1 { > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <1>; > + > + vga_bridge_out: endpoint@0 { > + reg = <0>; > + remote-endpoint = <&vga_con_in>; > + }; > + }; > + }; > + }; > + > + vga { > + compatible = "vga-connector"; > + > + ddc-i2c-bus = <&i2c0>; > + > + port { > + vga_con_in: endpoint { > + remote-endpoint = <&vga_bridge_out>; > + }; > + }; > + }; > }; > > &pmx_core { > @@ -236,3 +281,25 @@ > &memctrl { > status = "okay"; > }; > + > +&lcdc { > + status = "okay"; > + pinctrl-names = "default"; > + pinctrl-0 = <&lcd_pins>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + lcdc_out: port@1 { > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <1>; > + > + lcdc_out_vga: endpoint@0 { > + reg = <0>; > + remote-endpoint = <&vga_bridge_in>; > + }; > + }; Just to make sure you're aware, when there's a single endpoint you can simplify the DT by omitting the endpoint number. This would become lcdc_out: port@1 { reg = <1>; lcdc_out_vga: endpoint { remote-endpoint = <&vga_bridge_in>; }; }; It's entirely up to you, both get my Reviewed-by: Laurent Pinchart > + }; > +}; -- Regards, Laurent Pinchart