From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Message-ID: <1621383126.12301.4.camel@mtkswgap22> Subject: Re: [PATCH v2 0/2] mm: unify the allocation of pglist_data instances From: Miles Chen Date: Wed, 19 May 2021 08:12:06 +0800 In-Reply-To: References: <20210518092446.16382-1-miles.chen@mediatek.com> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Mike Rapoport Cc: Dave Young , Baoquan He , Vivek Goyal , Jonathan Corbet , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Andrew Morton , kexec@lists.infradead.org, linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org On Tue, 2021-05-18 at 19:09 +0300, Mike Rapoport wrote: > Hello Miles, > > On Tue, May 18, 2021 at 05:24:44PM +0800, Miles Chen wrote: > > This patches is created to fix the __pa() warning messages when > > CONFIG_DEBUG_VIRTUAL=y by unifying the allocation of pglist_data > > instances. > > > > In current implementation of node_data, if CONFIG_NEED_MULTIPLE_NODES=y, > > pglist_data is allocated by a memblock API. If CONFIG_NEED_MULTIPLE_NODES=n, > > we use a global variable named "contig_page_data". > > > > If CONFIG_DEBUG_VIRTUAL is not enabled. __pa() can handle both > > allocation and symbol cases. But if CONFIG_DEBUG_VIRTUAL is set, > > we will have the "virt_to_phys used for non-linear address" warning > > when booting. > > > > To fix the warning, always allocate pglist_data by memblock APIs and > > remove the usage of contig_page_data. > > Somehow I was sure that we can allocate pglist_data before it is accessed > in sparse_init() somewhere outside mm/sparse.c. It's really not the case > and having two places that may allocated this structure is surely worth > than your previous suggestion. > > Sorry about that. Do you mean taht to call allocation function arch/*, somewhere after paging_init() (so we can access pglist_data) and before sparse_init() and free_area_init()? Miles > > > Warning message: > > [ 0.000000] ------------[ cut here ]------------ > > [ 0.000000] virt_to_phys used for non-linear address: (____ptrval____) (contig_page_data+0x0/0x1c00) > > [ 0.000000] WARNING: CPU: 0 PID: 0 at arch/arm64/mm/physaddr.c:15 __virt_to_phys+0x58/0x68 > > [ 0.000000] Modules linked in: > > [ 0.000000] CPU: 0 PID: 0 Comm: swapper Tainted: G W 5.13.0-rc1-00074-g1140ab592e2e #3 > > [ 0.000000] Hardware name: linux,dummy-virt (DT) > > [ 0.000000] pstate: 600000c5 (nZCv daIF -PAN -UAO -TCO BTYPE=--) > > [ 0.000000] pc : __virt_to_phys+0x58/0x68 > > [ 0.000000] lr : __virt_to_phys+0x54/0x68 > > [ 0.000000] sp : ffff800011833e70 > > [ 0.000000] x29: ffff800011833e70 x28: 00000000418a0018 x27: 0000000000000000 > > [ 0.000000] x26: 000000000000000a x25: ffff800011b70000 x24: ffff800011b70000 > > [ 0.000000] x23: fffffc0001c00000 x22: ffff800011b70000 x21: 0000000047ffffb0 > > [ 0.000000] x20: 0000000000000008 x19: ffff800011b082c0 x18: ffffffffffffffff > > [ 0.000000] x17: 0000000000000000 x16: ffff800011833bf9 x15: 0000000000000004 > > [ 0.000000] x14: 0000000000000fff x13: ffff80001186a548 x12: 0000000000000000 > > [ 0.000000] x11: 0000000000000000 x10: 00000000ffffffff x9 : 0000000000000000 > > [ 0.000000] x8 : ffff8000115c9000 x7 : 737520737968705f x6 : ffff800011b62ef8 > > [ 0.000000] x5 : 0000000000000000 x4 : 0000000000000001 x3 : 0000000000000000 > > [ 0.000000] x2 : 0000000000000000 x1 : ffff80001159585e x0 : 0000000000000058 > > [ 0.000000] Call trace: > > [ 0.000000] __virt_to_phys+0x58/0x68 > > [ 0.000000] check_usemap_section_nr+0x50/0xfc > > [ 0.000000] sparse_init_nid+0x1ac/0x28c > > [ 0.000000] sparse_init+0x1c4/0x1e0 > > [ 0.000000] bootmem_init+0x60/0x90 > > [ 0.000000] setup_arch+0x184/0x1f0 > > [ 0.000000] start_kernel+0x78/0x488 > > [ 0.000000] ---[ end trace f68728a0d3053b60 ]--- > > > > [1] https://urldefense.com/v3/__https://lore.kernel.org/patchwork/patch/1425110/__;!!CTRNKA9wMg0ARbw!x-wGFEC1wLzXho2kI1CrC2fjXNaQm5f-n0ADQyJDckCOKZHAP_q055DCSWYcQ7Zdcw$ > > > > Change since v1: > > - use memblock_alloc() to create pglist_data when CONFIG_NUMA=n > > > > Miles Chen (2): > > mm: introduce prepare_node_data > > mm: replace contig_page_data with node_data > > > > Documentation/admin-guide/kdump/vmcoreinfo.rst | 13 ------------- > > arch/powerpc/kexec/core.c | 5 ----- > > include/linux/gfp.h | 3 --- > > include/linux/mm.h | 2 ++ > > include/linux/mmzone.h | 4 ++-- > > kernel/crash_core.c | 1 - > > mm/memblock.c | 3 +-- > > mm/page_alloc.c | 16 ++++++++++++++++ > > mm/sparse.c | 2 ++ > > 9 files changed, 23 insertions(+), 26 deletions(-) > > > > > > base-commit: 8ac91e6c6033ebc12c5c1e4aa171b81a662bd70f > > -- > > 2.18.0 > > > _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBD67C433ED for ; Wed, 19 May 2021 00:12:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9FCE2610CC for ; Wed, 19 May 2021 00:12:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233762AbhESANa (ORCPT ); Tue, 18 May 2021 20:13:30 -0400 Received: from mailgw01.mediatek.com ([210.61.82.183]:47493 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S232773AbhESANa (ORCPT ); Tue, 18 May 2021 20:13:30 -0400 X-UUID: d60617eb75fc498bb791eb231d98dbca-20210519 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=qPl/sSk5L5BJ00kmhUPZ9WBNL8LNmX162Mp2lwH5YCY=; b=dyIS+GIoMh8q3GHv80ISIR5RvQSId5tGq8FadANxnAZDeA/t7NE6K/RuBjCynCN6O2v+LlDcfCQw+DEBMKJvwPdiJcvQWBs0Zz43cfadowv5PDyjVpstCPuStMq7qIUQMb+z2Co6wH7xifXZmn3BBMrY1YAJkTvlV2HHyUXwuEU=; X-UUID: d60617eb75fc498bb791eb231d98dbca-20210519 Received: from mtkmbs10n1.mediatek.inc [(172.21.101.34)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1253459367; Wed, 19 May 2021 08:12:07 +0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs05n2.mediatek.inc (172.21.101.140) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 19 May 2021 08:12:06 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 19 May 2021 08:12:06 +0800 Message-ID: <1621383126.12301.4.camel@mtkswgap22> Subject: Re: [PATCH v2 0/2] mm: unify the allocation of pglist_data instances From: Miles Chen To: Mike Rapoport CC: Dave Young , Baoquan He , Vivek Goyal , Jonathan Corbet , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Andrew Morton , , , , , , Date: Wed, 19 May 2021 08:12:06 +0800 In-Reply-To: References: <20210518092446.16382-1-miles.chen@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N Content-Transfer-Encoding: base64 Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org T24gVHVlLCAyMDIxLTA1LTE4IGF0IDE5OjA5ICswMzAwLCBNaWtlIFJhcG9wb3J0IHdyb3RlOg0K PiBIZWxsbyBNaWxlcywNCj4gDQo+IE9uIFR1ZSwgTWF5IDE4LCAyMDIxIGF0IDA1OjI0OjQ0UE0g KzA4MDAsIE1pbGVzIENoZW4gd3JvdGU6DQo+ID4gVGhpcyBwYXRjaGVzIGlzIGNyZWF0ZWQgdG8g Zml4IHRoZSBfX3BhKCkgd2FybmluZyBtZXNzYWdlcyB3aGVuDQo+ID4gQ09ORklHX0RFQlVHX1ZJ UlRVQUw9eSBieSB1bmlmeWluZyB0aGUgYWxsb2NhdGlvbiBvZiBwZ2xpc3RfZGF0YQ0KPiA+IGlu c3RhbmNlcy4NCj4gPiANCj4gPiBJbiBjdXJyZW50IGltcGxlbWVudGF0aW9uIG9mIG5vZGVfZGF0 YSwgaWYgQ09ORklHX05FRURfTVVMVElQTEVfTk9ERVM9eSwNCj4gPiBwZ2xpc3RfZGF0YSBpcyBh bGxvY2F0ZWQgYnkgYSBtZW1ibG9jayBBUEkuIElmIENPTkZJR19ORUVEX01VTFRJUExFX05PREVT PW4sDQo+ID4gd2UgdXNlIGEgZ2xvYmFsIHZhcmlhYmxlIG5hbWVkICJjb250aWdfcGFnZV9kYXRh Ii4NCj4gPiANCj4gPiBJZiBDT05GSUdfREVCVUdfVklSVFVBTCBpcyBub3QgZW5hYmxlZC4gX19w YSgpIGNhbiBoYW5kbGUgYm90aA0KPiA+IGFsbG9jYXRpb24gYW5kIHN5bWJvbCBjYXNlcy4gQnV0 IGlmIENPTkZJR19ERUJVR19WSVJUVUFMIGlzIHNldCwNCj4gPiB3ZSB3aWxsIGhhdmUgdGhlICJ2 aXJ0X3RvX3BoeXMgdXNlZCBmb3Igbm9uLWxpbmVhciBhZGRyZXNzIiB3YXJuaW5nDQo+ID4gd2hl biBib290aW5nLg0KPiA+IA0KPiA+IFRvIGZpeCB0aGUgd2FybmluZywgYWx3YXlzIGFsbG9jYXRl IHBnbGlzdF9kYXRhIGJ5IG1lbWJsb2NrIEFQSXMgYW5kDQo+ID4gcmVtb3ZlIHRoZSB1c2FnZSBv ZiBjb250aWdfcGFnZV9kYXRhLg0KPiANCj4gU29tZWhvdyBJIHdhcyBzdXJlIHRoYXQgd2UgY2Fu IGFsbG9jYXRlIHBnbGlzdF9kYXRhIGJlZm9yZSBpdCBpcyBhY2Nlc3NlZA0KPiBpbiBzcGFyc2Vf aW5pdCgpIHNvbWV3aGVyZSBvdXRzaWRlIG1tL3NwYXJzZS5jLiBJdCdzIHJlYWxseSBub3QgdGhl IGNhc2UNCj4gYW5kIGhhdmluZyB0d28gcGxhY2VzIHRoYXQgbWF5IGFsbG9jYXRlZCB0aGlzIHN0 cnVjdHVyZSBpcyBzdXJlbHkgd29ydGgNCj4gdGhhbiB5b3VyIHByZXZpb3VzIHN1Z2dlc3Rpb24u DQo+IA0KPiBTb3JyeSBhYm91dCB0aGF0Lg0KDQpEbyB5b3UgbWVhbiB0YWh0IHRvIGNhbGwgYWxs b2NhdGlvbiBmdW5jdGlvbiBhcmNoLyosIHNvbWV3aGVyZSBhZnRlcg0KcGFnaW5nX2luaXQoKSAo c28gd2UgY2FuIGFjY2VzcyBwZ2xpc3RfZGF0YSkgYW5kIGJlZm9yZSBzcGFyc2VfaW5pdCgpDQph bmQgZnJlZV9hcmVhX2luaXQoKT8NCg0KTWlsZXMNCg0KPiAgDQo+ID4gV2FybmluZyBtZXNzYWdl Og0KPiA+IFsgICAgMC4wMDAwMDBdIC0tLS0tLS0tLS0tLVsgY3V0IGhlcmUgXS0tLS0tLS0tLS0t LQ0KPiA+IFsgICAgMC4wMDAwMDBdIHZpcnRfdG9fcGh5cyB1c2VkIGZvciBub24tbGluZWFyIGFk ZHJlc3M6IChfX19fcHRydmFsX19fXykgKGNvbnRpZ19wYWdlX2RhdGErMHgwLzB4MWMwMCkNCj4g PiBbICAgIDAuMDAwMDAwXSBXQVJOSU5HOiBDUFU6IDAgUElEOiAwIGF0IGFyY2gvYXJtNjQvbW0v cGh5c2FkZHIuYzoxNSBfX3ZpcnRfdG9fcGh5cysweDU4LzB4NjgNCj4gPiBbICAgIDAuMDAwMDAw XSBNb2R1bGVzIGxpbmtlZCBpbjoNCj4gPiBbICAgIDAuMDAwMDAwXSBDUFU6IDAgUElEOiAwIENv bW06IHN3YXBwZXIgVGFpbnRlZDogRyAgICAgICAgVyAgICAgICAgIDUuMTMuMC1yYzEtMDAwNzQt ZzExNDBhYjU5MmUyZSAjMw0KPiA+IFsgICAgMC4wMDAwMDBdIEhhcmR3YXJlIG5hbWU6IGxpbnV4 LGR1bW15LXZpcnQgKERUKQ0KPiA+IFsgICAgMC4wMDAwMDBdIHBzdGF0ZTogNjAwMDAwYzUgKG5a Q3YgZGFJRiAtUEFOIC1VQU8gLVRDTyBCVFlQRT0tLSkNCj4gPiBbICAgIDAuMDAwMDAwXSBwYyA6 IF9fdmlydF90b19waHlzKzB4NTgvMHg2OA0KPiA+IFsgICAgMC4wMDAwMDBdIGxyIDogX192aXJ0 X3RvX3BoeXMrMHg1NC8weDY4DQo+ID4gWyAgICAwLjAwMDAwMF0gc3AgOiBmZmZmODAwMDExODMz ZTcwDQo+ID4gWyAgICAwLjAwMDAwMF0geDI5OiBmZmZmODAwMDExODMzZTcwIHgyODogMDAwMDAw MDA0MThhMDAxOCB4Mjc6IDAwMDAwMDAwMDAwMDAwMDANCj4gPiBbICAgIDAuMDAwMDAwXSB4MjY6 IDAwMDAwMDAwMDAwMDAwMGEgeDI1OiBmZmZmODAwMDExYjcwMDAwIHgyNDogZmZmZjgwMDAxMWI3 MDAwMA0KPiA+IFsgICAgMC4wMDAwMDBdIHgyMzogZmZmZmZjMDAwMWMwMDAwMCB4MjI6IGZmZmY4 MDAwMTFiNzAwMDAgeDIxOiAwMDAwMDAwMDQ3ZmZmZmIwDQo+ID4gWyAgICAwLjAwMDAwMF0geDIw OiAwMDAwMDAwMDAwMDAwMDA4IHgxOTogZmZmZjgwMDAxMWIwODJjMCB4MTg6IGZmZmZmZmZmZmZm ZmZmZmYNCj4gPiBbICAgIDAuMDAwMDAwXSB4MTc6IDAwMDAwMDAwMDAwMDAwMDAgeDE2OiBmZmZm ODAwMDExODMzYmY5IHgxNTogMDAwMDAwMDAwMDAwMDAwNA0KPiA+IFsgICAgMC4wMDAwMDBdIHgx NDogMDAwMDAwMDAwMDAwMGZmZiB4MTM6IGZmZmY4MDAwMTE4NmE1NDggeDEyOiAwMDAwMDAwMDAw MDAwMDAwDQo+ID4gWyAgICAwLjAwMDAwMF0geDExOiAwMDAwMDAwMDAwMDAwMDAwIHgxMDogMDAw MDAwMDBmZmZmZmZmZiB4OSA6IDAwMDAwMDAwMDAwMDAwMDANCj4gPiBbICAgIDAuMDAwMDAwXSB4 OCA6IGZmZmY4MDAwMTE1YzkwMDAgeDcgOiA3Mzc1MjA3Mzc5Njg3MDVmIHg2IDogZmZmZjgwMDAx MWI2MmVmOA0KPiA+IFsgICAgMC4wMDAwMDBdIHg1IDogMDAwMDAwMDAwMDAwMDAwMCB4NCA6IDAw MDAwMDAwMDAwMDAwMDEgeDMgOiAwMDAwMDAwMDAwMDAwMDAwDQo+ID4gWyAgICAwLjAwMDAwMF0g eDIgOiAwMDAwMDAwMDAwMDAwMDAwIHgxIDogZmZmZjgwMDAxMTU5NTg1ZSB4MCA6IDAwMDAwMDAw MDAwMDAwNTgNCj4gPiBbICAgIDAuMDAwMDAwXSBDYWxsIHRyYWNlOg0KPiA+IFsgICAgMC4wMDAw MDBdICBfX3ZpcnRfdG9fcGh5cysweDU4LzB4NjgNCj4gPiBbICAgIDAuMDAwMDAwXSAgY2hlY2tf dXNlbWFwX3NlY3Rpb25fbnIrMHg1MC8weGZjDQo+ID4gWyAgICAwLjAwMDAwMF0gIHNwYXJzZV9p bml0X25pZCsweDFhYy8weDI4Yw0KPiA+IFsgICAgMC4wMDAwMDBdICBzcGFyc2VfaW5pdCsweDFj NC8weDFlMA0KPiA+IFsgICAgMC4wMDAwMDBdICBib290bWVtX2luaXQrMHg2MC8weDkwDQo+ID4g WyAgICAwLjAwMDAwMF0gIHNldHVwX2FyY2grMHgxODQvMHgxZjANCj4gPiBbICAgIDAuMDAwMDAw XSAgc3RhcnRfa2VybmVsKzB4NzgvMHg0ODgNCj4gPiBbICAgIDAuMDAwMDAwXSAtLS1bIGVuZCB0 cmFjZSBmNjg3MjhhMGQzMDUzYjYwIF0tLS0NCj4gPiANCj4gPiBbMV0gaHR0cHM6Ly91cmxkZWZl bnNlLmNvbS92My9fX2h0dHBzOi8vbG9yZS5rZXJuZWwub3JnL3BhdGNod29yay9wYXRjaC8xNDI1 MTEwL19fOyEhQ1RSTktBOXdNZzBBUmJ3IXgtd0dGRUMxd0x6WGhvMmtJMUNyQzJmalhOYVFtNWYt bjBBRFF5SkRja0NPS1pIQVBfcTA1NURDU1dZY1E3WmRjdyQgDQo+ID4gDQo+ID4gQ2hhbmdlIHNp bmNlIHYxOg0KPiA+IC0gdXNlIG1lbWJsb2NrX2FsbG9jKCkgdG8gY3JlYXRlIHBnbGlzdF9kYXRh IHdoZW4gQ09ORklHX05VTUE9bg0KPiA+IA0KPiA+IE1pbGVzIENoZW4gKDIpOg0KPiA+ICAgbW06 IGludHJvZHVjZSBwcmVwYXJlX25vZGVfZGF0YQ0KPiA+ICAgbW06IHJlcGxhY2UgY29udGlnX3Bh Z2VfZGF0YSB3aXRoIG5vZGVfZGF0YQ0KPiA+IA0KPiA+ICBEb2N1bWVudGF0aW9uL2FkbWluLWd1 aWRlL2tkdW1wL3ZtY29yZWluZm8ucnN0IHwgMTMgLS0tLS0tLS0tLS0tLQ0KPiA+ICBhcmNoL3Bv d2VycGMva2V4ZWMvY29yZS5jICAgICAgICAgICAgICAgICAgICAgIHwgIDUgLS0tLS0NCj4gPiAg aW5jbHVkZS9saW51eC9nZnAuaCAgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAzIC0tLQ0K PiA+ICBpbmNsdWRlL2xpbnV4L21tLmggICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgIDIg KysNCj4gPiAgaW5jbHVkZS9saW51eC9tbXpvbmUuaCAgICAgICAgICAgICAgICAgICAgICAgICB8 ICA0ICsrLS0NCj4gPiAga2VybmVsL2NyYXNoX2NvcmUuYyAgICAgICAgICAgICAgICAgICAgICAg ICAgICB8ICAxIC0NCj4gPiAgbW0vbWVtYmxvY2suYyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICB8ICAzICstLQ0KPiA+ICBtbS9wYWdlX2FsbG9jLmMgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIHwgMTYgKysrKysrKysrKysrKysrKw0KPiA+ICBtbS9zcGFyc2UuYyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgIDIgKysNCj4gPiAgOSBmaWxlcyBjaGFu Z2VkLCAyMyBpbnNlcnRpb25zKCspLCAyNiBkZWxldGlvbnMoLSkNCj4gPiANCj4gPiANCj4gPiBi YXNlLWNvbW1pdDogOGFjOTFlNmM2MDMzZWJjMTJjNWMxZTRhYTE3MWI4MWE2NjJiZDcwZg0KPiA+ IC0tIA0KPiA+IDIuMTguMA0KPiA+IA0KPiANCg0K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16046C433B4 for ; Wed, 19 May 2021 00:12:38 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8DA646100A for ; Wed, 19 May 2021 00:12:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8DA646100A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:CC:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=pSWlHAhRu9ZuKrpFGsw7xUyQ4niTuYnuPAWNbyzlfW0=; b=i2KozlQb9ixeSpBNON/o/66bq GNpSXYyltVzQbLiDv5wqf/2vptP/f60WRY2MauPkdOl6eH7RNkxXb23eqe9Fb4V9XxoRgfowdavyD 3kY5nxGfHhlWLYbBflpvceb2aqIwu/q5E2hApwEI9uvZJFneTE/v4F7H0CXk2bzI7ze6TEtT/BZy0 XRSysgdRTLdOdUFeq5RRyEj6R//n2Hbq69J41/p2JuITHJyt+bau38LO5JzR77aGzvrstQlEO67/C oFNPzUz1OAadN+gb97VUEA+lwFrV9OAA04JjHAQtZjxMcdaknhnIxsP7t3+2gzuACCrfOQl67D1bn tBKbEu1+A==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lj9ox-002Esb-Dj; Wed, 19 May 2021 00:12:19 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lj9ov-002EsC-Kd; Wed, 19 May 2021 00:12:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject: Message-ID:Sender:Reply-To:Content-ID:Content-Description; bh=qPl/sSk5L5BJ00kmhUPZ9WBNL8LNmX162Mp2lwH5YCY=; b=V+Rdx7gom1QkKnXSYwMYQwD6w9 lB7pN2xvibjbqPR10lJ3pf/F4Re1PAR7KhIOgGkTMGwxR9A+6TF/ukklpUti0YO659nXgZirJUY01 f3SndVM+hAKgqzUvRKp/qCOc9I0XiDQj16SDS8MCxPthy+AEk+vuwLOn9snWdmPPvJrrBuLSbO37+ bsRAy8wt1ryHEpfZOEHVV2nLsdHTNSL0z2U3jYddVqwdkB63o0c7JrcVg0li3FbYABlCtXWc+nUfx W3eaLTaUIsNzGvFLyRVLsxRcL3zL+EknZYJunxJrjiL1BuyrhmFuhedeeYmJf3BufNFVLS893Wbk5 hApmZSnQ==; Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lj9os-00F2Un-16; Wed, 19 May 2021 00:12:16 +0000 X-UUID: 17933abafb1045b48ae1a07d3374eb0d-20210518 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=qPl/sSk5L5BJ00kmhUPZ9WBNL8LNmX162Mp2lwH5YCY=; b=enO4WrT3/6ieDDhICEUuzgktcObVJ0rxY74s1D9YG4SYDWH9+MdTyovpGMzpwssR/oefPRXv8l07f98hqgWbAwK8EBWcCEgfE7yK1i4gT+psi38vnU+nZd/zso4ALyooSLAgYHA0cZpnQQDU9TkDw75sZv8ykK5IRXKnLIii6YQ=; X-UUID: 17933abafb1045b48ae1a07d3374eb0d-20210518 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1695687678; Tue, 18 May 2021 17:12:09 -0700 Received: from mtkmbs05n2.mediatek.inc (172.21.101.140) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 18 May 2021 17:12:07 -0700 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs05n2.mediatek.inc (172.21.101.140) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 19 May 2021 08:12:06 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 19 May 2021 08:12:06 +0800 Message-ID: <1621383126.12301.4.camel@mtkswgap22> Subject: Re: [PATCH v2 0/2] mm: unify the allocation of pglist_data instances From: Miles Chen To: Mike Rapoport CC: Dave Young , Baoquan He , Vivek Goyal , Jonathan Corbet , Michael Ellerman , Benjamin Herrenschmidt , "Paul Mackerras" , Andrew Morton , , , , , , Date: Wed, 19 May 2021 08:12:06 +0800 In-Reply-To: References: <20210518092446.16382-1-miles.chen@mediatek.com> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210518_171214_097060_7EED8CF9 X-CRM114-Status: GOOD ( 26.09 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Tue, 2021-05-18 at 19:09 +0300, Mike Rapoport wrote: > Hello Miles, > > On Tue, May 18, 2021 at 05:24:44PM +0800, Miles Chen wrote: > > This patches is created to fix the __pa() warning messages when > > CONFIG_DEBUG_VIRTUAL=y by unifying the allocation of pglist_data > > instances. > > > > In current implementation of node_data, if CONFIG_NEED_MULTIPLE_NODES=y, > > pglist_data is allocated by a memblock API. If CONFIG_NEED_MULTIPLE_NODES=n, > > we use a global variable named "contig_page_data". > > > > If CONFIG_DEBUG_VIRTUAL is not enabled. __pa() can handle both > > allocation and symbol cases. But if CONFIG_DEBUG_VIRTUAL is set, > > we will have the "virt_to_phys used for non-linear address" warning > > when booting. > > > > To fix the warning, always allocate pglist_data by memblock APIs and > > remove the usage of contig_page_data. > > Somehow I was sure that we can allocate pglist_data before it is accessed > in sparse_init() somewhere outside mm/sparse.c. It's really not the case > and having two places that may allocated this structure is surely worth > than your previous suggestion. > > Sorry about that. Do you mean taht to call allocation function arch/*, somewhere after paging_init() (so we can access pglist_data) and before sparse_init() and free_area_init()? Miles > > > Warning message: > > [ 0.000000] ------------[ cut here ]------------ > > [ 0.000000] virt_to_phys used for non-linear address: (____ptrval____) (contig_page_data+0x0/0x1c00) > > [ 0.000000] WARNING: CPU: 0 PID: 0 at arch/arm64/mm/physaddr.c:15 __virt_to_phys+0x58/0x68 > > [ 0.000000] Modules linked in: > > [ 0.000000] CPU: 0 PID: 0 Comm: swapper Tainted: G W 5.13.0-rc1-00074-g1140ab592e2e #3 > > [ 0.000000] Hardware name: linux,dummy-virt (DT) > > [ 0.000000] pstate: 600000c5 (nZCv daIF -PAN -UAO -TCO BTYPE=--) > > [ 0.000000] pc : __virt_to_phys+0x58/0x68 > > [ 0.000000] lr : __virt_to_phys+0x54/0x68 > > [ 0.000000] sp : ffff800011833e70 > > [ 0.000000] x29: ffff800011833e70 x28: 00000000418a0018 x27: 0000000000000000 > > [ 0.000000] x26: 000000000000000a x25: ffff800011b70000 x24: ffff800011b70000 > > [ 0.000000] x23: fffffc0001c00000 x22: ffff800011b70000 x21: 0000000047ffffb0 > > [ 0.000000] x20: 0000000000000008 x19: ffff800011b082c0 x18: ffffffffffffffff > > [ 0.000000] x17: 0000000000000000 x16: ffff800011833bf9 x15: 0000000000000004 > > [ 0.000000] x14: 0000000000000fff x13: ffff80001186a548 x12: 0000000000000000 > > [ 0.000000] x11: 0000000000000000 x10: 00000000ffffffff x9 : 0000000000000000 > > [ 0.000000] x8 : ffff8000115c9000 x7 : 737520737968705f x6 : ffff800011b62ef8 > > [ 0.000000] x5 : 0000000000000000 x4 : 0000000000000001 x3 : 0000000000000000 > > [ 0.000000] x2 : 0000000000000000 x1 : ffff80001159585e x0 : 0000000000000058 > > [ 0.000000] Call trace: > > [ 0.000000] __virt_to_phys+0x58/0x68 > > [ 0.000000] check_usemap_section_nr+0x50/0xfc > > [ 0.000000] sparse_init_nid+0x1ac/0x28c > > [ 0.000000] sparse_init+0x1c4/0x1e0 > > [ 0.000000] bootmem_init+0x60/0x90 > > [ 0.000000] setup_arch+0x184/0x1f0 > > [ 0.000000] start_kernel+0x78/0x488 > > [ 0.000000] ---[ end trace f68728a0d3053b60 ]--- > > > > [1] https://urldefense.com/v3/__https://lore.kernel.org/patchwork/patch/1425110/__;!!CTRNKA9wMg0ARbw!x-wGFEC1wLzXho2kI1CrC2fjXNaQm5f-n0ADQyJDckCOKZHAP_q055DCSWYcQ7Zdcw$ > > > > Change since v1: > > - use memblock_alloc() to create pglist_data when CONFIG_NUMA=n > > > > Miles Chen (2): > > mm: introduce prepare_node_data > > mm: replace contig_page_data with node_data > > > > Documentation/admin-guide/kdump/vmcoreinfo.rst | 13 ------------- > > arch/powerpc/kexec/core.c | 5 ----- > > include/linux/gfp.h | 3 --- > > include/linux/mm.h | 2 ++ > > include/linux/mmzone.h | 4 ++-- > > kernel/crash_core.c | 1 - > > mm/memblock.c | 3 +-- > > mm/page_alloc.c | 16 ++++++++++++++++ > > mm/sparse.c | 2 ++ > > 9 files changed, 23 insertions(+), 26 deletions(-) > > > > > > base-commit: 8ac91e6c6033ebc12c5c1e4aa171b81a662bd70f > > -- > > 2.18.0 > > > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86EC5C433ED for ; Wed, 19 May 2021 00:12:46 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1E4816100A for ; Wed, 19 May 2021 00:12:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1E4816100A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4FlCxS5jJNz30Hk for ; Wed, 19 May 2021 10:12:44 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=mediatek.com header.i=@mediatek.com header.a=rsa-sha256 header.s=dk header.b=dyIS+GIo; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=mediatek.com (client-ip=210.61.82.183; helo=mailgw01.mediatek.com; envelope-from=miles.chen@mediatek.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=mediatek.com header.i=@mediatek.com header.a=rsa-sha256 header.s=dk header.b=dyIS+GIo; dkim-atps=neutral Received: from mailgw01.mediatek.com (mailgw01.mediatek.com [210.61.82.183]) by lists.ozlabs.org (Postfix) with ESMTP id 4FlCwv5nBkz2xvV for ; Wed, 19 May 2021 10:12:13 +1000 (AEST) X-UUID: d60617eb75fc498bb791eb231d98dbca-20210519 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=qPl/sSk5L5BJ00kmhUPZ9WBNL8LNmX162Mp2lwH5YCY=; b=dyIS+GIoMh8q3GHv80ISIR5RvQSId5tGq8FadANxnAZDeA/t7NE6K/RuBjCynCN6O2v+LlDcfCQw+DEBMKJvwPdiJcvQWBs0Zz43cfadowv5PDyjVpstCPuStMq7qIUQMb+z2Co6wH7xifXZmn3BBMrY1YAJkTvlV2HHyUXwuEU=; X-UUID: d60617eb75fc498bb791eb231d98dbca-20210519 Received: from mtkmbs10n1.mediatek.inc [(172.21.101.34)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1253459367; Wed, 19 May 2021 08:12:07 +0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs05n2.mediatek.inc (172.21.101.140) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 19 May 2021 08:12:06 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 19 May 2021 08:12:06 +0800 Message-ID: <1621383126.12301.4.camel@mtkswgap22> Subject: Re: [PATCH v2 0/2] mm: unify the allocation of pglist_data instances From: Miles Chen To: Mike Rapoport Date: Wed, 19 May 2021 08:12:06 +0800 In-Reply-To: References: <20210518092446.16382-1-miles.chen@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N Content-Transfer-Encoding: base64 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Baoquan He , Jonathan Corbet , linux-doc@vger.kernel.org, kexec@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, Paul Mackerras , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Andrew Morton , Dave Young , Vivek Goyal Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" T24gVHVlLCAyMDIxLTA1LTE4IGF0IDE5OjA5ICswMzAwLCBNaWtlIFJhcG9wb3J0IHdyb3RlOg0K PiBIZWxsbyBNaWxlcywNCj4gDQo+IE9uIFR1ZSwgTWF5IDE4LCAyMDIxIGF0IDA1OjI0OjQ0UE0g KzA4MDAsIE1pbGVzIENoZW4gd3JvdGU6DQo+ID4gVGhpcyBwYXRjaGVzIGlzIGNyZWF0ZWQgdG8g Zml4IHRoZSBfX3BhKCkgd2FybmluZyBtZXNzYWdlcyB3aGVuDQo+ID4gQ09ORklHX0RFQlVHX1ZJ UlRVQUw9eSBieSB1bmlmeWluZyB0aGUgYWxsb2NhdGlvbiBvZiBwZ2xpc3RfZGF0YQ0KPiA+IGlu c3RhbmNlcy4NCj4gPiANCj4gPiBJbiBjdXJyZW50IGltcGxlbWVudGF0aW9uIG9mIG5vZGVfZGF0 YSwgaWYgQ09ORklHX05FRURfTVVMVElQTEVfTk9ERVM9eSwNCj4gPiBwZ2xpc3RfZGF0YSBpcyBh bGxvY2F0ZWQgYnkgYSBtZW1ibG9jayBBUEkuIElmIENPTkZJR19ORUVEX01VTFRJUExFX05PREVT PW4sDQo+ID4gd2UgdXNlIGEgZ2xvYmFsIHZhcmlhYmxlIG5hbWVkICJjb250aWdfcGFnZV9kYXRh Ii4NCj4gPiANCj4gPiBJZiBDT05GSUdfREVCVUdfVklSVFVBTCBpcyBub3QgZW5hYmxlZC4gX19w YSgpIGNhbiBoYW5kbGUgYm90aA0KPiA+IGFsbG9jYXRpb24gYW5kIHN5bWJvbCBjYXNlcy4gQnV0 IGlmIENPTkZJR19ERUJVR19WSVJUVUFMIGlzIHNldCwNCj4gPiB3ZSB3aWxsIGhhdmUgdGhlICJ2 aXJ0X3RvX3BoeXMgdXNlZCBmb3Igbm9uLWxpbmVhciBhZGRyZXNzIiB3YXJuaW5nDQo+ID4gd2hl biBib290aW5nLg0KPiA+IA0KPiA+IFRvIGZpeCB0aGUgd2FybmluZywgYWx3YXlzIGFsbG9jYXRl IHBnbGlzdF9kYXRhIGJ5IG1lbWJsb2NrIEFQSXMgYW5kDQo+ID4gcmVtb3ZlIHRoZSB1c2FnZSBv ZiBjb250aWdfcGFnZV9kYXRhLg0KPiANCj4gU29tZWhvdyBJIHdhcyBzdXJlIHRoYXQgd2UgY2Fu IGFsbG9jYXRlIHBnbGlzdF9kYXRhIGJlZm9yZSBpdCBpcyBhY2Nlc3NlZA0KPiBpbiBzcGFyc2Vf aW5pdCgpIHNvbWV3aGVyZSBvdXRzaWRlIG1tL3NwYXJzZS5jLiBJdCdzIHJlYWxseSBub3QgdGhl IGNhc2UNCj4gYW5kIGhhdmluZyB0d28gcGxhY2VzIHRoYXQgbWF5IGFsbG9jYXRlZCB0aGlzIHN0 cnVjdHVyZSBpcyBzdXJlbHkgd29ydGgNCj4gdGhhbiB5b3VyIHByZXZpb3VzIHN1Z2dlc3Rpb24u DQo+IA0KPiBTb3JyeSBhYm91dCB0aGF0Lg0KDQpEbyB5b3UgbWVhbiB0YWh0IHRvIGNhbGwgYWxs b2NhdGlvbiBmdW5jdGlvbiBhcmNoLyosIHNvbWV3aGVyZSBhZnRlcg0KcGFnaW5nX2luaXQoKSAo c28gd2UgY2FuIGFjY2VzcyBwZ2xpc3RfZGF0YSkgYW5kIGJlZm9yZSBzcGFyc2VfaW5pdCgpDQph bmQgZnJlZV9hcmVhX2luaXQoKT8NCg0KTWlsZXMNCg0KPiAgDQo+ID4gV2FybmluZyBtZXNzYWdl Og0KPiA+IFsgICAgMC4wMDAwMDBdIC0tLS0tLS0tLS0tLVsgY3V0IGhlcmUgXS0tLS0tLS0tLS0t LQ0KPiA+IFsgICAgMC4wMDAwMDBdIHZpcnRfdG9fcGh5cyB1c2VkIGZvciBub24tbGluZWFyIGFk ZHJlc3M6IChfX19fcHRydmFsX19fXykgKGNvbnRpZ19wYWdlX2RhdGErMHgwLzB4MWMwMCkNCj4g PiBbICAgIDAuMDAwMDAwXSBXQVJOSU5HOiBDUFU6IDAgUElEOiAwIGF0IGFyY2gvYXJtNjQvbW0v cGh5c2FkZHIuYzoxNSBfX3ZpcnRfdG9fcGh5cysweDU4LzB4NjgNCj4gPiBbICAgIDAuMDAwMDAw XSBNb2R1bGVzIGxpbmtlZCBpbjoNCj4gPiBbICAgIDAuMDAwMDAwXSBDUFU6IDAgUElEOiAwIENv bW06IHN3YXBwZXIgVGFpbnRlZDogRyAgICAgICAgVyAgICAgICAgIDUuMTMuMC1yYzEtMDAwNzQt ZzExNDBhYjU5MmUyZSAjMw0KPiA+IFsgICAgMC4wMDAwMDBdIEhhcmR3YXJlIG5hbWU6IGxpbnV4 LGR1bW15LXZpcnQgKERUKQ0KPiA+IFsgICAgMC4wMDAwMDBdIHBzdGF0ZTogNjAwMDAwYzUgKG5a Q3YgZGFJRiAtUEFOIC1VQU8gLVRDTyBCVFlQRT0tLSkNCj4gPiBbICAgIDAuMDAwMDAwXSBwYyA6 IF9fdmlydF90b19waHlzKzB4NTgvMHg2OA0KPiA+IFsgICAgMC4wMDAwMDBdIGxyIDogX192aXJ0 X3RvX3BoeXMrMHg1NC8weDY4DQo+ID4gWyAgICAwLjAwMDAwMF0gc3AgOiBmZmZmODAwMDExODMz ZTcwDQo+ID4gWyAgICAwLjAwMDAwMF0geDI5OiBmZmZmODAwMDExODMzZTcwIHgyODogMDAwMDAw MDA0MThhMDAxOCB4Mjc6IDAwMDAwMDAwMDAwMDAwMDANCj4gPiBbICAgIDAuMDAwMDAwXSB4MjY6 IDAwMDAwMDAwMDAwMDAwMGEgeDI1OiBmZmZmODAwMDExYjcwMDAwIHgyNDogZmZmZjgwMDAxMWI3 MDAwMA0KPiA+IFsgICAgMC4wMDAwMDBdIHgyMzogZmZmZmZjMDAwMWMwMDAwMCB4MjI6IGZmZmY4 MDAwMTFiNzAwMDAgeDIxOiAwMDAwMDAwMDQ3ZmZmZmIwDQo+ID4gWyAgICAwLjAwMDAwMF0geDIw OiAwMDAwMDAwMDAwMDAwMDA4IHgxOTogZmZmZjgwMDAxMWIwODJjMCB4MTg6IGZmZmZmZmZmZmZm ZmZmZmYNCj4gPiBbICAgIDAuMDAwMDAwXSB4MTc6IDAwMDAwMDAwMDAwMDAwMDAgeDE2OiBmZmZm ODAwMDExODMzYmY5IHgxNTogMDAwMDAwMDAwMDAwMDAwNA0KPiA+IFsgICAgMC4wMDAwMDBdIHgx NDogMDAwMDAwMDAwMDAwMGZmZiB4MTM6IGZmZmY4MDAwMTE4NmE1NDggeDEyOiAwMDAwMDAwMDAw MDAwMDAwDQo+ID4gWyAgICAwLjAwMDAwMF0geDExOiAwMDAwMDAwMDAwMDAwMDAwIHgxMDogMDAw MDAwMDBmZmZmZmZmZiB4OSA6IDAwMDAwMDAwMDAwMDAwMDANCj4gPiBbICAgIDAuMDAwMDAwXSB4 OCA6IGZmZmY4MDAwMTE1YzkwMDAgeDcgOiA3Mzc1MjA3Mzc5Njg3MDVmIHg2IDogZmZmZjgwMDAx MWI2MmVmOA0KPiA+IFsgICAgMC4wMDAwMDBdIHg1IDogMDAwMDAwMDAwMDAwMDAwMCB4NCA6IDAw MDAwMDAwMDAwMDAwMDEgeDMgOiAwMDAwMDAwMDAwMDAwMDAwDQo+ID4gWyAgICAwLjAwMDAwMF0g eDIgOiAwMDAwMDAwMDAwMDAwMDAwIHgxIDogZmZmZjgwMDAxMTU5NTg1ZSB4MCA6IDAwMDAwMDAw MDAwMDAwNTgNCj4gPiBbICAgIDAuMDAwMDAwXSBDYWxsIHRyYWNlOg0KPiA+IFsgICAgMC4wMDAw MDBdICBfX3ZpcnRfdG9fcGh5cysweDU4LzB4NjgNCj4gPiBbICAgIDAuMDAwMDAwXSAgY2hlY2tf dXNlbWFwX3NlY3Rpb25fbnIrMHg1MC8weGZjDQo+ID4gWyAgICAwLjAwMDAwMF0gIHNwYXJzZV9p bml0X25pZCsweDFhYy8weDI4Yw0KPiA+IFsgICAgMC4wMDAwMDBdICBzcGFyc2VfaW5pdCsweDFj NC8weDFlMA0KPiA+IFsgICAgMC4wMDAwMDBdICBib290bWVtX2luaXQrMHg2MC8weDkwDQo+ID4g WyAgICAwLjAwMDAwMF0gIHNldHVwX2FyY2grMHgxODQvMHgxZjANCj4gPiBbICAgIDAuMDAwMDAw XSAgc3RhcnRfa2VybmVsKzB4NzgvMHg0ODgNCj4gPiBbICAgIDAuMDAwMDAwXSAtLS1bIGVuZCB0 cmFjZSBmNjg3MjhhMGQzMDUzYjYwIF0tLS0NCj4gPiANCj4gPiBbMV0gaHR0cHM6Ly91cmxkZWZl bnNlLmNvbS92My9fX2h0dHBzOi8vbG9yZS5rZXJuZWwub3JnL3BhdGNod29yay9wYXRjaC8xNDI1 MTEwL19fOyEhQ1RSTktBOXdNZzBBUmJ3IXgtd0dGRUMxd0x6WGhvMmtJMUNyQzJmalhOYVFtNWYt bjBBRFF5SkRja0NPS1pIQVBfcTA1NURDU1dZY1E3WmRjdyQgDQo+ID4gDQo+ID4gQ2hhbmdlIHNp bmNlIHYxOg0KPiA+IC0gdXNlIG1lbWJsb2NrX2FsbG9jKCkgdG8gY3JlYXRlIHBnbGlzdF9kYXRh IHdoZW4gQ09ORklHX05VTUE9bg0KPiA+IA0KPiA+IE1pbGVzIENoZW4gKDIpOg0KPiA+ICAgbW06 IGludHJvZHVjZSBwcmVwYXJlX25vZGVfZGF0YQ0KPiA+ICAgbW06IHJlcGxhY2UgY29udGlnX3Bh Z2VfZGF0YSB3aXRoIG5vZGVfZGF0YQ0KPiA+IA0KPiA+ICBEb2N1bWVudGF0aW9uL2FkbWluLWd1 aWRlL2tkdW1wL3ZtY29yZWluZm8ucnN0IHwgMTMgLS0tLS0tLS0tLS0tLQ0KPiA+ICBhcmNoL3Bv d2VycGMva2V4ZWMvY29yZS5jICAgICAgICAgICAgICAgICAgICAgIHwgIDUgLS0tLS0NCj4gPiAg aW5jbHVkZS9saW51eC9nZnAuaCAgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAzIC0tLQ0K PiA+ICBpbmNsdWRlL2xpbnV4L21tLmggICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgIDIg KysNCj4gPiAgaW5jbHVkZS9saW51eC9tbXpvbmUuaCAgICAgICAgICAgICAgICAgICAgICAgICB8 ICA0ICsrLS0NCj4gPiAga2VybmVsL2NyYXNoX2NvcmUuYyAgICAgICAgICAgICAgICAgICAgICAg ICAgICB8ICAxIC0NCj4gPiAgbW0vbWVtYmxvY2suYyAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICB8ICAzICstLQ0KPiA+ICBtbS9wYWdlX2FsbG9jLmMgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgIHwgMTYgKysrKysrKysrKysrKysrKw0KPiA+ICBtbS9zcGFyc2UuYyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgIDIgKysNCj4gPiAgOSBmaWxlcyBjaGFu Z2VkLCAyMyBpbnNlcnRpb25zKCspLCAyNiBkZWxldGlvbnMoLSkNCj4gPiANCj4gPiANCj4gPiBi YXNlLWNvbW1pdDogOGFjOTFlNmM2MDMzZWJjMTJjNWMxZTRhYTE3MWI4MWE2NjJiZDcwZg0KPiA+ IC0tIA0KPiA+IDIuMTguMA0KPiA+IA0KPiANCg0K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6812DC433ED for ; Wed, 19 May 2021 00:14:21 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D44F66100A for ; Wed, 19 May 2021 00:14:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D44F66100A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:CC:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=G9xlR4RJZqSl1i+mSe5f7djMA5RxIcI9i5xzJnosbwk=; b=NP93xxB5aUMo2oVNYdtt8Yi9G +FQKfqh7wFwqNLPByYJAxUExuPVMvB1qpRP3QaBgdMa2yWc76liC+NNRloo1Urmmw4kyQYANQq8GE pUjrvFwGQo0RPAwGfa87BJCyAhIvep1zXZdn62KhVrNLHoS4XhIYoLT5jfMD/lJm9vN659ZNjSFe6 pQGVZGnd7Cc4yHziRDmKFC/4gtlVFxe/FbTHBn7gDoD9o4pWDiAqmfwCLIGRA20hNcoPspOapjuW3 nXGInEhPkhegRCs2Zw+P4PJdM6qtmPwk1KhfPp4UK/CqtuRGKPhzXPSqywm5wMRRZgHUtDvH699+/ i0ojctpMA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lj9p3-002EtV-PL; Wed, 19 May 2021 00:12:26 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lj9ov-002EsC-Kd; Wed, 19 May 2021 00:12:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject: Message-ID:Sender:Reply-To:Content-ID:Content-Description; bh=qPl/sSk5L5BJ00kmhUPZ9WBNL8LNmX162Mp2lwH5YCY=; b=V+Rdx7gom1QkKnXSYwMYQwD6w9 lB7pN2xvibjbqPR10lJ3pf/F4Re1PAR7KhIOgGkTMGwxR9A+6TF/ukklpUti0YO659nXgZirJUY01 f3SndVM+hAKgqzUvRKp/qCOc9I0XiDQj16SDS8MCxPthy+AEk+vuwLOn9snWdmPPvJrrBuLSbO37+ bsRAy8wt1ryHEpfZOEHVV2nLsdHTNSL0z2U3jYddVqwdkB63o0c7JrcVg0li3FbYABlCtXWc+nUfx W3eaLTaUIsNzGvFLyRVLsxRcL3zL+EknZYJunxJrjiL1BuyrhmFuhedeeYmJf3BufNFVLS893Wbk5 hApmZSnQ==; Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lj9os-00F2Un-16; Wed, 19 May 2021 00:12:16 +0000 X-UUID: 17933abafb1045b48ae1a07d3374eb0d-20210518 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=qPl/sSk5L5BJ00kmhUPZ9WBNL8LNmX162Mp2lwH5YCY=; b=enO4WrT3/6ieDDhICEUuzgktcObVJ0rxY74s1D9YG4SYDWH9+MdTyovpGMzpwssR/oefPRXv8l07f98hqgWbAwK8EBWcCEgfE7yK1i4gT+psi38vnU+nZd/zso4ALyooSLAgYHA0cZpnQQDU9TkDw75sZv8ykK5IRXKnLIii6YQ=; X-UUID: 17933abafb1045b48ae1a07d3374eb0d-20210518 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1695687678; Tue, 18 May 2021 17:12:09 -0700 Received: from mtkmbs05n2.mediatek.inc (172.21.101.140) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 18 May 2021 17:12:07 -0700 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs05n2.mediatek.inc (172.21.101.140) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 19 May 2021 08:12:06 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 19 May 2021 08:12:06 +0800 Message-ID: <1621383126.12301.4.camel@mtkswgap22> Subject: Re: [PATCH v2 0/2] mm: unify the allocation of pglist_data instances From: Miles Chen To: Mike Rapoport CC: Dave Young , Baoquan He , Vivek Goyal , Jonathan Corbet , Michael Ellerman , Benjamin Herrenschmidt , "Paul Mackerras" , Andrew Morton , , , , , , Date: Wed, 19 May 2021 08:12:06 +0800 In-Reply-To: References: <20210518092446.16382-1-miles.chen@mediatek.com> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210518_171214_097060_7EED8CF9 X-CRM114-Status: GOOD ( 26.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 2021-05-18 at 19:09 +0300, Mike Rapoport wrote: > Hello Miles, > > On Tue, May 18, 2021 at 05:24:44PM +0800, Miles Chen wrote: > > This patches is created to fix the __pa() warning messages when > > CONFIG_DEBUG_VIRTUAL=y by unifying the allocation of pglist_data > > instances. > > > > In current implementation of node_data, if CONFIG_NEED_MULTIPLE_NODES=y, > > pglist_data is allocated by a memblock API. If CONFIG_NEED_MULTIPLE_NODES=n, > > we use a global variable named "contig_page_data". > > > > If CONFIG_DEBUG_VIRTUAL is not enabled. __pa() can handle both > > allocation and symbol cases. But if CONFIG_DEBUG_VIRTUAL is set, > > we will have the "virt_to_phys used for non-linear address" warning > > when booting. > > > > To fix the warning, always allocate pglist_data by memblock APIs and > > remove the usage of contig_page_data. > > Somehow I was sure that we can allocate pglist_data before it is accessed > in sparse_init() somewhere outside mm/sparse.c. It's really not the case > and having two places that may allocated this structure is surely worth > than your previous suggestion. > > Sorry about that. Do you mean taht to call allocation function arch/*, somewhere after paging_init() (so we can access pglist_data) and before sparse_init() and free_area_init()? Miles > > > Warning message: > > [ 0.000000] ------------[ cut here ]------------ > > [ 0.000000] virt_to_phys used for non-linear address: (____ptrval____) (contig_page_data+0x0/0x1c00) > > [ 0.000000] WARNING: CPU: 0 PID: 0 at arch/arm64/mm/physaddr.c:15 __virt_to_phys+0x58/0x68 > > [ 0.000000] Modules linked in: > > [ 0.000000] CPU: 0 PID: 0 Comm: swapper Tainted: G W 5.13.0-rc1-00074-g1140ab592e2e #3 > > [ 0.000000] Hardware name: linux,dummy-virt (DT) > > [ 0.000000] pstate: 600000c5 (nZCv daIF -PAN -UAO -TCO BTYPE=--) > > [ 0.000000] pc : __virt_to_phys+0x58/0x68 > > [ 0.000000] lr : __virt_to_phys+0x54/0x68 > > [ 0.000000] sp : ffff800011833e70 > > [ 0.000000] x29: ffff800011833e70 x28: 00000000418a0018 x27: 0000000000000000 > > [ 0.000000] x26: 000000000000000a x25: ffff800011b70000 x24: ffff800011b70000 > > [ 0.000000] x23: fffffc0001c00000 x22: ffff800011b70000 x21: 0000000047ffffb0 > > [ 0.000000] x20: 0000000000000008 x19: ffff800011b082c0 x18: ffffffffffffffff > > [ 0.000000] x17: 0000000000000000 x16: ffff800011833bf9 x15: 0000000000000004 > > [ 0.000000] x14: 0000000000000fff x13: ffff80001186a548 x12: 0000000000000000 > > [ 0.000000] x11: 0000000000000000 x10: 00000000ffffffff x9 : 0000000000000000 > > [ 0.000000] x8 : ffff8000115c9000 x7 : 737520737968705f x6 : ffff800011b62ef8 > > [ 0.000000] x5 : 0000000000000000 x4 : 0000000000000001 x3 : 0000000000000000 > > [ 0.000000] x2 : 0000000000000000 x1 : ffff80001159585e x0 : 0000000000000058 > > [ 0.000000] Call trace: > > [ 0.000000] __virt_to_phys+0x58/0x68 > > [ 0.000000] check_usemap_section_nr+0x50/0xfc > > [ 0.000000] sparse_init_nid+0x1ac/0x28c > > [ 0.000000] sparse_init+0x1c4/0x1e0 > > [ 0.000000] bootmem_init+0x60/0x90 > > [ 0.000000] setup_arch+0x184/0x1f0 > > [ 0.000000] start_kernel+0x78/0x488 > > [ 0.000000] ---[ end trace f68728a0d3053b60 ]--- > > > > [1] https://urldefense.com/v3/__https://lore.kernel.org/patchwork/patch/1425110/__;!!CTRNKA9wMg0ARbw!x-wGFEC1wLzXho2kI1CrC2fjXNaQm5f-n0ADQyJDckCOKZHAP_q055DCSWYcQ7Zdcw$ > > > > Change since v1: > > - use memblock_alloc() to create pglist_data when CONFIG_NUMA=n > > > > Miles Chen (2): > > mm: introduce prepare_node_data > > mm: replace contig_page_data with node_data > > > > Documentation/admin-guide/kdump/vmcoreinfo.rst | 13 ------------- > > arch/powerpc/kexec/core.c | 5 ----- > > include/linux/gfp.h | 3 --- > > include/linux/mm.h | 2 ++ > > include/linux/mmzone.h | 4 ++-- > > kernel/crash_core.c | 1 - > > mm/memblock.c | 3 +-- > > mm/page_alloc.c | 16 ++++++++++++++++ > > mm/sparse.c | 2 ++ > > 9 files changed, 23 insertions(+), 26 deletions(-) > > > > > > base-commit: 8ac91e6c6033ebc12c5c1e4aa171b81a662bd70f > > -- > > 2.18.0 > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel