From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Message-ID: <1621396540.12301.7.camel@mtkswgap22> Subject: Re: [PATCH v2 0/2] mm: unify the allocation of pglist_data instances From: Miles Chen Date: Wed, 19 May 2021 11:55:40 +0800 In-Reply-To: References: <20210518092446.16382-1-miles.chen@mediatek.com> <1621383126.12301.4.camel@mtkswgap22> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Mike Rapoport Cc: Dave Young , Baoquan He , Vivek Goyal , Jonathan Corbet , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Andrew Morton , kexec@lists.infradead.org, linux-doc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org On Wed, 2021-05-19 at 06:48 +0300, Mike Rapoport wrote: > On Wed, May 19, 2021 at 08:12:06AM +0800, Miles Chen wrote: > > On Tue, 2021-05-18 at 19:09 +0300, Mike Rapoport wrote: > > > Hello Miles, > > > > > > On Tue, May 18, 2021 at 05:24:44PM +0800, Miles Chen wrote: > > > > This patches is created to fix the __pa() warning messages when > > > > CONFIG_DEBUG_VIRTUAL=y by unifying the allocation of pglist_data > > > > instances. > > > > > > > > In current implementation of node_data, if CONFIG_NEED_MULTIPLE_NODES=y, > > > > pglist_data is allocated by a memblock API. If CONFIG_NEED_MULTIPLE_NODES=n, > > > > we use a global variable named "contig_page_data". > > > > > > > > If CONFIG_DEBUG_VIRTUAL is not enabled. __pa() can handle both > > > > allocation and symbol cases. But if CONFIG_DEBUG_VIRTUAL is set, > > > > we will have the "virt_to_phys used for non-linear address" warning > > > > when booting. > > > > > > > > To fix the warning, always allocate pglist_data by memblock APIs and > > > > remove the usage of contig_page_data. > > > > > > Somehow I was sure that we can allocate pglist_data before it is accessed > > > in sparse_init() somewhere outside mm/sparse.c. It's really not the case > > > and having two places that may allocated this structure is surely worth > > > than your previous suggestion. > > > > > > Sorry about that. > > > > Do you mean taht to call allocation function arch/*, somewhere after > > paging_init() (so we can access pglist_data) and before sparse_init() > > and free_area_init()? > > No, I meant that your original patch is better than adding allocation of > NODE_DATA(0) in two places. Got it. will you re-review the original patch? > > > Miles > > > > > > > > > Warning message: > > > > [ 0.000000] ------------[ cut here ]------------ > > > > [ 0.000000] virt_to_phys used for non-linear address: (____ptrval____) (contig_page_data+0x0/0x1c00) > > > > [ 0.000000] WARNING: CPU: 0 PID: 0 at arch/arm64/mm/physaddr.c:15 __virt_to_phys+0x58/0x68 > > > > [ 0.000000] Modules linked in: > > > > [ 0.000000] CPU: 0 PID: 0 Comm: swapper Tainted: G W 5.13.0-rc1-00074-g1140ab592e2e #3 > > > > [ 0.000000] Hardware name: linux,dummy-virt (DT) > > > > [ 0.000000] pstate: 600000c5 (nZCv daIF -PAN -UAO -TCO BTYPE=--) > > > > [ 0.000000] pc : __virt_to_phys+0x58/0x68 > > > > [ 0.000000] lr : __virt_to_phys+0x54/0x68 > > > > [ 0.000000] sp : ffff800011833e70 > > > > [ 0.000000] x29: ffff800011833e70 x28: 00000000418a0018 x27: 0000000000000000 > > > > [ 0.000000] x26: 000000000000000a x25: ffff800011b70000 x24: ffff800011b70000 > > > > [ 0.000000] x23: fffffc0001c00000 x22: ffff800011b70000 x21: 0000000047ffffb0 > > > > [ 0.000000] x20: 0000000000000008 x19: ffff800011b082c0 x18: ffffffffffffffff > > > > [ 0.000000] x17: 0000000000000000 x16: ffff800011833bf9 x15: 0000000000000004 > > > > [ 0.000000] x14: 0000000000000fff x13: ffff80001186a548 x12: 0000000000000000 > > > > [ 0.000000] x11: 0000000000000000 x10: 00000000ffffffff x9 : 0000000000000000 > > > > [ 0.000000] x8 : ffff8000115c9000 x7 : 737520737968705f x6 : ffff800011b62ef8 > > > > [ 0.000000] x5 : 0000000000000000 x4 : 0000000000000001 x3 : 0000000000000000 > > > > [ 0.000000] x2 : 0000000000000000 x1 : ffff80001159585e x0 : 0000000000000058 > > > > [ 0.000000] Call trace: > > > > [ 0.000000] __virt_to_phys+0x58/0x68 > > > > [ 0.000000] check_usemap_section_nr+0x50/0xfc > > > > [ 0.000000] sparse_init_nid+0x1ac/0x28c > > > > [ 0.000000] sparse_init+0x1c4/0x1e0 > > > > [ 0.000000] bootmem_init+0x60/0x90 > > > > [ 0.000000] setup_arch+0x184/0x1f0 > > > > [ 0.000000] start_kernel+0x78/0x488 > > > > [ 0.000000] ---[ end trace f68728a0d3053b60 ]--- > > > > > > > > [1] https://urldefense.com/v3/__https://lore.kernel.org/patchwork/patch/1425110/__;!!CTRNKA9wMg0ARbw!x-wGFEC1wLzXho2kI1CrC2fjXNaQm5f-n0ADQyJDckCOKZHAP_q055DCSWYcQ7Zdcw$ > > > > > > > > Change since v1: > > > > - use memblock_alloc() to create pglist_data when CONFIG_NUMA=n > > > > > > > > Miles Chen (2): > > > > mm: introduce prepare_node_data > > > > mm: replace contig_page_data with node_data > > > > > > > > Documentation/admin-guide/kdump/vmcoreinfo.rst | 13 ------------- > > > > arch/powerpc/kexec/core.c | 5 ----- > > > > include/linux/gfp.h | 3 --- > > > > include/linux/mm.h | 2 ++ > > > > include/linux/mmzone.h | 4 ++-- > > > > kernel/crash_core.c | 1 - > > > > mm/memblock.c | 3 +-- > > > > mm/page_alloc.c | 16 ++++++++++++++++ > > > > mm/sparse.c | 2 ++ > > > > 9 files changed, 23 insertions(+), 26 deletions(-) > > > > > > > > > > > > base-commit: 8ac91e6c6033ebc12c5c1e4aa171b81a662bd70f > > > > -- > > > > 2.18.0 > > > > > > > > > > _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2814AC433ED for ; Wed, 19 May 2021 03:55:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0B3876135C for ; Wed, 19 May 2021 03:55:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238326AbhESD5F (ORCPT ); Tue, 18 May 2021 23:57:05 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:49788 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S235703AbhESD5E (ORCPT ); Tue, 18 May 2021 23:57:04 -0400 X-UUID: 198d4eae015548bc964e0d68dc629dfb-20210519 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=S/KAedclNU8qmnqec3Ml95ZT6h/23axBf0ZQuILgxHU=; b=UhEODi1CAV1trzS9be4WcS2xYe0b4vG6NkkI3YPaMzfmWOvVK5Weyu7BDJRXczZWVbhyHlBQjawXf5NgRha8xvUrGwLJZQtQFZuWKww4S5TyP7l6nMIkoHJCLQmkkjWttLmEIApc++w5NfMnUEs0vViyT6rJDS4BDnBNGHrC8nE=; X-UUID: 198d4eae015548bc964e0d68dc629dfb-20210519 Received: from mtkcas10.mediatek.inc [(172.21.101.39)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 8210983; Wed, 19 May 2021 11:55:41 +0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 19 May 2021 11:55:40 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 19 May 2021 11:55:39 +0800 Message-ID: <1621396540.12301.7.camel@mtkswgap22> Subject: Re: [PATCH v2 0/2] mm: unify the allocation of pglist_data instances From: Miles Chen To: Mike Rapoport CC: Dave Young , Baoquan He , Vivek Goyal , Jonathan Corbet , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Andrew Morton , , , , , , Date: Wed, 19 May 2021 11:55:40 +0800 In-Reply-To: References: <20210518092446.16382-1-miles.chen@mediatek.com> <1621383126.12301.4.camel@mtkswgap22> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N Content-Transfer-Encoding: base64 Precedence: bulk List-ID: X-Mailing-List: linux-doc@vger.kernel.org T24gV2VkLCAyMDIxLTA1LTE5IGF0IDA2OjQ4ICswMzAwLCBNaWtlIFJhcG9wb3J0IHdyb3RlOg0K PiBPbiBXZWQsIE1heSAxOSwgMjAyMSBhdCAwODoxMjowNkFNICswODAwLCBNaWxlcyBDaGVuIHdy b3RlOg0KPiA+IE9uIFR1ZSwgMjAyMS0wNS0xOCBhdCAxOTowOSArMDMwMCwgTWlrZSBSYXBvcG9y dCB3cm90ZToNCj4gPiA+IEhlbGxvIE1pbGVzLA0KPiA+ID4gDQo+ID4gPiBPbiBUdWUsIE1heSAx OCwgMjAyMSBhdCAwNToyNDo0NFBNICswODAwLCBNaWxlcyBDaGVuIHdyb3RlOg0KPiA+ID4gPiBU aGlzIHBhdGNoZXMgaXMgY3JlYXRlZCB0byBmaXggdGhlIF9fcGEoKSB3YXJuaW5nIG1lc3NhZ2Vz IHdoZW4NCj4gPiA+ID4gQ09ORklHX0RFQlVHX1ZJUlRVQUw9eSBieSB1bmlmeWluZyB0aGUgYWxs b2NhdGlvbiBvZiBwZ2xpc3RfZGF0YQ0KPiA+ID4gPiBpbnN0YW5jZXMuDQo+ID4gPiA+IA0KPiA+ ID4gPiBJbiBjdXJyZW50IGltcGxlbWVudGF0aW9uIG9mIG5vZGVfZGF0YSwgaWYgQ09ORklHX05F RURfTVVMVElQTEVfTk9ERVM9eSwNCj4gPiA+ID4gcGdsaXN0X2RhdGEgaXMgYWxsb2NhdGVkIGJ5 IGEgbWVtYmxvY2sgQVBJLiBJZiBDT05GSUdfTkVFRF9NVUxUSVBMRV9OT0RFUz1uLA0KPiA+ID4g PiB3ZSB1c2UgYSBnbG9iYWwgdmFyaWFibGUgbmFtZWQgImNvbnRpZ19wYWdlX2RhdGEiLg0KPiA+ ID4gPiANCj4gPiA+ID4gSWYgQ09ORklHX0RFQlVHX1ZJUlRVQUwgaXMgbm90IGVuYWJsZWQuIF9f cGEoKSBjYW4gaGFuZGxlIGJvdGgNCj4gPiA+ID4gYWxsb2NhdGlvbiBhbmQgc3ltYm9sIGNhc2Vz LiBCdXQgaWYgQ09ORklHX0RFQlVHX1ZJUlRVQUwgaXMgc2V0LA0KPiA+ID4gPiB3ZSB3aWxsIGhh dmUgdGhlICJ2aXJ0X3RvX3BoeXMgdXNlZCBmb3Igbm9uLWxpbmVhciBhZGRyZXNzIiB3YXJuaW5n DQo+ID4gPiA+IHdoZW4gYm9vdGluZy4NCj4gPiA+ID4gDQo+ID4gPiA+IFRvIGZpeCB0aGUgd2Fy bmluZywgYWx3YXlzIGFsbG9jYXRlIHBnbGlzdF9kYXRhIGJ5IG1lbWJsb2NrIEFQSXMgYW5kDQo+ ID4gPiA+IHJlbW92ZSB0aGUgdXNhZ2Ugb2YgY29udGlnX3BhZ2VfZGF0YS4NCj4gPiA+IA0KPiA+ ID4gU29tZWhvdyBJIHdhcyBzdXJlIHRoYXQgd2UgY2FuIGFsbG9jYXRlIHBnbGlzdF9kYXRhIGJl Zm9yZSBpdCBpcyBhY2Nlc3NlZA0KPiA+ID4gaW4gc3BhcnNlX2luaXQoKSBzb21ld2hlcmUgb3V0 c2lkZSBtbS9zcGFyc2UuYy4gSXQncyByZWFsbHkgbm90IHRoZSBjYXNlDQo+ID4gPiBhbmQgaGF2 aW5nIHR3byBwbGFjZXMgdGhhdCBtYXkgYWxsb2NhdGVkIHRoaXMgc3RydWN0dXJlIGlzIHN1cmVs eSB3b3J0aA0KPiA+ID4gdGhhbiB5b3VyIHByZXZpb3VzIHN1Z2dlc3Rpb24uDQo+ID4gPiANCj4g PiA+IFNvcnJ5IGFib3V0IHRoYXQuDQo+ID4gDQo+ID4gRG8geW91IG1lYW4gdGFodCB0byBjYWxs IGFsbG9jYXRpb24gZnVuY3Rpb24gYXJjaC8qLCBzb21ld2hlcmUgYWZ0ZXINCj4gPiBwYWdpbmdf aW5pdCgpIChzbyB3ZSBjYW4gYWNjZXNzIHBnbGlzdF9kYXRhKSBhbmQgYmVmb3JlIHNwYXJzZV9p bml0KCkNCj4gPiBhbmQgZnJlZV9hcmVhX2luaXQoKT8NCj4gDQo+IE5vLCBJIG1lYW50IHRoYXQg eW91ciBvcmlnaW5hbCBwYXRjaCBpcyBiZXR0ZXIgdGhhbiBhZGRpbmcgYWxsb2NhdGlvbiBvZg0K PiBOT0RFX0RBVEEoMCkgaW4gdHdvIHBsYWNlcy4NCg0KR290IGl0LiB3aWxsIHlvdSByZS1yZXZp ZXcgdGhlIG9yaWdpbmFsIHBhdGNoPw0KDQoNCj4gIA0KPiA+IE1pbGVzDQo+ID4gDQo+ID4gPiAg DQo+ID4gPiA+IFdhcm5pbmcgbWVzc2FnZToNCj4gPiA+ID4gWyAgICAwLjAwMDAwMF0gLS0tLS0t LS0tLS0tWyBjdXQgaGVyZSBdLS0tLS0tLS0tLS0tDQo+ID4gPiA+IFsgICAgMC4wMDAwMDBdIHZp cnRfdG9fcGh5cyB1c2VkIGZvciBub24tbGluZWFyIGFkZHJlc3M6IChfX19fcHRydmFsX19fXykg KGNvbnRpZ19wYWdlX2RhdGErMHgwLzB4MWMwMCkNCj4gPiA+ID4gWyAgICAwLjAwMDAwMF0gV0FS TklORzogQ1BVOiAwIFBJRDogMCBhdCBhcmNoL2FybTY0L21tL3BoeXNhZGRyLmM6MTUgX192aXJ0 X3RvX3BoeXMrMHg1OC8weDY4DQo+ID4gPiA+IFsgICAgMC4wMDAwMDBdIE1vZHVsZXMgbGlua2Vk IGluOg0KPiA+ID4gPiBbICAgIDAuMDAwMDAwXSBDUFU6IDAgUElEOiAwIENvbW06IHN3YXBwZXIg VGFpbnRlZDogRyAgICAgICAgVyAgICAgICAgIDUuMTMuMC1yYzEtMDAwNzQtZzExNDBhYjU5MmUy ZSAjMw0KPiA+ID4gPiBbICAgIDAuMDAwMDAwXSBIYXJkd2FyZSBuYW1lOiBsaW51eCxkdW1teS12 aXJ0IChEVCkNCj4gPiA+ID4gWyAgICAwLjAwMDAwMF0gcHN0YXRlOiA2MDAwMDBjNSAoblpDdiBk YUlGIC1QQU4gLVVBTyAtVENPIEJUWVBFPS0tKQ0KPiA+ID4gPiBbICAgIDAuMDAwMDAwXSBwYyA6 IF9fdmlydF90b19waHlzKzB4NTgvMHg2OA0KPiA+ID4gPiBbICAgIDAuMDAwMDAwXSBsciA6IF9f dmlydF90b19waHlzKzB4NTQvMHg2OA0KPiA+ID4gPiBbICAgIDAuMDAwMDAwXSBzcCA6IGZmZmY4 MDAwMTE4MzNlNzANCj4gPiA+ID4gWyAgICAwLjAwMDAwMF0geDI5OiBmZmZmODAwMDExODMzZTcw IHgyODogMDAwMDAwMDA0MThhMDAxOCB4Mjc6IDAwMDAwMDAwMDAwMDAwMDANCj4gPiA+ID4gWyAg ICAwLjAwMDAwMF0geDI2OiAwMDAwMDAwMDAwMDAwMDBhIHgyNTogZmZmZjgwMDAxMWI3MDAwMCB4 MjQ6IGZmZmY4MDAwMTFiNzAwMDANCj4gPiA+ID4gWyAgICAwLjAwMDAwMF0geDIzOiBmZmZmZmMw MDAxYzAwMDAwIHgyMjogZmZmZjgwMDAxMWI3MDAwMCB4MjE6IDAwMDAwMDAwNDdmZmZmYjANCj4g PiA+ID4gWyAgICAwLjAwMDAwMF0geDIwOiAwMDAwMDAwMDAwMDAwMDA4IHgxOTogZmZmZjgwMDAx MWIwODJjMCB4MTg6IGZmZmZmZmZmZmZmZmZmZmYNCj4gPiA+ID4gWyAgICAwLjAwMDAwMF0geDE3 OiAwMDAwMDAwMDAwMDAwMDAwIHgxNjogZmZmZjgwMDAxMTgzM2JmOSB4MTU6IDAwMDAwMDAwMDAw MDAwMDQNCj4gPiA+ID4gWyAgICAwLjAwMDAwMF0geDE0OiAwMDAwMDAwMDAwMDAwZmZmIHgxMzog ZmZmZjgwMDAxMTg2YTU0OCB4MTI6IDAwMDAwMDAwMDAwMDAwMDANCj4gPiA+ID4gWyAgICAwLjAw MDAwMF0geDExOiAwMDAwMDAwMDAwMDAwMDAwIHgxMDogMDAwMDAwMDBmZmZmZmZmZiB4OSA6IDAw MDAwMDAwMDAwMDAwMDANCj4gPiA+ID4gWyAgICAwLjAwMDAwMF0geDggOiBmZmZmODAwMDExNWM5 MDAwIHg3IDogNzM3NTIwNzM3OTY4NzA1ZiB4NiA6IGZmZmY4MDAwMTFiNjJlZjgNCj4gPiA+ID4g WyAgICAwLjAwMDAwMF0geDUgOiAwMDAwMDAwMDAwMDAwMDAwIHg0IDogMDAwMDAwMDAwMDAwMDAw MSB4MyA6IDAwMDAwMDAwMDAwMDAwMDANCj4gPiA+ID4gWyAgICAwLjAwMDAwMF0geDIgOiAwMDAw MDAwMDAwMDAwMDAwIHgxIDogZmZmZjgwMDAxMTU5NTg1ZSB4MCA6IDAwMDAwMDAwMDAwMDAwNTgN Cj4gPiA+ID4gWyAgICAwLjAwMDAwMF0gQ2FsbCB0cmFjZToNCj4gPiA+ID4gWyAgICAwLjAwMDAw MF0gIF9fdmlydF90b19waHlzKzB4NTgvMHg2OA0KPiA+ID4gPiBbICAgIDAuMDAwMDAwXSAgY2hl Y2tfdXNlbWFwX3NlY3Rpb25fbnIrMHg1MC8weGZjDQo+ID4gPiA+IFsgICAgMC4wMDAwMDBdICBz cGFyc2VfaW5pdF9uaWQrMHgxYWMvMHgyOGMNCj4gPiA+ID4gWyAgICAwLjAwMDAwMF0gIHNwYXJz ZV9pbml0KzB4MWM0LzB4MWUwDQo+ID4gPiA+IFsgICAgMC4wMDAwMDBdICBib290bWVtX2luaXQr MHg2MC8weDkwDQo+ID4gPiA+IFsgICAgMC4wMDAwMDBdICBzZXR1cF9hcmNoKzB4MTg0LzB4MWYw DQo+ID4gPiA+IFsgICAgMC4wMDAwMDBdICBzdGFydF9rZXJuZWwrMHg3OC8weDQ4OA0KPiA+ID4g PiBbICAgIDAuMDAwMDAwXSAtLS1bIGVuZCB0cmFjZSBmNjg3MjhhMGQzMDUzYjYwIF0tLS0NCj4g PiA+ID4gDQo+ID4gPiA+IFsxXSBodHRwczovL3VybGRlZmVuc2UuY29tL3YzL19faHR0cHM6Ly9s b3JlLmtlcm5lbC5vcmcvcGF0Y2h3b3JrL3BhdGNoLzE0MjUxMTAvX187ISFDVFJOS0E5d01nMEFS YncheC13R0ZFQzF3THpYaG8ya0kxQ3JDMmZqWE5hUW01Zi1uMEFEUXlKRGNrQ09LWkhBUF9xMDU1 RENTV1ljUTdaZGN3JCANCj4gPiA+ID4gDQo+ID4gPiA+IENoYW5nZSBzaW5jZSB2MToNCj4gPiA+ ID4gLSB1c2UgbWVtYmxvY2tfYWxsb2MoKSB0byBjcmVhdGUgcGdsaXN0X2RhdGEgd2hlbiBDT05G SUdfTlVNQT1uDQo+ID4gPiA+IA0KPiA+ID4gPiBNaWxlcyBDaGVuICgyKToNCj4gPiA+ID4gICBt bTogaW50cm9kdWNlIHByZXBhcmVfbm9kZV9kYXRhDQo+ID4gPiA+ICAgbW06IHJlcGxhY2UgY29u dGlnX3BhZ2VfZGF0YSB3aXRoIG5vZGVfZGF0YQ0KPiA+ID4gPiANCj4gPiA+ID4gIERvY3VtZW50 YXRpb24vYWRtaW4tZ3VpZGUva2R1bXAvdm1jb3JlaW5mby5yc3QgfCAxMyAtLS0tLS0tLS0tLS0t DQo+ID4gPiA+ICBhcmNoL3Bvd2VycGMva2V4ZWMvY29yZS5jICAgICAgICAgICAgICAgICAgICAg IHwgIDUgLS0tLS0NCj4gPiA+ID4gIGluY2x1ZGUvbGludXgvZ2ZwLmggICAgICAgICAgICAgICAg ICAgICAgICAgICAgfCAgMyAtLS0NCj4gPiA+ID4gIGluY2x1ZGUvbGludXgvbW0uaCAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgfCAgMiArKw0KPiA+ID4gPiAgaW5jbHVkZS9saW51eC9tbXpv bmUuaCAgICAgICAgICAgICAgICAgICAgICAgICB8ICA0ICsrLS0NCj4gPiA+ID4gIGtlcm5lbC9j cmFzaF9jb3JlLmMgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgMSAtDQo+ID4gPiA+ICBt bS9tZW1ibG9jay5jICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgIDMgKy0tDQo+ ID4gPiA+ICBtbS9wYWdlX2FsbG9jLmMgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwg MTYgKysrKysrKysrKysrKysrKw0KPiA+ID4gPiAgbW0vc3BhcnNlLmMgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICB8ICAyICsrDQo+ID4gPiA+ICA5IGZpbGVzIGNoYW5nZWQsIDIz IGluc2VydGlvbnMoKyksIDI2IGRlbGV0aW9ucygtKQ0KPiA+ID4gPiANCj4gPiA+ID4gDQo+ID4g PiA+IGJhc2UtY29tbWl0OiA4YWM5MWU2YzYwMzNlYmMxMmM1YzFlNGFhMTcxYjgxYTY2MmJkNzBm DQo+ID4gPiA+IC0tIA0KPiA+ID4gPiAyLjE4LjANCj4gPiA+ID4gDQo+ID4gPiANCj4gPiANCj4g DQoNCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A293CC433B4 for ; Wed, 19 May 2021 03:56:08 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 207AC6135C for ; Wed, 19 May 2021 03:56:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 207AC6135C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:CC:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Clc7Autz6gCgCvkix3MqvJUUHr4MH9dsajvhElQPm+c=; b=SnQZi4IJxPTtL1TSjeGYvm7q6 vHhFp6k3ZSJMZxuh9dxhSzgVlP9N2THeyyzUWx3NbumDKvPjz6UoWemk4UJgaG2gPU9pIqD7v6M5A iBenbXymos3DZmT5M4ofEeGjPSPZStrdPuyh3LtJZmOFR4mveEAakWHAKS47nVocJsGdk9xMXXdW1 7MhReLBvHwAhqr78KLwpdMQqM1xqPskLN9JcMBXjL1uH60vOrMUM13Oqe9ftpz1nfmJ4KNULRCM5k NfALPTRQkGjaVDg+h8s3U3WfQlFAkyMs/BI0lYnNfROE/14vWGm6zjEmEAaQP7J8aKK8nrHrJzSO5 w0tlcheZA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1ljDJJ-002evq-He; Wed, 19 May 2021 03:55:53 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ljDJG-002ev1-Qs; Wed, 19 May 2021 03:55:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject: Message-ID:Sender:Reply-To:Content-ID:Content-Description; bh=S/KAedclNU8qmnqec3Ml95ZT6h/23axBf0ZQuILgxHU=; b=35zKIaD1MCU7xbGvjr09k5KBVh loELaszjjG+qWB0yK21eKnVYqfDQwmcr3tmzrczNG7vxV5POmPEMZ4MkjlyUdxct0KY8tfKLuyp9t D5e6m5UrEiuM6PUD8IKF48m0GkbDfEhwVpRVPjbeq+bScTB9DkC++UxFJeJUgcCaY7SonLhIkftnq qMxcJHFXQxYTrKthsW7m8xYF29eh5j8OpCWvvw9An/wPBXGJ2A1mZDfK04+sqg/qFB/bJUXK924m3 S2gncv+uJqYIJq5bHVBaoNYGHxyrTe60NyZwzrOGB4edVQbTT+t1Ma76g+1+wgCneCKn7YxH6u5j+ scm7Euhg==; Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ljDJD-00F6cb-G1; Wed, 19 May 2021 03:55:49 +0000 X-UUID: 193191836dcd467098e55df2779b503a-20210518 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=S/KAedclNU8qmnqec3Ml95ZT6h/23axBf0ZQuILgxHU=; b=YToRZ8NaMqOYXDrnE8bDlqAAOkUKR45jAYu4PJTKKfssqrbclns3pyBkfYRZiMlmM04qcxmadyj941yPJzcJxnMc8iAm4k8cmsIbqEgwFneGXL91JIP3VMvGzTBtkZuC7tK2ZIk4IyLm/6D7s1sQitftcS5iMVM3AjyUVfLm+Dw=; X-UUID: 193191836dcd467098e55df2779b503a-20210518 Received: from mtkcas68.mediatek.inc [(172.29.94.19)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1756794877; Tue, 18 May 2021 20:55:44 -0700 Received: from MTKMBS07N2.mediatek.inc (172.21.101.141) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 18 May 2021 20:55:42 -0700 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 19 May 2021 11:55:40 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 19 May 2021 11:55:39 +0800 Message-ID: <1621396540.12301.7.camel@mtkswgap22> Subject: Re: [PATCH v2 0/2] mm: unify the allocation of pglist_data instances From: Miles Chen To: Mike Rapoport CC: Dave Young , Baoquan He , Vivek Goyal , Jonathan Corbet , Michael Ellerman , Benjamin Herrenschmidt , "Paul Mackerras" , Andrew Morton , , , , , , Date: Wed, 19 May 2021 11:55:40 +0800 In-Reply-To: References: <20210518092446.16382-1-miles.chen@mediatek.com> <1621383126.12301.4.camel@mtkswgap22> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210518_205547_560711_8D729FC2 X-CRM114-Status: GOOD ( 31.64 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Wed, 2021-05-19 at 06:48 +0300, Mike Rapoport wrote: > On Wed, May 19, 2021 at 08:12:06AM +0800, Miles Chen wrote: > > On Tue, 2021-05-18 at 19:09 +0300, Mike Rapoport wrote: > > > Hello Miles, > > > > > > On Tue, May 18, 2021 at 05:24:44PM +0800, Miles Chen wrote: > > > > This patches is created to fix the __pa() warning messages when > > > > CONFIG_DEBUG_VIRTUAL=y by unifying the allocation of pglist_data > > > > instances. > > > > > > > > In current implementation of node_data, if CONFIG_NEED_MULTIPLE_NODES=y, > > > > pglist_data is allocated by a memblock API. If CONFIG_NEED_MULTIPLE_NODES=n, > > > > we use a global variable named "contig_page_data". > > > > > > > > If CONFIG_DEBUG_VIRTUAL is not enabled. __pa() can handle both > > > > allocation and symbol cases. But if CONFIG_DEBUG_VIRTUAL is set, > > > > we will have the "virt_to_phys used for non-linear address" warning > > > > when booting. > > > > > > > > To fix the warning, always allocate pglist_data by memblock APIs and > > > > remove the usage of contig_page_data. > > > > > > Somehow I was sure that we can allocate pglist_data before it is accessed > > > in sparse_init() somewhere outside mm/sparse.c. It's really not the case > > > and having two places that may allocated this structure is surely worth > > > than your previous suggestion. > > > > > > Sorry about that. > > > > Do you mean taht to call allocation function arch/*, somewhere after > > paging_init() (so we can access pglist_data) and before sparse_init() > > and free_area_init()? > > No, I meant that your original patch is better than adding allocation of > NODE_DATA(0) in two places. Got it. will you re-review the original patch? > > > Miles > > > > > > > > > Warning message: > > > > [ 0.000000] ------------[ cut here ]------------ > > > > [ 0.000000] virt_to_phys used for non-linear address: (____ptrval____) (contig_page_data+0x0/0x1c00) > > > > [ 0.000000] WARNING: CPU: 0 PID: 0 at arch/arm64/mm/physaddr.c:15 __virt_to_phys+0x58/0x68 > > > > [ 0.000000] Modules linked in: > > > > [ 0.000000] CPU: 0 PID: 0 Comm: swapper Tainted: G W 5.13.0-rc1-00074-g1140ab592e2e #3 > > > > [ 0.000000] Hardware name: linux,dummy-virt (DT) > > > > [ 0.000000] pstate: 600000c5 (nZCv daIF -PAN -UAO -TCO BTYPE=--) > > > > [ 0.000000] pc : __virt_to_phys+0x58/0x68 > > > > [ 0.000000] lr : __virt_to_phys+0x54/0x68 > > > > [ 0.000000] sp : ffff800011833e70 > > > > [ 0.000000] x29: ffff800011833e70 x28: 00000000418a0018 x27: 0000000000000000 > > > > [ 0.000000] x26: 000000000000000a x25: ffff800011b70000 x24: ffff800011b70000 > > > > [ 0.000000] x23: fffffc0001c00000 x22: ffff800011b70000 x21: 0000000047ffffb0 > > > > [ 0.000000] x20: 0000000000000008 x19: ffff800011b082c0 x18: ffffffffffffffff > > > > [ 0.000000] x17: 0000000000000000 x16: ffff800011833bf9 x15: 0000000000000004 > > > > [ 0.000000] x14: 0000000000000fff x13: ffff80001186a548 x12: 0000000000000000 > > > > [ 0.000000] x11: 0000000000000000 x10: 00000000ffffffff x9 : 0000000000000000 > > > > [ 0.000000] x8 : ffff8000115c9000 x7 : 737520737968705f x6 : ffff800011b62ef8 > > > > [ 0.000000] x5 : 0000000000000000 x4 : 0000000000000001 x3 : 0000000000000000 > > > > [ 0.000000] x2 : 0000000000000000 x1 : ffff80001159585e x0 : 0000000000000058 > > > > [ 0.000000] Call trace: > > > > [ 0.000000] __virt_to_phys+0x58/0x68 > > > > [ 0.000000] check_usemap_section_nr+0x50/0xfc > > > > [ 0.000000] sparse_init_nid+0x1ac/0x28c > > > > [ 0.000000] sparse_init+0x1c4/0x1e0 > > > > [ 0.000000] bootmem_init+0x60/0x90 > > > > [ 0.000000] setup_arch+0x184/0x1f0 > > > > [ 0.000000] start_kernel+0x78/0x488 > > > > [ 0.000000] ---[ end trace f68728a0d3053b60 ]--- > > > > > > > > [1] https://urldefense.com/v3/__https://lore.kernel.org/patchwork/patch/1425110/__;!!CTRNKA9wMg0ARbw!x-wGFEC1wLzXho2kI1CrC2fjXNaQm5f-n0ADQyJDckCOKZHAP_q055DCSWYcQ7Zdcw$ > > > > > > > > Change since v1: > > > > - use memblock_alloc() to create pglist_data when CONFIG_NUMA=n > > > > > > > > Miles Chen (2): > > > > mm: introduce prepare_node_data > > > > mm: replace contig_page_data with node_data > > > > > > > > Documentation/admin-guide/kdump/vmcoreinfo.rst | 13 ------------- > > > > arch/powerpc/kexec/core.c | 5 ----- > > > > include/linux/gfp.h | 3 --- > > > > include/linux/mm.h | 2 ++ > > > > include/linux/mmzone.h | 4 ++-- > > > > kernel/crash_core.c | 1 - > > > > mm/memblock.c | 3 +-- > > > > mm/page_alloc.c | 16 ++++++++++++++++ > > > > mm/sparse.c | 2 ++ > > > > 9 files changed, 23 insertions(+), 26 deletions(-) > > > > > > > > > > > > base-commit: 8ac91e6c6033ebc12c5c1e4aa171b81a662bd70f > > > > -- > > > > 2.18.0 > > > > > > > > > > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBDE4C433B4 for ; Wed, 19 May 2021 03:56:21 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E4FB76112F for ; Wed, 19 May 2021 03:56:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E4FB76112F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4FlJvR3BCPz3bTN for ; Wed, 19 May 2021 13:56:19 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=mediatek.com header.i=@mediatek.com header.a=rsa-sha256 header.s=dk header.b=UhEODi1C; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=mediatek.com (client-ip=210.61.82.184; helo=mailgw02.mediatek.com; envelope-from=miles.chen@mediatek.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=mediatek.com header.i=@mediatek.com header.a=rsa-sha256 header.s=dk header.b=UhEODi1C; dkim-atps=neutral Received: from mailgw02.mediatek.com (mailgw02.mediatek.com [210.61.82.184]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4FlJts59Bbz2yWv for ; Wed, 19 May 2021 13:55:48 +1000 (AEST) X-UUID: 198d4eae015548bc964e0d68dc629dfb-20210519 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=S/KAedclNU8qmnqec3Ml95ZT6h/23axBf0ZQuILgxHU=; b=UhEODi1CAV1trzS9be4WcS2xYe0b4vG6NkkI3YPaMzfmWOvVK5Weyu7BDJRXczZWVbhyHlBQjawXf5NgRha8xvUrGwLJZQtQFZuWKww4S5TyP7l6nMIkoHJCLQmkkjWttLmEIApc++w5NfMnUEs0vViyT6rJDS4BDnBNGHrC8nE=; X-UUID: 198d4eae015548bc964e0d68dc629dfb-20210519 Received: from mtkcas10.mediatek.inc [(172.21.101.39)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 8210983; Wed, 19 May 2021 11:55:41 +0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 19 May 2021 11:55:40 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 19 May 2021 11:55:39 +0800 Message-ID: <1621396540.12301.7.camel@mtkswgap22> Subject: Re: [PATCH v2 0/2] mm: unify the allocation of pglist_data instances From: Miles Chen To: Mike Rapoport Date: Wed, 19 May 2021 11:55:40 +0800 In-Reply-To: References: <20210518092446.16382-1-miles.chen@mediatek.com> <1621383126.12301.4.camel@mtkswgap22> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N Content-Transfer-Encoding: base64 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Baoquan He , Jonathan Corbet , linux-doc@vger.kernel.org, kexec@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-mm@kvack.org, Paul Mackerras , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Andrew Morton , Dave Young , Vivek Goyal Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" T24gV2VkLCAyMDIxLTA1LTE5IGF0IDA2OjQ4ICswMzAwLCBNaWtlIFJhcG9wb3J0IHdyb3RlOg0K PiBPbiBXZWQsIE1heSAxOSwgMjAyMSBhdCAwODoxMjowNkFNICswODAwLCBNaWxlcyBDaGVuIHdy b3RlOg0KPiA+IE9uIFR1ZSwgMjAyMS0wNS0xOCBhdCAxOTowOSArMDMwMCwgTWlrZSBSYXBvcG9y dCB3cm90ZToNCj4gPiA+IEhlbGxvIE1pbGVzLA0KPiA+ID4gDQo+ID4gPiBPbiBUdWUsIE1heSAx OCwgMjAyMSBhdCAwNToyNDo0NFBNICswODAwLCBNaWxlcyBDaGVuIHdyb3RlOg0KPiA+ID4gPiBU aGlzIHBhdGNoZXMgaXMgY3JlYXRlZCB0byBmaXggdGhlIF9fcGEoKSB3YXJuaW5nIG1lc3NhZ2Vz IHdoZW4NCj4gPiA+ID4gQ09ORklHX0RFQlVHX1ZJUlRVQUw9eSBieSB1bmlmeWluZyB0aGUgYWxs b2NhdGlvbiBvZiBwZ2xpc3RfZGF0YQ0KPiA+ID4gPiBpbnN0YW5jZXMuDQo+ID4gPiA+IA0KPiA+ ID4gPiBJbiBjdXJyZW50IGltcGxlbWVudGF0aW9uIG9mIG5vZGVfZGF0YSwgaWYgQ09ORklHX05F RURfTVVMVElQTEVfTk9ERVM9eSwNCj4gPiA+ID4gcGdsaXN0X2RhdGEgaXMgYWxsb2NhdGVkIGJ5 IGEgbWVtYmxvY2sgQVBJLiBJZiBDT05GSUdfTkVFRF9NVUxUSVBMRV9OT0RFUz1uLA0KPiA+ID4g PiB3ZSB1c2UgYSBnbG9iYWwgdmFyaWFibGUgbmFtZWQgImNvbnRpZ19wYWdlX2RhdGEiLg0KPiA+ ID4gPiANCj4gPiA+ID4gSWYgQ09ORklHX0RFQlVHX1ZJUlRVQUwgaXMgbm90IGVuYWJsZWQuIF9f cGEoKSBjYW4gaGFuZGxlIGJvdGgNCj4gPiA+ID4gYWxsb2NhdGlvbiBhbmQgc3ltYm9sIGNhc2Vz LiBCdXQgaWYgQ09ORklHX0RFQlVHX1ZJUlRVQUwgaXMgc2V0LA0KPiA+ID4gPiB3ZSB3aWxsIGhh dmUgdGhlICJ2aXJ0X3RvX3BoeXMgdXNlZCBmb3Igbm9uLWxpbmVhciBhZGRyZXNzIiB3YXJuaW5n DQo+ID4gPiA+IHdoZW4gYm9vdGluZy4NCj4gPiA+ID4gDQo+ID4gPiA+IFRvIGZpeCB0aGUgd2Fy bmluZywgYWx3YXlzIGFsbG9jYXRlIHBnbGlzdF9kYXRhIGJ5IG1lbWJsb2NrIEFQSXMgYW5kDQo+ ID4gPiA+IHJlbW92ZSB0aGUgdXNhZ2Ugb2YgY29udGlnX3BhZ2VfZGF0YS4NCj4gPiA+IA0KPiA+ ID4gU29tZWhvdyBJIHdhcyBzdXJlIHRoYXQgd2UgY2FuIGFsbG9jYXRlIHBnbGlzdF9kYXRhIGJl Zm9yZSBpdCBpcyBhY2Nlc3NlZA0KPiA+ID4gaW4gc3BhcnNlX2luaXQoKSBzb21ld2hlcmUgb3V0 c2lkZSBtbS9zcGFyc2UuYy4gSXQncyByZWFsbHkgbm90IHRoZSBjYXNlDQo+ID4gPiBhbmQgaGF2 aW5nIHR3byBwbGFjZXMgdGhhdCBtYXkgYWxsb2NhdGVkIHRoaXMgc3RydWN0dXJlIGlzIHN1cmVs eSB3b3J0aA0KPiA+ID4gdGhhbiB5b3VyIHByZXZpb3VzIHN1Z2dlc3Rpb24uDQo+ID4gPiANCj4g PiA+IFNvcnJ5IGFib3V0IHRoYXQuDQo+ID4gDQo+ID4gRG8geW91IG1lYW4gdGFodCB0byBjYWxs IGFsbG9jYXRpb24gZnVuY3Rpb24gYXJjaC8qLCBzb21ld2hlcmUgYWZ0ZXINCj4gPiBwYWdpbmdf aW5pdCgpIChzbyB3ZSBjYW4gYWNjZXNzIHBnbGlzdF9kYXRhKSBhbmQgYmVmb3JlIHNwYXJzZV9p bml0KCkNCj4gPiBhbmQgZnJlZV9hcmVhX2luaXQoKT8NCj4gDQo+IE5vLCBJIG1lYW50IHRoYXQg eW91ciBvcmlnaW5hbCBwYXRjaCBpcyBiZXR0ZXIgdGhhbiBhZGRpbmcgYWxsb2NhdGlvbiBvZg0K PiBOT0RFX0RBVEEoMCkgaW4gdHdvIHBsYWNlcy4NCg0KR290IGl0LiB3aWxsIHlvdSByZS1yZXZp ZXcgdGhlIG9yaWdpbmFsIHBhdGNoPw0KDQoNCj4gIA0KPiA+IE1pbGVzDQo+ID4gDQo+ID4gPiAg DQo+ID4gPiA+IFdhcm5pbmcgbWVzc2FnZToNCj4gPiA+ID4gWyAgICAwLjAwMDAwMF0gLS0tLS0t LS0tLS0tWyBjdXQgaGVyZSBdLS0tLS0tLS0tLS0tDQo+ID4gPiA+IFsgICAgMC4wMDAwMDBdIHZp cnRfdG9fcGh5cyB1c2VkIGZvciBub24tbGluZWFyIGFkZHJlc3M6IChfX19fcHRydmFsX19fXykg KGNvbnRpZ19wYWdlX2RhdGErMHgwLzB4MWMwMCkNCj4gPiA+ID4gWyAgICAwLjAwMDAwMF0gV0FS TklORzogQ1BVOiAwIFBJRDogMCBhdCBhcmNoL2FybTY0L21tL3BoeXNhZGRyLmM6MTUgX192aXJ0 X3RvX3BoeXMrMHg1OC8weDY4DQo+ID4gPiA+IFsgICAgMC4wMDAwMDBdIE1vZHVsZXMgbGlua2Vk IGluOg0KPiA+ID4gPiBbICAgIDAuMDAwMDAwXSBDUFU6IDAgUElEOiAwIENvbW06IHN3YXBwZXIg VGFpbnRlZDogRyAgICAgICAgVyAgICAgICAgIDUuMTMuMC1yYzEtMDAwNzQtZzExNDBhYjU5MmUy ZSAjMw0KPiA+ID4gPiBbICAgIDAuMDAwMDAwXSBIYXJkd2FyZSBuYW1lOiBsaW51eCxkdW1teS12 aXJ0IChEVCkNCj4gPiA+ID4gWyAgICAwLjAwMDAwMF0gcHN0YXRlOiA2MDAwMDBjNSAoblpDdiBk YUlGIC1QQU4gLVVBTyAtVENPIEJUWVBFPS0tKQ0KPiA+ID4gPiBbICAgIDAuMDAwMDAwXSBwYyA6 IF9fdmlydF90b19waHlzKzB4NTgvMHg2OA0KPiA+ID4gPiBbICAgIDAuMDAwMDAwXSBsciA6IF9f dmlydF90b19waHlzKzB4NTQvMHg2OA0KPiA+ID4gPiBbICAgIDAuMDAwMDAwXSBzcCA6IGZmZmY4 MDAwMTE4MzNlNzANCj4gPiA+ID4gWyAgICAwLjAwMDAwMF0geDI5OiBmZmZmODAwMDExODMzZTcw IHgyODogMDAwMDAwMDA0MThhMDAxOCB4Mjc6IDAwMDAwMDAwMDAwMDAwMDANCj4gPiA+ID4gWyAg ICAwLjAwMDAwMF0geDI2OiAwMDAwMDAwMDAwMDAwMDBhIHgyNTogZmZmZjgwMDAxMWI3MDAwMCB4 MjQ6IGZmZmY4MDAwMTFiNzAwMDANCj4gPiA+ID4gWyAgICAwLjAwMDAwMF0geDIzOiBmZmZmZmMw MDAxYzAwMDAwIHgyMjogZmZmZjgwMDAxMWI3MDAwMCB4MjE6IDAwMDAwMDAwNDdmZmZmYjANCj4g PiA+ID4gWyAgICAwLjAwMDAwMF0geDIwOiAwMDAwMDAwMDAwMDAwMDA4IHgxOTogZmZmZjgwMDAx MWIwODJjMCB4MTg6IGZmZmZmZmZmZmZmZmZmZmYNCj4gPiA+ID4gWyAgICAwLjAwMDAwMF0geDE3 OiAwMDAwMDAwMDAwMDAwMDAwIHgxNjogZmZmZjgwMDAxMTgzM2JmOSB4MTU6IDAwMDAwMDAwMDAw MDAwMDQNCj4gPiA+ID4gWyAgICAwLjAwMDAwMF0geDE0OiAwMDAwMDAwMDAwMDAwZmZmIHgxMzog ZmZmZjgwMDAxMTg2YTU0OCB4MTI6IDAwMDAwMDAwMDAwMDAwMDANCj4gPiA+ID4gWyAgICAwLjAw MDAwMF0geDExOiAwMDAwMDAwMDAwMDAwMDAwIHgxMDogMDAwMDAwMDBmZmZmZmZmZiB4OSA6IDAw MDAwMDAwMDAwMDAwMDANCj4gPiA+ID4gWyAgICAwLjAwMDAwMF0geDggOiBmZmZmODAwMDExNWM5 MDAwIHg3IDogNzM3NTIwNzM3OTY4NzA1ZiB4NiA6IGZmZmY4MDAwMTFiNjJlZjgNCj4gPiA+ID4g WyAgICAwLjAwMDAwMF0geDUgOiAwMDAwMDAwMDAwMDAwMDAwIHg0IDogMDAwMDAwMDAwMDAwMDAw MSB4MyA6IDAwMDAwMDAwMDAwMDAwMDANCj4gPiA+ID4gWyAgICAwLjAwMDAwMF0geDIgOiAwMDAw MDAwMDAwMDAwMDAwIHgxIDogZmZmZjgwMDAxMTU5NTg1ZSB4MCA6IDAwMDAwMDAwMDAwMDAwNTgN Cj4gPiA+ID4gWyAgICAwLjAwMDAwMF0gQ2FsbCB0cmFjZToNCj4gPiA+ID4gWyAgICAwLjAwMDAw MF0gIF9fdmlydF90b19waHlzKzB4NTgvMHg2OA0KPiA+ID4gPiBbICAgIDAuMDAwMDAwXSAgY2hl Y2tfdXNlbWFwX3NlY3Rpb25fbnIrMHg1MC8weGZjDQo+ID4gPiA+IFsgICAgMC4wMDAwMDBdICBz cGFyc2VfaW5pdF9uaWQrMHgxYWMvMHgyOGMNCj4gPiA+ID4gWyAgICAwLjAwMDAwMF0gIHNwYXJz ZV9pbml0KzB4MWM0LzB4MWUwDQo+ID4gPiA+IFsgICAgMC4wMDAwMDBdICBib290bWVtX2luaXQr MHg2MC8weDkwDQo+ID4gPiA+IFsgICAgMC4wMDAwMDBdICBzZXR1cF9hcmNoKzB4MTg0LzB4MWYw DQo+ID4gPiA+IFsgICAgMC4wMDAwMDBdICBzdGFydF9rZXJuZWwrMHg3OC8weDQ4OA0KPiA+ID4g PiBbICAgIDAuMDAwMDAwXSAtLS1bIGVuZCB0cmFjZSBmNjg3MjhhMGQzMDUzYjYwIF0tLS0NCj4g PiA+ID4gDQo+ID4gPiA+IFsxXSBodHRwczovL3VybGRlZmVuc2UuY29tL3YzL19faHR0cHM6Ly9s b3JlLmtlcm5lbC5vcmcvcGF0Y2h3b3JrL3BhdGNoLzE0MjUxMTAvX187ISFDVFJOS0E5d01nMEFS YncheC13R0ZFQzF3THpYaG8ya0kxQ3JDMmZqWE5hUW01Zi1uMEFEUXlKRGNrQ09LWkhBUF9xMDU1 RENTV1ljUTdaZGN3JCANCj4gPiA+ID4gDQo+ID4gPiA+IENoYW5nZSBzaW5jZSB2MToNCj4gPiA+ ID4gLSB1c2UgbWVtYmxvY2tfYWxsb2MoKSB0byBjcmVhdGUgcGdsaXN0X2RhdGEgd2hlbiBDT05G SUdfTlVNQT1uDQo+ID4gPiA+IA0KPiA+ID4gPiBNaWxlcyBDaGVuICgyKToNCj4gPiA+ID4gICBt bTogaW50cm9kdWNlIHByZXBhcmVfbm9kZV9kYXRhDQo+ID4gPiA+ICAgbW06IHJlcGxhY2UgY29u dGlnX3BhZ2VfZGF0YSB3aXRoIG5vZGVfZGF0YQ0KPiA+ID4gPiANCj4gPiA+ID4gIERvY3VtZW50 YXRpb24vYWRtaW4tZ3VpZGUva2R1bXAvdm1jb3JlaW5mby5yc3QgfCAxMyAtLS0tLS0tLS0tLS0t DQo+ID4gPiA+ICBhcmNoL3Bvd2VycGMva2V4ZWMvY29yZS5jICAgICAgICAgICAgICAgICAgICAg IHwgIDUgLS0tLS0NCj4gPiA+ID4gIGluY2x1ZGUvbGludXgvZ2ZwLmggICAgICAgICAgICAgICAg ICAgICAgICAgICAgfCAgMyAtLS0NCj4gPiA+ID4gIGluY2x1ZGUvbGludXgvbW0uaCAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgfCAgMiArKw0KPiA+ID4gPiAgaW5jbHVkZS9saW51eC9tbXpv bmUuaCAgICAgICAgICAgICAgICAgICAgICAgICB8ICA0ICsrLS0NCj4gPiA+ID4gIGtlcm5lbC9j cmFzaF9jb3JlLmMgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgMSAtDQo+ID4gPiA+ICBt bS9tZW1ibG9jay5jICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgIDMgKy0tDQo+ ID4gPiA+ICBtbS9wYWdlX2FsbG9jLmMgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwg MTYgKysrKysrKysrKysrKysrKw0KPiA+ID4gPiAgbW0vc3BhcnNlLmMgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICB8ICAyICsrDQo+ID4gPiA+ICA5IGZpbGVzIGNoYW5nZWQsIDIz IGluc2VydGlvbnMoKyksIDI2IGRlbGV0aW9ucygtKQ0KPiA+ID4gPiANCj4gPiA+ID4gDQo+ID4g PiA+IGJhc2UtY29tbWl0OiA4YWM5MWU2YzYwMzNlYmMxMmM1YzFlNGFhMTcxYjgxYTY2MmJkNzBm DQo+ID4gPiA+IC0tIA0KPiA+ID4gPiAyLjE4LjANCj4gPiA+ID4gDQo+ID4gPiANCj4gPiANCj4g DQoNCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3209C433B4 for ; Wed, 19 May 2021 03:58:28 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 36DDD610A1 for ; Wed, 19 May 2021 03:58:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 36DDD610A1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:CC:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=IFUS2tH/gwMKHS6s17PWZ/kqjhmsRvQHB55BHY87muc=; b=KNdaJCl9U0tnHR1Op64AkTxYO YYagK4Xr50PcbeUmpLTHBEKRzncZK5kH/EaJWBni3bv0/zLNma62QfjkhZKu6StHMEjBCocMhWBVt I507RTvPQSsHQcflOgnP+M5CSb/nqS4Qy+8wcuVH7NevoDWyWVB1Pw3tEKOL17GrL4UMwZ/nk7ylj yeDKzbaWe9pbhSZ7IqNcRxU8PFmq6RD2TV/tQPk54gKXEbRc7ezjkN5wbRu7lXGyD2WCWTsmWnV1g 4jCkqYFsO5PsEuwPdM/Frzr/MAxOK/Nkr2RutEPftn8HLzcacOlGZ/nHWPU1imCVy0hKVOmBlxTCx +AE3+hJlQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1ljDJR-002exZ-2y; Wed, 19 May 2021 03:56:01 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ljDJG-002ev1-Qs; Wed, 19 May 2021 03:55:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject: Message-ID:Sender:Reply-To:Content-ID:Content-Description; bh=S/KAedclNU8qmnqec3Ml95ZT6h/23axBf0ZQuILgxHU=; b=35zKIaD1MCU7xbGvjr09k5KBVh loELaszjjG+qWB0yK21eKnVYqfDQwmcr3tmzrczNG7vxV5POmPEMZ4MkjlyUdxct0KY8tfKLuyp9t D5e6m5UrEiuM6PUD8IKF48m0GkbDfEhwVpRVPjbeq+bScTB9DkC++UxFJeJUgcCaY7SonLhIkftnq qMxcJHFXQxYTrKthsW7m8xYF29eh5j8OpCWvvw9An/wPBXGJ2A1mZDfK04+sqg/qFB/bJUXK924m3 S2gncv+uJqYIJq5bHVBaoNYGHxyrTe60NyZwzrOGB4edVQbTT+t1Ma76g+1+wgCneCKn7YxH6u5j+ scm7Euhg==; Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ljDJD-00F6cb-G1; Wed, 19 May 2021 03:55:49 +0000 X-UUID: 193191836dcd467098e55df2779b503a-20210518 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=S/KAedclNU8qmnqec3Ml95ZT6h/23axBf0ZQuILgxHU=; b=YToRZ8NaMqOYXDrnE8bDlqAAOkUKR45jAYu4PJTKKfssqrbclns3pyBkfYRZiMlmM04qcxmadyj941yPJzcJxnMc8iAm4k8cmsIbqEgwFneGXL91JIP3VMvGzTBtkZuC7tK2ZIk4IyLm/6D7s1sQitftcS5iMVM3AjyUVfLm+Dw=; X-UUID: 193191836dcd467098e55df2779b503a-20210518 Received: from mtkcas68.mediatek.inc [(172.29.94.19)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1756794877; Tue, 18 May 2021 20:55:44 -0700 Received: from MTKMBS07N2.mediatek.inc (172.21.101.141) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 18 May 2021 20:55:42 -0700 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 19 May 2021 11:55:40 +0800 Received: from [172.21.77.33] (172.21.77.33) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 19 May 2021 11:55:39 +0800 Message-ID: <1621396540.12301.7.camel@mtkswgap22> Subject: Re: [PATCH v2 0/2] mm: unify the allocation of pglist_data instances From: Miles Chen To: Mike Rapoport CC: Dave Young , Baoquan He , Vivek Goyal , Jonathan Corbet , Michael Ellerman , Benjamin Herrenschmidt , "Paul Mackerras" , Andrew Morton , , , , , , Date: Wed, 19 May 2021 11:55:40 +0800 In-Reply-To: References: <20210518092446.16382-1-miles.chen@mediatek.com> <1621383126.12301.4.camel@mtkswgap22> X-Mailer: Evolution 3.2.3-0ubuntu6 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210518_205547_560711_8D729FC2 X-CRM114-Status: GOOD ( 31.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 2021-05-19 at 06:48 +0300, Mike Rapoport wrote: > On Wed, May 19, 2021 at 08:12:06AM +0800, Miles Chen wrote: > > On Tue, 2021-05-18 at 19:09 +0300, Mike Rapoport wrote: > > > Hello Miles, > > > > > > On Tue, May 18, 2021 at 05:24:44PM +0800, Miles Chen wrote: > > > > This patches is created to fix the __pa() warning messages when > > > > CONFIG_DEBUG_VIRTUAL=y by unifying the allocation of pglist_data > > > > instances. > > > > > > > > In current implementation of node_data, if CONFIG_NEED_MULTIPLE_NODES=y, > > > > pglist_data is allocated by a memblock API. If CONFIG_NEED_MULTIPLE_NODES=n, > > > > we use a global variable named "contig_page_data". > > > > > > > > If CONFIG_DEBUG_VIRTUAL is not enabled. __pa() can handle both > > > > allocation and symbol cases. But if CONFIG_DEBUG_VIRTUAL is set, > > > > we will have the "virt_to_phys used for non-linear address" warning > > > > when booting. > > > > > > > > To fix the warning, always allocate pglist_data by memblock APIs and > > > > remove the usage of contig_page_data. > > > > > > Somehow I was sure that we can allocate pglist_data before it is accessed > > > in sparse_init() somewhere outside mm/sparse.c. It's really not the case > > > and having two places that may allocated this structure is surely worth > > > than your previous suggestion. > > > > > > Sorry about that. > > > > Do you mean taht to call allocation function arch/*, somewhere after > > paging_init() (so we can access pglist_data) and before sparse_init() > > and free_area_init()? > > No, I meant that your original patch is better than adding allocation of > NODE_DATA(0) in two places. Got it. will you re-review the original patch? > > > Miles > > > > > > > > > Warning message: > > > > [ 0.000000] ------------[ cut here ]------------ > > > > [ 0.000000] virt_to_phys used for non-linear address: (____ptrval____) (contig_page_data+0x0/0x1c00) > > > > [ 0.000000] WARNING: CPU: 0 PID: 0 at arch/arm64/mm/physaddr.c:15 __virt_to_phys+0x58/0x68 > > > > [ 0.000000] Modules linked in: > > > > [ 0.000000] CPU: 0 PID: 0 Comm: swapper Tainted: G W 5.13.0-rc1-00074-g1140ab592e2e #3 > > > > [ 0.000000] Hardware name: linux,dummy-virt (DT) > > > > [ 0.000000] pstate: 600000c5 (nZCv daIF -PAN -UAO -TCO BTYPE=--) > > > > [ 0.000000] pc : __virt_to_phys+0x58/0x68 > > > > [ 0.000000] lr : __virt_to_phys+0x54/0x68 > > > > [ 0.000000] sp : ffff800011833e70 > > > > [ 0.000000] x29: ffff800011833e70 x28: 00000000418a0018 x27: 0000000000000000 > > > > [ 0.000000] x26: 000000000000000a x25: ffff800011b70000 x24: ffff800011b70000 > > > > [ 0.000000] x23: fffffc0001c00000 x22: ffff800011b70000 x21: 0000000047ffffb0 > > > > [ 0.000000] x20: 0000000000000008 x19: ffff800011b082c0 x18: ffffffffffffffff > > > > [ 0.000000] x17: 0000000000000000 x16: ffff800011833bf9 x15: 0000000000000004 > > > > [ 0.000000] x14: 0000000000000fff x13: ffff80001186a548 x12: 0000000000000000 > > > > [ 0.000000] x11: 0000000000000000 x10: 00000000ffffffff x9 : 0000000000000000 > > > > [ 0.000000] x8 : ffff8000115c9000 x7 : 737520737968705f x6 : ffff800011b62ef8 > > > > [ 0.000000] x5 : 0000000000000000 x4 : 0000000000000001 x3 : 0000000000000000 > > > > [ 0.000000] x2 : 0000000000000000 x1 : ffff80001159585e x0 : 0000000000000058 > > > > [ 0.000000] Call trace: > > > > [ 0.000000] __virt_to_phys+0x58/0x68 > > > > [ 0.000000] check_usemap_section_nr+0x50/0xfc > > > > [ 0.000000] sparse_init_nid+0x1ac/0x28c > > > > [ 0.000000] sparse_init+0x1c4/0x1e0 > > > > [ 0.000000] bootmem_init+0x60/0x90 > > > > [ 0.000000] setup_arch+0x184/0x1f0 > > > > [ 0.000000] start_kernel+0x78/0x488 > > > > [ 0.000000] ---[ end trace f68728a0d3053b60 ]--- > > > > > > > > [1] https://urldefense.com/v3/__https://lore.kernel.org/patchwork/patch/1425110/__;!!CTRNKA9wMg0ARbw!x-wGFEC1wLzXho2kI1CrC2fjXNaQm5f-n0ADQyJDckCOKZHAP_q055DCSWYcQ7Zdcw$ > > > > > > > > Change since v1: > > > > - use memblock_alloc() to create pglist_data when CONFIG_NUMA=n > > > > > > > > Miles Chen (2): > > > > mm: introduce prepare_node_data > > > > mm: replace contig_page_data with node_data > > > > > > > > Documentation/admin-guide/kdump/vmcoreinfo.rst | 13 ------------- > > > > arch/powerpc/kexec/core.c | 5 ----- > > > > include/linux/gfp.h | 3 --- > > > > include/linux/mm.h | 2 ++ > > > > include/linux/mmzone.h | 4 ++-- > > > > kernel/crash_core.c | 1 - > > > > mm/memblock.c | 3 +-- > > > > mm/page_alloc.c | 16 ++++++++++++++++ > > > > mm/sparse.c | 2 ++ > > > > 9 files changed, 23 insertions(+), 26 deletions(-) > > > > > > > > > > > > base-commit: 8ac91e6c6033ebc12c5c1e4aa171b81a662bd70f > > > > -- > > > > 2.18.0 > > > > > > > > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel