Re: [PATCH] doc: fix support table for ETH and VLAN flow items

[Thomas Monjalon <thomas@monjalon.net>]

13/10/2022 13:01, Ilya Maximets:
> On 10/12/22 17:30, Thomas Monjalon wrote:
> > 07/10/2022 13:55, Ilya Maximets:
> >> On 10/7/22 13:50, Ilya Maximets wrote:
> >>> On 9/12/22 12:09, Thomas Monjalon wrote:
> >>>> 16/03/2022 13:01, Ilya Maximets:
> >>>>> 'has_vlan' attribute is only supported by sfc, mlx5 and cnxk.
> >>>>> Other drivers doesn't support it.  Most of them (like i40e) just
> >>>>> ignore it silently.  Some drivers (like mlx4) never had a full
> >>>>> support of the eth item even before introduction of 'has_vlan'
> >>>>> (mlx4 allows to match on the destination MAC only).
> >>>>>
> >>>>> Same for the 'has_more_vlan' flag of the vlan item.
> >>>>>
> >>>>> Changing the support level to 'partial' for all such drivers.
> >>>>> This doesn't solve the issue, but at least marks the problematic
> >>>>> drivers.
> >>>>
> >>>> You changed "eth" and "vlan" from "Y" to "P".
> >>>> The field "has_vlan" is part of "rte_flow_item_eth",
> >>>> and "has_more_vlan" is part of "rte_flow_item_vlan",
> >>>> so I agree we need to change both items to "partial support".
> >>>> It looks to be a good change, just needs to more explicit,
> >>>> adding this kind of explanation about the fields.
> >>>
> >>> I can add this to the commit message.  Should I also add
> >>> some note alongside the table in that documentation page?
> > 
> > I'm afraid it can be long and complex to add notes in the page
> > about what is missing to get complete support for each feature/PMD.
> > I think you can just re-spin with a clear explanation in the commit,
> > so PMD maintainers can refer to it.
> 
> OK.  v2 sent here:
>   https://patches.dpdk.org/project/dpdk/patch/20221013104849.2677995-1-i.maximets@ovn.org/

Thank you, I'm currently working on the rte_flow_items to use structs from librte_net.