From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A47FC4707F for ; Wed, 26 May 2021 01:45:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8AC8D61429 for ; Wed, 26 May 2021 01:45:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8AC8D61429 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9nVbtDUz1ASkv42tFnA+t6lQHJufmo9yUOlmwF0chPg=; b=SnA1l3vN8XriUe koKfucT2BTz1ZNOPtQCr3pnRRzjXgkjEf1UpbnDak6Peg56cT/RsLQRrwNuKH79J+KuTlpABW5Kah 9S9yecuWvYT6c4iorAvWGvotneIQwV8m8FNo5/FF422tyMNHHfJ+dhPbpdnaxdS+PWpGft2P6YROg vYtkj5lOKHyzJO0ROf7NT3GWDDWvVXHInb4kcIpZH0BbazYEqS+QWXyBTdiHJQ6Ya69OwdVbykudB Emv9MtTrCtesK8DtDxZ/HkqHAfU8ZRXqgZCO/1sYzUaiq9zvu67AibAk2IDNgp6LKhrmIKRI+0HAN Qosy+7Zu56ADI38ldZEQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1llibg-009sjq-9q; Wed, 26 May 2021 01:45:12 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1llibV-009sdw-TA; Wed, 26 May 2021 01:45:10 +0000 X-UUID: 8cb6f537cdd840a7a51f5f423da3fa9f-20210525 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=NmtG8PtbQGS64/5D4XTWx2C/g8jAAgXP164fQIUW45A=; b=Q9E5cXo9aXD6XSawc5MLK/h9cgswAyrIzSrBuUsr4SankYVwMq1p+7WuVU1GvZm00DyvwIEF1i6ugCuAzbftnG6yZKK4fpWiLM2e/i4V0Qw/OXTWriT9AGaSthd04nOCEAc7r/H731G93Uy5y/ObPWQKCrtAO4j4j8aE/BQBe5Q=; X-UUID: 8cb6f537cdd840a7a51f5f423da3fa9f-20210525 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 552885127; Tue, 25 May 2021 18:44:58 -0700 Received: from MTKMBS31N1.mediatek.inc (172.27.4.69) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 25 May 2021 18:44:56 -0700 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by MTKMBS31N1.mediatek.inc (172.27.4.69) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 26 May 2021 09:44:48 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 26 May 2021 09:44:48 +0800 Message-ID: <1621993487.26501.19.camel@mhfsdcap03> Subject: Re: [PATCH v2 3/3] Revert "usb: common: usb-conn-gpio: Make VBUS supply optional" From: Chunfeng Yun To: Thierry Reding CC: Greg Kroah-Hartman , Liam Girdwood , Mark Brown , Matthias Brugger , Paul Cercueil , Lee Jones , , , , Date: Wed, 26 May 2021 09:44:47 +0800 In-Reply-To: References: <1621406386-18838-1-git-send-email-chunfeng.yun@mediatek.com> <1621406386-18838-3-git-send-email-chunfeng.yun@mediatek.com> <1621835511.26501.14.camel@mhfsdcap03> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: DBEF9475E366CD9EE010AAD1B760E5197873115102002DEC0FB5709042E1CFEF2000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210525_184508_298564_9B0CD7DD X-CRM114-Status: GOOD ( 35.33 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Tue, 2021-05-25 at 13:36 +0200, Thierry Reding wrote: > On Mon, May 24, 2021 at 01:51:51PM +0800, Chunfeng Yun wrote: > > On Fri, 2021-05-21 at 15:20 +0200, Thierry Reding wrote: > > > On Wed, May 19, 2021 at 02:39:46PM +0800, Chunfeng Yun wrote: > > > > Vbus is already an optional supply, if the vbus-supply is not > > > > provided in DTS, will use a dummy regulator, > > > > > > That statement is not entirely correct. The dummy regulator is > > > substituted only if the supply is in fact not optional. The idea behind > > > that is to allow DTS files that don't specify all required regulators to > > > get away with it, based on the assumption that the supply is one of > > > those always-on supplies that are often not described in DTS. > > Yes, you are right. > > But from the point of result, it indeed can help to handle the absent > > regulator. > > > > > > > the warning log is as below: > > > > "supply vbus not found, using dummy regulator" > > > > > > And the reason why we get that warning is to point out that the DTS has > > > a bug and that it should be fixed (by adding a proper regulator to take > > > the place of the dummy). > > > > > > > This reverts commit 4ddf1ac79e5f082451cd549283d2eb7559ab6ca9. > > > > > > But if you read the description of that commit, the purpose of that > > > patch was in fact to make the supply completely optional in the case > > > where we already have the VBUS supply specified for the USB port that > > > the connector is parented to. > > Could you please give an example you mentioned? > > You can find examples of this in these: > > arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi > arch/arm64/boot/dts/nvidia/tegra210-p3450-0000.dts > arch/arm64/boot/dts/nvidia/tegra186-p2771-0000.dts > > > It seems prefer to provide vbus supply in connector instead of port > > according to dt-binding > > My recollection is that the above (or at least some of them) predate USB > connectors. > > It's possible that we could convert the above to have the VBUS supply > listed in the connector instead of the port. However, since we have to > preserve backwards compatibility with older device trees, we can't > revert the commit anyway. Got it, thanks a lot > > Thierry _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7438C4707F for ; Wed, 26 May 2021 01:45:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7BD196142B for ; Wed, 26 May 2021 01:45:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231993AbhEZBq3 (ORCPT ); Tue, 25 May 2021 21:46:29 -0400 Received: from Mailgw01.mediatek.com ([1.203.163.78]:20674 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S230306AbhEZBq3 (ORCPT ); Tue, 25 May 2021 21:46:29 -0400 X-UUID: 403647ee35cf48008ed38b7218b6d2af-20210526 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=NmtG8PtbQGS64/5D4XTWx2C/g8jAAgXP164fQIUW45A=; b=Q9E5cXo9aXD6XSawc5MLK/h9cgswAyrIzSrBuUsr4SankYVwMq1p+7WuVU1GvZm00DyvwIEF1i6ugCuAzbftnG6yZKK4fpWiLM2e/i4V0Qw/OXTWriT9AGaSthd04nOCEAc7r/H731G93Uy5y/ObPWQKCrtAO4j4j8aE/BQBe5Q=; X-UUID: 403647ee35cf48008ed38b7218b6d2af-20210526 Received: from mtkcas36.mediatek.inc [(172.27.4.253)] by mailgw01.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 775569361; Wed, 26 May 2021 09:44:56 +0800 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by MTKMBS31N1.mediatek.inc (172.27.4.69) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 26 May 2021 09:44:48 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 26 May 2021 09:44:48 +0800 Message-ID: <1621993487.26501.19.camel@mhfsdcap03> Subject: Re: [PATCH v2 3/3] Revert "usb: common: usb-conn-gpio: Make VBUS supply optional" From: Chunfeng Yun To: Thierry Reding CC: Greg Kroah-Hartman , Liam Girdwood , Mark Brown , Matthias Brugger , Paul Cercueil , Lee Jones , , , , Date: Wed, 26 May 2021 09:44:47 +0800 In-Reply-To: References: <1621406386-18838-1-git-send-email-chunfeng.yun@mediatek.com> <1621406386-18838-3-git-send-email-chunfeng.yun@mediatek.com> <1621835511.26501.14.camel@mhfsdcap03> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: DBEF9475E366CD9EE010AAD1B760E5197873115102002DEC0FB5709042E1CFEF2000:8 X-MTK: N Content-Transfer-Encoding: base64 Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org T24gVHVlLCAyMDIxLTA1LTI1IGF0IDEzOjM2ICswMjAwLCBUaGllcnJ5IFJlZGluZyB3cm90ZToN Cj4gT24gTW9uLCBNYXkgMjQsIDIwMjEgYXQgMDE6NTE6NTFQTSArMDgwMCwgQ2h1bmZlbmcgWXVu IHdyb3RlOg0KPiA+IE9uIEZyaSwgMjAyMS0wNS0yMSBhdCAxNToyMCArMDIwMCwgVGhpZXJyeSBS ZWRpbmcgd3JvdGU6DQo+ID4gPiBPbiBXZWQsIE1heSAxOSwgMjAyMSBhdCAwMjozOTo0NlBNICsw ODAwLCBDaHVuZmVuZyBZdW4gd3JvdGU6DQo+ID4gPiA+IFZidXMgaXMgYWxyZWFkeSBhbiBvcHRp b25hbCBzdXBwbHksIGlmIHRoZSB2YnVzLXN1cHBseSBpcyBub3QNCj4gPiA+ID4gcHJvdmlkZWQg aW4gRFRTLCB3aWxsIHVzZSBhIGR1bW15IHJlZ3VsYXRvciwNCj4gPiA+IA0KPiA+ID4gVGhhdCBz dGF0ZW1lbnQgaXMgbm90IGVudGlyZWx5IGNvcnJlY3QuIFRoZSBkdW1teSByZWd1bGF0b3IgaXMN Cj4gPiA+IHN1YnN0aXR1dGVkIG9ubHkgaWYgdGhlIHN1cHBseSBpcyBpbiBmYWN0IG5vdCBvcHRp b25hbC4gVGhlIGlkZWEgYmVoaW5kDQo+ID4gPiB0aGF0IGlzIHRvIGFsbG93IERUUyBmaWxlcyB0 aGF0IGRvbid0IHNwZWNpZnkgYWxsIHJlcXVpcmVkIHJlZ3VsYXRvcnMgdG8NCj4gPiA+IGdldCBh d2F5IHdpdGggaXQsIGJhc2VkIG9uIHRoZSBhc3N1bXB0aW9uIHRoYXQgdGhlIHN1cHBseSBpcyBv bmUgb2YNCj4gPiA+IHRob3NlIGFsd2F5cy1vbiBzdXBwbGllcyB0aGF0IGFyZSBvZnRlbiBub3Qg ZGVzY3JpYmVkIGluIERUUy4NCj4gPiBZZXMsIHlvdSBhcmUgcmlnaHQuDQo+ID4gQnV0IGZyb20g dGhlIHBvaW50IG9mIHJlc3VsdCwgaXQgaW5kZWVkIGNhbiBoZWxwIHRvIGhhbmRsZSB0aGUgYWJz ZW50DQo+ID4gcmVndWxhdG9yLg0KPiA+ID4gDQo+ID4gPiA+IHRoZSB3YXJuaW5nIGxvZyBpcyBh cyBiZWxvdzoNCj4gPiA+ID4gInN1cHBseSB2YnVzIG5vdCBmb3VuZCwgdXNpbmcgZHVtbXkgcmVn dWxhdG9yIg0KPiA+ID4gDQo+ID4gPiBBbmQgdGhlIHJlYXNvbiB3aHkgd2UgZ2V0IHRoYXQgd2Fy bmluZyBpcyB0byBwb2ludCBvdXQgdGhhdCB0aGUgRFRTIGhhcw0KPiA+ID4gYSBidWcgYW5kIHRo YXQgaXQgc2hvdWxkIGJlIGZpeGVkIChieSBhZGRpbmcgYSBwcm9wZXIgcmVndWxhdG9yIHRvIHRh a2UNCj4gPiA+IHRoZSBwbGFjZSBvZiB0aGUgZHVtbXkpLg0KPiA+ID4gDQo+ID4gPiA+IFRoaXMg cmV2ZXJ0cyBjb21taXQgNGRkZjFhYzc5ZTVmMDgyNDUxY2Q1NDkyODNkMmViNzU1OWFiNmNhOS4N Cj4gPiA+IA0KPiA+ID4gQnV0IGlmIHlvdSByZWFkIHRoZSBkZXNjcmlwdGlvbiBvZiB0aGF0IGNv bW1pdCwgdGhlIHB1cnBvc2Ugb2YgdGhhdA0KPiA+ID4gcGF0Y2ggd2FzIGluIGZhY3QgdG8gbWFr ZSB0aGUgc3VwcGx5IGNvbXBsZXRlbHkgb3B0aW9uYWwgaW4gdGhlIGNhc2UNCj4gPiA+IHdoZXJl IHdlIGFscmVhZHkgaGF2ZSB0aGUgVkJVUyBzdXBwbHkgc3BlY2lmaWVkIGZvciB0aGUgVVNCIHBv cnQgdGhhdA0KPiA+ID4gdGhlIGNvbm5lY3RvciBpcyBwYXJlbnRlZCB0by4NCj4gPiBDb3VsZCB5 b3UgcGxlYXNlIGdpdmUgYW4gZXhhbXBsZSB5b3UgbWVudGlvbmVkPw0KPiANCj4gWW91IGNhbiBm aW5kIGV4YW1wbGVzIG9mIHRoaXMgaW4gdGhlc2U6DQo+IA0KPiAJYXJjaC9hcm02NC9ib290L2R0 cy9udmlkaWEvdGVncmEyMTAtcDI1OTcuZHRzaQ0KPiAJYXJjaC9hcm02NC9ib290L2R0cy9udmlk aWEvdGVncmEyMTAtcDM0NTAtMDAwMC5kdHMNCj4gCWFyY2gvYXJtNjQvYm9vdC9kdHMvbnZpZGlh L3RlZ3JhMTg2LXAyNzcxLTAwMDAuZHRzDQo+IA0KPiA+IEl0IHNlZW1zIHByZWZlciB0byBwcm92 aWRlIHZidXMgc3VwcGx5IGluIGNvbm5lY3RvciBpbnN0ZWFkIG9mIHBvcnQNCj4gPiBhY2NvcmRp bmcgdG8gZHQtYmluZGluZw0KPiANCj4gTXkgcmVjb2xsZWN0aW9uIGlzIHRoYXQgdGhlIGFib3Zl IChvciBhdCBsZWFzdCBzb21lIG9mIHRoZW0pIHByZWRhdGUgVVNCDQo+IGNvbm5lY3RvcnMuDQo+ IA0KPiBJdCdzIHBvc3NpYmxlIHRoYXQgd2UgY291bGQgY29udmVydCB0aGUgYWJvdmUgdG8gaGF2 ZSB0aGUgVkJVUyBzdXBwbHkNCj4gbGlzdGVkIGluIHRoZSBjb25uZWN0b3IgaW5zdGVhZCBvZiB0 aGUgcG9ydC4gSG93ZXZlciwgc2luY2Ugd2UgaGF2ZSB0bw0KPiBwcmVzZXJ2ZSBiYWNrd2FyZHMg Y29tcGF0aWJpbGl0eSB3aXRoIG9sZGVyIGRldmljZSB0cmVlcywgd2UgY2FuJ3QNCj4gcmV2ZXJ0 IHRoZSBjb21taXQgYW55d2F5Lg0KR290IGl0LCB0aGFua3MgYSBsb3QNCg0KPiANCj4gVGhpZXJy eQ0KDQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84BB7C47088 for ; Wed, 26 May 2021 01:47:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 534F261090 for ; Wed, 26 May 2021 01:47:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 534F261090 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9FJoRs7oTXzEHN+I36pbLcBThMLpXD7uSe6YuCn4cxA=; b=ymqJoAke2xKs07 Rvd2vBHh0Q7Fj7G58+HnqaF1hkwews1DBuntHuewnB28czk0I9ePZNwmT68r0H8Wns2tSFExDTs+i 76pyWjSIj8Zprb3XrKBGJEGN+jvUzZ+MHgyZzBITjDpA4RgxBvGVGSHi1/ZfCzObdOmpCwnGD4Y4u GAWgIjep+8nKxBfadT8LlgQPl4HbSJol641Np5shLczozwXc99Ao5dBac2HNUd0AJdya3xv7i4RMz SDqioX3kBnQFjKyNPhMeBhT1wWjPP61kCqwOw7Tfx6OrV5VBx/AF11chwP3+tJw/lZpUHADEX4+eT 0aAJiNVtGri1reaO1Zmg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1llibi-009skS-Sa; Wed, 26 May 2021 01:45:15 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1llibV-009sdw-TA; Wed, 26 May 2021 01:45:10 +0000 X-UUID: 8cb6f537cdd840a7a51f5f423da3fa9f-20210525 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=NmtG8PtbQGS64/5D4XTWx2C/g8jAAgXP164fQIUW45A=; b=Q9E5cXo9aXD6XSawc5MLK/h9cgswAyrIzSrBuUsr4SankYVwMq1p+7WuVU1GvZm00DyvwIEF1i6ugCuAzbftnG6yZKK4fpWiLM2e/i4V0Qw/OXTWriT9AGaSthd04nOCEAc7r/H731G93Uy5y/ObPWQKCrtAO4j4j8aE/BQBe5Q=; X-UUID: 8cb6f537cdd840a7a51f5f423da3fa9f-20210525 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 552885127; Tue, 25 May 2021 18:44:58 -0700 Received: from MTKMBS31N1.mediatek.inc (172.27.4.69) by MTKMBS62DR.mediatek.inc (172.29.94.18) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 25 May 2021 18:44:56 -0700 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by MTKMBS31N1.mediatek.inc (172.27.4.69) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 26 May 2021 09:44:48 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 26 May 2021 09:44:48 +0800 Message-ID: <1621993487.26501.19.camel@mhfsdcap03> Subject: Re: [PATCH v2 3/3] Revert "usb: common: usb-conn-gpio: Make VBUS supply optional" From: Chunfeng Yun To: Thierry Reding CC: Greg Kroah-Hartman , Liam Girdwood , Mark Brown , Matthias Brugger , Paul Cercueil , Lee Jones , , , , Date: Wed, 26 May 2021 09:44:47 +0800 In-Reply-To: References: <1621406386-18838-1-git-send-email-chunfeng.yun@mediatek.com> <1621406386-18838-3-git-send-email-chunfeng.yun@mediatek.com> <1621835511.26501.14.camel@mhfsdcap03> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: DBEF9475E366CD9EE010AAD1B760E5197873115102002DEC0FB5709042E1CFEF2000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210525_184508_298564_9B0CD7DD X-CRM114-Status: GOOD ( 35.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 2021-05-25 at 13:36 +0200, Thierry Reding wrote: > On Mon, May 24, 2021 at 01:51:51PM +0800, Chunfeng Yun wrote: > > On Fri, 2021-05-21 at 15:20 +0200, Thierry Reding wrote: > > > On Wed, May 19, 2021 at 02:39:46PM +0800, Chunfeng Yun wrote: > > > > Vbus is already an optional supply, if the vbus-supply is not > > > > provided in DTS, will use a dummy regulator, > > > > > > That statement is not entirely correct. The dummy regulator is > > > substituted only if the supply is in fact not optional. The idea behind > > > that is to allow DTS files that don't specify all required regulators to > > > get away with it, based on the assumption that the supply is one of > > > those always-on supplies that are often not described in DTS. > > Yes, you are right. > > But from the point of result, it indeed can help to handle the absent > > regulator. > > > > > > > the warning log is as below: > > > > "supply vbus not found, using dummy regulator" > > > > > > And the reason why we get that warning is to point out that the DTS has > > > a bug and that it should be fixed (by adding a proper regulator to take > > > the place of the dummy). > > > > > > > This reverts commit 4ddf1ac79e5f082451cd549283d2eb7559ab6ca9. > > > > > > But if you read the description of that commit, the purpose of that > > > patch was in fact to make the supply completely optional in the case > > > where we already have the VBUS supply specified for the USB port that > > > the connector is parented to. > > Could you please give an example you mentioned? > > You can find examples of this in these: > > arch/arm64/boot/dts/nvidia/tegra210-p2597.dtsi > arch/arm64/boot/dts/nvidia/tegra210-p3450-0000.dts > arch/arm64/boot/dts/nvidia/tegra186-p2771-0000.dts > > > It seems prefer to provide vbus supply in connector instead of port > > according to dt-binding > > My recollection is that the above (or at least some of them) predate USB > connectors. > > It's possible that we could convert the above to have the VBUS supply > listed in the connector instead of the port. However, since we have to > preserve backwards compatibility with older device trees, we can't > revert the commit anyway. Got it, thanks a lot > > Thierry _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel