From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1EFCC4708F for ; Tue, 1 Jun 2021 05:50:19 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 83AD26139A for ; Tue, 1 Jun 2021 05:50:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 83AD26139A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FCrfmOmpiGQYl/WkiSjQau4uLV9KgC2ZfJ981YyXsDk=; b=0ezOv6KZrmxy4n +MIXmpaNvOh6LW+mS6jNtw1vgQj12bOrRQMN66Cfc2MNgU+3u81v6snSIyq3R1PZxdZvdckDmO1EU v16x6ZhFeZa3E/XmTISg9hh9DpwN/oGGn8Oj6455HOSoanUdszrww4bzeElR1v6mr9dAut+Wzq64O K5CU602DjR9FbbrFWbpMTdA8jFroGde6ucOO66gMWAK3z+B4H8AKusHqoeFmFBLMEYqZ+5aP6gX0q opBY6+7FtSebHg3E+EptJjWSXb1NInqQ2QJirH2wAzSNc9bX6zdLZbuHi+E0rQt0mYpngrNZQL2Ag ssp9qxvHGE18TjnyFCxA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lnxI1-00EopW-3o; Tue, 01 Jun 2021 05:50:09 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lnxHw-00Eonn-3R; Tue, 01 Jun 2021 05:50:07 +0000 X-UUID: 32bdeb09b72e4ebdbc58f4c533af3246-20210531 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=jiSLFkIn1fEytymJzHWtMUL+9HgJF2xAn74O+cTz5C4=; b=tRm3/ronP2BskDtwbWBhHsaA4mr/GVUFdWPUyT1rt1b8kLk8JDz5LMVtiPUBMqSYsz0QbG3AmxGR5EAS4jiJlJr03hcuqEDfpnP/7VZ0uK9bPJCz+WP1m+peYoP9BBG+nTsHGEuY4YXgEYnJOUwjDGX9/XLHUvCpCpLJWAlFZ/g=; X-UUID: 32bdeb09b72e4ebdbc58f4c533af3246-20210531 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1383701657; Mon, 31 May 2021 22:50:02 -0700 Received: from MTKMBS31N2.mediatek.inc (172.27.4.87) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 31 May 2021 22:50:00 -0700 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by MTKMBS31N2.mediatek.inc (172.27.4.87) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 1 Jun 2021 13:49:55 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 1 Jun 2021 13:49:54 +0800 Message-ID: <1622526594.9054.6.camel@mhfsdcap03> Subject: Re: [PATCH 1/2] dt-bindings: PCI: mediatek-gen3: Add support for MT8195 From: Jianjun Wang To: Chen-Yu Tsai CC: Ryder Lee , Bjorn Helgaas , Rob Herring , Lorenzo Pieralisi , Matthias Brugger , , , , , , Randy Wu , Date: Tue, 1 Jun 2021 13:49:54 +0800 In-Reply-To: References: <20210601024408.24485-1-jianjun.wang@mediatek.com> <20210601024408.24485-2-jianjun.wang@mediatek.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: B186BFA5F6860A0A9441A37F5F3612750236F03574A7631EB87997CBB9D33AC02000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210531_225004_199279_893775FF X-CRM114-Status: GOOD ( 26.07 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Tue, 2021-06-01 at 11:53 +0800, Chen-Yu Tsai wrote: > Hi, > > On Tue, Jun 1, 2021 at 10:50 AM Jianjun Wang wrote: > > > > MT8195 is an ARM platform SoC which has the same PCIe IP with MT8192. > > Based on what I'm seeing internally, there seems to be some inconsistency > across the MediaTek platform on whether new compatible strings should be > introduced for "fully compatible" IP blocks. > > If this hardware block in MT8195 is "the same" as the one in MT8192, do we > really need the new compatible string? Are there any concerns? Hi Chen-Yu, It's ok to reuse the compatible string with MT8192, but I think this will be easier to find which platforms this driver is compatible with, especially when we have more and more platforms in the future. Thanks. > > > Thanks > ChenYu > > > > Signed-off-by: Jianjun Wang > > --- > > Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml > > index e7b1f9892da4..d5e4a3e63d97 100644 > > --- a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml > > +++ b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml > > @@ -48,7 +48,9 @@ allOf: > > > > properties: > > compatible: > > - const: mediatek,mt8192-pcie > > + oneOf: > > + - const: mediatek,mt8192-pcie > > + - const: mediatek,mt8195-pcie > > > > reg: > > maxItems: 1 > > -- > > 2.18.0 > > _______________________________________________ > > Linux-mediatek mailing list > > Linux-mediatek@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-mediatek _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F90AC47080 for ; Tue, 1 Jun 2021 05:50:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 37F2461396 for ; Tue, 1 Jun 2021 05:50:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232869AbhFAFvo (ORCPT ); Tue, 1 Jun 2021 01:51:44 -0400 Received: from Mailgw01.mediatek.com ([1.203.163.78]:59266 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S229477AbhFAFvn (ORCPT ); Tue, 1 Jun 2021 01:51:43 -0400 X-UUID: 1cb6a43bf84b4a87878f30a5af8883f2-20210601 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=jiSLFkIn1fEytymJzHWtMUL+9HgJF2xAn74O+cTz5C4=; b=tRm3/ronP2BskDtwbWBhHsaA4mr/GVUFdWPUyT1rt1b8kLk8JDz5LMVtiPUBMqSYsz0QbG3AmxGR5EAS4jiJlJr03hcuqEDfpnP/7VZ0uK9bPJCz+WP1m+peYoP9BBG+nTsHGEuY4YXgEYnJOUwjDGX9/XLHUvCpCpLJWAlFZ/g=; X-UUID: 1cb6a43bf84b4a87878f30a5af8883f2-20210601 Received: from mtkcas36.mediatek.inc [(172.27.4.253)] by mailgw01.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 303169635; Tue, 01 Jun 2021 13:50:00 +0800 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by MTKMBS31N2.mediatek.inc (172.27.4.87) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 1 Jun 2021 13:49:55 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 1 Jun 2021 13:49:54 +0800 Message-ID: <1622526594.9054.6.camel@mhfsdcap03> Subject: Re: [PATCH 1/2] dt-bindings: PCI: mediatek-gen3: Add support for MT8195 From: Jianjun Wang To: Chen-Yu Tsai CC: Ryder Lee , Bjorn Helgaas , Rob Herring , Lorenzo Pieralisi , Matthias Brugger , , , , , , Randy Wu , Date: Tue, 1 Jun 2021 13:49:54 +0800 In-Reply-To: References: <20210601024408.24485-1-jianjun.wang@mediatek.com> <20210601024408.24485-2-jianjun.wang@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: B186BFA5F6860A0A9441A37F5F3612750236F03574A7631EB87997CBB9D33AC02000:8 X-MTK: N Content-Transfer-Encoding: base64 Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org T24gVHVlLCAyMDIxLTA2LTAxIGF0IDExOjUzICswODAwLCBDaGVuLVl1IFRzYWkgd3JvdGU6DQo+ IEhpLA0KPiANCj4gT24gVHVlLCBKdW4gMSwgMjAyMSBhdCAxMDo1MCBBTSBKaWFuanVuIFdhbmcg PGppYW5qdW4ud2FuZ0BtZWRpYXRlay5jb20+IHdyb3RlOg0KPiA+DQo+ID4gTVQ4MTk1IGlzIGFu IEFSTSBwbGF0Zm9ybSBTb0Mgd2hpY2ggaGFzIHRoZSBzYW1lIFBDSWUgSVAgd2l0aCBNVDgxOTIu DQo+IA0KPiBCYXNlZCBvbiB3aGF0IEknbSBzZWVpbmcgaW50ZXJuYWxseSwgdGhlcmUgc2VlbXMg dG8gYmUgc29tZSBpbmNvbnNpc3RlbmN5DQo+IGFjcm9zcyB0aGUgTWVkaWFUZWsgcGxhdGZvcm0g b24gd2hldGhlciBuZXcgY29tcGF0aWJsZSBzdHJpbmdzIHNob3VsZCBiZQ0KPiBpbnRyb2R1Y2Vk IGZvciAiZnVsbHkgY29tcGF0aWJsZSIgSVAgYmxvY2tzLg0KPiANCj4gSWYgdGhpcyBoYXJkd2Fy ZSBibG9jayBpbiBNVDgxOTUgaXMgInRoZSBzYW1lIiBhcyB0aGUgb25lIGluIE1UODE5MiwgZG8g d2UNCj4gcmVhbGx5IG5lZWQgdGhlIG5ldyBjb21wYXRpYmxlIHN0cmluZz8gQXJlIHRoZXJlIGFu eSBjb25jZXJucz8NCg0KSGkgQ2hlbi1ZdSwNCg0KSXQncyBvayB0byByZXVzZSB0aGUgY29tcGF0 aWJsZSBzdHJpbmcgd2l0aCBNVDgxOTIsIGJ1dCBJIHRoaW5rIHRoaXMNCndpbGwgYmUgZWFzaWVy IHRvIGZpbmQgd2hpY2ggcGxhdGZvcm1zIHRoaXMgZHJpdmVyIGlzIGNvbXBhdGlibGUgd2l0aCwN CmVzcGVjaWFsbHkgd2hlbiB3ZSBoYXZlIG1vcmUgYW5kIG1vcmUgcGxhdGZvcm1zIGluIHRoZSBm dXR1cmUuDQoNClRoYW5rcy4gDQo+IA0KPiANCj4gVGhhbmtzDQo+IENoZW5ZdQ0KPiANCj4gDQo+ ID4gU2lnbmVkLW9mZi1ieTogSmlhbmp1biBXYW5nIDxqaWFuanVuLndhbmdAbWVkaWF0ZWsuY29t Pg0KPiA+IC0tLQ0KPiA+ICBEb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvcGNpL21l ZGlhdGVrLXBjaWUtZ2VuMy55YW1sIHwgNCArKystDQo+ID4gIDEgZmlsZSBjaGFuZ2VkLCAzIGlu c2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkNCj4gPg0KPiA+IGRpZmYgLS1naXQgYS9Eb2N1bWVu dGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvcGNpL21lZGlhdGVrLXBjaWUtZ2VuMy55YW1sIGIv RG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3BjaS9tZWRpYXRlay1wY2llLWdlbjMu eWFtbA0KPiA+IGluZGV4IGU3YjFmOTg5MmRhNC4uZDVlNGEzZTYzZDk3IDEwMDY0NA0KPiA+IC0t LSBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9wY2kvbWVkaWF0ZWstcGNpZS1n ZW4zLnlhbWwNCj4gPiArKysgYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvcGNp L21lZGlhdGVrLXBjaWUtZ2VuMy55YW1sDQo+ID4gQEAgLTQ4LDcgKzQ4LDkgQEAgYWxsT2Y6DQo+ ID4NCj4gPiAgcHJvcGVydGllczoNCj4gPiAgICBjb21wYXRpYmxlOg0KPiA+IC0gICAgY29uc3Q6 IG1lZGlhdGVrLG10ODE5Mi1wY2llDQo+ID4gKyAgICBvbmVPZjoNCj4gPiArICAgICAgLSBjb25z dDogbWVkaWF0ZWssbXQ4MTkyLXBjaWUNCj4gPiArICAgICAgLSBjb25zdDogbWVkaWF0ZWssbXQ4 MTk1LXBjaWUNCj4gPg0KPiA+ICAgIHJlZzoNCj4gPiAgICAgIG1heEl0ZW1zOiAxDQo+ID4gLS0N Cj4gPiAyLjE4LjANCj4gPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXw0KPiA+IExpbnV4LW1lZGlhdGVrIG1haWxpbmcgbGlzdA0KPiA+IExpbnV4LW1lZGlh dGVrQGxpc3RzLmluZnJhZGVhZC5vcmcNCj4gPiBodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2xpbnV4LW1lZGlhdGVrDQoNCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0EA2CC4708F for ; Tue, 1 Jun 2021 05:51:58 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C267060C40 for ; Tue, 1 Jun 2021 05:51:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C267060C40 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iQbWcZ6UZncOCjw0Wul+T6zHgFElKvH+GXum4hzX2ug=; b=GsRa+8oHeKXLgw K6Fa3DsFpwlPywQc06PPFeF4HVipggz/7E/cpWYc+j+bLgpmBdJbsYZlgwu7TJ2m5pXJUMKDmT5gp PfMi+gPpEl5ilIob/h3+Lk57ZuzuDx/5u08HbovsXcNVeOSfE8Xn73Qj6rwf908aVO+3xbyH3iUS4 mjUuzRP44Qn6Y/YVB30JJwraCecUUaMR8sukzJ1bFGhx1DFfBjOC/5E0J06SL6GfupzUet9goP3Ha 3lLzQ1CexZemPVoCIaxE3furu1J0CjjNKRQN/jZ6tUIpdqPSnSVxZ2Lenagc51XsREuidIiKUpRFu 4dTIg6InnBS/RJ3FjjAA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lnxI5-00Eoq9-6Y; Tue, 01 Jun 2021 05:50:13 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lnxHw-00Eonn-3R; Tue, 01 Jun 2021 05:50:07 +0000 X-UUID: 32bdeb09b72e4ebdbc58f4c533af3246-20210531 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=jiSLFkIn1fEytymJzHWtMUL+9HgJF2xAn74O+cTz5C4=; b=tRm3/ronP2BskDtwbWBhHsaA4mr/GVUFdWPUyT1rt1b8kLk8JDz5LMVtiPUBMqSYsz0QbG3AmxGR5EAS4jiJlJr03hcuqEDfpnP/7VZ0uK9bPJCz+WP1m+peYoP9BBG+nTsHGEuY4YXgEYnJOUwjDGX9/XLHUvCpCpLJWAlFZ/g=; X-UUID: 32bdeb09b72e4ebdbc58f4c533af3246-20210531 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1383701657; Mon, 31 May 2021 22:50:02 -0700 Received: from MTKMBS31N2.mediatek.inc (172.27.4.87) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 31 May 2021 22:50:00 -0700 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by MTKMBS31N2.mediatek.inc (172.27.4.87) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 1 Jun 2021 13:49:55 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 1 Jun 2021 13:49:54 +0800 Message-ID: <1622526594.9054.6.camel@mhfsdcap03> Subject: Re: [PATCH 1/2] dt-bindings: PCI: mediatek-gen3: Add support for MT8195 From: Jianjun Wang To: Chen-Yu Tsai CC: Ryder Lee , Bjorn Helgaas , Rob Herring , Lorenzo Pieralisi , Matthias Brugger , , , , , , Randy Wu , Date: Tue, 1 Jun 2021 13:49:54 +0800 In-Reply-To: References: <20210601024408.24485-1-jianjun.wang@mediatek.com> <20210601024408.24485-2-jianjun.wang@mediatek.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: B186BFA5F6860A0A9441A37F5F3612750236F03574A7631EB87997CBB9D33AC02000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210531_225004_199279_893775FF X-CRM114-Status: GOOD ( 26.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 2021-06-01 at 11:53 +0800, Chen-Yu Tsai wrote: > Hi, > > On Tue, Jun 1, 2021 at 10:50 AM Jianjun Wang wrote: > > > > MT8195 is an ARM platform SoC which has the same PCIe IP with MT8192. > > Based on what I'm seeing internally, there seems to be some inconsistency > across the MediaTek platform on whether new compatible strings should be > introduced for "fully compatible" IP blocks. > > If this hardware block in MT8195 is "the same" as the one in MT8192, do we > really need the new compatible string? Are there any concerns? Hi Chen-Yu, It's ok to reuse the compatible string with MT8192, but I think this will be easier to find which platforms this driver is compatible with, especially when we have more and more platforms in the future. Thanks. > > > Thanks > ChenYu > > > > Signed-off-by: Jianjun Wang > > --- > > Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml > > index e7b1f9892da4..d5e4a3e63d97 100644 > > --- a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml > > +++ b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml > > @@ -48,7 +48,9 @@ allOf: > > > > properties: > > compatible: > > - const: mediatek,mt8192-pcie > > + oneOf: > > + - const: mediatek,mt8192-pcie > > + - const: mediatek,mt8195-pcie > > > > reg: > > maxItems: 1 > > -- > > 2.18.0 > > _______________________________________________ > > Linux-mediatek mailing list > > Linux-mediatek@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-mediatek _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel