From: Dietmar Hahn <dietmar.hahn@ts.fujitsu.com>
To: xen-devel@lists.xen.org
Cc: suravee.suthikulpanit@amd.com, Eddie Dong <eddie.dong@intel.com>,
Jun Nakajima <jun.nakajima@intel.com>,
Jan Beulich <JBeulich@suse.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Subject: Re: [PATCH 3/3 v2] vpmu intel: Dump vpmu infos in 'q' keyhandler
Date: Mon, 08 Apr 2013 08:17:07 +0200 [thread overview]
Message-ID: <1622721.VDfLxvJ8se@amur> (raw)
In-Reply-To: <515F0A2502000078000CAEC7@nat28.tlf.novell.com>
Am Freitag 05 April 2013, 16:30:13 schrieb Jan Beulich:
> >>> On 05.04.13 at 15:33, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> wrote:
> > On Thu, Apr 04, 2013 at 02:10:32PM +0200, Dietmar Hahn wrote:
> >> Am Donnerstag 28 März 2013, 14:01:10 schrieb Dietmar Hahn:
> >> > @@ -132,6 +132,16 @@ static const u32 core2_fix_counters_msr[
> >> > MSR_CORE_PERF_FIXED_CTR2
> >> > };
> >> >
> >> > +/*
> >> > + * MSR_CORE_PERF_FIXED_CTR_CTRL contains the configuration of all fixed
> >> > + * counters. 4 bits for every counter.
> >> > + */
> >> > +#define FIXED_CTR_CTRL_BITS 4
> >
> > That is a lot of 'CTR' in it. Can it be just one CTRL ?
> >
> > Say FIXED_CTRL_BITS? One of them is for 'Control', what is the other CTR
> > for?
>
> Actually, with CTR being "counter", I'd like the naming to stay that
> way: These are "fixed control bits" bit "control bits of a fixed
> counter".
Yes Jan, Fixed-Function Performance Counter Control Bits (from the MSR name).
Thanks.
Dietmar.
--
Company details: http://ts.fujitsu.com/imprint.html
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2013-04-08 6:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-28 13:01 [PATCH 3/3 v2] vpmu intel: Dump vpmu infos in 'q' keyhandler Dietmar Hahn
2013-04-04 12:10 ` Dietmar Hahn
2013-04-05 13:33 ` Konrad Rzeszutek Wilk
2013-04-05 15:30 ` Jan Beulich
2013-04-08 6:17 ` Dietmar Hahn [this message]
2013-04-08 9:39 ` Dietmar Hahn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1622721.VDfLxvJ8se@amur \
--to=dietmar.hahn@ts.fujitsu.com \
--cc=JBeulich@suse.com \
--cc=eddie.dong@intel.com \
--cc=jun.nakajima@intel.com \
--cc=konrad.wilk@oracle.com \
--cc=suravee.suthikulpanit@amd.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.