From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH 2/2] mk: fix two more missing libm dependencies Date: Tue, 22 Mar 2016 20:39:05 +0100 Message-ID: <1622870.FhASFun3h6@xps13> References: <233492f10ac71dd9f6902eaa4bca425febc5d2c0.1458560038.git.pmatilai@redhat.com> <27d49a881875edbfdacbf8f621d38c3927a95881.1458560038.git.pmatilai@redhat.com> <56EFDF88.2040309@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Ferruh Yigit To: Panu Matilainen Return-path: Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53]) by dpdk.org (Postfix) with ESMTP id 6D0FA2BD6 for ; Tue, 22 Mar 2016 20:40:46 +0100 (CET) Received: by mail-wm0-f53.google.com with SMTP id l68so206838997wml.0 for ; Tue, 22 Mar 2016 12:40:46 -0700 (PDT) In-Reply-To: <56EFDF88.2040309@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-03-21 11:48, Ferruh Yigit: > On 3/21/2016 11:33 AM, Panu Matilainen wrote: > > Commit e86a699cf6b1 missed two further libm dependencies: ceil() used by > > librte_meter is typically inlined so the missing dependency does not > > actually cause failures, and librte_pmd_nfp is not built by default > > so its easy to miss. > > > > This causes duplicates in LDLIBS in many configurations so its vital > > they are removed before passing to linker. > > > > Fixes: e86a699cf6b1 ("mk: fix shared library dependencies on libm and librt") > > > > Reported-by: Ferruh Yigit > > Signed-off-by: Panu Matilainen > > Tested-by: Ferruh Yigit Applied, thanks