All of lore.kernel.org
 help / color / mirror / Atom feed
From: patchwork-bot+netdevbpf@kernel.org
To: Tony Ambardar <tony.ambardar@gmail.com>
Cc: daniel@iogearbox.net, ast@kernel.org, andrii@kernel.org,
	Tony.Ambardar@gmail.com, bpf@vger.kernel.org,
	netdev@vger.kernel.org, linux-mips@vger.kernel.org,
	stable@vger.kernel.org, fche@redhat.com, mark@klomp.org,
	jolsa@kernel.org, yhs@fb.com, jolsa@redhat.com
Subject: Re: [PATCH bpf v2] bpf: fix libelf endian handling in resolv_btfids
Date: Fri, 18 Jun 2021 15:10:03 +0000	[thread overview]
Message-ID: <162402900350.14256.7811206211874890348.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20210618061404.818569-1-Tony.Ambardar@gmail.com>

Hello:

This patch was applied to bpf/bpf.git (refs/heads/master):

On Thu, 17 Jun 2021 23:14:04 -0700 you wrote:
> The vmlinux ".BTF_ids" ELF section is declared in btf_ids.h to hold a list
> of zero-filled BTF IDs, which is then patched at link-time with correct
> values by resolv_btfids. The section is flagged as "allocable" to preclude
> compression, but notably the section contents (BTF IDs) are untyped.
> 
> When patching the BTF IDs, resolve_btfids writes in host-native endianness
> and relies on libelf for any required translation on reading and updating
> vmlinux. However, since the type of the .BTF_ids section content defaults
> to ELF_T_BYTE (i.e. unsigned char), no translation occurs. This results in
> incorrect patched values when cross-compiling to non-native endianness,
> and can manifest as kernel Oops and test failures which are difficult to
> troubleshoot [1].
> 
> [...]

Here is the summary with links:
  - [bpf,v2] bpf: fix libelf endian handling in resolv_btfids
    https://git.kernel.org/bpf/bpf/c/61e8aeda9398

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



      reply	other threads:[~2021-06-18 15:10 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-16  9:25 [PATCH bpf v1] bpf: fix libelf endian handling in resolv_btfids Tony Ambardar
2021-06-16 15:56 ` Yonghong Song
2021-06-16 16:38   ` Jiri Olsa
2021-06-16 22:09     ` Tony Ambardar
2021-06-17  9:10       ` Jiri Olsa
2021-06-17 10:44         ` Mark Wielaard
2021-06-16 22:28     ` Mark Wielaard
2021-06-17  9:02       ` Jiri Olsa
2021-06-17 11:22         ` Daniel Borkmann
2021-06-18  0:20           ` Tony Ambardar
2021-06-18  6:14 ` [PATCH bpf v2] " Tony Ambardar
2021-06-18 15:10   ` patchwork-bot+netdevbpf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=162402900350.14256.7811206211874890348.git-patchwork-notify@kernel.org \
    --to=patchwork-bot+netdevbpf@kernel.org \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=fche@redhat.com \
    --cc=jolsa@kernel.org \
    --cc=jolsa@redhat.com \
    --cc=linux-mips@vger.kernel.org \
    --cc=mark@klomp.org \
    --cc=netdev@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=tony.ambardar@gmail.com \
    --cc=yhs@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.