diff for duplicates of <16246194.1257928342802.JavaMail.ngmail@webmail19.ha2.local> diff --git a/a/1.txt b/N1/1.txt index 000290c..dc1fd7f 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,48 +1,41 @@ Hi Grant: -O.k., thanks for your comments. If Wim doesn't have any objections to it, = -I will provide a merged patch. One consequence I forgot to mention is that= - we loose the ability to build the wdt support as module, but I don't think= - it's a real problem. +O.k., thanks for your comments. If Wim doesn't have any objections to it, I will provide a merged patch. One consequence I forgot to mention is that we loose the ability to build the wdt support as module, but I don't think it's a real problem. -I think we still should keep the kernel config option enable/disable the wd= -t support, which would mask out the wdt code if disabled. Is that ok for y= -ou? +I think we still should keep the kernel config option enable/disable the wdt support, which would mask out the wdt code if disabled. Is that ok for you? Thanks, Albrecht. ----- Original Nachricht ---- Von: Grant Likely <grant.likely@secretlab.ca> -An: Albrecht Dre=DF <albrecht.dress@arcor.de> +An: Albrecht Dreß <albrecht.dress@arcor.de> Datum: 10.11.2009 22:07 Betreff: Re: [PATCH 3/3] mpc52xx/wdt: WDT uses GPT api -> On Tue, Nov 10, 2009 at 1:26 PM, Albrecht Dre=DF <albrecht.dress@arcor.de= -> +> On Tue, Nov 10, 2009 at 1:26 PM, Albrecht Dreß <albrecht.dress@arcor.de> > wrote: > > Hi Grant: > > > > Am 10.11.09 20:59 schrieb(en) Grant Likely: > >> -> >> On Tue, Nov 10, 2009 at 12:43 PM, Albrecht Dre=DF +> >> On Tue, Nov 10, 2009 at 12:43 PM, Albrecht Dreß > <albrecht.dress@arcor.de> > >> wrote: -> >> > Use the MPC5200 GPT api for the WDT which drastically simplifies thi= -s +> >> > Use the MPC5200 GPT api for the WDT which drastically simplifies this > >> > file. > >> > -> >> > Signed-off-by: Albrecht Dre=DF <albrecht.dress@arcor.de> +> >> > Signed-off-by: Albrecht Dreß <albrecht.dress@arcor.de> > >> > --- > >> > -> >> > =A0drivers/watchdog/mpc5200_wdt.c | =A0246 +> >> > drivers/watchdog/mpc5200_wdt.c | 246 > >> > +++++++++++----------------------------- -> >> > =A01 files changed, 65 insertions(+), 181 deletions(-) +> >> > 1 files changed, 65 insertions(+), 181 deletions(-) > >> > >> > >> Can the WDT functionality just be merged entirely into > >> arch/powerpc/platforms/52xx/mpc52xx_gpt.c, eliminating the need for -> >> this file entirely? =A0I think I'd rather have all the GPT "built in" +> >> this file entirely? I think I'd rather have all the GPT "built in" > >> behaviour handled by a single driver. > > > > I also thought about it, as it has IMHO the cleaner code, and it would @@ -52,47 +45,44 @@ s > > However, the reasons I hesitated to do so are: > > - I don't want to remove a file someone else wrote (even it doesn't > work); ->=20 +> > Shouldn't be a problem, and I'll handle the fallout if it is. ->=20 +> > > - WDT code is shifted from drivers/watchdog to > arch/powerpc/platforms/52xx > > which might not be the "logical" place from the directory layout's pov; ->=20 +> > There is precedence of this in the past, particularly on arch or > platform specific hardware drivers and multifunction devices. (Heck, > that's almost entirely what arch/powerpc/sysdev is). I'm not > concerned. ->=20 +> > > - a file living in arch/powerpc/platforms/52xx depends upon config > options > > set from drivers/watchdog/Kconfig which may be confusing. ->=20 +> > I'm not concerned about this either. ->=20 -> > You see these are more political/cosmetical questions, so I would prefe= -r +> +> > You see these are more political/cosmetical questions, so I would prefer > to -> > leave the decision to the maintainers (i.e. you and Wim). =A0Preparing = -a +> > leave the decision to the maintainers (i.e. you and Wim). Preparing a > fully > > merged driver is actually a matter of minutes! ->=20 +> > Do it. I'll champion getting it in. Wim, do you have any issues with > this? ->=20 +> > g. ->=20 -> --=20 +> +> -- > Grant Likely, B.Sc., P.Eng. > Secret Lab Technologies Ltd. > _______________________________________________ > Linuxppc-dev mailing list > Linuxppc-dev@lists.ozlabs.org > https://lists.ozlabs.org/listinfo/linuxppc-dev ->=20 +> Jetzt NEU: Do it youself E-Cards bei Arcor.de! -Stellen Sie Ihr eigenes Unikat zusammen und machen Sie dem Empf=E4nger eine= - ganz pers=F6nliche Freude! +Stellen Sie Ihr eigenes Unikat zusammen und machen Sie dem Empfänger eine ganz persönliche Freude! E-Card Marke Eigenbau: HIER KLICKEN: http://www.arcor.de/rd/footer.ecard diff --git a/a/content_digest b/N1/content_digest index 56ebde2..5f45503 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -12,49 +12,42 @@ "b\0" "Hi Grant:\n" "\n" - "O.k., thanks for your comments. If Wim doesn't have any objections to it, =\n" - "I will provide a merged patch. One consequence I forgot to mention is that=\n" - " we loose the ability to build the wdt support as module, but I don't think=\n" - " it's a real problem.\n" + "O.k., thanks for your comments. If Wim doesn't have any objections to it, I will provide a merged patch. One consequence I forgot to mention is that we loose the ability to build the wdt support as module, but I don't think it's a real problem.\n" "\n" - "I think we still should keep the kernel config option enable/disable the wd=\n" - "t support, which would mask out the wdt code if disabled. Is that ok for y=\n" - "ou?\n" + "I think we still should keep the kernel config option enable/disable the wdt support, which would mask out the wdt code if disabled. Is that ok for you?\n" "\n" "Thanks, Albrecht.\n" "\n" "\n" "----- Original Nachricht ----\n" "Von: Grant Likely <grant.likely@secretlab.ca>\n" - "An: Albrecht Dre=DF <albrecht.dress@arcor.de>\n" + "An: Albrecht Dre\303\237 <albrecht.dress@arcor.de>\n" "Datum: 10.11.2009 22:07\n" "Betreff: Re: [PATCH 3/3] mpc52xx/wdt: WDT uses GPT api\n" "\n" - "> On Tue, Nov 10, 2009 at 1:26 PM, Albrecht Dre=DF <albrecht.dress@arcor.de=\n" - ">\n" + "> On Tue, Nov 10, 2009 at 1:26 PM, Albrecht Dre\303\237 <albrecht.dress@arcor.de>\n" "> wrote:\n" "> > Hi Grant:\n" "> >\n" "> > Am 10.11.09 20:59 schrieb(en) Grant Likely:\n" "> >>\n" - "> >> On Tue, Nov 10, 2009 at 12:43 PM, Albrecht Dre=DF\n" + "> >> On Tue, Nov 10, 2009 at 12:43 PM, Albrecht Dre\303\237\n" "> <albrecht.dress@arcor.de>\n" "> >> wrote:\n" - "> >> > Use the MPC5200 GPT api for the WDT which drastically simplifies thi=\n" - "s\n" + "> >> > Use the MPC5200 GPT api for the WDT which drastically simplifies this\n" "> >> > file.\n" "> >> >\n" - "> >> > Signed-off-by: Albrecht Dre=DF <albrecht.dress@arcor.de>\n" + "> >> > Signed-off-by: Albrecht Dre\303\237 <albrecht.dress@arcor.de>\n" "> >> > ---\n" "> >> >\n" - "> >> > =A0drivers/watchdog/mpc5200_wdt.c | =A0246\n" + "> >> > \302\240drivers/watchdog/mpc5200_wdt.c | \302\240246\n" "> >> > +++++++++++-----------------------------\n" - "> >> > =A01 files changed, 65 insertions(+), 181 deletions(-)\n" + "> >> > \302\2401 files changed, 65 insertions(+), 181 deletions(-)\n" "> >>\n" "> >>\n" "> >> Can the WDT functionality just be merged entirely into\n" "> >> arch/powerpc/platforms/52xx/mpc52xx_gpt.c, eliminating the need for\n" - "> >> this file entirely? =A0I think I'd rather have all the GPT \"built in\"\n" + "> >> this file entirely? \302\240I think I'd rather have all the GPT \"built in\"\n" "> >> behaviour handled by a single driver.\n" "> >\n" "> > I also thought about it, as it has IMHO the cleaner code, and it would\n" @@ -64,49 +57,46 @@ "> > However, the reasons I hesitated to do so are:\n" "> > - I don't want to remove a file someone else wrote (even it doesn't\n" "> work);\n" - ">=20\n" + "> \n" "> Shouldn't be a problem, and I'll handle the fallout if it is.\n" - ">=20\n" + "> \n" "> > - WDT code is shifted from drivers/watchdog to\n" "> arch/powerpc/platforms/52xx\n" "> > which might not be the \"logical\" place from the directory layout's pov;\n" - ">=20\n" + "> \n" "> There is precedence of this in the past, particularly on arch or\n" "> platform specific hardware drivers and multifunction devices. (Heck,\n" "> that's almost entirely what arch/powerpc/sysdev is). I'm not\n" "> concerned.\n" - ">=20\n" + "> \n" "> > - a file living in arch/powerpc/platforms/52xx depends upon config\n" "> options\n" "> > set from drivers/watchdog/Kconfig which may be confusing.\n" - ">=20\n" + "> \n" "> I'm not concerned about this either.\n" - ">=20\n" - "> > You see these are more political/cosmetical questions, so I would prefe=\n" - "r\n" + "> \n" + "> > You see these are more political/cosmetical questions, so I would prefer\n" "> to\n" - "> > leave the decision to the maintainers (i.e. you and Wim). =A0Preparing =\n" - "a\n" + "> > leave the decision to the maintainers (i.e. you and Wim). \302\240Preparing a\n" "> fully\n" "> > merged driver is actually a matter of minutes!\n" - ">=20\n" + "> \n" "> Do it. I'll champion getting it in. Wim, do you have any issues with\n" "> this?\n" - ">=20\n" + "> \n" "> g.\n" - ">=20\n" - "> --=20\n" + "> \n" + "> -- \n" "> Grant Likely, B.Sc., P.Eng.\n" "> Secret Lab Technologies Ltd.\n" "> _______________________________________________\n" "> Linuxppc-dev mailing list\n" "> Linuxppc-dev@lists.ozlabs.org\n" "> https://lists.ozlabs.org/listinfo/linuxppc-dev\n" - ">=20\n" + "> \n" "\n" "Jetzt NEU: Do it youself E-Cards bei Arcor.de!\n" - "Stellen Sie Ihr eigenes Unikat zusammen und machen Sie dem Empf=E4nger eine=\n" - " ganz pers=F6nliche Freude!\n" + "Stellen Sie Ihr eigenes Unikat zusammen und machen Sie dem Empf\303\244nger eine ganz pers\303\266nliche Freude!\n" E-Card Marke Eigenbau: HIER KLICKEN: http://www.arcor.de/rd/footer.ecard -9e4786a6c12bdc062f71eac9d393ff320aadd793cfdf08274d8f162d94af3706 +43bebbcda1f8be27b8a7147f3377b923d8fc4a50ca7ee34fa942a14d6fd3ba80
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.