Re: [PATCH 1/5] iommu: Enhance domain allocation code to take additional flags

[Baolu Lu <baolu.lu@linux.intel.com>]

On 8/22/24 8:40 PM, Jason Gunthorpe wrote:
> On Thu, Aug 22, 2024 at 09:38:31AM +0800, Baolu Lu wrote:
> 
>>> -EXPORT_SYMBOL_GPL(iommu_paging_domain_alloc);
>>> +EXPORT_SYMBOL_GPL(iommu_paging_domain_alloc_flags);
>> Some external modules are still using iommu_paging_domain_alloc(). Would
>> it break the kernel build if you simply remove it here?
> modules have to be recompiled if the kernel is changed, they will pick
> up the inline in the header and shift to this API. But generally we
> don't worry about external/out of tree modules..

I see. I overlooked below inline helper.

+static inline struct iommu_domain *iommu_paging_domain_alloc(struct 
device *dev)
+{
+	return iommu_paging_domain_alloc_flags(dev, 0);
+}

Thanks,
baolu