From: Hemant Kumar <hemantk@codeaurora.org>
To: Paul Davey <paul.davey@alliedtelesis.co.nz>,
Manivannan Sadhasivam <mani@kernel.org>
Cc: Bhaumik Bhatt <bbhatt@codeaurora.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] bus: mhi: Fix pm_state conversion to string
Date: Wed, 30 Jun 2021 18:50:31 -0700 [thread overview]
Message-ID: <1625104231.10055.19.camel@codeaurora.org> (raw)
In-Reply-To: <20210629035357.11091-2-paul.davey@alliedtelesis.co.nz>
On Tue, 2021-06-29 at 15:53 +1200, Paul Davey wrote:
> On big endian architectures the mhi debugfs files which report pm
> state
> give "Invalid State" for all states. This is caused by using
> find_last_bit which takes an unsigned long* while the state is passed
> in
> as an enum mhi_pm_state which will be of int size.
>
> Fix by using __fls to pass the value of state instead of
> find_last_bit.
>
> Signed-off-by: Paul Davey <paul.davey@alliedtelesis.co.nz>
Reviewed-by: Hemant Kumar <hemantk@codeaurora.org>
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2021-07-01 1:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-29 3:53 [PATCH v3 0/2] bus: mhi: Fix MHI on big endian architectures Paul Davey
2021-06-29 3:53 ` [PATCH v3 1/2] bus: mhi: Fix pm_state conversion to string Paul Davey
2021-07-01 1:50 ` Hemant Kumar [this message]
2021-07-16 5:35 ` Manivannan Sadhasivam
2021-06-29 3:53 ` [PATCH v3 2/2] bus: mhi: Fix MHI DMA structure endianness Paul Davey
2021-07-01 1:52 ` Hemant Kumar
2021-07-16 0:35 ` Bhaumik Bhatt
2021-07-16 5:43 ` [PATCH v3 0/2] bus: mhi: Fix MHI on big endian architectures Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1625104231.10055.19.camel@codeaurora.org \
--to=hemantk@codeaurora.org \
--cc=bbhatt@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mani@kernel.org \
--cc=paul.davey@alliedtelesis.co.nz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.