From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=185.11.138.130 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793969442; b=ka3R3c9OeI6EbTSVetNT2tUUma7MTqUS4OhKhwWzRIJPuwWLs0sphYq+2Lp71Y4TYGcy aTYoG3wcRWjcBWGfzp2vo8m7tBPxbPj8SpJFpiFMT+ZGj5ViDglybXt8IJ4e9ILJxDioJ UivAbLZm3b2LkfqPi//tVM7j25hjw49LePfc45sTR2Hgaei2yVNqasGcRgql2KjgRFHsS PUT9kJ0ZleBjCaYyu5Ap9h3biAaEBk2M7d0fqCqhkVbQt5AZk8FUni1blq+vlH7c3Ddt+ SIi0mxJqjvWExUApXB4Y/BrhzcUEtiwrWrb9z5bN8raQ1o8MdgRv46TsfV7sNo2jWHg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793969442; h=DMARC-Filter:DKIM-Signature:From:To:Cc:Subject:Date:Message-ID: In-Reply-To:References:MIME-Version:Content-Transfer-Encoding: Content-Type; bh=FBjIBgDWbZCo9SaA6U+cSq8TU+erFs29CF/2hr/QbOQ=; b=rs33cMiQ4p/3lauanmdpOydODjrRuRgHmZwDoeDe4hTrEJYR1GtilB8b70yZ9gtMzjkS h+fw02flY3XVQIjg4ifO6RpydDT8AjNnXp1Z6fXaTojDpcaSEAHrDBnP0Xmu6pMM/x79u oeP5nUXw13XL9f3PcKyzy/jv9h7UbQAa0Jb292aEHttURjm/MxX3Khd6QIe7Tlq6ynpLW coPWkuafxbomvE+eTA4ogrvCGsaDSk+6D9tF6N5I+vF+tOpEpcmVfdgj0yQJKjB27oP9s 45YD63jPs3ncn6UybHHfgUm2LkGGAxp59AHJK8BvFqCsvqT7l6GHAgWUkKuKKnrMBjg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=sntech.de; spf=pass smtp.mailfrom=sntech.de; dkim=pass header.d=sntech.de header.i=@sntech.de header.a=rsa-sha256 header.s=gloria202408 header.b=WHEv8Bmz; arc=none smtp.remote-ip=185.11.138.130 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 078A1606A330; Fri, 6 Nov 2026 12:50:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 078A1606A330 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=sntech.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sntech.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=sntech.de header.i=@sntech.de header.a=rsa-sha256 header.s=gloria202408 header.b=WHEv8Bmz DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Type:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Reply-To; bh=FBjIBgDWbZCo9SaA6U+cSq8TU+erFs29CF/2hr/QbOQ=; b=WHEv8BmzZlBskbtiRsC4Yz/6tF lVJsH/z7pFdPbcrteUfO96lrIzu6yFa42ask2ACLtB8O6uGMAjJ5FkSqxMKs8yMyT7o7Hs0ZuH/2N 4GkPXRnZ7UYI7WmuDLcVG55y5hJJHUVGaRsnVFAvyX9zV/fjb9Uw1RfdJCS97gPuNrho07j/aW+1F pOJern4i9oeuE7j8otJl9949EwHRfUv+7LRx9Kd4TbmcROCdlLLufc3Qteg0RmyjsU3rG6JeoPs2K k++dAKZdxZIbbcOTn+0G93w14T0clcHEu2gUYgi3SOM1wcSDowGQdPNb/nXXKvmf4sWXrtqwqUcHH TaIrvW+A==; From: Heiko =?UTF-8?B?U3TDvGJuZXI=?= To: Marc Kleine-Budde , Vincent Mailhol , "David S. Miller" , Wolfgang Grandegger , Oliver Hartkopp , kernel@pengutronix.de, Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Jonathan Corbet , Shuah Khan , Randy Dunlap , 1579567540@qq.com Cc: Cunhao Lu <1579567540@qq.com>, linux-can@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, netdev@vger.kernel.org, linux-doc@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH net v7 0/7] can: fix bus-off restart and device close races Date: Fri, 06 Nov 2026 13:50:20 +0100 Message-ID: <16255046.uLZWGnKmhe@diego> In-Reply-To: <20261106-rockchip-canfd-restart-close-v7-0-accdb11bc845@qq.com> References: <20261106-rockchip-canfd-restart-close-v7-0-accdb11bc845@qq.com> X-Mailing-List: linux-can@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Hi, Am Freitag, 6. November 2026, 10:37:19 Mitteleurop=C3=A4ische Normalzeit sc= hrieb Cunhao Lu via B4 Relay: > This work started from a real failure on a production robot using a > LubanCat-5IO with an RK3588. RX continued, but the TX queue remained > stopped and subsequent sends returned ENOBUFS. The interface still > reported ERROR-ACTIVE, and the hardware indicated neither a bus-off > condition nor a pending TX request. [...] > This series depends on the three patches in "can: skb: make CAN skb > freeing safe in any IRQ context" [1] and the three patches in "can: > rockchip_canfd: fix TX stalls and races" [2]. >=20 > [1] https://lore.kernel.org/linux-can/tencent_CD05F020BAFB2537F5D1F4CBB42= 5588EA80A@qq.com/ > [2] https://lore.kernel.org/linux-can/tencent_E25C9BE6689264E4138A464803B= 810FDFD09@qq.com/ Both these series are from july and seemingly from before you started using the b4-relay. So they may or may not have survived the kernel releases and their threading is broken both on lore and in any maibox they arrived in. And if there haven't been any responses to them since then, I'd think they have been lost or so. So I'd suggest rolling both your dependencies forward on top of the can tree and sending them as a new version, so that reviewers can find them? Heiko From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B0822606A334 for ; Fri, 6 Nov 2026 12:50:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=C7a9O4Kn; dkim=fail reason="signature verification failed" (2048-bit key, unprotected) header.d=sntech.de header.i=@sntech.de header.a=rsa-sha256 header.s=gloria202408 header.b=WHEv8Bmz DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=FN2voaeahbG1GlApp/6a3LFxpm/gbDsdimzhe/qBVjs=; b=C7a9O4Kna72m/8bqgYFrOlSgwc PCPKsRgoRmb+5tj05GOqzjWUrUF768ZV7LLhJglObcaKEYmQEygOqaTfZ+e7RmYrZwW75KSe6BWT5 rMJ5HsTIuf1W/IXb6g6nRbTpxUjoK2PqZq9Qv1gHpKbMWunIb/BoHd3CBO+egRGexoqcyIRjabp6l LPjnQYpB/e3JdW2f7S7OsjPt8Dfa48TAnDfteF4d/TnEVsQfDdJ8ttw4f9q4vvhLFV4GGG6RM/izM MIx+fRQf6tNT0Uh4FZTiX515xOfaGCFFx995tuq7Yy6uoCtK5nnXiEyjVz31hjIBynvpzUfykksuK z6GSHwUg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xPJP1-0000000CLv7-2SFc; Fri, 06 Nov 2026 12:50:43 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xPJOx-0000000CLuH-3kBj; Fri, 06 Nov 2026 12:50:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sntech.de; s=gloria202408; h=Content-Type:Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Reply-To; bh=FBjIBgDWbZCo9SaA6U+cSq8TU+erFs29CF/2hr/QbOQ=; b=WHEv8BmzZlBskbtiRsC4Yz/6tF lVJsH/z7pFdPbcrteUfO96lrIzu6yFa42ask2ACLtB8O6uGMAjJ5FkSqxMKs8yMyT7o7Hs0ZuH/2N 4GkPXRnZ7UYI7WmuDLcVG55y5hJJHUVGaRsnVFAvyX9zV/fjb9Uw1RfdJCS97gPuNrho07j/aW+1F pOJern4i9oeuE7j8otJl9949EwHRfUv+7LRx9Kd4TbmcROCdlLLufc3Qteg0RmyjsU3rG6JeoPs2K k++dAKZdxZIbbcOTn+0G93w14T0clcHEu2gUYgi3SOM1wcSDowGQdPNb/nXXKvmf4sWXrtqwqUcHH TaIrvW+A==; From: Heiko =?UTF-8?B?U3TDvGJuZXI=?= To: Marc Kleine-Budde , Vincent Mailhol , "David S. Miller" , Wolfgang Grandegger , Oliver Hartkopp , kernel@pengutronix.de, Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Jonathan Corbet , Shuah Khan , Randy Dunlap , 1579567540@qq.com Cc: Cunhao Lu <1579567540@qq.com>, linux-can@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, netdev@vger.kernel.org, linux-doc@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH net v7 0/7] can: fix bus-off restart and device close races Date: Fri, 06 Nov 2026 13:50:20 +0100 Message-ID: <16255046.uLZWGnKmhe@diego> In-Reply-To: <20261106-rockchip-canfd-restart-close-v7-0-accdb11bc845@qq.com> References: <20261106-rockchip-canfd-restart-close-v7-0-accdb11bc845@qq.com> X-Archived-By: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261106_045040_173631_18B4C159 X-CRM114-Status: GOOD ( 13.87 ) X-Spam-Score: -2.1 (--) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 SGksCgpBbSBGcmVpdGFnLCA2LiBOb3ZlbWJlciAyMDI2LCAxMDozNzoxOSBNaXR0ZWxldXJvcMOk aXNjaGUgTm9ybWFsemVpdCBzY2hyaWViIEN1bmhhbyBMdSB2aWEgQjQgUmVsYXk6Cj4gVGhpcyB3 b3JrIHN0YXJ0ZWQgZnJvbSBhIHJlYWwgZmFpbHVyZSBvbiBhIHByb2R1Y3Rpb24gcm9ib3QgdXNp bmcgYQo+IEx1YmFuQ2F0LTVJTyB3aXRoIGFuIFJLMzU4OC4gUlggY29udGludWVkLCBidXQgdGhl IFRYIHF1ZXVlIHJlbWFpbmVkCj4gc3RvcHBlZCBhbmQgc3Vic2VxdWVudCBzZW5kcyByZXR1cm5l ZCBFTk9CVUZTLiBUaGUgaW50ZXJmYWNlIHN0aWxsCj4gcmVwb3J0ZWQgRVJST1ItQUNUSVZFLCBh bmQgdGhlIGhhcmR3YXJlIGluZGljYXRlZCBuZWl0aGVyIGEgYnVzLW9mZgo+IGNvbmRpdGlvbiBu b3IgYSBwZW5kaW5nIFRYIHJlcXVlc3QuCgpbLi4uXQoKPiBUaGlzIHNlcmllcyBkZXBlbmRzIG9u IHRoZSB0aHJlZSBwYXRjaGVzIGluICJjYW46IHNrYjogbWFrZSBDQU4gc2tiCj4gZnJlZWluZyBz YWZlIGluIGFueSBJUlEgY29udGV4dCIgWzFdIGFuZCB0aGUgdGhyZWUgcGF0Y2hlcyBpbiAiY2Fu Ogo+IHJvY2tjaGlwX2NhbmZkOiBmaXggVFggc3RhbGxzIGFuZCByYWNlcyIgWzJdLgo+IAo+IFsx XSBodHRwczovL2xvcmUua2VybmVsLm9yZy9saW51eC1jYW4vdGVuY2VudF9DRDA1RjAyMEJBRkIy NTM3RjVEMUY0Q0JCNDI1NTg4RUE4MEFAcXEuY29tLwo+IFsyXSBodHRwczovL2xvcmUua2VybmVs Lm9yZy9saW51eC1jYW4vdGVuY2VudF9FMjVDOUJFNjY4OTI2NEU0MTM4QTQ2NDgwM0I4MTBGREZE MDlAcXEuY29tLwoKQm90aCB0aGVzZSBzZXJpZXMgYXJlIGZyb20ganVseSBhbmQgc2VlbWluZ2x5 IGZyb20gYmVmb3JlIHlvdSBzdGFydGVkCnVzaW5nIHRoZSBiNC1yZWxheS4gU28gdGhleSBtYXkg b3IgbWF5IG5vdCBoYXZlIHN1cnZpdmVkIHRoZSBrZXJuZWwKcmVsZWFzZXMgYW5kIHRoZWlyIHRo cmVhZGluZyBpcyBicm9rZW4gYm90aCBvbiBsb3JlIGFuZCBpbiBhbnkgbWFpYm94CnRoZXkgYXJy aXZlZCBpbi4KCkFuZCBpZiB0aGVyZSBoYXZlbid0IGJlZW4gYW55IHJlc3BvbnNlcyB0byB0aGVt IHNpbmNlIHRoZW4sIEknZCB0aGluawp0aGV5IGhhdmUgYmVlbiBsb3N0IG9yIHNvLgoKU28gSSdk IHN1Z2dlc3Qgcm9sbGluZyBib3RoIHlvdXIgZGVwZW5kZW5jaWVzIGZvcndhcmQgb24gdG9wIG9m IHRoZSBjYW4KdHJlZSBhbmQgc2VuZGluZyB0aGVtIGFzIGEgbmV3IHZlcnNpb24sIHNvIHRoYXQg cmV2aWV3ZXJzIGNhbiBmaW5kIHRoZW0/CgoKSGVpa28KCgoKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KTGludXgtcm9ja2NoaXAgbWFpbGluZyBsaXN0Ckxp bnV4LXJvY2tjaGlwQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5v cmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1yb2NrY2hpcAo=