All of lore.kernel.org
 help / color / mirror / Atom feed
From: Francis Laniel <flaniel@linux.microsoft.com>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: Samuel Martin <s.martin49@gmail.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2 2/2] linux: add BR2_LINUX_KERNEL_NEEDS_HOST_PAHOLE
Date: Mon, 17 Jan 2022 14:51:28 +0100	[thread overview]
Message-ID: <16263830.Pqoitud5sI@machine> (raw)
In-Reply-To: <20220113224126.6b0801dd@windsurf>

Hi.


Le jeudi 13 janvier 2022, 22:41:26 CET Thomas Petazzoni a écrit :
> Hello,
> 
> On Wed, 22 Dec 2021 18:49:05 +0100
> 
> Francis Laniel <flaniel@linux.microsoft.com> wrote:
> > CONFIG_DEBUG_BTF_INFO relies on pahole, so kernel DWARF are converted to
> > BTF. If CONFIG_DEBUG_BTF_INFO is set and
> > BR2_LINUX_KERNEL_NEEDS_HOST_PAHOLE not, an error message is shown and
> > .config is not written.
> > 
> > Signed-off-by: Francis Laniel <flaniel@linux.microsoft.com>
> 
> Thanks, applied, with one change.
> 
> > diff --git a/package/pahole/Config.in.host b/package/pahole/Config.in.host
> > index e427629632..521874961b 100644
> > --- a/package/pahole/Config.in.host
> > +++ b/package/pahole/Config.in.host
> > @@ -3,4 +3,6 @@ config BR2_PACKAGE_HOST_PAHOLE
> > 
> >  	help
> >  	
> >  	  Pahole and other DWARF utils.
> > 
> > +	  Select this if you want to build a kernel with CONFIG_DEBUG_INFO_BTF
> > set. +
> 
> I've dropped this, because it's not really this option that should be
> enabled if the kernel is configured with CONFIG_DEBUG_INFO_BTF, but the
> BR2_LINUX_KERNEL_NEEDS_HOST_PAHOLE option.

Your modification made the thing clearer, thank you for it!

> Thanks for your contribution!

You are welcome! I thank you for the merge!

> Best regards,

Best regards.
 
> Thomas




_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2022-01-17 13:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-22 17:49 [Buildroot] [PATCH v2 0/2] Enable BTF headers for Linux kernel Francis Laniel
2021-12-22 17:49 ` [Buildroot] [PATCH v2 1/2] package/pahole: new host package Francis Laniel
2022-01-13 21:40   ` Thomas Petazzoni
2021-12-22 17:49 ` [Buildroot] [PATCH v2 2/2] linux: add BR2_LINUX_KERNEL_NEEDS_HOST_PAHOLE Francis Laniel
2022-01-13 21:41   ` Thomas Petazzoni
2022-01-17 13:51     ` Francis Laniel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16263830.Pqoitud5sI@machine \
    --to=flaniel@linux.microsoft.com \
    --cc=buildroot@buildroot.org \
    --cc=s.martin49@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.