From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96424C4338F for ; Sat, 24 Jul 2021 08:19:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 63C9B60EAF for ; Sat, 24 Jul 2021 08:19:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 63C9B60EAF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HiOzIFe3NcpnS9oF1NtHtpEqPhCxyq8iSVKwm03kZP0=; b=fcfwu7midZMPC+ GGBMxqjAOLwtAuRetfwUHaY3Jy7BnZr3hya3GZSW4o3+FJ/uX6a8LcYAGcYGLD3DuwE5NCJiSFMsA 7FsClK4ilMA0iOkf+WDm1+LB2UDLcsQiNwMagM6hsKwHcqjFmmMvvyJVTPam0X9VVjVQW3Uj4Tvy0 tMEmvCgmhQt4oJatpmTMwbgj2xAGSQI+LI8mhGitWrtYu9Y5vDJFdjrGxEdYRMSZY6GFVrfYoU5MP odKXdS5IVfEnPRMQtHiJ00ImIWBJzme6T/7wH53icJYoRQI666f1/sOIV2RClb2FZo15ou7N9exqS 5glc7w4Q1IyXaBOTq9Vg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m7Cs7-006t4L-LL; Sat, 24 Jul 2021 08:18:59 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m7Crn-006t2z-4l; Sat, 24 Jul 2021 08:18:47 +0000 X-UUID: 4a45dc13b8f444349e9277c58558b6d0-20210724 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=J0yN25JZHNEfnssofagyOsjY9Ns6Uelzjl6td4UChnU=; b=KZ6ABnsiEVtn8Gof7oQ7gD3entmXPcKzTl3xeNhajHVt25hLyFq4NUIzJkv+kF0JPIgL345/8ixLF2IVHr8fW6j5/HFnz8b4TChBO1UmGk8flUA+W1OqN86AdtFIoNh2ixF4dO1hl5qqu4z0TpikKfIYXSpmC74xDR3tqRlHd4c=; X-UUID: 4a45dc13b8f444349e9277c58558b6d0-20210724 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 145167813; Sat, 24 Jul 2021 01:18:35 -0700 Received: from MTKMBS07N2.mediatek.inc (172.21.101.141) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sat, 24 Jul 2021 01:18:27 -0700 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sat, 24 Jul 2021 16:18:25 +0800 Received: from [10.17.3.153] (10.17.3.153) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Sat, 24 Jul 2021 16:18:24 +0800 Message-ID: <1627114703.32022.13.camel@mhfsdcap03> Subject: Re: [PATCH v2, 03/14] media: mtk-vcodec: Use component framework to manage each hardware information From: mtk12024 To: Dafna Hirschfeld CC: Alexandre Courbot , Hans Verkuil , Tzung-Bi Shih , "Tiffany Lin" , Andrew-CT Chen , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Tomasz Figa , Hsin-Yi Wang , "Fritz Koenig" , Irui Wang , , , , , , , , Collabora Kernel ML , Enric Balletbo i Serra Date: Sat, 24 Jul 2021 16:18:23 +0800 In-Reply-To: <281efe4d-aa38-53f7-7b90-8458b0d366f0@collabora.com> References: <20210717081233.7809-1-yunfei.dong@mediatek.com> <20210717081233.7809-4-yunfei.dong@mediatek.com> <281efe4d-aa38-53f7-7b90-8458b0d366f0@collabora.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210724_011842_794274_6408C9DF X-CRM114-Status: GOOD ( 38.49 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi Dafna, Thanks for your detail advices. On Mon, 2021-07-19 at 11:00 +0200, Dafna Hirschfeld wrote: > > On 17.07.21 10:12, Yunfei Dong wrote: > > Uses component framework to manage each hardware information which > > includes irq/power/clk. The hardware includes LAT0, LAT1 and CORE. > > > > Signed-off-by: Yunfei Dong > > --- > > v2: fix coding style and remove useless header files > > --- > > drivers/media/platform/mtk-vcodec/Makefile | 1 + > > .../platform/mtk-vcodec/mtk_vcodec_dec.h | 1 + > > .../platform/mtk-vcodec/mtk_vcodec_dec_drv.c | 220 +++++++++++++++--- > > .../platform/mtk-vcodec/mtk_vcodec_dec_hw.c | 193 +++++++++++++++ > > .../platform/mtk-vcodec/mtk_vcodec_dec_hw.h | 46 ++++ > > .../platform/mtk-vcodec/mtk_vcodec_drv.h | 26 +++ > > 6 files changed, 452 insertions(+), 35 deletions(-) > > create mode 100644 drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_hw.c > > create mode 100644 drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_hw.h > > > > diff --git a/drivers/media/platform/mtk-vcodec/Makefile b/drivers/media/platform/mtk-vcodec/Makefile > > index ca8e9e7a9c4e..edeb3b66e9e9 100644 > > --- a/drivers/media/platform/mtk-vcodec/Makefile > > +++ b/drivers/media/platform/mtk-vcodec/Makefile > > @@ -15,6 +15,7 @@ mtk-vcodec-dec-y := vdec/vdec_h264_if.o \ > > mtk_vcodec_dec_stateful.o \ > > mtk_vcodec_dec_stateless.o \ > > mtk_vcodec_dec_pm.o \ > > + mtk_vcodec_dec_hw.o \ > > > > mtk-vcodec-enc-y := venc/venc_vp8_if.o \ > > venc/venc_h264_if.o \ > > diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.h b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.h > > index 9fbd24186c1a..c509224cbff4 100644 > > --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.h > > +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.h > > @@ -66,6 +66,7 @@ extern const struct v4l2_ioctl_ops mtk_vdec_ioctl_ops; > > extern const struct v4l2_m2m_ops mtk_vdec_m2m_ops; > > extern const struct media_device_ops mtk_vcodec_media_ops; > > > > +extern struct platform_driver mtk_vdec_comp_driver; > > > > /* > > * mtk_vdec_lock/mtk_vdec_unlock are for ctx instance to > > diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c > > index 8d7ba881ef75..e7f60e948fe8 100644 > > --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c > > +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c > > @@ -5,6 +5,7 @@ > > * Tiffany Lin > > */ > > > > +#include > > #include > > #include > > #include > > @@ -23,14 +24,50 @@ > > #include "mtk_vcodec_util.h" > > #include "mtk_vcodec_fw.h" > > > > -#define VDEC_HW_ACTIVE 0x10 > > -#define VDEC_IRQ_CFG 0x11 > > -#define VDEC_IRQ_CLR 0x10 > > -#define VDEC_IRQ_CFG_REG 0xa4 > > - > > module_param(mtk_v4l2_dbg_level, int, 0644); > > module_param(mtk_vcodec_dbg, bool, 0644); > > > > +static struct of_device_id mtk_vdec_drv_ids[] = { > > + { > > + .compatible = "mediatek,mtk-vcodec-lat", > > + .data = (void *)MTK_VDEC_LAT0, > > + }, > > + { > > + .compatible = "mediatek,mtk-vcodec-core", > > + .data = (void *)MTK_VDEC_CORE, > > + }, > > + {}, > > +}; > > + > > +static inline int mtk_vdec_compare_of(struct device *dev, void *data) > > +{ > > + return dev->of_node == data; > > +} > > + > > +static inline void mtk_vdec_release_of(struct device *dev, void *data) > > +{ > > + of_node_put(data); > > +} > > + > > +static inline int mtk_vdec_bind(struct device *dev) > > +{ > > + struct mtk_vcodec_dev *data = dev_get_drvdata(dev); > > + > > + return component_bind_all(dev, data); > > +} > > + > > +static inline void mtk_vdec_unbind(struct device *dev) > > +{ > > + struct mtk_vcodec_dev *data = dev_get_drvdata(dev); > > + > > + component_unbind_all(dev, data); > > +} > > + > > +static const struct component_master_ops mtk_vdec_ops = { > > + .bind = mtk_vdec_bind, > > + .unbind = mtk_vdec_unbind, > > +}; > > + > > /* Wake up context wait_queue */ > > static void wake_up_ctx(struct mtk_vcodec_ctx *ctx) > > { > > @@ -38,6 +75,48 @@ static void wake_up_ctx(struct mtk_vcodec_ctx *ctx) > > wake_up_interruptible(&ctx->queue); > > } > > > > +static struct component_match *mtk_vcodec_match_add( > > + struct mtk_vcodec_dev *vdec_dev) > > +{ > > + struct platform_device *pdev = vdec_dev->plat_dev; > > + struct component_match *match = NULL; > > + int i; > > + > > + for (i = 0; i < ARRAY_SIZE(mtk_vdec_drv_ids); i++) { > > + struct device_node *comp_node; > > + enum mtk_vdec_hw_id comp_idx; > > + const struct of_device_id *of_id; > > + > > + comp_node = of_find_compatible_node(NULL, NULL, > > + mtk_vdec_drv_ids[i].compatible); > > + if (!comp_node) > > + continue; > > + > > + if (!of_device_is_available(comp_node)) { > > + of_node_put(comp_node); > > + dev_err(&pdev->dev, "Fail to get MMSYS node\n"); > > + continue; > > + } > > + > > + of_node_put(comp_node); > > I think this line should come after the last usage of comp_node > > > + of_id = of_match_node(mtk_vdec_drv_ids, comp_node); > > I think this might be redundent since of_match_node will return &mtk_vdec_drv_ids[i] > So I think you can just do: > of_id = &mtk_vdec_drv_ids[i] > You are right, fix. > > + if (!of_id) { > > + dev_err(&pdev->dev, "Failed to get match node\n"); > > + return ERR_PTR(-EINVAL); > > + > + > > + comp_idx = (enum mtk_vdec_hw_id)of_id->data; > > + mtk_v4l2_debug(4, "Get component:hw_id(%d),vdec_dev(0x%p),comp_node(0x%p)\n", > > + comp_idx, vdec_dev, comp_node); > > + vdec_dev->component_node[comp_idx] = comp_node; > > + > > + component_match_add_release(&pdev->dev, &match, mtk_vdec_release_of, > > + mtk_vdec_compare_of, comp_node); > > + } > > + > > + return match; > > +} > > + > > static irqreturn_t mtk_vcodec_dec_irq_handler(int irq, void *priv) > > { > > struct mtk_vcodec_dev *dev = priv; > > @@ -103,6 +182,66 @@ static int mtk_vcodec_get_reg_bases(struct mtk_vcodec_dev *dev) > > return ret; > > } > > > > +static int mtk_vcodec_init_master(struct mtk_vcodec_dev *dev) > > +{ > > + struct platform_device *pdev = dev->plat_dev; > > + struct component_match *match; > > + int ret; > > + > > + match = mtk_vcodec_match_add(dev); > > + if (IS_ERR_OR_NULL(match)) > > + return -EINVAL; > > + > > + platform_set_drvdata(pdev, dev); > > + ret = component_master_add_with_match(&pdev->dev, &mtk_vdec_ops, match); > > + if (ret < 0) > > + return ret; > > + > > + return 0; > > +} > > + > > +static int mtk_vcodec_init_dec_params(struct mtk_vcodec_dev *dev) > > +{ > > + struct platform_device *pdev = dev->plat_dev; > > + struct resource *res; > > + int ret; > > + > > + if (!dev->is_support_comp) { > > + res = platform_get_resource(pdev, IORESOURCE_IRQ, 0); > > is the call to platform_get_resource needed? res is not used > No need to use. > > + if (!res) { > > + dev_err(&pdev->dev, "failed to get irq resource"); > > + return -ENOENT; > > + } > > + > > + dev->dec_irq = platform_get_irq(dev->plat_dev, 0); > > you can change dev->plat_dev with pdev Fix. > > > + if (dev->dec_irq < 0) { > > + dev_err(&pdev->dev, "failed to get irq number"); > > + return -EINVAL; > > return dev->dec_irq here instead of -EINVAL > Fix. > > + } > > + > > + irq_set_status_flags(dev->dec_irq, IRQ_NOAUTOEN); > > + ret = devm_request_irq(&pdev->dev, dev->dec_irq, > > + mtk_vcodec_dec_irq_handler, 0, pdev->name, dev); > > + if (ret) { > > + dev_err(&pdev->dev, "failed to install dev->dec_irq %d (%d)", > > + dev->dec_irq, ret); > > + return ret; > > + } > > + > > + ret = mtk_vcodec_init_dec_pm(dev->plat_dev, &dev->pm); > > you can change dev->plat_dev with pdev > > > + if (ret < 0) { > > + dev_err(&pdev->dev, "failed to get mt vcodec clock source"); > > + return ret; > > + } > > + } > > + > > + ret = mtk_vcodec_get_reg_bases(dev); > > you can do this call first in the beginning of the function, > then you don't need to test !dev->is_support_comp in order to undo the pm initialization > You are right, fix. > > + if (ret && !dev->is_support_comp) > > + mtk_vcodec_release_dec_pm(&dev->pm); > > + > > > > + return ret; > > +} > > + > > static int fops_vcodec_open(struct file *file) > > { > > struct mtk_vcodec_dev *dev = video_drvdata(file); > > @@ -228,9 +367,9 @@ static int mtk_vcodec_probe(struct platform_device *pdev) > > { > > struct mtk_vcodec_dev *dev; > > struct video_device *vfd_dec; > > - struct resource *res; > > phandle rproc_phandle; > > enum mtk_vcodec_fw_type fw_type; > > + struct device_node *comp_node; > > int ret; > > > > dev = devm_kzalloc(&pdev->dev, sizeof(*dev), GFP_KERNEL); > > @@ -257,31 +396,17 @@ static int mtk_vcodec_probe(struct platform_device *pdev) > > if (IS_ERR(dev->fw_handler)) > > return PTR_ERR(dev->fw_handler); > > > > - ret = mtk_vcodec_init_dec_pm(dev->plat_dev, &dev->pm); > > - if (ret < 0) { > > - dev_err(&pdev->dev, "Failed to get mt vcodec clock source"); > > - goto err_dec_pm; > > - } > > - > > - ret = mtk_vcodec_get_reg_bases(dev); > > - if (ret) > > - goto err_res; > > + comp_node = > > + of_find_compatible_node(NULL, NULL, "mediatek,mtk-vcodec-core"); > > + if (!comp_node) > > + dev->is_support_comp = false; > > + else > > + dev->is_support_comp = true; > > + of_node_put(comp_node); > > > > - res = platform_get_resource(pdev, IORESOURCE_IRQ, 0); > > - if (res == NULL) { > > - dev_err(&pdev->dev, "failed to get irq resource"); > > - ret = -ENOENT; > > - goto err_res; > > - } > > - > > - dev->dec_irq = platform_get_irq(pdev, 0); > > - irq_set_status_flags(dev->dec_irq, IRQ_NOAUTOEN); > > - ret = devm_request_irq(&pdev->dev, dev->dec_irq, > > - mtk_vcodec_dec_irq_handler, 0, pdev->name, dev); > > - if (ret) { > > - dev_err(&pdev->dev, "Failed to install dev->dec_irq %d (%d)", > > - dev->dec_irq, > > - ret); > > + if (mtk_vcodec_init_dec_params(dev)) { > > + dev_err(&pdev->dev, "Failed to init pm and registers"); > > + ret = -EINVAL; > > ret sould be the return value of mtk_vcodec_init_dec_params > > > goto err_res; > > } > > > > @@ -319,7 +444,6 @@ static int mtk_vcodec_probe(struct platform_device *pdev) > > MTK_VCODEC_DEC_NAME); > > video_set_drvdata(vfd_dec, dev); > > dev->vfd_dec = vfd_dec; > > - platform_set_drvdata(pdev, dev);> > > dev->m2m_dev_dec = v4l2_m2m_init(&mtk_vdec_m2m_ops); > > if (IS_ERR((__force void *)dev->m2m_dev_dec)) { > > @@ -370,8 +494,17 @@ static int mtk_vcodec_probe(struct platform_device *pdev) > > mtk_v4l2_debug(0, "decoder registered as /dev/video%d", > > vfd_dec->num); > > > > - return 0; > > + if (dev->is_support_comp) { > > + ret = mtk_vcodec_init_master(dev); > > + if (ret < 0) > > + goto err_component_match; > > + } else { > > + platform_set_drvdata(pdev, dev); > > why do that only if components are not supported? > Will call platform_set_drvdata in mtk_vcodec_init_master for component. component_master_add_with_match should be after platform_set_drvdata for component arch. > > + } > > > > + return 0; > > +err_component_match: > > + video_unregister_device(vfd_dec); > > err_dec_reg: > > if (dev->vdec_pdata->uses_stateless_api) > > media_device_unregister(&dev->mdev_dec); > > @@ -387,9 +520,8 @@ static int mtk_vcodec_probe(struct platform_device *pdev) > > err_dec_alloc: > > v4l2_device_unregister(&dev->v4l2_dev); > > err_res: > > - mtk_vcodec_release_dec_pm(&dev->pm); > > -err_dec_pm: > > mtk_vcodec_fw_release(dev->fw_handler); > > + > > return ret; > > } > > > > @@ -444,7 +576,25 @@ static struct platform_driver mtk_vcodec_dec_driver = { > > }, > > }; > > > > -module_platform_driver(mtk_vcodec_dec_driver); > > +static struct platform_driver * const mtk_vdec_drivers[] = { > > + &mtk_vdec_comp_driver, > > + &mtk_vcodec_dec_driver, > > +}; > > + > > +static int __init mtk_vdec_init(void) > > +{ > > + return platform_register_drivers(mtk_vdec_drivers, > > + ARRAY_SIZE(mtk_vdec_drivers)); > > +} > > + > > +static void __exit mtk_vdec_exit(void) > > +{ > > + platform_unregister_drivers(mtk_vdec_drivers, > > + ARRAY_SIZE(mtk_vdec_drivers)); > > +} > > + > > +module_init(mtk_vdec_init); > > +module_exit(mtk_vdec_exit); > > > > MODULE_LICENSE("GPL v2"); > > MODULE_DESCRIPTION("Mediatek video codec V4L2 decoder driver"); > > diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_hw.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_hw.c > > new file mode 100644 > > index 000000000000..ea6d289d9773 > > --- /dev/null > > +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_hw.c > > @@ -0,0 +1,193 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * Copyright (c) 2021 MediaTek Inc. > > + * Author: Yunfei Dong > > + */ > > + > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > + > > +#include "mtk_vcodec_drv.h" > > +#include "mtk_vcodec_dec.h" > > +#include "mtk_vcodec_dec_hw.h" > > +#include "mtk_vcodec_dec_pm.h" > > +#include "mtk_vcodec_intr.h" > > +#include "mtk_vcodec_util.h" > > + > > +static int mtk_vdec_comp_bind(struct device *dev, struct device *master, > > + void *data) > > +{ > > + struct mtk_vdec_comp_dev *comp_dev = dev_get_drvdata(dev); > > + struct mtk_vcodec_dev *master_dev = data; > > + int i; > > + > > + for (i = 0; i < MTK_VDEC_HW_MAX; i++) { > > + if (dev->of_node != master_dev->component_node[i]) > > + continue; > > + > > + master_dev->comp_dev[i] = comp_dev; > > + comp_dev->comp_idx = i; > > + comp_dev->master_dev = master_dev; > > + break; > > + } > > + > > + if (i == MTK_VDEC_HW_MAX) { > > + dev_err(dev, "Failed to get component node\n"); > > + return -EINVAL; > > + } > > + > > + comp_dev->reg_base[VDEC_COMP_SYS] = > > + master_dev->reg_base[VDEC_COMP_SYS]; > > + return 0; > > +} > > + > > +static void mtk_vdec_comp_unbind(struct device *dev, struct device *master, > > + void *data) > > +{ > > + struct mtk_vdec_comp_dev *comp_dev = dev_get_drvdata(dev); > > + > > + comp_dev->reg_base[VDEC_COMP_SYS] = NULL; > > +} > > + > > +static const struct component_ops mtk_vdec_hw_component_ops = { > > + .bind = mtk_vdec_comp_bind, > > + .unbind = mtk_vdec_comp_unbind, > > +}; > > + > > +/* Wake up context wait_queue */ > > +static void mtk_vdec_comp_wake_up_ctx(struct mtk_vcodec_ctx *ctx) > > +{ > > + ctx->int_cond = 1; > > + wake_up_interruptible(&ctx->queue); > > +} > > This function is identical to the function 'wake_up_ctx' so you should > proably not duplicate it. > Align vdec and venc wake up ctx interface. > > + > > +static irqreturn_t mtk_vdec_comp_irq_handler(int irq, void *priv) > > +{ > > + struct mtk_vdec_comp_dev *dev = priv; > > + struct mtk_vcodec_ctx *ctx; > > + u32 cg_status; > > + unsigned int dec_done_status; > > + void __iomem *vdec_misc_addr = dev->reg_base[VDEC_COMP_MISC] + > > + VDEC_IRQ_CFG_REG; > > + > > + ctx = mtk_vcodec_get_curr_ctx(dev->master_dev); > > + > > + /* check if HW active or not */ > > + cg_status = readl(dev->reg_base[VDEC_COMP_SYS]); > > + if ((cg_status & VDEC_HW_ACTIVE) != 0) { > > + mtk_v4l2_err("vdec active is not 0x0 (0x%08x)", > > + cg_status); > > + return IRQ_HANDLED; > > + } > > + > > + dec_done_status = readl(vdec_misc_addr); > > + if ((dec_done_status & MTK_VDEC_IRQ_STATUS_DEC_SUCCESS) != > > + MTK_VDEC_IRQ_STATUS_DEC_SUCCESS) > > + return IRQ_HANDLED; > > + > > + /* clear interrupt */ > > + writel(readl(vdec_misc_addr) | VDEC_IRQ_CFG, vdec_misc_addr); > > + writel(readl(vdec_misc_addr) & ~VDEC_IRQ_CLR, vdec_misc_addr); > > could these two writel be combined into one writel? > and could the calls 'readl(vdec_misc_addr)' be replaced with 'dec_done_status'? > Fix. > > + > > + mtk_vdec_comp_wake_up_ctx(ctx); > > + > > + mtk_v4l2_debug(3, "wake up ctx %d, dec_done_status=%x", > > + ctx->id, dec_done_status); > > + > > + return IRQ_HANDLED; > > +} > > + > > +static int mtk_vdec_comp_init_irq(struct mtk_vdec_comp_dev *dev) > > +{ > > + struct platform_device *pdev = dev->plat_dev; > > + int ret; > > + > > + dev->dec_irq = platform_get_irq(pdev, 0); > > + if (dev->dec_irq < 0) { > > + dev_err(&pdev->dev, "Failed to get irq resource"); > > + return dev->dec_irq; > > + } > > + > > + ret = devm_request_irq(&pdev->dev, dev->dec_irq, > > + mtk_vdec_comp_irq_handler, 0, pdev->name, dev); > > + if (ret) { > > + dev_err(&pdev->dev, "Failed to install dev->dec_irq %d (%d)", > > + dev->dec_irq, ret); > > + return -ENOENT; > > should return 'ret' here > > > + } > > + > > + disable_irq(dev->dec_irq); > > should this be replaced with: > > irq_set_status_flags(dev->dec_irq, IRQ_NOAUTOEN); > > ? > Should call this interface, fix it. > > + return 0; > > +} > > + > > +static int mtk_vdec_comp_probe(struct platform_device *pdev) > > +{ > > + struct mtk_vdec_comp_dev *dev; > > + int ret; > > + > > + dev = devm_kzalloc(&pdev->dev, sizeof(*dev), GFP_KERNEL); > > + if (!dev) > > + return -ENOMEM; > > + > > + dev->plat_dev = pdev; > > + spin_lock_init(&dev->irqlock); > > I don't see where this lock is used > > > + > > + ret = mtk_vcodec_init_dec_pm(pdev, &dev->pm); > > + if (ret) { > > + dev_err(&pdev->dev, "Failed to get mt vcodec clock source"); > > + return ret; > > + } > > + > > + dev->reg_base[VDEC_COMP_MISC] = > > + devm_platform_ioremap_resource(pdev, 0); > > + if (IS_ERR((__force void *)dev->reg_base[VDEC_COMP_MISC])) { > > + ret = PTR_ERR((__force void *)dev->reg_base[VDEC_COMP_MISC]); > > + goto err; > > + } > > + > > + if (of_get_property(pdev->dev.of_node, "dma-ranges", NULL)) > > + dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(34)); > > + > > + ret = mtk_vdec_comp_init_irq(dev); > > + if (ret) { > > + dev_err(&pdev->dev, "Failed to register irq handler.\n"); > > + goto err; > > + } > > + > > + platform_set_drvdata(pdev, dev); > > + > > + ret = component_add(&pdev->dev, &mtk_vdec_hw_component_ops); > > + if (ret) { > > + dev_err(&pdev->dev, "Failed to add component: %d\n", ret); > > + goto err; > > + } > > + > > + return 0; > > +err: > > + mtk_vcodec_release_dec_pm(&dev->pm); > > + return ret; > > +} > > + > > +static const struct of_device_id mtk_vdec_comp_ids[] = { > > + { > > + .compatible = "mediatek,mtk-vcodec-lat", > > + }, > > + { > > + .compatible = "mediatek,mtk-vcodec-core", > > + }, > > + {}, > > +}; > > +MODULE_DEVICE_TABLE(of, mtk_vdec_comp_ids); > > + > > +struct platform_driver mtk_vdec_comp_driver = { > > + .probe = mtk_vdec_comp_probe, > > + .driver = { > > + .name = "mtk-vdec-comp", > > + .of_match_table = mtk_vdec_comp_ids, > > + }, > > +}; > > diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_hw.h b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_hw.h > > new file mode 100644 > > index 000000000000..514e3fd190d1 > > --- /dev/null > > +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_hw.h > > @@ -0,0 +1,46 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * Copyright (c) 2021 MediaTek Inc. > > + * Author: Yunfei Dong > > + */ > > + > > +#ifndef _MTK_VCODEC_DEC_HW_H_ > > +#define _MTK_VCODEC_DEC_HW_H_ > > + > > +#include > > +#include > > + > > +#include "mtk_vcodec_drv.h" > > + > > +/** > > + * enum mtk_comp_hw_reg_idx - component register base index > > + */ > > +enum mtk_comp_hw_reg_idx { > > + VDEC_COMP_SYS, > > + VDEC_COMP_MISC, > > + VDEC_COMP_MAX > > +}; > > + > > +/** > > + * struct mtk_vdec_comp_dev - component framwork driver data > > + * @plat_dev: platform device > > + * @master_dev: master device > > + * @irqlock: protect data access by irq handler and work thread > > + * @reg_base: Mapped address of MTK Vcodec registers. > > + * > > + * @dec_irq: decoder irq resource > > + * @pm: power management control > > + * @comp_idx: component index > > + */ > > +struct mtk_vdec_comp_dev { > > + struct platform_device *plat_dev; > > + struct mtk_vcodec_dev *master_dev; > > + spinlock_t irqlock; > > + void __iomem *reg_base[VDEC_COMP_MAX]; > > + > > + int dec_irq; > > + struct mtk_vcodec_pm pm; > > + int comp_idx; > > +}; > > + > > +#endif /* _MTK_VCODEC_DEC_HW_H_ */ > > diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h b/drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h > > index 19296fd41c31..4002f786b6e3 100644 > > --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h > > +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h > > @@ -17,6 +17,11 @@ > > #include > > #include "mtk_vcodec_util.h" > > > > +#define VDEC_HW_ACTIVE 0x10 > > +#define VDEC_IRQ_CFG 0x11 > > +#define VDEC_IRQ_CLR 0x10 > > +#define VDEC_IRQ_CFG_REG 0xa4 > > + > > #define MTK_VCODEC_DRV_NAME "mtk_vcodec_drv" > > #define MTK_VCODEC_DEC_NAME "mtk-vcodec-dec" > > #define MTK_VCODEC_ENC_NAME "mtk-vcodec-enc" > > @@ -93,6 +98,17 @@ enum mtk_fmt_type { > > MTK_FMT_FRAME = 2, > > }; > > > > +/** > > + * struct mtk_vdec_hw_id - Hardware index used to separate > > + * different hardware > > + */ > > +enum mtk_vdec_hw_id { > > + MTK_VDEC_CORE, > > + MTK_VDEC_LAT0, > > + MTK_VDEC_LAT1, > > + MTK_VDEC_HW_MAX, > > + }; > > + > > /* > > * struct mtk_video_fmt - Structure used to store information about pixelformats > > */ > > @@ -404,6 +420,7 @@ struct mtk_vcodec_enc_pdata { > > * > > * @fw_handler: used to communicate with the firmware. > > * @id_counter: used to identify current opened instance > > + * @is_support_comp: true: using compoent framework, false: not support > > I would rename to 'is_comp_supported' > Can change the name. > > * > > * @decode_workqueue: decode work queue > > * @encode_workqueue: encode work queue > > @@ -422,6 +439,10 @@ struct mtk_vcodec_enc_pdata { > > * @pm: power management control > > * @dec_capability: used to identify decode capability, ex: 4k > > * @enc_capability: used to identify encode capability > > + * > > + * @comp_dev: component hardware device > > This field is not needed, it is only set without beeing used > comp_dev is used in mtk_vcodec_dec_hw.c > > + * @component_node: component node > > + * @comp_idx: component index > > This field is not used > comp_idx will be used in the future, can remove it and add it when need to use. > Thanks, > Dafna > > > */ > > struct mtk_vcodec_dev { > > struct v4l2_device v4l2_dev; > > @@ -442,6 +463,7 @@ struct mtk_vcodec_dev { > > struct mtk_vcodec_fw *fw_handler; > > > > unsigned long id_counter; > > + bool is_support_comp; > > > > struct workqueue_struct *decode_workqueue; > > struct workqueue_struct *encode_workqueue; > > @@ -459,6 +481,10 @@ struct mtk_vcodec_dev { > > struct mtk_vcodec_pm pm; > > unsigned int dec_capability; > > unsigned int enc_capability; > > + > > + void *comp_dev[MTK_VDEC_HW_MAX]; > > + struct device_node *component_node[MTK_VDEC_HW_MAX]; > > + int comp_idx; > > }; > > > > static inline struct mtk_vcodec_ctx *fh_to_ctx(struct v4l2_fh *fh) > > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C9F8C4320A for ; Sat, 24 Jul 2021 08:20:55 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3CC9160EB0 for ; Sat, 24 Jul 2021 08:20:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3CC9160EB0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FRjC8we2A+82qDiZBa+c//VZQH4DRDHFq1FIgIIb8EA=; b=XpBqT1bxVAkmnS 9OCgmB83n9GkHgSzhmupCrSdXyF2TqiVsMSlSh2uJo9g8QJPiyIraQEJTvyssG8EVAlzLge2yFtnH +FLva4DpD24+MThNwuu2N78b0eVzq3vHd/wb09RnOpLLosylD0qHJ+ix7YHs1ZQmarq+I+ejYD/j1 asudbll6hS7EhTkWfv0yd9TDvXd4VhXvVGP1RThWcRqZA8Oc3RuPv+XUayckr0aJ4cifsM3X7IRQw Xkpd2LGxjmZgCEyyo1lz1d0caytE7Yg2dTMHdAp7u2/q4F+ei9th/B6qdo26vsFPdrU06dwsgVs4w WWoVWzLcQJaq1IvC1PlA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m7Cry-006t3r-CI; Sat, 24 Jul 2021 08:18:50 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m7Crn-006t2z-4l; Sat, 24 Jul 2021 08:18:47 +0000 X-UUID: 4a45dc13b8f444349e9277c58558b6d0-20210724 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=J0yN25JZHNEfnssofagyOsjY9Ns6Uelzjl6td4UChnU=; b=KZ6ABnsiEVtn8Gof7oQ7gD3entmXPcKzTl3xeNhajHVt25hLyFq4NUIzJkv+kF0JPIgL345/8ixLF2IVHr8fW6j5/HFnz8b4TChBO1UmGk8flUA+W1OqN86AdtFIoNh2ixF4dO1hl5qqu4z0TpikKfIYXSpmC74xDR3tqRlHd4c=; X-UUID: 4a45dc13b8f444349e9277c58558b6d0-20210724 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 145167813; Sat, 24 Jul 2021 01:18:35 -0700 Received: from MTKMBS07N2.mediatek.inc (172.21.101.141) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sat, 24 Jul 2021 01:18:27 -0700 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sat, 24 Jul 2021 16:18:25 +0800 Received: from [10.17.3.153] (10.17.3.153) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Sat, 24 Jul 2021 16:18:24 +0800 Message-ID: <1627114703.32022.13.camel@mhfsdcap03> Subject: Re: [PATCH v2, 03/14] media: mtk-vcodec: Use component framework to manage each hardware information From: mtk12024 To: Dafna Hirschfeld CC: Alexandre Courbot , Hans Verkuil , Tzung-Bi Shih , "Tiffany Lin" , Andrew-CT Chen , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Tomasz Figa , Hsin-Yi Wang , "Fritz Koenig" , Irui Wang , , , , , , , , Collabora Kernel ML , Enric Balletbo i Serra Date: Sat, 24 Jul 2021 16:18:23 +0800 In-Reply-To: <281efe4d-aa38-53f7-7b90-8458b0d366f0@collabora.com> References: <20210717081233.7809-1-yunfei.dong@mediatek.com> <20210717081233.7809-4-yunfei.dong@mediatek.com> <281efe4d-aa38-53f7-7b90-8458b0d366f0@collabora.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210724_011842_794274_6408C9DF X-CRM114-Status: GOOD ( 38.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Dafna, Thanks for your detail advices. On Mon, 2021-07-19 at 11:00 +0200, Dafna Hirschfeld wrote: > > On 17.07.21 10:12, Yunfei Dong wrote: > > Uses component framework to manage each hardware information which > > includes irq/power/clk. The hardware includes LAT0, LAT1 and CORE. > > > > Signed-off-by: Yunfei Dong > > --- > > v2: fix coding style and remove useless header files > > --- > > drivers/media/platform/mtk-vcodec/Makefile | 1 + > > .../platform/mtk-vcodec/mtk_vcodec_dec.h | 1 + > > .../platform/mtk-vcodec/mtk_vcodec_dec_drv.c | 220 +++++++++++++++--- > > .../platform/mtk-vcodec/mtk_vcodec_dec_hw.c | 193 +++++++++++++++ > > .../platform/mtk-vcodec/mtk_vcodec_dec_hw.h | 46 ++++ > > .../platform/mtk-vcodec/mtk_vcodec_drv.h | 26 +++ > > 6 files changed, 452 insertions(+), 35 deletions(-) > > create mode 100644 drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_hw.c > > create mode 100644 drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_hw.h > > > > diff --git a/drivers/media/platform/mtk-vcodec/Makefile b/drivers/media/platform/mtk-vcodec/Makefile > > index ca8e9e7a9c4e..edeb3b66e9e9 100644 > > --- a/drivers/media/platform/mtk-vcodec/Makefile > > +++ b/drivers/media/platform/mtk-vcodec/Makefile > > @@ -15,6 +15,7 @@ mtk-vcodec-dec-y := vdec/vdec_h264_if.o \ > > mtk_vcodec_dec_stateful.o \ > > mtk_vcodec_dec_stateless.o \ > > mtk_vcodec_dec_pm.o \ > > + mtk_vcodec_dec_hw.o \ > > > > mtk-vcodec-enc-y := venc/venc_vp8_if.o \ > > venc/venc_h264_if.o \ > > diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.h b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.h > > index 9fbd24186c1a..c509224cbff4 100644 > > --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.h > > +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.h > > @@ -66,6 +66,7 @@ extern const struct v4l2_ioctl_ops mtk_vdec_ioctl_ops; > > extern const struct v4l2_m2m_ops mtk_vdec_m2m_ops; > > extern const struct media_device_ops mtk_vcodec_media_ops; > > > > +extern struct platform_driver mtk_vdec_comp_driver; > > > > /* > > * mtk_vdec_lock/mtk_vdec_unlock are for ctx instance to > > diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c > > index 8d7ba881ef75..e7f60e948fe8 100644 > > --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c > > +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_drv.c > > @@ -5,6 +5,7 @@ > > * Tiffany Lin > > */ > > > > +#include > > #include > > #include > > #include > > @@ -23,14 +24,50 @@ > > #include "mtk_vcodec_util.h" > > #include "mtk_vcodec_fw.h" > > > > -#define VDEC_HW_ACTIVE 0x10 > > -#define VDEC_IRQ_CFG 0x11 > > -#define VDEC_IRQ_CLR 0x10 > > -#define VDEC_IRQ_CFG_REG 0xa4 > > - > > module_param(mtk_v4l2_dbg_level, int, 0644); > > module_param(mtk_vcodec_dbg, bool, 0644); > > > > +static struct of_device_id mtk_vdec_drv_ids[] = { > > + { > > + .compatible = "mediatek,mtk-vcodec-lat", > > + .data = (void *)MTK_VDEC_LAT0, > > + }, > > + { > > + .compatible = "mediatek,mtk-vcodec-core", > > + .data = (void *)MTK_VDEC_CORE, > > + }, > > + {}, > > +}; > > + > > +static inline int mtk_vdec_compare_of(struct device *dev, void *data) > > +{ > > + return dev->of_node == data; > > +} > > + > > +static inline void mtk_vdec_release_of(struct device *dev, void *data) > > +{ > > + of_node_put(data); > > +} > > + > > +static inline int mtk_vdec_bind(struct device *dev) > > +{ > > + struct mtk_vcodec_dev *data = dev_get_drvdata(dev); > > + > > + return component_bind_all(dev, data); > > +} > > + > > +static inline void mtk_vdec_unbind(struct device *dev) > > +{ > > + struct mtk_vcodec_dev *data = dev_get_drvdata(dev); > > + > > + component_unbind_all(dev, data); > > +} > > + > > +static const struct component_master_ops mtk_vdec_ops = { > > + .bind = mtk_vdec_bind, > > + .unbind = mtk_vdec_unbind, > > +}; > > + > > /* Wake up context wait_queue */ > > static void wake_up_ctx(struct mtk_vcodec_ctx *ctx) > > { > > @@ -38,6 +75,48 @@ static void wake_up_ctx(struct mtk_vcodec_ctx *ctx) > > wake_up_interruptible(&ctx->queue); > > } > > > > +static struct component_match *mtk_vcodec_match_add( > > + struct mtk_vcodec_dev *vdec_dev) > > +{ > > + struct platform_device *pdev = vdec_dev->plat_dev; > > + struct component_match *match = NULL; > > + int i; > > + > > + for (i = 0; i < ARRAY_SIZE(mtk_vdec_drv_ids); i++) { > > + struct device_node *comp_node; > > + enum mtk_vdec_hw_id comp_idx; > > + const struct of_device_id *of_id; > > + > > + comp_node = of_find_compatible_node(NULL, NULL, > > + mtk_vdec_drv_ids[i].compatible); > > + if (!comp_node) > > + continue; > > + > > + if (!of_device_is_available(comp_node)) { > > + of_node_put(comp_node); > > + dev_err(&pdev->dev, "Fail to get MMSYS node\n"); > > + continue; > > + } > > + > > + of_node_put(comp_node); > > I think this line should come after the last usage of comp_node > > > + of_id = of_match_node(mtk_vdec_drv_ids, comp_node); > > I think this might be redundent since of_match_node will return &mtk_vdec_drv_ids[i] > So I think you can just do: > of_id = &mtk_vdec_drv_ids[i] > You are right, fix. > > + if (!of_id) { > > + dev_err(&pdev->dev, "Failed to get match node\n"); > > + return ERR_PTR(-EINVAL); > > + > + > > + comp_idx = (enum mtk_vdec_hw_id)of_id->data; > > + mtk_v4l2_debug(4, "Get component:hw_id(%d),vdec_dev(0x%p),comp_node(0x%p)\n", > > + comp_idx, vdec_dev, comp_node); > > + vdec_dev->component_node[comp_idx] = comp_node; > > + > > + component_match_add_release(&pdev->dev, &match, mtk_vdec_release_of, > > + mtk_vdec_compare_of, comp_node); > > + } > > + > > + return match; > > +} > > + > > static irqreturn_t mtk_vcodec_dec_irq_handler(int irq, void *priv) > > { > > struct mtk_vcodec_dev *dev = priv; > > @@ -103,6 +182,66 @@ static int mtk_vcodec_get_reg_bases(struct mtk_vcodec_dev *dev) > > return ret; > > } > > > > +static int mtk_vcodec_init_master(struct mtk_vcodec_dev *dev) > > +{ > > + struct platform_device *pdev = dev->plat_dev; > > + struct component_match *match; > > + int ret; > > + > > + match = mtk_vcodec_match_add(dev); > > + if (IS_ERR_OR_NULL(match)) > > + return -EINVAL; > > + > > + platform_set_drvdata(pdev, dev); > > + ret = component_master_add_with_match(&pdev->dev, &mtk_vdec_ops, match); > > + if (ret < 0) > > + return ret; > > + > > + return 0; > > +} > > + > > +static int mtk_vcodec_init_dec_params(struct mtk_vcodec_dev *dev) > > +{ > > + struct platform_device *pdev = dev->plat_dev; > > + struct resource *res; > > + int ret; > > + > > + if (!dev->is_support_comp) { > > + res = platform_get_resource(pdev, IORESOURCE_IRQ, 0); > > is the call to platform_get_resource needed? res is not used > No need to use. > > + if (!res) { > > + dev_err(&pdev->dev, "failed to get irq resource"); > > + return -ENOENT; > > + } > > + > > + dev->dec_irq = platform_get_irq(dev->plat_dev, 0); > > you can change dev->plat_dev with pdev Fix. > > > + if (dev->dec_irq < 0) { > > + dev_err(&pdev->dev, "failed to get irq number"); > > + return -EINVAL; > > return dev->dec_irq here instead of -EINVAL > Fix. > > + } > > + > > + irq_set_status_flags(dev->dec_irq, IRQ_NOAUTOEN); > > + ret = devm_request_irq(&pdev->dev, dev->dec_irq, > > + mtk_vcodec_dec_irq_handler, 0, pdev->name, dev); > > + if (ret) { > > + dev_err(&pdev->dev, "failed to install dev->dec_irq %d (%d)", > > + dev->dec_irq, ret); > > + return ret; > > + } > > + > > + ret = mtk_vcodec_init_dec_pm(dev->plat_dev, &dev->pm); > > you can change dev->plat_dev with pdev > > > + if (ret < 0) { > > + dev_err(&pdev->dev, "failed to get mt vcodec clock source"); > > + return ret; > > + } > > + } > > + > > + ret = mtk_vcodec_get_reg_bases(dev); > > you can do this call first in the beginning of the function, > then you don't need to test !dev->is_support_comp in order to undo the pm initialization > You are right, fix. > > + if (ret && !dev->is_support_comp) > > + mtk_vcodec_release_dec_pm(&dev->pm); > > + > > > > + return ret; > > +} > > + > > static int fops_vcodec_open(struct file *file) > > { > > struct mtk_vcodec_dev *dev = video_drvdata(file); > > @@ -228,9 +367,9 @@ static int mtk_vcodec_probe(struct platform_device *pdev) > > { > > struct mtk_vcodec_dev *dev; > > struct video_device *vfd_dec; > > - struct resource *res; > > phandle rproc_phandle; > > enum mtk_vcodec_fw_type fw_type; > > + struct device_node *comp_node; > > int ret; > > > > dev = devm_kzalloc(&pdev->dev, sizeof(*dev), GFP_KERNEL); > > @@ -257,31 +396,17 @@ static int mtk_vcodec_probe(struct platform_device *pdev) > > if (IS_ERR(dev->fw_handler)) > > return PTR_ERR(dev->fw_handler); > > > > - ret = mtk_vcodec_init_dec_pm(dev->plat_dev, &dev->pm); > > - if (ret < 0) { > > - dev_err(&pdev->dev, "Failed to get mt vcodec clock source"); > > - goto err_dec_pm; > > - } > > - > > - ret = mtk_vcodec_get_reg_bases(dev); > > - if (ret) > > - goto err_res; > > + comp_node = > > + of_find_compatible_node(NULL, NULL, "mediatek,mtk-vcodec-core"); > > + if (!comp_node) > > + dev->is_support_comp = false; > > + else > > + dev->is_support_comp = true; > > + of_node_put(comp_node); > > > > - res = platform_get_resource(pdev, IORESOURCE_IRQ, 0); > > - if (res == NULL) { > > - dev_err(&pdev->dev, "failed to get irq resource"); > > - ret = -ENOENT; > > - goto err_res; > > - } > > - > > - dev->dec_irq = platform_get_irq(pdev, 0); > > - irq_set_status_flags(dev->dec_irq, IRQ_NOAUTOEN); > > - ret = devm_request_irq(&pdev->dev, dev->dec_irq, > > - mtk_vcodec_dec_irq_handler, 0, pdev->name, dev); > > - if (ret) { > > - dev_err(&pdev->dev, "Failed to install dev->dec_irq %d (%d)", > > - dev->dec_irq, > > - ret); > > + if (mtk_vcodec_init_dec_params(dev)) { > > + dev_err(&pdev->dev, "Failed to init pm and registers"); > > + ret = -EINVAL; > > ret sould be the return value of mtk_vcodec_init_dec_params > > > goto err_res; > > } > > > > @@ -319,7 +444,6 @@ static int mtk_vcodec_probe(struct platform_device *pdev) > > MTK_VCODEC_DEC_NAME); > > video_set_drvdata(vfd_dec, dev); > > dev->vfd_dec = vfd_dec; > > - platform_set_drvdata(pdev, dev);> > > dev->m2m_dev_dec = v4l2_m2m_init(&mtk_vdec_m2m_ops); > > if (IS_ERR((__force void *)dev->m2m_dev_dec)) { > > @@ -370,8 +494,17 @@ static int mtk_vcodec_probe(struct platform_device *pdev) > > mtk_v4l2_debug(0, "decoder registered as /dev/video%d", > > vfd_dec->num); > > > > - return 0; > > + if (dev->is_support_comp) { > > + ret = mtk_vcodec_init_master(dev); > > + if (ret < 0) > > + goto err_component_match; > > + } else { > > + platform_set_drvdata(pdev, dev); > > why do that only if components are not supported? > Will call platform_set_drvdata in mtk_vcodec_init_master for component. component_master_add_with_match should be after platform_set_drvdata for component arch. > > + } > > > > + return 0; > > +err_component_match: > > + video_unregister_device(vfd_dec); > > err_dec_reg: > > if (dev->vdec_pdata->uses_stateless_api) > > media_device_unregister(&dev->mdev_dec); > > @@ -387,9 +520,8 @@ static int mtk_vcodec_probe(struct platform_device *pdev) > > err_dec_alloc: > > v4l2_device_unregister(&dev->v4l2_dev); > > err_res: > > - mtk_vcodec_release_dec_pm(&dev->pm); > > -err_dec_pm: > > mtk_vcodec_fw_release(dev->fw_handler); > > + > > return ret; > > } > > > > @@ -444,7 +576,25 @@ static struct platform_driver mtk_vcodec_dec_driver = { > > }, > > }; > > > > -module_platform_driver(mtk_vcodec_dec_driver); > > +static struct platform_driver * const mtk_vdec_drivers[] = { > > + &mtk_vdec_comp_driver, > > + &mtk_vcodec_dec_driver, > > +}; > > + > > +static int __init mtk_vdec_init(void) > > +{ > > + return platform_register_drivers(mtk_vdec_drivers, > > + ARRAY_SIZE(mtk_vdec_drivers)); > > +} > > + > > +static void __exit mtk_vdec_exit(void) > > +{ > > + platform_unregister_drivers(mtk_vdec_drivers, > > + ARRAY_SIZE(mtk_vdec_drivers)); > > +} > > + > > +module_init(mtk_vdec_init); > > +module_exit(mtk_vdec_exit); > > > > MODULE_LICENSE("GPL v2"); > > MODULE_DESCRIPTION("Mediatek video codec V4L2 decoder driver"); > > diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_hw.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_hw.c > > new file mode 100644 > > index 000000000000..ea6d289d9773 > > --- /dev/null > > +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_hw.c > > @@ -0,0 +1,193 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * Copyright (c) 2021 MediaTek Inc. > > + * Author: Yunfei Dong > > + */ > > + > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > + > > +#include "mtk_vcodec_drv.h" > > +#include "mtk_vcodec_dec.h" > > +#include "mtk_vcodec_dec_hw.h" > > +#include "mtk_vcodec_dec_pm.h" > > +#include "mtk_vcodec_intr.h" > > +#include "mtk_vcodec_util.h" > > + > > +static int mtk_vdec_comp_bind(struct device *dev, struct device *master, > > + void *data) > > +{ > > + struct mtk_vdec_comp_dev *comp_dev = dev_get_drvdata(dev); > > + struct mtk_vcodec_dev *master_dev = data; > > + int i; > > + > > + for (i = 0; i < MTK_VDEC_HW_MAX; i++) { > > + if (dev->of_node != master_dev->component_node[i]) > > + continue; > > + > > + master_dev->comp_dev[i] = comp_dev; > > + comp_dev->comp_idx = i; > > + comp_dev->master_dev = master_dev; > > + break; > > + } > > + > > + if (i == MTK_VDEC_HW_MAX) { > > + dev_err(dev, "Failed to get component node\n"); > > + return -EINVAL; > > + } > > + > > + comp_dev->reg_base[VDEC_COMP_SYS] = > > + master_dev->reg_base[VDEC_COMP_SYS]; > > + return 0; > > +} > > + > > +static void mtk_vdec_comp_unbind(struct device *dev, struct device *master, > > + void *data) > > +{ > > + struct mtk_vdec_comp_dev *comp_dev = dev_get_drvdata(dev); > > + > > + comp_dev->reg_base[VDEC_COMP_SYS] = NULL; > > +} > > + > > +static const struct component_ops mtk_vdec_hw_component_ops = { > > + .bind = mtk_vdec_comp_bind, > > + .unbind = mtk_vdec_comp_unbind, > > +}; > > + > > +/* Wake up context wait_queue */ > > +static void mtk_vdec_comp_wake_up_ctx(struct mtk_vcodec_ctx *ctx) > > +{ > > + ctx->int_cond = 1; > > + wake_up_interruptible(&ctx->queue); > > +} > > This function is identical to the function 'wake_up_ctx' so you should > proably not duplicate it. > Align vdec and venc wake up ctx interface. > > + > > +static irqreturn_t mtk_vdec_comp_irq_handler(int irq, void *priv) > > +{ > > + struct mtk_vdec_comp_dev *dev = priv; > > + struct mtk_vcodec_ctx *ctx; > > + u32 cg_status; > > + unsigned int dec_done_status; > > + void __iomem *vdec_misc_addr = dev->reg_base[VDEC_COMP_MISC] + > > + VDEC_IRQ_CFG_REG; > > + > > + ctx = mtk_vcodec_get_curr_ctx(dev->master_dev); > > + > > + /* check if HW active or not */ > > + cg_status = readl(dev->reg_base[VDEC_COMP_SYS]); > > + if ((cg_status & VDEC_HW_ACTIVE) != 0) { > > + mtk_v4l2_err("vdec active is not 0x0 (0x%08x)", > > + cg_status); > > + return IRQ_HANDLED; > > + } > > + > > + dec_done_status = readl(vdec_misc_addr); > > + if ((dec_done_status & MTK_VDEC_IRQ_STATUS_DEC_SUCCESS) != > > + MTK_VDEC_IRQ_STATUS_DEC_SUCCESS) > > + return IRQ_HANDLED; > > + > > + /* clear interrupt */ > > + writel(readl(vdec_misc_addr) | VDEC_IRQ_CFG, vdec_misc_addr); > > + writel(readl(vdec_misc_addr) & ~VDEC_IRQ_CLR, vdec_misc_addr); > > could these two writel be combined into one writel? > and could the calls 'readl(vdec_misc_addr)' be replaced with 'dec_done_status'? > Fix. > > + > > + mtk_vdec_comp_wake_up_ctx(ctx); > > + > > + mtk_v4l2_debug(3, "wake up ctx %d, dec_done_status=%x", > > + ctx->id, dec_done_status); > > + > > + return IRQ_HANDLED; > > +} > > + > > +static int mtk_vdec_comp_init_irq(struct mtk_vdec_comp_dev *dev) > > +{ > > + struct platform_device *pdev = dev->plat_dev; > > + int ret; > > + > > + dev->dec_irq = platform_get_irq(pdev, 0); > > + if (dev->dec_irq < 0) { > > + dev_err(&pdev->dev, "Failed to get irq resource"); > > + return dev->dec_irq; > > + } > > + > > + ret = devm_request_irq(&pdev->dev, dev->dec_irq, > > + mtk_vdec_comp_irq_handler, 0, pdev->name, dev); > > + if (ret) { > > + dev_err(&pdev->dev, "Failed to install dev->dec_irq %d (%d)", > > + dev->dec_irq, ret); > > + return -ENOENT; > > should return 'ret' here > > > + } > > + > > + disable_irq(dev->dec_irq); > > should this be replaced with: > > irq_set_status_flags(dev->dec_irq, IRQ_NOAUTOEN); > > ? > Should call this interface, fix it. > > + return 0; > > +} > > + > > +static int mtk_vdec_comp_probe(struct platform_device *pdev) > > +{ > > + struct mtk_vdec_comp_dev *dev; > > + int ret; > > + > > + dev = devm_kzalloc(&pdev->dev, sizeof(*dev), GFP_KERNEL); > > + if (!dev) > > + return -ENOMEM; > > + > > + dev->plat_dev = pdev; > > + spin_lock_init(&dev->irqlock); > > I don't see where this lock is used > > > + > > + ret = mtk_vcodec_init_dec_pm(pdev, &dev->pm); > > + if (ret) { > > + dev_err(&pdev->dev, "Failed to get mt vcodec clock source"); > > + return ret; > > + } > > + > > + dev->reg_base[VDEC_COMP_MISC] = > > + devm_platform_ioremap_resource(pdev, 0); > > + if (IS_ERR((__force void *)dev->reg_base[VDEC_COMP_MISC])) { > > + ret = PTR_ERR((__force void *)dev->reg_base[VDEC_COMP_MISC]); > > + goto err; > > + } > > + > > + if (of_get_property(pdev->dev.of_node, "dma-ranges", NULL)) > > + dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(34)); > > + > > + ret = mtk_vdec_comp_init_irq(dev); > > + if (ret) { > > + dev_err(&pdev->dev, "Failed to register irq handler.\n"); > > + goto err; > > + } > > + > > + platform_set_drvdata(pdev, dev); > > + > > + ret = component_add(&pdev->dev, &mtk_vdec_hw_component_ops); > > + if (ret) { > > + dev_err(&pdev->dev, "Failed to add component: %d\n", ret); > > + goto err; > > + } > > + > > + return 0; > > +err: > > + mtk_vcodec_release_dec_pm(&dev->pm); > > + return ret; > > +} > > + > > +static const struct of_device_id mtk_vdec_comp_ids[] = { > > + { > > + .compatible = "mediatek,mtk-vcodec-lat", > > + }, > > + { > > + .compatible = "mediatek,mtk-vcodec-core", > > + }, > > + {}, > > +}; > > +MODULE_DEVICE_TABLE(of, mtk_vdec_comp_ids); > > + > > +struct platform_driver mtk_vdec_comp_driver = { > > + .probe = mtk_vdec_comp_probe, > > + .driver = { > > + .name = "mtk-vdec-comp", > > + .of_match_table = mtk_vdec_comp_ids, > > + }, > > +}; > > diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_hw.h b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_hw.h > > new file mode 100644 > > index 000000000000..514e3fd190d1 > > --- /dev/null > > +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec_hw.h > > @@ -0,0 +1,46 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * Copyright (c) 2021 MediaTek Inc. > > + * Author: Yunfei Dong > > + */ > > + > > +#ifndef _MTK_VCODEC_DEC_HW_H_ > > +#define _MTK_VCODEC_DEC_HW_H_ > > + > > +#include > > +#include > > + > > +#include "mtk_vcodec_drv.h" > > + > > +/** > > + * enum mtk_comp_hw_reg_idx - component register base index > > + */ > > +enum mtk_comp_hw_reg_idx { > > + VDEC_COMP_SYS, > > + VDEC_COMP_MISC, > > + VDEC_COMP_MAX > > +}; > > + > > +/** > > + * struct mtk_vdec_comp_dev - component framwork driver data > > + * @plat_dev: platform device > > + * @master_dev: master device > > + * @irqlock: protect data access by irq handler and work thread > > + * @reg_base: Mapped address of MTK Vcodec registers. > > + * > > + * @dec_irq: decoder irq resource > > + * @pm: power management control > > + * @comp_idx: component index > > + */ > > +struct mtk_vdec_comp_dev { > > + struct platform_device *plat_dev; > > + struct mtk_vcodec_dev *master_dev; > > + spinlock_t irqlock; > > + void __iomem *reg_base[VDEC_COMP_MAX]; > > + > > + int dec_irq; > > + struct mtk_vcodec_pm pm; > > + int comp_idx; > > +}; > > + > > +#endif /* _MTK_VCODEC_DEC_HW_H_ */ > > diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h b/drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h > > index 19296fd41c31..4002f786b6e3 100644 > > --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h > > +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_drv.h > > @@ -17,6 +17,11 @@ > > #include > > #include "mtk_vcodec_util.h" > > > > +#define VDEC_HW_ACTIVE 0x10 > > +#define VDEC_IRQ_CFG 0x11 > > +#define VDEC_IRQ_CLR 0x10 > > +#define VDEC_IRQ_CFG_REG 0xa4 > > + > > #define MTK_VCODEC_DRV_NAME "mtk_vcodec_drv" > > #define MTK_VCODEC_DEC_NAME "mtk-vcodec-dec" > > #define MTK_VCODEC_ENC_NAME "mtk-vcodec-enc" > > @@ -93,6 +98,17 @@ enum mtk_fmt_type { > > MTK_FMT_FRAME = 2, > > }; > > > > +/** > > + * struct mtk_vdec_hw_id - Hardware index used to separate > > + * different hardware > > + */ > > +enum mtk_vdec_hw_id { > > + MTK_VDEC_CORE, > > + MTK_VDEC_LAT0, > > + MTK_VDEC_LAT1, > > + MTK_VDEC_HW_MAX, > > + }; > > + > > /* > > * struct mtk_video_fmt - Structure used to store information about pixelformats > > */ > > @@ -404,6 +420,7 @@ struct mtk_vcodec_enc_pdata { > > * > > * @fw_handler: used to communicate with the firmware. > > * @id_counter: used to identify current opened instance > > + * @is_support_comp: true: using compoent framework, false: not support > > I would rename to 'is_comp_supported' > Can change the name. > > * > > * @decode_workqueue: decode work queue > > * @encode_workqueue: encode work queue > > @@ -422,6 +439,10 @@ struct mtk_vcodec_enc_pdata { > > * @pm: power management control > > * @dec_capability: used to identify decode capability, ex: 4k > > * @enc_capability: used to identify encode capability > > + * > > + * @comp_dev: component hardware device > > This field is not needed, it is only set without beeing used > comp_dev is used in mtk_vcodec_dec_hw.c > > + * @component_node: component node > > + * @comp_idx: component index > > This field is not used > comp_idx will be used in the future, can remove it and add it when need to use. > Thanks, > Dafna > > > */ > > struct mtk_vcodec_dev { > > struct v4l2_device v4l2_dev; > > @@ -442,6 +463,7 @@ struct mtk_vcodec_dev { > > struct mtk_vcodec_fw *fw_handler; > > > > unsigned long id_counter; > > + bool is_support_comp; > > > > struct workqueue_struct *decode_workqueue; > > struct workqueue_struct *encode_workqueue; > > @@ -459,6 +481,10 @@ struct mtk_vcodec_dev { > > struct mtk_vcodec_pm pm; > > unsigned int dec_capability; > > unsigned int enc_capability; > > + > > + void *comp_dev[MTK_VDEC_HW_MAX]; > > + struct device_node *component_node[MTK_VDEC_HW_MAX]; > > + int comp_idx; > > }; > > > > static inline struct mtk_vcodec_ctx *fh_to_ctx(struct v4l2_fh *fh) > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20664C4338F for ; Sat, 24 Jul 2021 08:18:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 01F5560E97 for ; Sat, 24 Jul 2021 08:18:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234264AbhGXHiC (ORCPT ); Sat, 24 Jul 2021 03:38:02 -0400 Received: from mailgw01.mediatek.com ([60.244.123.138]:60320 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S234216AbhGXHh6 (ORCPT ); Sat, 24 Jul 2021 03:37:58 -0400 X-UUID: d1cd232212584b419418c0eeb94df54d-20210724 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=J0yN25JZHNEfnssofagyOsjY9Ns6Uelzjl6td4UChnU=; b=EMcreTjMcwFj+SiudDKeYWVVJJOjFBGMVocIh55/yHSK/mAs84iR+YrcV4aWs/iAdIYSWLS2ZAPaKE2Kcb/CBtIwTHpcbQMLdauhYPfQJiirQCcUAKVXCfSkmA0x6YRZ0UL2qLQF4cBjXsUN66wd7lIggrA9/21wzvoDZIRWAvI=; X-UUID: d1cd232212584b419418c0eeb94df54d-20210724 Received: from mtkcas06.mediatek.inc [(172.21.101.30)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 883894818; Sat, 24 Jul 2021 16:18:26 +0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs07n2.mediatek.inc (172.21.101.141) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sat, 24 Jul 2021 16:18:25 +0800 Received: from [10.17.3.153] (10.17.3.153) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Sat, 24 Jul 2021 16:18:24 +0800 Message-ID: <1627114703.32022.13.camel@mhfsdcap03> Subject: Re: [PATCH v2, 03/14] media: mtk-vcodec: Use component framework to manage each hardware information From: mtk12024 To: Dafna Hirschfeld CC: Alexandre Courbot , Hans Verkuil , Tzung-Bi Shih , "Tiffany Lin" , Andrew-CT Chen , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Tomasz Figa , Hsin-Yi Wang , Fritz Koenig , Irui Wang , , , , , , , , Collabora Kernel ML , Enric Balletbo i Serra Date: Sat, 24 Jul 2021 16:18:23 +0800 In-Reply-To: <281efe4d-aa38-53f7-7b90-8458b0d366f0@collabora.com> References: <20210717081233.7809-1-yunfei.dong@mediatek.com> <20210717081233.7809-4-yunfei.dong@mediatek.com> <281efe4d-aa38-53f7-7b90-8458b0d366f0@collabora.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N Content-Transfer-Encoding: base64 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org SGkgRGFmbmEsDQoNClRoYW5rcyBmb3IgeW91ciBkZXRhaWwgYWR2aWNlcy4NCk9uIE1vbiwgMjAy MS0wNy0xOSBhdCAxMTowMCArMDIwMCwgRGFmbmEgSGlyc2NoZmVsZCB3cm90ZToNCj4gDQo+IE9u IDE3LjA3LjIxIDEwOjEyLCBZdW5mZWkgRG9uZyB3cm90ZToNCj4gPiBVc2VzIGNvbXBvbmVudCBm cmFtZXdvcmsgdG8gbWFuYWdlIGVhY2ggaGFyZHdhcmUgaW5mb3JtYXRpb24gd2hpY2gNCj4gPiBp bmNsdWRlcyBpcnEvcG93ZXIvY2xrLiBUaGUgaGFyZHdhcmUgaW5jbHVkZXMgTEFUMCwgTEFUMSBh bmQgQ09SRS4NCj4gPiANCj4gPiBTaWduZWQtb2ZmLWJ5OiBZdW5mZWkgRG9uZyA8eXVuZmVpLmRv bmdAbWVkaWF0ZWsuY29tPg0KPiA+IC0tLQ0KPiA+IHYyOiBmaXggY29kaW5nIHN0eWxlIGFuZCBy ZW1vdmUgdXNlbGVzcyBoZWFkZXIgZmlsZXMNCj4gPiAtLS0NCj4gPiAgIGRyaXZlcnMvbWVkaWEv cGxhdGZvcm0vbXRrLXZjb2RlYy9NYWtlZmlsZSAgICB8ICAgMSArDQo+ID4gICAuLi4vcGxhdGZv cm0vbXRrLXZjb2RlYy9tdGtfdmNvZGVjX2RlYy5oICAgICAgfCAgIDEgKw0KPiA+ICAgLi4uL3Bs YXRmb3JtL210ay12Y29kZWMvbXRrX3Zjb2RlY19kZWNfZHJ2LmMgIHwgMjIwICsrKysrKysrKysr KysrKy0tLQ0KPiA+ICAgLi4uL3BsYXRmb3JtL210ay12Y29kZWMvbXRrX3Zjb2RlY19kZWNfaHcu YyAgIHwgMTkzICsrKysrKysrKysrKysrKw0KPiA+ICAgLi4uL3BsYXRmb3JtL210ay12Y29kZWMv bXRrX3Zjb2RlY19kZWNfaHcuaCAgIHwgIDQ2ICsrKysNCj4gPiAgIC4uLi9wbGF0Zm9ybS9tdGst dmNvZGVjL210a192Y29kZWNfZHJ2LmggICAgICB8ICAyNiArKysNCj4gPiAgIDYgZmlsZXMgY2hh bmdlZCwgNDUyIGluc2VydGlvbnMoKyksIDM1IGRlbGV0aW9ucygtKQ0KPiA+ICAgY3JlYXRlIG1v ZGUgMTAwNjQ0IGRyaXZlcnMvbWVkaWEvcGxhdGZvcm0vbXRrLXZjb2RlYy9tdGtfdmNvZGVjX2Rl Y19ody5jDQo+ID4gICBjcmVhdGUgbW9kZSAxMDA2NDQgZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS9t dGstdmNvZGVjL210a192Y29kZWNfZGVjX2h3LmgNCj4gPiANCj4gPiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9tZWRpYS9wbGF0Zm9ybS9tdGstdmNvZGVjL01ha2VmaWxlIGIvZHJpdmVycy9tZWRpYS9w bGF0Zm9ybS9tdGstdmNvZGVjL01ha2VmaWxlDQo+ID4gaW5kZXggY2E4ZTllN2E5YzRlLi5lZGVi M2I2NmU5ZTkgMTAwNjQ0DQo+ID4gLS0tIGEvZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS9tdGstdmNv ZGVjL01ha2VmaWxlDQo+ID4gKysrIGIvZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS9tdGstdmNvZGVj L01ha2VmaWxlDQo+ID4gQEAgLTE1LDYgKzE1LDcgQEAgbXRrLXZjb2RlYy1kZWMteSA6PSB2ZGVj L3ZkZWNfaDI2NF9pZi5vIFwNCj4gPiAgIAkJbXRrX3Zjb2RlY19kZWNfc3RhdGVmdWwubyBcDQo+ ID4gICAJCW10a192Y29kZWNfZGVjX3N0YXRlbGVzcy5vIFwNCj4gPiAgIAkJbXRrX3Zjb2RlY19k ZWNfcG0ubyBcDQo+ID4gKwkJbXRrX3Zjb2RlY19kZWNfaHcubyBcDQo+ID4gICANCj4gPiAgIG10 ay12Y29kZWMtZW5jLXkgOj0gdmVuYy92ZW5jX3ZwOF9pZi5vIFwNCj4gPiAgIAkJdmVuYy92ZW5j X2gyNjRfaWYubyBcDQo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbWVkaWEvcGxhdGZvcm0vbXRr LXZjb2RlYy9tdGtfdmNvZGVjX2RlYy5oIGIvZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS9tdGstdmNv ZGVjL210a192Y29kZWNfZGVjLmgNCj4gPiBpbmRleCA5ZmJkMjQxODZjMWEuLmM1MDkyMjRjYmZm NCAxMDA2NDQNCj4gPiAtLS0gYS9kcml2ZXJzL21lZGlhL3BsYXRmb3JtL210ay12Y29kZWMvbXRr X3Zjb2RlY19kZWMuaA0KPiA+ICsrKyBiL2RyaXZlcnMvbWVkaWEvcGxhdGZvcm0vbXRrLXZjb2Rl Yy9tdGtfdmNvZGVjX2RlYy5oDQo+ID4gQEAgLTY2LDYgKzY2LDcgQEAgZXh0ZXJuIGNvbnN0IHN0 cnVjdCB2NGwyX2lvY3RsX29wcyBtdGtfdmRlY19pb2N0bF9vcHM7DQo+ID4gICBleHRlcm4gY29u c3Qgc3RydWN0IHY0bDJfbTJtX29wcyBtdGtfdmRlY19tMm1fb3BzOw0KPiA+ICAgZXh0ZXJuIGNv bnN0IHN0cnVjdCBtZWRpYV9kZXZpY2Vfb3BzIG10a192Y29kZWNfbWVkaWFfb3BzOw0KPiA+ICAg DQo+ID4gK2V4dGVybiBzdHJ1Y3QgcGxhdGZvcm1fZHJpdmVyIG10a192ZGVjX2NvbXBfZHJpdmVy Ow0KPiA+ICAgDQo+ID4gICAvKg0KPiA+ICAgICogbXRrX3ZkZWNfbG9jay9tdGtfdmRlY191bmxv Y2sgYXJlIGZvciBjdHggaW5zdGFuY2UgdG8NCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9tZWRp YS9wbGF0Zm9ybS9tdGstdmNvZGVjL210a192Y29kZWNfZGVjX2Rydi5jIGIvZHJpdmVycy9tZWRp YS9wbGF0Zm9ybS9tdGstdmNvZGVjL210a192Y29kZWNfZGVjX2Rydi5jDQo+ID4gaW5kZXggOGQ3 YmE4ODFlZjc1Li5lN2Y2MGU5NDhmZTggMTAwNjQ0DQo+ID4gLS0tIGEvZHJpdmVycy9tZWRpYS9w bGF0Zm9ybS9tdGstdmNvZGVjL210a192Y29kZWNfZGVjX2Rydi5jDQo+ID4gKysrIGIvZHJpdmVy cy9tZWRpYS9wbGF0Zm9ybS9tdGstdmNvZGVjL210a192Y29kZWNfZGVjX2Rydi5jDQo+ID4gQEAg LTUsNiArNSw3IEBADQo+ID4gICAgKiAgICAgICAgIFRpZmZhbnkgTGluIDx0aWZmYW55LmxpbkBt ZWRpYXRlay5jb20+DQo+ID4gICAgKi8NCj4gPiAgIA0KPiA+ICsjaW5jbHVkZSA8bGludXgvY29t cG9uZW50Lmg+DQo+ID4gICAjaW5jbHVkZSA8bGludXgvc2xhYi5oPg0KPiA+ICAgI2luY2x1ZGUg PGxpbnV4L2ludGVycnVwdC5oPg0KPiA+ICAgI2luY2x1ZGUgPGxpbnV4L2lycS5oPg0KPiA+IEBA IC0yMywxNCArMjQsNTAgQEANCj4gPiAgICNpbmNsdWRlICJtdGtfdmNvZGVjX3V0aWwuaCINCj4g PiAgICNpbmNsdWRlICJtdGtfdmNvZGVjX2Z3LmgiDQo+ID4gICANCj4gPiAtI2RlZmluZSBWREVD X0hXX0FDVElWRQkweDEwDQo+ID4gLSNkZWZpbmUgVkRFQ19JUlFfQ0ZHCTB4MTENCj4gPiAtI2Rl ZmluZSBWREVDX0lSUV9DTFIJMHgxMA0KPiA+IC0jZGVmaW5lIFZERUNfSVJRX0NGR19SRUcJMHhh NA0KPiA+IC0NCj4gPiAgIG1vZHVsZV9wYXJhbShtdGtfdjRsMl9kYmdfbGV2ZWwsIGludCwgMDY0 NCk7DQo+ID4gICBtb2R1bGVfcGFyYW0obXRrX3Zjb2RlY19kYmcsIGJvb2wsIDA2NDQpOw0KPiA+ ICAgDQo+ID4gK3N0YXRpYyBzdHJ1Y3Qgb2ZfZGV2aWNlX2lkIG10a192ZGVjX2Rydl9pZHNbXSA9 IHsNCj4gPiArCXsNCj4gPiArCQkuY29tcGF0aWJsZSA9ICJtZWRpYXRlayxtdGstdmNvZGVjLWxh dCIsDQo+ID4gKwkJLmRhdGEgPSAodm9pZCAqKU1US19WREVDX0xBVDAsDQo+ID4gKwl9LA0KPiA+ ICsJew0KPiA+ICsJCS5jb21wYXRpYmxlID0gIm1lZGlhdGVrLG10ay12Y29kZWMtY29yZSIsDQo+ ID4gKwkJLmRhdGEgPSAodm9pZCAqKU1US19WREVDX0NPUkUsDQo+ID4gKwl9LA0KPiA+ICsJe30s DQo+ID4gK307DQo+ID4gKw0KPiA+ICtzdGF0aWMgaW5saW5lIGludCBtdGtfdmRlY19jb21wYXJl X29mKHN0cnVjdCBkZXZpY2UgKmRldiwgdm9pZCAqZGF0YSkNCj4gPiArew0KPiA+ICsJcmV0dXJu IGRldi0+b2Zfbm9kZSA9PSBkYXRhOw0KPiA+ICt9DQo+ID4gKw0KPiA+ICtzdGF0aWMgaW5saW5l IHZvaWQgbXRrX3ZkZWNfcmVsZWFzZV9vZihzdHJ1Y3QgZGV2aWNlICpkZXYsIHZvaWQgKmRhdGEp DQo+ID4gK3sNCj4gPiArCW9mX25vZGVfcHV0KGRhdGEpOw0KPiA+ICt9DQo+ID4gKw0KPiA+ICtz dGF0aWMgaW5saW5lIGludCBtdGtfdmRlY19iaW5kKHN0cnVjdCBkZXZpY2UgKmRldikNCj4gPiAr ew0KPiA+ICsJc3RydWN0IG10a192Y29kZWNfZGV2ICpkYXRhID0gZGV2X2dldF9kcnZkYXRhKGRl dik7DQo+ID4gKw0KPiA+ICsJcmV0dXJuIGNvbXBvbmVudF9iaW5kX2FsbChkZXYsIGRhdGEpOw0K PiA+ICt9DQo+ID4gKw0KPiA+ICtzdGF0aWMgaW5saW5lIHZvaWQgbXRrX3ZkZWNfdW5iaW5kKHN0 cnVjdCBkZXZpY2UgKmRldikNCj4gPiArew0KPiA+ICsJc3RydWN0IG10a192Y29kZWNfZGV2ICpk YXRhID0gZGV2X2dldF9kcnZkYXRhKGRldik7DQo+ID4gKw0KPiA+ICsJY29tcG9uZW50X3VuYmlu ZF9hbGwoZGV2LCBkYXRhKTsNCj4gPiArfQ0KPiA+ICsNCj4gPiArc3RhdGljIGNvbnN0IHN0cnVj dCBjb21wb25lbnRfbWFzdGVyX29wcyBtdGtfdmRlY19vcHMgPSB7DQo+ID4gKwkuYmluZCA9IG10 a192ZGVjX2JpbmQsDQo+ID4gKwkudW5iaW5kID0gbXRrX3ZkZWNfdW5iaW5kLA0KPiA+ICt9Ow0K PiA+ICsNCj4gPiAgIC8qIFdha2UgdXAgY29udGV4dCB3YWl0X3F1ZXVlICovDQo+ID4gICBzdGF0 aWMgdm9pZCB3YWtlX3VwX2N0eChzdHJ1Y3QgbXRrX3Zjb2RlY19jdHggKmN0eCkNCj4gPiAgIHsN Cj4gPiBAQCAtMzgsNiArNzUsNDggQEAgc3RhdGljIHZvaWQgd2FrZV91cF9jdHgoc3RydWN0IG10 a192Y29kZWNfY3R4ICpjdHgpDQo+ID4gICAJd2FrZV91cF9pbnRlcnJ1cHRpYmxlKCZjdHgtPnF1 ZXVlKTsNCj4gPiAgIH0NCj4gPiAgIA0KPiA+ICtzdGF0aWMgc3RydWN0IGNvbXBvbmVudF9tYXRj aCAqbXRrX3Zjb2RlY19tYXRjaF9hZGQoDQo+ID4gKwlzdHJ1Y3QgbXRrX3Zjb2RlY19kZXYgKnZk ZWNfZGV2KQ0KPiA+ICt7DQo+ID4gKwlzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2ID0gdmRl Y19kZXYtPnBsYXRfZGV2Ow0KPiA+ICsJc3RydWN0IGNvbXBvbmVudF9tYXRjaCAqbWF0Y2ggPSBO VUxMOw0KPiA+ICsJaW50IGk7DQo+ID4gKw0KPiA+ICsJZm9yIChpID0gMDsgaSA8IEFSUkFZX1NJ WkUobXRrX3ZkZWNfZHJ2X2lkcyk7IGkrKykgew0KPiA+ICsJCXN0cnVjdCBkZXZpY2Vfbm9kZSAq Y29tcF9ub2RlOw0KPiA+ICsJCWVudW0gbXRrX3ZkZWNfaHdfaWQgY29tcF9pZHg7DQo+ID4gKwkJ Y29uc3Qgc3RydWN0IG9mX2RldmljZV9pZCAqb2ZfaWQ7DQo+ID4gKw0KPiA+ICsJCWNvbXBfbm9k ZSA9IG9mX2ZpbmRfY29tcGF0aWJsZV9ub2RlKE5VTEwsIE5VTEwsDQo+ID4gKwkJCW10a192ZGVj X2Rydl9pZHNbaV0uY29tcGF0aWJsZSk7DQo+ID4gKwkJaWYgKCFjb21wX25vZGUpDQo+ID4gKwkJ CWNvbnRpbnVlOw0KPiA+ICsNCj4gPiArCQlpZiAoIW9mX2RldmljZV9pc19hdmFpbGFibGUoY29t cF9ub2RlKSkgew0KPiA+ICsJCQlvZl9ub2RlX3B1dChjb21wX25vZGUpOw0KPiA+ICsJCQlkZXZf ZXJyKCZwZGV2LT5kZXYsICJGYWlsIHRvIGdldCBNTVNZUyBub2RlXG4iKTsNCj4gPiArCQkJY29u dGludWU7DQo+ID4gKwkJfQ0KPiA+ICsNCj4gPiArCQlvZl9ub2RlX3B1dChjb21wX25vZGUpOw0K PiANCj4gSSB0aGluayB0aGlzIGxpbmUgc2hvdWxkIGNvbWUgYWZ0ZXIgdGhlIGxhc3QgdXNhZ2Ug b2YgY29tcF9ub2RlDQo+IA0KPiA+ICsJCW9mX2lkID0gb2ZfbWF0Y2hfbm9kZShtdGtfdmRlY19k cnZfaWRzLCBjb21wX25vZGUpOw0KPiANCj4gSSB0aGluayB0aGlzIG1pZ2h0IGJlIHJlZHVuZGVu dCBzaW5jZSBvZl9tYXRjaF9ub2RlIHdpbGwgcmV0dXJuICZtdGtfdmRlY19kcnZfaWRzW2ldDQo+ IFNvIEkgdGhpbmsgeW91IGNhbiBqdXN0IGRvOg0KPiBvZl9pZCA9ICZtdGtfdmRlY19kcnZfaWRz W2ldDQo+IA0KWW91IGFyZSByaWdodCwgZml4Lg0KPiA+ICsJCWlmICghb2ZfaWQpIHsNCj4gPiAr CQkJZGV2X2VycigmcGRldi0+ZGV2LCAiRmFpbGVkIHRvIGdldCBtYXRjaCBub2RlXG4iKTsNCj4g PiArCQkJcmV0dXJuIEVSUl9QVFIoLUVJTlZBTCk7DQo+ID4gKwkJPiArDQo+ID4gKwkJY29tcF9p ZHggPSAoZW51bSBtdGtfdmRlY19od19pZClvZl9pZC0+ZGF0YTsNCj4gPiArCQltdGtfdjRsMl9k ZWJ1Zyg0LCAiR2V0IGNvbXBvbmVudDpod19pZCglZCksdmRlY19kZXYoMHglcCksY29tcF9ub2Rl KDB4JXApXG4iLA0KPiA+ICsJCQljb21wX2lkeCwgdmRlY19kZXYsIGNvbXBfbm9kZSk7DQo+ID4g KwkJdmRlY19kZXYtPmNvbXBvbmVudF9ub2RlW2NvbXBfaWR4XSA9IGNvbXBfbm9kZTsNCj4gPiAr DQo+ID4gKwkJY29tcG9uZW50X21hdGNoX2FkZF9yZWxlYXNlKCZwZGV2LT5kZXYsICZtYXRjaCwg bXRrX3ZkZWNfcmVsZWFzZV9vZiwNCj4gPiArCQkJbXRrX3ZkZWNfY29tcGFyZV9vZiwgY29tcF9u b2RlKTsNCj4gPiArCX0NCj4gPiArDQo+ID4gKwlyZXR1cm4gbWF0Y2g7DQo+ID4gK30NCj4gPiAr DQo+ID4gICBzdGF0aWMgaXJxcmV0dXJuX3QgbXRrX3Zjb2RlY19kZWNfaXJxX2hhbmRsZXIoaW50 IGlycSwgdm9pZCAqcHJpdikNCj4gPiAgIHsNCj4gPiAgIAlzdHJ1Y3QgbXRrX3Zjb2RlY19kZXYg KmRldiA9IHByaXY7DQo+ID4gQEAgLTEwMyw2ICsxODIsNjYgQEAgc3RhdGljIGludCBtdGtfdmNv ZGVjX2dldF9yZWdfYmFzZXMoc3RydWN0IG10a192Y29kZWNfZGV2ICpkZXYpDQo+ID4gICAJcmV0 dXJuIHJldDsNCj4gPiAgIH0NCj4gPiAgIA0KPiA+ICtzdGF0aWMgaW50IG10a192Y29kZWNfaW5p dF9tYXN0ZXIoc3RydWN0IG10a192Y29kZWNfZGV2ICpkZXYpDQo+ID4gK3sNCj4gPiArCXN0cnVj dCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYgPSBkZXYtPnBsYXRfZGV2Ow0KPiA+ICsJc3RydWN0IGNv bXBvbmVudF9tYXRjaCAqbWF0Y2g7DQo+ID4gKwlpbnQgcmV0Ow0KPiA+ICsNCj4gPiArCW1hdGNo ID0gbXRrX3Zjb2RlY19tYXRjaF9hZGQoZGV2KTsNCj4gPiArCWlmIChJU19FUlJfT1JfTlVMTCht YXRjaCkpDQo+ID4gKwkJcmV0dXJuIC1FSU5WQUw7DQo+ID4gKw0KPiA+ICsJcGxhdGZvcm1fc2V0 X2RydmRhdGEocGRldiwgZGV2KTsNCj4gPiArCXJldCA9IGNvbXBvbmVudF9tYXN0ZXJfYWRkX3dp dGhfbWF0Y2goJnBkZXYtPmRldiwgJm10a192ZGVjX29wcywgbWF0Y2gpOw0KPiA+ICsJaWYgKHJl dCA8IDApDQo+ID4gKwkJcmV0dXJuIHJldDsNCj4gPiArDQo+ID4gKwlyZXR1cm4gMDsNCj4gPiAr fQ0KPiA+ICsNCj4gPiArc3RhdGljIGludCBtdGtfdmNvZGVjX2luaXRfZGVjX3BhcmFtcyhzdHJ1 Y3QgbXRrX3Zjb2RlY19kZXYgKmRldikNCj4gPiArew0KPiA+ICsJc3RydWN0IHBsYXRmb3JtX2Rl dmljZSAqcGRldiA9IGRldi0+cGxhdF9kZXY7DQo+ID4gKwlzdHJ1Y3QgcmVzb3VyY2UgKnJlczsN Cj4gPiArCWludCByZXQ7DQo+ID4gKw0KPiA+ICsJaWYgKCFkZXYtPmlzX3N1cHBvcnRfY29tcCkg ew0KPiA+ICsJCXJlcyA9IHBsYXRmb3JtX2dldF9yZXNvdXJjZShwZGV2LCBJT1JFU09VUkNFX0lS USwgMCk7DQo+IA0KPiBpcyB0aGUgY2FsbCB0byBwbGF0Zm9ybV9nZXRfcmVzb3VyY2UgbmVlZGVk PyByZXMgaXMgbm90IHVzZWQNCj4gDQpObyBuZWVkIHRvIHVzZS4NCj4gPiArCQlpZiAoIXJlcykg ew0KPiA+ICsJCQlkZXZfZXJyKCZwZGV2LT5kZXYsICJmYWlsZWQgdG8gZ2V0IGlycSByZXNvdXJj ZSIpOw0KPiA+ICsJCQlyZXR1cm4gLUVOT0VOVDsNCj4gPiArCQl9DQo+ID4gKw0KPiA+ICsJCWRl di0+ZGVjX2lycSA9IHBsYXRmb3JtX2dldF9pcnEoZGV2LT5wbGF0X2RldiwgMCk7DQo+IA0KPiB5 b3UgY2FuIGNoYW5nZSBkZXYtPnBsYXRfZGV2IHdpdGggcGRldg0KRml4Lg0KPiANCj4gPiArCQlp ZiAoZGV2LT5kZWNfaXJxIDwgMCkgew0KPiA+ICsJCQlkZXZfZXJyKCZwZGV2LT5kZXYsICJmYWls ZWQgdG8gZ2V0IGlycSBudW1iZXIiKTsNCj4gPiArCQkJcmV0dXJuIC1FSU5WQUw7DQo+IA0KPiBy ZXR1cm4gZGV2LT5kZWNfaXJxIGhlcmUgaW5zdGVhZCBvZiAtRUlOVkFMDQo+IA0KRml4Lg0KPiA+ ICsJCX0NCj4gPiArDQo+ID4gKwkJaXJxX3NldF9zdGF0dXNfZmxhZ3MoZGV2LT5kZWNfaXJxLCBJ UlFfTk9BVVRPRU4pOw0KPiA+ICsJCXJldCA9IGRldm1fcmVxdWVzdF9pcnEoJnBkZXYtPmRldiwg ZGV2LT5kZWNfaXJxLA0KPiA+ICsJCQkJbXRrX3Zjb2RlY19kZWNfaXJxX2hhbmRsZXIsIDAsIHBk ZXYtPm5hbWUsIGRldik7DQo+ID4gKwkJaWYgKHJldCkgew0KPiA+ICsJCQlkZXZfZXJyKCZwZGV2 LT5kZXYsICJmYWlsZWQgdG8gaW5zdGFsbCBkZXYtPmRlY19pcnEgJWQgKCVkKSIsDQo+ID4gKwkJ CQlkZXYtPmRlY19pcnEsIHJldCk7DQo+ID4gKwkJCXJldHVybiByZXQ7DQo+ID4gKwkJfQ0KPiA+ ICsNCj4gPiArCQlyZXQgPSBtdGtfdmNvZGVjX2luaXRfZGVjX3BtKGRldi0+cGxhdF9kZXYsICZk ZXYtPnBtKTsNCj4gDQo+IHlvdSBjYW4gY2hhbmdlIGRldi0+cGxhdF9kZXYgd2l0aCBwZGV2DQo+ IA0KPiA+ICsJCWlmIChyZXQgPCAwKSB7DQo+ID4gKwkJCWRldl9lcnIoJnBkZXYtPmRldiwgImZh aWxlZCB0byBnZXQgbXQgdmNvZGVjIGNsb2NrIHNvdXJjZSIpOw0KPiA+ICsJCQlyZXR1cm4gcmV0 Ow0KPiA+ICsJCX0NCj4gPiArCX0NCj4gPiArDQo+ID4gKwlyZXQgPSBtdGtfdmNvZGVjX2dldF9y ZWdfYmFzZXMoZGV2KTsNCj4gDQo+IHlvdSBjYW4gZG8gdGhpcyBjYWxsIGZpcnN0IGluIHRoZSBi ZWdpbm5pbmcgb2YgdGhlIGZ1bmN0aW9uLA0KPiB0aGVuIHlvdSBkb24ndCBuZWVkIHRvIHRlc3Qg IWRldi0+aXNfc3VwcG9ydF9jb21wIGluIG9yZGVyIHRvIHVuZG8gdGhlIHBtIGluaXRpYWxpemF0 aW9uDQo+IA0KWW91IGFyZSByaWdodCwgZml4Lg0KPiA+ICsJaWYgKHJldCAmJiAhZGV2LT5pc19z dXBwb3J0X2NvbXApDQo+ID4gKwkJbXRrX3Zjb2RlY19yZWxlYXNlX2RlY19wbSgmZGV2LT5wbSk7 DQo+ID4gKw0KPiANCj4gDQo+ID4gKwlyZXR1cm4gcmV0Ow0KPiA+ICt9DQo+ID4gKw0KPiA+ICAg c3RhdGljIGludCBmb3BzX3Zjb2RlY19vcGVuKHN0cnVjdCBmaWxlICpmaWxlKQ0KPiA+ICAgew0K PiA+ICAgCXN0cnVjdCBtdGtfdmNvZGVjX2RldiAqZGV2ID0gdmlkZW9fZHJ2ZGF0YShmaWxlKTsN Cj4gPiBAQCAtMjI4LDkgKzM2Nyw5IEBAIHN0YXRpYyBpbnQgbXRrX3Zjb2RlY19wcm9iZShzdHJ1 Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQ0KPiA+ICAgew0KPiA+ICAgCXN0cnVjdCBtdGtfdmNv ZGVjX2RldiAqZGV2Ow0KPiA+ICAgCXN0cnVjdCB2aWRlb19kZXZpY2UgKnZmZF9kZWM7DQo+ID4g LQlzdHJ1Y3QgcmVzb3VyY2UgKnJlczsNCj4gPiAgIAlwaGFuZGxlIHJwcm9jX3BoYW5kbGU7DQo+ ID4gICAJZW51bSBtdGtfdmNvZGVjX2Z3X3R5cGUgZndfdHlwZTsNCj4gPiArCXN0cnVjdCBkZXZp Y2Vfbm9kZSAqY29tcF9ub2RlOw0KPiA+ICAgCWludCByZXQ7DQo+ID4gICANCj4gPiAgIAlkZXYg PSBkZXZtX2t6YWxsb2MoJnBkZXYtPmRldiwgc2l6ZW9mKCpkZXYpLCBHRlBfS0VSTkVMKTsNCj4g PiBAQCAtMjU3LDMxICszOTYsMTcgQEAgc3RhdGljIGludCBtdGtfdmNvZGVjX3Byb2JlKHN0cnVj dCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpDQo+ID4gICAJaWYgKElTX0VSUihkZXYtPmZ3X2hhbmRs ZXIpKQ0KPiA+ICAgCQlyZXR1cm4gUFRSX0VSUihkZXYtPmZ3X2hhbmRsZXIpOw0KPiA+ICAgDQo+ ID4gLQlyZXQgPSBtdGtfdmNvZGVjX2luaXRfZGVjX3BtKGRldi0+cGxhdF9kZXYsICZkZXYtPnBt KTsNCj4gPiAtCWlmIChyZXQgPCAwKSB7DQo+ID4gLQkJZGV2X2VycigmcGRldi0+ZGV2LCAiRmFp bGVkIHRvIGdldCBtdCB2Y29kZWMgY2xvY2sgc291cmNlIik7DQo+ID4gLQkJZ290byBlcnJfZGVj X3BtOw0KPiA+IC0JfQ0KPiA+IC0NCj4gPiAtCXJldCA9IG10a192Y29kZWNfZ2V0X3JlZ19iYXNl cyhkZXYpOw0KPiA+IC0JaWYgKHJldCkNCj4gPiAtCQlnb3RvIGVycl9yZXM7DQo+ID4gKwljb21w X25vZGUgPQ0KPiA+ICsJCW9mX2ZpbmRfY29tcGF0aWJsZV9ub2RlKE5VTEwsIE5VTEwsICJtZWRp YXRlayxtdGstdmNvZGVjLWNvcmUiKTsNCj4gPiArCWlmICghY29tcF9ub2RlKQ0KPiA+ICsJCWRl di0+aXNfc3VwcG9ydF9jb21wID0gZmFsc2U7DQo+ID4gKwllbHNlDQo+ID4gKwkJZGV2LT5pc19z dXBwb3J0X2NvbXAgPSB0cnVlOw0KPiA+ICsJb2Zfbm9kZV9wdXQoY29tcF9ub2RlKTsNCj4gPiAg IA0KPiA+IC0JcmVzID0gcGxhdGZvcm1fZ2V0X3Jlc291cmNlKHBkZXYsIElPUkVTT1VSQ0VfSVJR LCAwKTsNCj4gPiAtCWlmIChyZXMgPT0gTlVMTCkgew0KPiA+IC0JCWRldl9lcnIoJnBkZXYtPmRl diwgImZhaWxlZCB0byBnZXQgaXJxIHJlc291cmNlIik7DQo+ID4gLQkJcmV0ID0gLUVOT0VOVDsN Cj4gPiAtCQlnb3RvIGVycl9yZXM7DQo+ID4gLQl9DQo+ID4gLQ0KPiA+IC0JZGV2LT5kZWNfaXJx ID0gcGxhdGZvcm1fZ2V0X2lycShwZGV2LCAwKTsNCj4gPiAtCWlycV9zZXRfc3RhdHVzX2ZsYWdz KGRldi0+ZGVjX2lycSwgSVJRX05PQVVUT0VOKTsNCj4gPiAtCXJldCA9IGRldm1fcmVxdWVzdF9p cnEoJnBkZXYtPmRldiwgZGV2LT5kZWNfaXJxLA0KPiA+IC0JCQltdGtfdmNvZGVjX2RlY19pcnFf aGFuZGxlciwgMCwgcGRldi0+bmFtZSwgZGV2KTsNCj4gPiAtCWlmIChyZXQpIHsNCj4gPiAtCQlk ZXZfZXJyKCZwZGV2LT5kZXYsICJGYWlsZWQgdG8gaW5zdGFsbCBkZXYtPmRlY19pcnEgJWQgKCVk KSIsDQo+ID4gLQkJCWRldi0+ZGVjX2lycSwNCj4gPiAtCQkJcmV0KTsNCj4gPiArCWlmIChtdGtf dmNvZGVjX2luaXRfZGVjX3BhcmFtcyhkZXYpKSB7DQo+ID4gKwkJZGV2X2VycigmcGRldi0+ZGV2 LCAiRmFpbGVkIHRvIGluaXQgcG0gYW5kIHJlZ2lzdGVycyIpOw0KPiA+ICsJCXJldCA9IC1FSU5W QUw7DQo+IA0KPiByZXQgc291bGQgYmUgdGhlIHJldHVybiB2YWx1ZSBvZiBtdGtfdmNvZGVjX2lu aXRfZGVjX3BhcmFtcw0KPiANCj4gPiAgIAkJZ290byBlcnJfcmVzOw0KPiA+ICAgCX0NCj4gPiAg IA0KPiA+IEBAIC0zMTksNyArNDQ0LDYgQEAgc3RhdGljIGludCBtdGtfdmNvZGVjX3Byb2JlKHN0 cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpDQo+ID4gICAJCU1US19WQ09ERUNfREVDX05BTUUp Ow0KPiA+ICAgCXZpZGVvX3NldF9kcnZkYXRhKHZmZF9kZWMsIGRldik7DQo+ID4gICAJZGV2LT52 ZmRfZGVjID0gdmZkX2RlYzsNCj4gPiAtCXBsYXRmb3JtX3NldF9kcnZkYXRhKHBkZXYsIGRldik7 PiAgIA0KPiA+ICAgCWRldi0+bTJtX2Rldl9kZWMgPSB2NGwyX20ybV9pbml0KCZtdGtfdmRlY19t Mm1fb3BzKTsNCj4gPiAgIAlpZiAoSVNfRVJSKChfX2ZvcmNlIHZvaWQgKilkZXYtPm0ybV9kZXZf ZGVjKSkgew0KPiA+IEBAIC0zNzAsOCArNDk0LDE3IEBAIHN0YXRpYyBpbnQgbXRrX3Zjb2RlY19w cm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQ0KPiA+ICAgCW10a192NGwyX2RlYnVn KDAsICJkZWNvZGVyIHJlZ2lzdGVyZWQgYXMgL2Rldi92aWRlbyVkIiwNCj4gPiAgIAkJdmZkX2Rl Yy0+bnVtKTsNCj4gPiAgIA0KPiA+IC0JcmV0dXJuIDA7DQo+ID4gKwlpZiAoZGV2LT5pc19zdXBw b3J0X2NvbXApIHsNCj4gPiArCQlyZXQgPSBtdGtfdmNvZGVjX2luaXRfbWFzdGVyKGRldik7DQo+ ID4gKwkJaWYgKHJldCA8IDApDQo+ID4gKwkJCWdvdG8gZXJyX2NvbXBvbmVudF9tYXRjaDsNCj4g PiArCX0gZWxzZSB7DQo+ID4gKwkJcGxhdGZvcm1fc2V0X2RydmRhdGEocGRldiwgZGV2KTsNCj4g DQo+IHdoeSBkbyB0aGF0IG9ubHkgaWYgY29tcG9uZW50cyBhcmUgbm90IHN1cHBvcnRlZD8NCj4g DQpXaWxsIGNhbGwgcGxhdGZvcm1fc2V0X2RydmRhdGEgaW4gbXRrX3Zjb2RlY19pbml0X21hc3Rl ciBmb3IgY29tcG9uZW50Lg0KY29tcG9uZW50X21hc3Rlcl9hZGRfd2l0aF9tYXRjaCBzaG91bGQg YmUgYWZ0ZXIgcGxhdGZvcm1fc2V0X2RydmRhdGEgZm9yDQpjb21wb25lbnQgYXJjaC4NCj4gPiAr CX0NCj4gPiAgIA0KPiA+ICsJcmV0dXJuIDA7DQo+ID4gK2Vycl9jb21wb25lbnRfbWF0Y2g6DQo+ ID4gKwl2aWRlb191bnJlZ2lzdGVyX2RldmljZSh2ZmRfZGVjKTsNCj4gPiAgIGVycl9kZWNfcmVn Og0KPiA+ICAgCWlmIChkZXYtPnZkZWNfcGRhdGEtPnVzZXNfc3RhdGVsZXNzX2FwaSkNCj4gPiAg IAkJbWVkaWFfZGV2aWNlX3VucmVnaXN0ZXIoJmRldi0+bWRldl9kZWMpOw0KPiA+IEBAIC0zODcs OSArNTIwLDggQEAgc3RhdGljIGludCBtdGtfdmNvZGVjX3Byb2JlKHN0cnVjdCBwbGF0Zm9ybV9k ZXZpY2UgKnBkZXYpDQo+ID4gICBlcnJfZGVjX2FsbG9jOg0KPiA+ICAgCXY0bDJfZGV2aWNlX3Vu cmVnaXN0ZXIoJmRldi0+djRsMl9kZXYpOw0KPiA+ICAgZXJyX3JlczoNCj4gPiAtCW10a192Y29k ZWNfcmVsZWFzZV9kZWNfcG0oJmRldi0+cG0pOw0KPiA+IC1lcnJfZGVjX3BtOg0KPiA+ICAgCW10 a192Y29kZWNfZndfcmVsZWFzZShkZXYtPmZ3X2hhbmRsZXIpOw0KPiA+ICsNCj4gPiAgIAlyZXR1 cm4gcmV0Ow0KPiA+ICAgfQ0KPiA+ICAgDQo+ID4gQEAgLTQ0NCw3ICs1NzYsMjUgQEAgc3RhdGlj IHN0cnVjdCBwbGF0Zm9ybV9kcml2ZXIgbXRrX3Zjb2RlY19kZWNfZHJpdmVyID0gew0KPiA+ICAg CX0sDQo+ID4gICB9Ow0KPiA+ICAgDQo+ID4gLW1vZHVsZV9wbGF0Zm9ybV9kcml2ZXIobXRrX3Zj b2RlY19kZWNfZHJpdmVyKTsNCj4gPiArc3RhdGljIHN0cnVjdCBwbGF0Zm9ybV9kcml2ZXIgKiBj b25zdCBtdGtfdmRlY19kcml2ZXJzW10gPSB7DQo+ID4gKwkmbXRrX3ZkZWNfY29tcF9kcml2ZXIs DQo+ID4gKwkmbXRrX3Zjb2RlY19kZWNfZHJpdmVyLA0KPiA+ICt9Ow0KPiA+ICsNCj4gPiArc3Rh dGljIGludCBfX2luaXQgbXRrX3ZkZWNfaW5pdCh2b2lkKQ0KPiA+ICt7DQo+ID4gKwlyZXR1cm4g cGxhdGZvcm1fcmVnaXN0ZXJfZHJpdmVycyhtdGtfdmRlY19kcml2ZXJzLA0KPiA+ICsJCQkJCSBB UlJBWV9TSVpFKG10a192ZGVjX2RyaXZlcnMpKTsNCj4gPiArfQ0KPiA+ICsNCj4gPiArc3RhdGlj IHZvaWQgX19leGl0IG10a192ZGVjX2V4aXQodm9pZCkNCj4gPiArew0KPiA+ICsJcGxhdGZvcm1f dW5yZWdpc3Rlcl9kcml2ZXJzKG10a192ZGVjX2RyaXZlcnMsDQo+ID4gKwkJCQkgICAgQVJSQVlf U0laRShtdGtfdmRlY19kcml2ZXJzKSk7DQo+ID4gK30NCj4gPiArDQo+ID4gK21vZHVsZV9pbml0 KG10a192ZGVjX2luaXQpOw0KPiA+ICttb2R1bGVfZXhpdChtdGtfdmRlY19leGl0KTsNCj4gPiAg IA0KPiA+ICAgTU9EVUxFX0xJQ0VOU0UoIkdQTCB2MiIpOw0KPiA+ICAgTU9EVUxFX0RFU0NSSVBU SU9OKCJNZWRpYXRlayB2aWRlbyBjb2RlYyBWNEwyIGRlY29kZXIgZHJpdmVyIik7DQo+ID4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvbWVkaWEvcGxhdGZvcm0vbXRrLXZjb2RlYy9tdGtfdmNvZGVjX2Rl Y19ody5jIGIvZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS9tdGstdmNvZGVjL210a192Y29kZWNfZGVj X2h3LmMNCj4gPiBuZXcgZmlsZSBtb2RlIDEwMDY0NA0KPiA+IGluZGV4IDAwMDAwMDAwMDAwMC4u ZWE2ZDI4OWQ5NzczDQo+ID4gLS0tIC9kZXYvbnVsbA0KPiA+ICsrKyBiL2RyaXZlcnMvbWVkaWEv cGxhdGZvcm0vbXRrLXZjb2RlYy9tdGtfdmNvZGVjX2RlY19ody5jDQo+ID4gQEAgLTAsMCArMSwx OTMgQEANCj4gPiArLy8gU1BEWC1MaWNlbnNlLUlkZW50aWZpZXI6IEdQTC0yLjANCj4gPiArLyoN Cj4gPiArICogQ29weXJpZ2h0IChjKSAyMDIxIE1lZGlhVGVrIEluYy4NCj4gPiArICogQXV0aG9y OiBZdW5mZWkgRG9uZyA8eXVuZmVpLmRvbmdAbWVkaWF0ZWsuY29tPg0KPiA+ICsgKi8NCj4gPiAr DQo+ID4gKyNpbmNsdWRlIDxsaW51eC9jb21wb25lbnQuaD4NCj4gPiArI2luY2x1ZGUgPGxpbnV4 L2ludGVycnVwdC5oPg0KPiA+ICsjaW5jbHVkZSA8bGludXgvaXJxLmg+DQo+ID4gKyNpbmNsdWRl IDxsaW51eC9tb2R1bGUuaD4NCj4gPiArI2luY2x1ZGUgPGxpbnV4L29mLmg+DQo+ID4gKyNpbmNs dWRlIDxsaW51eC9vZl9kZXZpY2UuaD4NCj4gPiArI2luY2x1ZGUgPGxpbnV4L3NsYWIuaD4NCj4g PiArDQo+ID4gKyNpbmNsdWRlICJtdGtfdmNvZGVjX2Rydi5oIg0KPiA+ICsjaW5jbHVkZSAibXRr X3Zjb2RlY19kZWMuaCINCj4gPiArI2luY2x1ZGUgIm10a192Y29kZWNfZGVjX2h3LmgiDQo+ID4g KyNpbmNsdWRlICJtdGtfdmNvZGVjX2RlY19wbS5oIg0KPiA+ICsjaW5jbHVkZSAibXRrX3Zjb2Rl Y19pbnRyLmgiDQo+ID4gKyNpbmNsdWRlICJtdGtfdmNvZGVjX3V0aWwuaCINCj4gPiArDQo+ID4g K3N0YXRpYyBpbnQgbXRrX3ZkZWNfY29tcF9iaW5kKHN0cnVjdCBkZXZpY2UgKmRldiwgc3RydWN0 IGRldmljZSAqbWFzdGVyLA0KPiA+ICsJdm9pZCAqZGF0YSkNCj4gPiArew0KPiA+ICsJc3RydWN0 IG10a192ZGVjX2NvbXBfZGV2ICpjb21wX2RldiA9IGRldl9nZXRfZHJ2ZGF0YShkZXYpOw0KPiA+ ICsJc3RydWN0IG10a192Y29kZWNfZGV2ICptYXN0ZXJfZGV2ID0gZGF0YTsNCj4gPiArCWludCBp Ow0KPiA+ICsNCj4gPiArCWZvciAoaSA9IDA7IGkgPCBNVEtfVkRFQ19IV19NQVg7IGkrKykgew0K PiA+ICsJCWlmIChkZXYtPm9mX25vZGUgIT0gbWFzdGVyX2Rldi0+Y29tcG9uZW50X25vZGVbaV0p DQo+ID4gKwkJCWNvbnRpbnVlOw0KPiA+ICsNCj4gPiArCQltYXN0ZXJfZGV2LT5jb21wX2Rldltp XSA9IGNvbXBfZGV2Ow0KPiA+ICsJCWNvbXBfZGV2LT5jb21wX2lkeCA9IGk7DQo+ID4gKwkJY29t cF9kZXYtPm1hc3Rlcl9kZXYgPSBtYXN0ZXJfZGV2Ow0KPiA+ICsJCWJyZWFrOw0KPiA+ICsJfQ0K PiA+ICsNCj4gPiArCWlmIChpID09IE1US19WREVDX0hXX01BWCkgew0KPiA+ICsJCWRldl9lcnIo ZGV2LCAiRmFpbGVkIHRvIGdldCBjb21wb25lbnQgbm9kZVxuIik7DQo+ID4gKwkJcmV0dXJuIC1F SU5WQUw7DQo+ID4gKwl9DQo+ID4gKw0KPiA+ICsJY29tcF9kZXYtPnJlZ19iYXNlW1ZERUNfQ09N UF9TWVNdID0NCj4gPiArCQltYXN0ZXJfZGV2LT5yZWdfYmFzZVtWREVDX0NPTVBfU1lTXTsNCj4g PiArCXJldHVybiAwOw0KPiA+ICt9DQo+ID4gKw0KPiA+ICtzdGF0aWMgdm9pZCBtdGtfdmRlY19j b21wX3VuYmluZChzdHJ1Y3QgZGV2aWNlICpkZXYsIHN0cnVjdCBkZXZpY2UgKm1hc3RlciwNCj4g PiArCXZvaWQgKmRhdGEpDQo+ID4gK3sNCj4gPiArCXN0cnVjdCBtdGtfdmRlY19jb21wX2RldiAq Y29tcF9kZXYgPSBkZXZfZ2V0X2RydmRhdGEoZGV2KTsNCj4gPiArDQo+ID4gKwljb21wX2Rldi0+ cmVnX2Jhc2VbVkRFQ19DT01QX1NZU10gPSBOVUxMOw0KPiA+ICt9DQo+ID4gKw0KPiA+ICtzdGF0 aWMgY29uc3Qgc3RydWN0IGNvbXBvbmVudF9vcHMgbXRrX3ZkZWNfaHdfY29tcG9uZW50X29wcyA9 IHsNCj4gPiArCS5iaW5kID0gbXRrX3ZkZWNfY29tcF9iaW5kLA0KPiA+ICsJLnVuYmluZCA9IG10 a192ZGVjX2NvbXBfdW5iaW5kLA0KPiA+ICt9Ow0KPiA+ICsNCj4gPiArLyogV2FrZSB1cCBjb250 ZXh0IHdhaXRfcXVldWUgKi8NCj4gPiArc3RhdGljIHZvaWQgbXRrX3ZkZWNfY29tcF93YWtlX3Vw X2N0eChzdHJ1Y3QgbXRrX3Zjb2RlY19jdHggKmN0eCkNCj4gPiArew0KPiA+ICsJY3R4LT5pbnRf Y29uZCA9IDE7DQo+ID4gKwl3YWtlX3VwX2ludGVycnVwdGlibGUoJmN0eC0+cXVldWUpOw0KPiA+ ICt9DQo+IA0KPiBUaGlzIGZ1bmN0aW9uIGlzIGlkZW50aWNhbCB0byB0aGUgZnVuY3Rpb24gJ3dh a2VfdXBfY3R4JyBzbyB5b3Ugc2hvdWxkDQo+IHByb2FibHkgbm90IGR1cGxpY2F0ZSBpdC4NCj4g DQpBbGlnbiB2ZGVjIGFuZCB2ZW5jIHdha2UgdXAgY3R4IGludGVyZmFjZS4NCj4gPiArDQo+ID4g K3N0YXRpYyBpcnFyZXR1cm5fdCBtdGtfdmRlY19jb21wX2lycV9oYW5kbGVyKGludCBpcnEsIHZv aWQgKnByaXYpDQo+ID4gK3sNCj4gPiArCXN0cnVjdCBtdGtfdmRlY19jb21wX2RldiAqZGV2ID0g cHJpdjsNCj4gPiArCXN0cnVjdCBtdGtfdmNvZGVjX2N0eCAqY3R4Ow0KPiA+ICsJdTMyIGNnX3N0 YXR1czsNCj4gPiArCXVuc2lnbmVkIGludCBkZWNfZG9uZV9zdGF0dXM7DQo+ID4gKwl2b2lkIF9f aW9tZW0gKnZkZWNfbWlzY19hZGRyID0gZGV2LT5yZWdfYmFzZVtWREVDX0NPTVBfTUlTQ10gKw0K PiA+ICsJCQkJCVZERUNfSVJRX0NGR19SRUc7DQo+ID4gKw0KPiA+ICsJY3R4ID0gbXRrX3Zjb2Rl Y19nZXRfY3Vycl9jdHgoZGV2LT5tYXN0ZXJfZGV2KTsNCj4gPiArDQo+ID4gKwkvKiBjaGVjayBp ZiBIVyBhY3RpdmUgb3Igbm90ICovDQo+ID4gKwljZ19zdGF0dXMgPSByZWFkbChkZXYtPnJlZ19i YXNlW1ZERUNfQ09NUF9TWVNdKTsNCj4gPiArCWlmICgoY2dfc3RhdHVzICYgVkRFQ19IV19BQ1RJ VkUpICE9IDApIHsNCj4gPiArCQltdGtfdjRsMl9lcnIoInZkZWMgYWN0aXZlIGlzIG5vdCAweDAg KDB4JTA4eCkiLA0KPiA+ICsJCQljZ19zdGF0dXMpOw0KPiA+ICsJCXJldHVybiBJUlFfSEFORExF RDsNCj4gPiArCX0NCj4gPiArDQo+ID4gKwlkZWNfZG9uZV9zdGF0dXMgPSByZWFkbCh2ZGVjX21p c2NfYWRkcik7DQo+ID4gKwlpZiAoKGRlY19kb25lX3N0YXR1cyAmIE1US19WREVDX0lSUV9TVEFU VVNfREVDX1NVQ0NFU1MpICE9DQo+ID4gKwkJTVRLX1ZERUNfSVJRX1NUQVRVU19ERUNfU1VDQ0VT UykNCj4gPiArCQlyZXR1cm4gSVJRX0hBTkRMRUQ7DQo+ID4gKw0KPiA+ICsJLyogY2xlYXIgaW50 ZXJydXB0ICovDQo+ID4gKwl3cml0ZWwocmVhZGwodmRlY19taXNjX2FkZHIpIHwgVkRFQ19JUlFf Q0ZHLCB2ZGVjX21pc2NfYWRkcik7DQo+ID4gKwl3cml0ZWwocmVhZGwodmRlY19taXNjX2FkZHIp ICYgflZERUNfSVJRX0NMUiwgdmRlY19taXNjX2FkZHIpOw0KPiANCj4gY291bGQgdGhlc2UgdHdv IHdyaXRlbCBiZSBjb21iaW5lZCBpbnRvIG9uZSB3cml0ZWw/DQo+IGFuZCBjb3VsZCB0aGUgY2Fs bHMgJ3JlYWRsKHZkZWNfbWlzY19hZGRyKScgYmUgcmVwbGFjZWQgd2l0aCAnZGVjX2RvbmVfc3Rh dHVzJz8NCj4gDQpGaXguDQo+ID4gKw0KPiA+ICsJbXRrX3ZkZWNfY29tcF93YWtlX3VwX2N0eChj dHgpOw0KPiA+ICsNCj4gPiArCW10a192NGwyX2RlYnVnKDMsICJ3YWtlIHVwIGN0eCAlZCwgZGVj X2RvbmVfc3RhdHVzPSV4IiwNCj4gPiArCQljdHgtPmlkLCBkZWNfZG9uZV9zdGF0dXMpOw0KPiA+ ICsNCj4gPiArCXJldHVybiBJUlFfSEFORExFRDsNCj4gPiArfQ0KPiA+ICsNCj4gPiArc3RhdGlj IGludCBtdGtfdmRlY19jb21wX2luaXRfaXJxKHN0cnVjdCBtdGtfdmRlY19jb21wX2RldiAqZGV2 KQ0KPiA+ICt7DQo+ID4gKwlzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2ID0gZGV2LT5wbGF0 X2RldjsNCj4gPiArCWludCByZXQ7DQo+ID4gKw0KPiA+ICsJZGV2LT5kZWNfaXJxID0gcGxhdGZv cm1fZ2V0X2lycShwZGV2LCAwKTsNCj4gPiArCWlmIChkZXYtPmRlY19pcnEgPCAwKSB7DQo+ID4g KwkJZGV2X2VycigmcGRldi0+ZGV2LCAiRmFpbGVkIHRvIGdldCBpcnEgcmVzb3VyY2UiKTsNCj4g PiArCQlyZXR1cm4gZGV2LT5kZWNfaXJxOw0KPiA+ICsJfQ0KPiA+ICsNCj4gPiArCXJldCA9IGRl dm1fcmVxdWVzdF9pcnEoJnBkZXYtPmRldiwgZGV2LT5kZWNfaXJxLA0KPiA+ICsJCQkJbXRrX3Zk ZWNfY29tcF9pcnFfaGFuZGxlciwgMCwgcGRldi0+bmFtZSwgZGV2KTsNCj4gPiArCWlmIChyZXQp IHsNCj4gPiArCQlkZXZfZXJyKCZwZGV2LT5kZXYsICJGYWlsZWQgdG8gaW5zdGFsbCBkZXYtPmRl Y19pcnEgJWQgKCVkKSIsDQo+ID4gKwkJCWRldi0+ZGVjX2lycSwgcmV0KTsNCj4gPiArCQlyZXR1 cm4gLUVOT0VOVDsNCj4gDQo+IHNob3VsZCByZXR1cm4gJ3JldCcgaGVyZQ0KPiANCj4gPiArCX0N Cj4gPiArDQo+ID4gKwlkaXNhYmxlX2lycShkZXYtPmRlY19pcnEpOw0KPiANCj4gc2hvdWxkIHRo aXMgYmUgcmVwbGFjZWQgd2l0aDoNCj4gDQo+IGlycV9zZXRfc3RhdHVzX2ZsYWdzKGRldi0+ZGVj X2lycSwgSVJRX05PQVVUT0VOKTsNCj4gDQo+ID8NCj4gDQpTaG91bGQgY2FsbCB0aGlzIGludGVy ZmFjZSwgZml4IGl0Lg0KPiA+ICsJcmV0dXJuIDA7DQo+ID4gK30NCj4gPiArDQo+ID4gK3N0YXRp YyBpbnQgbXRrX3ZkZWNfY29tcF9wcm9iZShzdHJ1Y3QgcGxhdGZvcm1fZGV2aWNlICpwZGV2KQ0K PiA+ICt7DQo+ID4gKwlzdHJ1Y3QgbXRrX3ZkZWNfY29tcF9kZXYgKmRldjsNCj4gPiArCWludCBy ZXQ7DQo+ID4gKw0KPiA+ICsJZGV2ID0gZGV2bV9remFsbG9jKCZwZGV2LT5kZXYsIHNpemVvZigq ZGV2KSwgR0ZQX0tFUk5FTCk7DQo+ID4gKwlpZiAoIWRldikNCj4gPiArCQlyZXR1cm4gLUVOT01F TTsNCj4gPiArDQo+ID4gKwlkZXYtPnBsYXRfZGV2ID0gcGRldjsNCj4gPiArCXNwaW5fbG9ja19p bml0KCZkZXYtPmlycWxvY2spOw0KPiANCj4gSSBkb24ndCBzZWUgd2hlcmUgdGhpcyBsb2NrIGlz IHVzZWQNCj4gDQo+ID4gKw0KPiA+ICsJcmV0ID0gbXRrX3Zjb2RlY19pbml0X2RlY19wbShwZGV2 LCAmZGV2LT5wbSk7DQo+ID4gKwlpZiAocmV0KSB7DQo+ID4gKwkJZGV2X2VycigmcGRldi0+ZGV2 LCAiRmFpbGVkIHRvIGdldCBtdCB2Y29kZWMgY2xvY2sgc291cmNlIik7DQo+ID4gKwkJcmV0dXJu IHJldDsNCj4gPiArCX0NCj4gPiArDQo+ID4gKwlkZXYtPnJlZ19iYXNlW1ZERUNfQ09NUF9NSVND XSA9DQo+ID4gKwkJZGV2bV9wbGF0Zm9ybV9pb3JlbWFwX3Jlc291cmNlKHBkZXYsIDApOw0KPiA+ ICsJaWYgKElTX0VSUigoX19mb3JjZSB2b2lkICopZGV2LT5yZWdfYmFzZVtWREVDX0NPTVBfTUlT Q10pKSB7DQo+ID4gKwkJcmV0ID0gUFRSX0VSUigoX19mb3JjZSB2b2lkICopZGV2LT5yZWdfYmFz ZVtWREVDX0NPTVBfTUlTQ10pOw0KPiA+ICsJCWdvdG8gZXJyOw0KPiA+ICsJfQ0KPiA+ICsNCj4g PiArCWlmIChvZl9nZXRfcHJvcGVydHkocGRldi0+ZGV2Lm9mX25vZGUsICJkbWEtcmFuZ2VzIiwg TlVMTCkpDQo+ID4gKwkJZG1hX3NldF9tYXNrX2FuZF9jb2hlcmVudCgmcGRldi0+ZGV2LCBETUFf QklUX01BU0soMzQpKTsNCj4gPiArDQo+ID4gKwlyZXQgPSBtdGtfdmRlY19jb21wX2luaXRfaXJx KGRldik7DQo+ID4gKwlpZiAocmV0KSB7DQo+ID4gKwkJZGV2X2VycigmcGRldi0+ZGV2LCAiRmFp bGVkIHRvIHJlZ2lzdGVyIGlycSBoYW5kbGVyLlxuIik7DQo+ID4gKwkJZ290byBlcnI7DQo+ID4g Kwl9DQo+ID4gKw0KPiA+ICsJcGxhdGZvcm1fc2V0X2RydmRhdGEocGRldiwgZGV2KTsNCj4gPiAr DQo+ID4gKwlyZXQgPSBjb21wb25lbnRfYWRkKCZwZGV2LT5kZXYsICZtdGtfdmRlY19od19jb21w b25lbnRfb3BzKTsNCj4gPiArCWlmIChyZXQpIHsNCj4gPiArCQlkZXZfZXJyKCZwZGV2LT5kZXYs ICJGYWlsZWQgdG8gYWRkIGNvbXBvbmVudDogJWRcbiIsIHJldCk7DQo+ID4gKwkJZ290byBlcnI7 DQo+ID4gKwl9DQo+ID4gKw0KPiA+ICsJcmV0dXJuIDA7DQo+ID4gK2VycjoNCj4gPiArCW10a192 Y29kZWNfcmVsZWFzZV9kZWNfcG0oJmRldi0+cG0pOw0KPiA+ICsJcmV0dXJuIHJldDsNCj4gPiAr fQ0KPiA+ICsNCj4gPiArc3RhdGljIGNvbnN0IHN0cnVjdCBvZl9kZXZpY2VfaWQgbXRrX3ZkZWNf Y29tcF9pZHNbXSA9IHsNCj4gPiArCXsNCj4gPiArCQkuY29tcGF0aWJsZSA9ICJtZWRpYXRlayxt dGstdmNvZGVjLWxhdCIsDQo+ID4gKwl9LA0KPiA+ICsJew0KPiA+ICsJCS5jb21wYXRpYmxlID0g Im1lZGlhdGVrLG10ay12Y29kZWMtY29yZSIsDQo+ID4gKwl9LA0KPiA+ICsJe30sDQo+ID4gK307 DQo+ID4gK01PRFVMRV9ERVZJQ0VfVEFCTEUob2YsIG10a192ZGVjX2NvbXBfaWRzKTsNCj4gPiAr DQo+ID4gK3N0cnVjdCBwbGF0Zm9ybV9kcml2ZXIgbXRrX3ZkZWNfY29tcF9kcml2ZXIgPSB7DQo+ ID4gKwkucHJvYmUJPSBtdGtfdmRlY19jb21wX3Byb2JlLA0KPiA+ICsJLmRyaXZlcgk9IHsNCj4g PiArCQkubmFtZQk9ICJtdGstdmRlYy1jb21wIiwNCj4gPiArCQkub2ZfbWF0Y2hfdGFibGUgPSBt dGtfdmRlY19jb21wX2lkcywNCj4gPiArCX0sDQo+ID4gK307DQo+ID4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvbWVkaWEvcGxhdGZvcm0vbXRrLXZjb2RlYy9tdGtfdmNvZGVjX2RlY19ody5oIGIvZHJp dmVycy9tZWRpYS9wbGF0Zm9ybS9tdGstdmNvZGVjL210a192Y29kZWNfZGVjX2h3LmgNCj4gPiBu ZXcgZmlsZSBtb2RlIDEwMDY0NA0KPiA+IGluZGV4IDAwMDAwMDAwMDAwMC4uNTE0ZTNmZDE5MGQx DQo+ID4gLS0tIC9kZXYvbnVsbA0KPiA+ICsrKyBiL2RyaXZlcnMvbWVkaWEvcGxhdGZvcm0vbXRr LXZjb2RlYy9tdGtfdmNvZGVjX2RlY19ody5oDQo+ID4gQEAgLTAsMCArMSw0NiBAQA0KPiA+ICsv LyBTUERYLUxpY2Vuc2UtSWRlbnRpZmllcjogR1BMLTIuMA0KPiA+ICsvKg0KPiA+ICsgKiBDb3B5 cmlnaHQgKGMpIDIwMjEgTWVkaWFUZWsgSW5jLg0KPiA+ICsgKiBBdXRob3I6IFl1bmZlaSBEb25n IDx5dW5mZWkuZG9uZ0BtZWRpYXRlay5jb20+DQo+ID4gKyAqLw0KPiA+ICsNCj4gPiArI2lmbmRl ZiBfTVRLX1ZDT0RFQ19ERUNfSFdfSF8NCj4gPiArI2RlZmluZSBfTVRLX1ZDT0RFQ19ERUNfSFdf SF8NCj4gPiArDQo+ID4gKyNpbmNsdWRlIDxsaW51eC9pby5oPg0KPiA+ICsjaW5jbHVkZSA8bGlu dXgvcGxhdGZvcm1fZGV2aWNlLmg+DQo+ID4gKw0KPiA+ICsjaW5jbHVkZSAibXRrX3Zjb2RlY19k cnYuaCINCj4gPiArDQo+ID4gKy8qKg0KPiA+ICsgKiBlbnVtIG10a19jb21wX2h3X3JlZ19pZHgg LSBjb21wb25lbnQgcmVnaXN0ZXIgYmFzZSBpbmRleA0KPiA+ICsgKi8NCj4gPiArZW51bSBtdGtf Y29tcF9od19yZWdfaWR4IHsNCj4gPiArCVZERUNfQ09NUF9TWVMsDQo+ID4gKwlWREVDX0NPTVBf TUlTQywNCj4gPiArCVZERUNfQ09NUF9NQVgNCj4gPiArfTsNCj4gPiArDQo+ID4gKy8qKg0KPiA+ ICsgKiBzdHJ1Y3QgbXRrX3ZkZWNfY29tcF9kZXYgLSBjb21wb25lbnQgZnJhbXdvcmsgZHJpdmVy IGRhdGENCj4gPiArICogQHBsYXRfZGV2OiBwbGF0Zm9ybSBkZXZpY2UNCj4gPiArICogQG1hc3Rl cl9kZXY6IG1hc3RlciBkZXZpY2UNCj4gPiArICogQGlycWxvY2s6IHByb3RlY3QgZGF0YSBhY2Nl c3MgYnkgaXJxIGhhbmRsZXIgYW5kIHdvcmsgdGhyZWFkDQo+ID4gKyAqIEByZWdfYmFzZTogTWFw cGVkIGFkZHJlc3Mgb2YgTVRLIFZjb2RlYyByZWdpc3RlcnMuDQo+ID4gKyAqDQo+ID4gKyAqIEBk ZWNfaXJxOiBkZWNvZGVyIGlycSByZXNvdXJjZQ0KPiA+ICsgKiBAcG06IHBvd2VyIG1hbmFnZW1l bnQgY29udHJvbA0KPiA+ICsgKiBAY29tcF9pZHg6IGNvbXBvbmVudCBpbmRleA0KPiA+ICsgKi8N Cj4gPiArc3RydWN0IG10a192ZGVjX2NvbXBfZGV2IHsNCj4gPiArCXN0cnVjdCBwbGF0Zm9ybV9k ZXZpY2UgKnBsYXRfZGV2Ow0KPiA+ICsJc3RydWN0IG10a192Y29kZWNfZGV2ICptYXN0ZXJfZGV2 Ow0KPiA+ICsJc3BpbmxvY2tfdCBpcnFsb2NrOw0KPiA+ICsJdm9pZCBfX2lvbWVtICpyZWdfYmFz ZVtWREVDX0NPTVBfTUFYXTsNCj4gPiArDQo+ID4gKwlpbnQgZGVjX2lycTsNCj4gPiArCXN0cnVj dCBtdGtfdmNvZGVjX3BtIHBtOw0KPiA+ICsJaW50IGNvbXBfaWR4Ow0KPiA+ICt9Ow0KPiA+ICsN Cj4gPiArI2VuZGlmIC8qIF9NVEtfVkNPREVDX0RFQ19IV19IXyAqLw0KPiA+IGRpZmYgLS1naXQg YS9kcml2ZXJzL21lZGlhL3BsYXRmb3JtL210ay12Y29kZWMvbXRrX3Zjb2RlY19kcnYuaCBiL2Ry aXZlcnMvbWVkaWEvcGxhdGZvcm0vbXRrLXZjb2RlYy9tdGtfdmNvZGVjX2Rydi5oDQo+ID4gaW5k ZXggMTkyOTZmZDQxYzMxLi40MDAyZjc4NmI2ZTMgMTAwNjQ0DQo+ID4gLS0tIGEvZHJpdmVycy9t ZWRpYS9wbGF0Zm9ybS9tdGstdmNvZGVjL210a192Y29kZWNfZHJ2LmgNCj4gPiArKysgYi9kcml2 ZXJzL21lZGlhL3BsYXRmb3JtL210ay12Y29kZWMvbXRrX3Zjb2RlY19kcnYuaA0KPiA+IEBAIC0x Nyw2ICsxNywxMSBAQA0KPiA+ICAgI2luY2x1ZGUgPG1lZGlhL3ZpZGVvYnVmMi1jb3JlLmg+DQo+ ID4gICAjaW5jbHVkZSAibXRrX3Zjb2RlY191dGlsLmgiDQo+ID4gICANCj4gPiArI2RlZmluZSBW REVDX0hXX0FDVElWRQkweDEwDQo+ID4gKyNkZWZpbmUgVkRFQ19JUlFfQ0ZHCTB4MTENCj4gPiAr I2RlZmluZSBWREVDX0lSUV9DTFIJMHgxMA0KPiA+ICsjZGVmaW5lIFZERUNfSVJRX0NGR19SRUcJ MHhhNA0KPiA+ICsNCj4gPiAgICNkZWZpbmUgTVRLX1ZDT0RFQ19EUlZfTkFNRQkibXRrX3Zjb2Rl Y19kcnYiDQo+ID4gICAjZGVmaW5lIE1US19WQ09ERUNfREVDX05BTUUJIm10ay12Y29kZWMtZGVj Ig0KPiA+ICAgI2RlZmluZSBNVEtfVkNPREVDX0VOQ19OQU1FCSJtdGstdmNvZGVjLWVuYyINCj4g PiBAQCAtOTMsNiArOTgsMTcgQEAgZW51bSBtdGtfZm10X3R5cGUgew0KPiA+ICAgCU1US19GTVRf RlJBTUUgPSAyLA0KPiA+ICAgfTsNCj4gPiAgIA0KPiA+ICsvKioNCj4gPiArICogc3RydWN0IG10 a192ZGVjX2h3X2lkIC0gSGFyZHdhcmUgaW5kZXggdXNlZCB0byBzZXBhcmF0ZQ0KPiA+ICsgKiAg ICAgICAgICAgICAgICAgICAgICAgICBkaWZmZXJlbnQgaGFyZHdhcmUNCj4gPiArICovDQo+ID4g K2VudW0gbXRrX3ZkZWNfaHdfaWQgew0KPiA+ICsJTVRLX1ZERUNfQ09SRSwNCj4gPiArCU1US19W REVDX0xBVDAsDQo+ID4gKwlNVEtfVkRFQ19MQVQxLA0KPiA+ICsJTVRLX1ZERUNfSFdfTUFYLA0K PiA+ICsgfTsNCj4gPiArDQo+ID4gICAvKg0KPiA+ICAgICogc3RydWN0IG10a192aWRlb19mbXQg LSBTdHJ1Y3R1cmUgdXNlZCB0byBzdG9yZSBpbmZvcm1hdGlvbiBhYm91dCBwaXhlbGZvcm1hdHMN Cj4gPiAgICAqLw0KPiA+IEBAIC00MDQsNiArNDIwLDcgQEAgc3RydWN0IG10a192Y29kZWNfZW5j X3BkYXRhIHsNCj4gPiAgICAqDQo+ID4gICAgKiBAZndfaGFuZGxlcjogdXNlZCB0byBjb21tdW5p Y2F0ZSB3aXRoIHRoZSBmaXJtd2FyZS4NCj4gPiAgICAqIEBpZF9jb3VudGVyOiB1c2VkIHRvIGlk ZW50aWZ5IGN1cnJlbnQgb3BlbmVkIGluc3RhbmNlDQo+ID4gKyAqIEBpc19zdXBwb3J0X2NvbXA6 IHRydWU6IHVzaW5nIGNvbXBvZW50IGZyYW1ld29yaywgZmFsc2U6IG5vdCBzdXBwb3J0DQo+IA0K PiBJIHdvdWxkIHJlbmFtZSB0byAnaXNfY29tcF9zdXBwb3J0ZWQnDQo+IA0KQ2FuIGNoYW5nZSB0 aGUgbmFtZS4NCj4gPiAgICAqDQo+ID4gICAgKiBAZGVjb2RlX3dvcmtxdWV1ZTogZGVjb2RlIHdv cmsgcXVldWUNCj4gPiAgICAqIEBlbmNvZGVfd29ya3F1ZXVlOiBlbmNvZGUgd29yayBxdWV1ZQ0K PiA+IEBAIC00MjIsNiArNDM5LDEwIEBAIHN0cnVjdCBtdGtfdmNvZGVjX2VuY19wZGF0YSB7DQo+ ID4gICAgKiBAcG06IHBvd2VyIG1hbmFnZW1lbnQgY29udHJvbA0KPiA+ICAgICogQGRlY19jYXBh YmlsaXR5OiB1c2VkIHRvIGlkZW50aWZ5IGRlY29kZSBjYXBhYmlsaXR5LCBleDogNGsNCj4gPiAg ICAqIEBlbmNfY2FwYWJpbGl0eTogdXNlZCB0byBpZGVudGlmeSBlbmNvZGUgY2FwYWJpbGl0eQ0K PiA+ICsgKg0KPiA+ICsgKiBAY29tcF9kZXY6IGNvbXBvbmVudCBoYXJkd2FyZSBkZXZpY2UNCj4g DQo+IFRoaXMgZmllbGQgaXMgbm90IG5lZWRlZCwgaXQgaXMgb25seSBzZXQgd2l0aG91dCBiZWVp bmcgdXNlZA0KPiANCmNvbXBfZGV2IGlzIHVzZWQgaW4gbXRrX3Zjb2RlY19kZWNfaHcuYw0KDQo+ ID4gKyAqIEBjb21wb25lbnRfbm9kZTogY29tcG9uZW50IG5vZGUNCj4gPiArICogQGNvbXBfaWR4 OiBjb21wb25lbnQgaW5kZXgNCj4gDQo+IFRoaXMgZmllbGQgaXMgbm90IHVzZWQNCj4gDQpjb21w X2lkeCB3aWxsIGJlIHVzZWQgaW4gdGhlIGZ1dHVyZSwgY2FuIHJlbW92ZSBpdCBhbmQgYWRkIGl0 IHdoZW4gbmVlZA0KdG8gdXNlLg0KPiBUaGFua3MsDQo+IERhZm5hDQo+IA0KPiA+ICAgICovDQo+ ID4gICBzdHJ1Y3QgbXRrX3Zjb2RlY19kZXYgew0KPiA+ICAgCXN0cnVjdCB2NGwyX2RldmljZSB2 NGwyX2RldjsNCj4gPiBAQCAtNDQyLDYgKzQ2Myw3IEBAIHN0cnVjdCBtdGtfdmNvZGVjX2RldiB7 DQo+ID4gICAJc3RydWN0IG10a192Y29kZWNfZncgKmZ3X2hhbmRsZXI7DQo+ID4gICANCj4gPiAg IAl1bnNpZ25lZCBsb25nIGlkX2NvdW50ZXI7DQo+ID4gKwlib29sIGlzX3N1cHBvcnRfY29tcDsN Cj4gPiAgIA0KPiA+ICAgCXN0cnVjdCB3b3JrcXVldWVfc3RydWN0ICpkZWNvZGVfd29ya3F1ZXVl Ow0KPiA+ICAgCXN0cnVjdCB3b3JrcXVldWVfc3RydWN0ICplbmNvZGVfd29ya3F1ZXVlOw0KPiA+ IEBAIC00NTksNiArNDgxLDEwIEBAIHN0cnVjdCBtdGtfdmNvZGVjX2RldiB7DQo+ID4gICAJc3Ry dWN0IG10a192Y29kZWNfcG0gcG07DQo+ID4gICAJdW5zaWduZWQgaW50IGRlY19jYXBhYmlsaXR5 Ow0KPiA+ICAgCXVuc2lnbmVkIGludCBlbmNfY2FwYWJpbGl0eTsNCj4gPiArDQo+ID4gKwl2b2lk ICpjb21wX2RldltNVEtfVkRFQ19IV19NQVhdOw0KPiA+ICsJc3RydWN0IGRldmljZV9ub2RlICpj b21wb25lbnRfbm9kZVtNVEtfVkRFQ19IV19NQVhdOw0KPiA+ICsJaW50IGNvbXBfaWR4Ow0KPiA+ ICAgfTsNCj4gPiAgIA0KPiA+ICAgc3RhdGljIGlubGluZSBzdHJ1Y3QgbXRrX3Zjb2RlY19jdHgg KmZoX3RvX2N0eChzdHJ1Y3QgdjRsMl9maCAqZmgpDQo+ID4gDQoNCg==