Re: [PATCH 2.6.20] updated dm-loop patch

[devzero@web.de]

Hi Bryn, 

with this patch and also with 0.415 i have the following problem when compiling it with stock 2.6.20 :

  Building modules, stage 2.
  MODPOST 1 modules
WARNING: "invalidate_mapping_pages" [drivers/md/dm-loop.ko] undefined!
make[1]: *** [__modpost] Error 1
make: *** [modules] Error 2

i found , that this was due to missing 

EXPORT_SYMBOL(invalidate_mapping_pages);

in mm/truncate.c 

i found 
http://lkml.org/lkml/2007/1/3/154

it looks that this didn`t go into 2.6.20 and we need at least 2.6.20-git11 ?
changelog at http://www.kernel.org/pub/linux/kernel/v2.6/snapshots/patch-2.6.20-git11.log telling that it had just had been merged on 10th of february:


commit 54bc485522afdac33de5504da2ea8cdcc690674e
Author: Anton Altaparmakov <aia21@cam.ac.uk>
Date:   Sat Feb 10 01:45:38 2007 -0800

    [PATCH] Export invalidate_mapping_pages() to modules
    
    It makes no sense to me to export invalidate_inode_pages() and not
    invalidate_mapping_pages() and I actually need invalidate_mapping_pages()
    because of its range specification ability...
    
    akpm: also remove the export of invalidate_inode_pages() by making it an
    inlined wrapper.
    

so, we need 2.6.20-git11 for dm-loop or we would need to modify mm/truncate.c manually !?

regards
roland




> -----Ursprüngliche Nachricht-----
> Von: "Bryn M. Reeves" <breeves@redhat.com>
> Gesendet: 15.02.07 01:52:12
> An: device-mapper development <dm-devel@redhat.com>
> Betreff: Re: [dm-devel] [PATCH 2.6.20] updated dm-loop patch


> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Bryn M. Reeves wrote:
> > This version of the patch fixes a couple of problems that Roland found
> > with file offsets & the use of some conversion routines from dm.h:
> 
> Unfortunately, it also added a new bug: in backing out some other
> changes I'd accidentally reverted to a version of the patch with some
> experimental changes to the file I/O workqueue. This was incomplete and
> harms performance for file mapped loop devices.
> 
> The attached version changes this back to the previous per-loop device
> workqueue.
> 
> Apologies for the confusion.
> 
> Kind regards,
> 
> Bryn.
> 
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.5 (GNU/Linux)
> Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org
> 
> iD8DBQFF066R6YSQoMYUY94RArhtAJ9J0Cc5o+Hg3NjzX8iikrIli9UlYgCggLaE
> /hJdDhTkiybsmfxz8SdLVko=
> =4pK0
> -----END PGP SIGNATURE-----
> 
> 


_____________________________________________________________________
Der WEB.DE SmartSurfer hilft bis zu 70% Ihrer Onlinekosten zu sparen!
http://smartsurfer.web.de/?mc=100071&distributionid=000000000066