From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: Build with -Werror=declaration-after-statement Date: Fri, 02 Sep 2016 15:13:35 +0200 Message-ID: <1628119.kfExARmFLF@xps13> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: ASM Return-path: Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) by dpdk.org (Postfix) with ESMTP id 64A2137B4 for ; Fri, 2 Sep 2016 15:13:37 +0200 (CEST) Received: by mail-wm0-f47.google.com with SMTP id w2so29310119wmd.0 for ; Fri, 02 Sep 2016 06:13:37 -0700 (PDT) In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-09-02 13:49, ASM: > Hi folks! > > Many groups have flag -Werror=declaration-after-statement in the > their coding conventions. Dpdk have many code as static inline > function in the headers files and have trouble with it. > > For example: > * lib/librte_ether/rte_ether.h, function rte_vlan_strip > * lib/librte_eal/common/include/rte_dev.h, function rte_pmd_debug_trace > * lib/librte_eal/common/include/arch/x86/rte_spinlock.h, fucntion rte_try_tm > > Any project who use -Werror=declaration-after-statement can't to > compile own projects without > patching this headers. > > How do you look at to fix this problem? It is probably a good fix to have on top of Adrien's series: http://dpdk.org/ml/archives/dev/2016-July/043928.html You are welcome to fix any header to be more widely used :)