From: Bing Fan <hptsfb@gmail.com>
To: gregkh@linuxfoundation.org
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v6] arm pl011 serial: support multi-irq request
Date: Fri, 13 Aug 2021 11:31:30 +0800 [thread overview]
Message-ID: <1628825490-18937-1-git-send-email-hptsfb@gmail.com> (raw)
From: Bing Fan <tombinfan@tencent.com>
In order to make pl011 work better, multiple interrupts are
required, such as TXIM, RXIM, RTIM, error interrupt(FE/PE/BE/OE);
at the same time, pl011 to GIC does not merge the interrupt
lines(each serial-interrupt corresponding to different GIC hardware
interrupt), so need to enable and request multiple gic interrupt
numbers in the driver.
Signed-off-by: Bing Fan <tombinfan@tencent.com>
---
drivers/tty/serial/amba-pl011.c | 39 +++++++++++++++++++++++++++++++--
1 file changed, 37 insertions(+), 2 deletions(-)
diff --git a/drivers/tty/serial/amba-pl011.c b/drivers/tty/serial/amba-pl011.c
index e14f3378b8a0..eaac3431459c 100644
--- a/drivers/tty/serial/amba-pl011.c
+++ b/drivers/tty/serial/amba-pl011.c
@@ -1701,6 +1701,41 @@ static void pl011_write_lcr_h(struct uart_amba_port *uap, unsigned int lcr_h)
}
}
+static void pl011_release_multi_irqs(struct uart_amba_port *uap, unsigned int max_cnt)
+{
+ struct amba_device *amba_dev = container_of(uap->port.dev, struct amba_device, dev);
+ int i;
+
+ for (i = 0; i < max_cnt; i++)
+ if (amba_dev->irq[i])
+ free_irq(amba_dev->irq[i], uap);
+}
+
+static int pl011_allocate_multi_irqs(struct uart_amba_port *uap)
+{
+ int ret = 0;
+ int i;
+ unsigned int virq;
+ struct amba_device *amba_dev = container_of(uap->port.dev, struct amba_device, dev);
+
+ pl011_write(uap->im, uap, REG_IMSC);
+
+ for (i = 0; i < AMBA_NR_IRQS; i++) {
+ virq = amba_dev->irq[i];
+ if (virq == 0)
+ break;
+
+ ret = request_irq(virq, pl011_int, IRQF_SHARED, dev_name(&amba_dev->dev), uap);
+ if (ret) {
+ dev_err(uap->port.dev, "request %u interrupt failed\n", virq);
+ pl011_release_multi_irqs(uap, i - 1);
+ break;
+ }
+ }
+
+ return ret;
+}
+
static int pl011_allocate_irq(struct uart_amba_port *uap)
{
pl011_write(uap->im, uap, REG_IMSC);
@@ -1753,7 +1788,7 @@ static int pl011_startup(struct uart_port *port)
if (retval)
goto clk_dis;
- retval = pl011_allocate_irq(uap);
+ retval = pl011_allocate_multi_irqs(uap);
if (retval)
goto clk_dis;
@@ -1864,7 +1899,7 @@ static void pl011_shutdown(struct uart_port *port)
pl011_dma_shutdown(uap);
- free_irq(uap->port.irq, uap);
+ pl011_release_multi_irqs(uap, AMBA_NR_IRQS);
pl011_disable_uart(uap);
--
2.17.1
next reply other threads:[~2021-08-13 3:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-13 3:31 Bing Fan [this message]
2021-08-13 7:19 ` [PATCH v6] arm pl011 serial: support multi-irq request Greg KH
[not found] ` <9c3a4336-b6c4-d96e-9a9d-8001dddcee20@gmail.com>
2021-08-13 8:17 ` Greg KH
2021-08-13 14:08 ` Robin Murphy
2021-08-13 15:04 ` Greg KH
2021-08-13 15:17 ` Robin Murphy
2021-08-13 14:37 ` Robin Murphy
[not found] ` <5b68f69c-f9cd-b0a4-45dd-d6db6d09fd65@gmail.com>
2021-08-16 10:19 ` Robin Murphy
2021-08-16 10:34 ` Russell King (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1628825490-18937-1-git-send-email-hptsfb@gmail.com \
--to=hptsfb@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.