From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from perceval.ideasonboard.com ([213.167.242.64]:44606 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030469AbeEXKvJ (ORCPT ); Thu, 24 May 2018 06:51:09 -0400 From: Laurent Pinchart To: Kieran Bingham Cc: linux-renesas-soc@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v4 03/11] media: vsp1: Rename dl_child to dl_next Date: Thu, 24 May 2018 13:51:05 +0300 Message-ID: <1629785.SXvnFGcEuQ@avalon> In-Reply-To: <6de8b0a020738df7775fdcae22adccc0e97d8a96.1525354194.git-series.kieran.bingham+renesas@ideasonboard.com> References: <6de8b0a020738df7775fdcae22adccc0e97d8a96.1525354194.git-series.kieran.bingham+renesas@ideasonboard.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Kieran, Thank you for the patch. On Thursday, 3 May 2018 16:36:14 EEST Kieran Bingham wrote: > Both vsp1_dl_list_commit() and __vsp1_dl_list_put() walk the display > list chain referencing the nodes as children, when in reality they are > siblings. > > Update the terminology to 'dl_next' to be consistent with the > vsp1_video_pipeline_run() usage. > > Signed-off-by: Kieran Bingham Reviewed-by: Laurent Pinchart > --- > drivers/media/platform/vsp1/vsp1_dl.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/media/platform/vsp1/vsp1_dl.c > b/drivers/media/platform/vsp1/vsp1_dl.c index f4cede9b9b43..ec6fc21fabe0 > 100644 > --- a/drivers/media/platform/vsp1/vsp1_dl.c > +++ b/drivers/media/platform/vsp1/vsp1_dl.c > @@ -398,7 +398,7 @@ struct vsp1_dl_list *vsp1_dl_list_get(struct > vsp1_dl_manager *dlm) /* This function must be called with the display list > manager lock held.*/ static void __vsp1_dl_list_put(struct vsp1_dl_list > *dl) > { > - struct vsp1_dl_list *dl_child; > + struct vsp1_dl_list *dl_next; > > if (!dl) > return; > @@ -408,8 +408,8 @@ static void __vsp1_dl_list_put(struct vsp1_dl_list *dl) > * hardware operation. > */ > if (dl->has_chain) { > - list_for_each_entry(dl_child, &dl->chain, chain) > - __vsp1_dl_list_put(dl_child); > + list_for_each_entry(dl_next, &dl->chain, chain) > + __vsp1_dl_list_put(dl_next); > } > > dl->has_chain = false; > @@ -673,17 +673,17 @@ static void vsp1_dl_list_commit_singleshot(struct > vsp1_dl_list *dl) void vsp1_dl_list_commit(struct vsp1_dl_list *dl, bool > internal) > { > struct vsp1_dl_manager *dlm = dl->dlm; > - struct vsp1_dl_list *dl_child; > + struct vsp1_dl_list *dl_next; > unsigned long flags; > > if (dlm->mode == VSP1_DL_MODE_HEADER) { > /* Fill the header for the head and chained display lists. */ > vsp1_dl_list_fill_header(dl, list_empty(&dl->chain)); > > - list_for_each_entry(dl_child, &dl->chain, chain) { > - bool last = list_is_last(&dl_child->chain, &dl->chain); > + list_for_each_entry(dl_next, &dl->chain, chain) { > + bool last = list_is_last(&dl_next->chain, &dl->chain); > > - vsp1_dl_list_fill_header(dl_child, last); > + vsp1_dl_list_fill_header(dl_next, last); > } > } -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v4 03/11] media: vsp1: Rename dl_child to dl_next Date: Thu, 24 May 2018 13:51:05 +0300 Message-ID: <1629785.SXvnFGcEuQ@avalon> References: <6de8b0a020738df7775fdcae22adccc0e97d8a96.1525354194.git-series.kieran.bingham+renesas@ideasonboard.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by gabe.freedesktop.org (Postfix) with ESMTPS id BC20D6E01C for ; Thu, 24 May 2018 10:51:09 +0000 (UTC) In-Reply-To: <6de8b0a020738df7775fdcae22adccc0e97d8a96.1525354194.git-series.kieran.bingham+renesas@ideasonboard.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Kieran Bingham Cc: linux-renesas-soc@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org SGkgS2llcmFuLAoKVGhhbmsgeW91IGZvciB0aGUgcGF0Y2guCgpPbiBUaHVyc2RheSwgMyBNYXkg MjAxOCAxNjozNjoxNCBFRVNUIEtpZXJhbiBCaW5naGFtIHdyb3RlOgo+IEJvdGggdnNwMV9kbF9s aXN0X2NvbW1pdCgpIGFuZCBfX3ZzcDFfZGxfbGlzdF9wdXQoKSB3YWxrIHRoZSBkaXNwbGF5Cj4g bGlzdCBjaGFpbiByZWZlcmVuY2luZyB0aGUgbm9kZXMgYXMgY2hpbGRyZW4sIHdoZW4gaW4gcmVh bGl0eSB0aGV5IGFyZQo+IHNpYmxpbmdzLgo+IAo+IFVwZGF0ZSB0aGUgdGVybWlub2xvZ3kgdG8g J2RsX25leHQnIHRvIGJlIGNvbnNpc3RlbnQgd2l0aCB0aGUKPiB2c3AxX3ZpZGVvX3BpcGVsaW5l X3J1bigpIHVzYWdlLgo+IAo+IFNpZ25lZC1vZmYtYnk6IEtpZXJhbiBCaW5naGFtIDxraWVyYW4u YmluZ2hhbStyZW5lc2FzQGlkZWFzb25ib2FyZC5jb20+CgpSZXZpZXdlZC1ieTogTGF1cmVudCBQ aW5jaGFydCA8bGF1cmVudC5waW5jaGFydEBpZGVhc29uYm9hcmQuY29tPgoKPiAtLS0KPiAgZHJp dmVycy9tZWRpYS9wbGF0Zm9ybS92c3AxL3ZzcDFfZGwuYyB8IDE0ICsrKysrKystLS0tLS0tCj4g IDEgZmlsZSBjaGFuZ2VkLCA3IGluc2VydGlvbnMoKyksIDcgZGVsZXRpb25zKC0pCj4gCj4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvbWVkaWEvcGxhdGZvcm0vdnNwMS92c3AxX2RsLmMKPiBiL2RyaXZl cnMvbWVkaWEvcGxhdGZvcm0vdnNwMS92c3AxX2RsLmMgaW5kZXggZjRjZWRlOWI5YjQzLi5lYzZm YzIxZmFiZTAKPiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL21lZGlhL3BsYXRmb3JtL3ZzcDEvdnNw MV9kbC5jCj4gKysrIGIvZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS92c3AxL3ZzcDFfZGwuYwo+IEBA IC0zOTgsNyArMzk4LDcgQEAgc3RydWN0IHZzcDFfZGxfbGlzdCAqdnNwMV9kbF9saXN0X2dldChz dHJ1Y3QKPiB2c3AxX2RsX21hbmFnZXIgKmRsbSkgLyogVGhpcyBmdW5jdGlvbiBtdXN0IGJlIGNh bGxlZCB3aXRoIHRoZSBkaXNwbGF5IGxpc3QKPiBtYW5hZ2VyIGxvY2sgaGVsZC4qLyBzdGF0aWMg dm9pZCBfX3ZzcDFfZGxfbGlzdF9wdXQoc3RydWN0IHZzcDFfZGxfbGlzdAo+ICpkbCkKPiAgewo+ IC0Jc3RydWN0IHZzcDFfZGxfbGlzdCAqZGxfY2hpbGQ7Cj4gKwlzdHJ1Y3QgdnNwMV9kbF9saXN0 ICpkbF9uZXh0Owo+IAo+ICAJaWYgKCFkbCkKPiAgCQlyZXR1cm47Cj4gQEAgLTQwOCw4ICs0MDgs OCBAQCBzdGF0aWMgdm9pZCBfX3ZzcDFfZGxfbGlzdF9wdXQoc3RydWN0IHZzcDFfZGxfbGlzdCAq ZGwpCj4gIAkgKiBoYXJkd2FyZSBvcGVyYXRpb24uCj4gIAkgKi8KPiAgCWlmIChkbC0+aGFzX2No YWluKSB7Cj4gLQkJbGlzdF9mb3JfZWFjaF9lbnRyeShkbF9jaGlsZCwgJmRsLT5jaGFpbiwgY2hh aW4pCj4gLQkJCV9fdnNwMV9kbF9saXN0X3B1dChkbF9jaGlsZCk7Cj4gKwkJbGlzdF9mb3JfZWFj aF9lbnRyeShkbF9uZXh0LCAmZGwtPmNoYWluLCBjaGFpbikKPiArCQkJX192c3AxX2RsX2xpc3Rf cHV0KGRsX25leHQpOwo+ICAJfQo+IAo+ICAJZGwtPmhhc19jaGFpbiA9IGZhbHNlOwo+IEBAIC02 NzMsMTcgKzY3MywxNyBAQCBzdGF0aWMgdm9pZCB2c3AxX2RsX2xpc3RfY29tbWl0X3NpbmdsZXNo b3Qoc3RydWN0Cj4gdnNwMV9kbF9saXN0ICpkbCkgdm9pZCB2c3AxX2RsX2xpc3RfY29tbWl0KHN0 cnVjdCB2c3AxX2RsX2xpc3QgKmRsLCBib29sCj4gaW50ZXJuYWwpCj4gIHsKPiAgCXN0cnVjdCB2 c3AxX2RsX21hbmFnZXIgKmRsbSA9IGRsLT5kbG07Cj4gLQlzdHJ1Y3QgdnNwMV9kbF9saXN0ICpk bF9jaGlsZDsKPiArCXN0cnVjdCB2c3AxX2RsX2xpc3QgKmRsX25leHQ7Cj4gIAl1bnNpZ25lZCBs b25nIGZsYWdzOwo+IAo+ICAJaWYgKGRsbS0+bW9kZSA9PSBWU1AxX0RMX01PREVfSEVBREVSKSB7 Cj4gIAkJLyogRmlsbCB0aGUgaGVhZGVyIGZvciB0aGUgaGVhZCBhbmQgY2hhaW5lZCBkaXNwbGF5 IGxpc3RzLiAqLwo+ICAJCXZzcDFfZGxfbGlzdF9maWxsX2hlYWRlcihkbCwgbGlzdF9lbXB0eSgm ZGwtPmNoYWluKSk7Cj4gCj4gLQkJbGlzdF9mb3JfZWFjaF9lbnRyeShkbF9jaGlsZCwgJmRsLT5j aGFpbiwgY2hhaW4pIHsKPiAtCQkJYm9vbCBsYXN0ID0gbGlzdF9pc19sYXN0KCZkbF9jaGlsZC0+ Y2hhaW4sICZkbC0+Y2hhaW4pOwo+ICsJCWxpc3RfZm9yX2VhY2hfZW50cnkoZGxfbmV4dCwgJmRs LT5jaGFpbiwgY2hhaW4pIHsKPiArCQkJYm9vbCBsYXN0ID0gbGlzdF9pc19sYXN0KCZkbF9uZXh0 LT5jaGFpbiwgJmRsLT5jaGFpbik7Cj4gCj4gLQkJCXZzcDFfZGxfbGlzdF9maWxsX2hlYWRlcihk bF9jaGlsZCwgbGFzdCk7Cj4gKwkJCXZzcDFfZGxfbGlzdF9maWxsX2hlYWRlcihkbF9uZXh0LCBs YXN0KTsKPiAgCQl9Cj4gIAl9CgoKLS0gClJlZ2FyZHMsCgpMYXVyZW50IFBpbmNoYXJ0CgoKCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBt YWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=