From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oleksandr Natalenko Subject: Re: Dell Vostro 3360 multimedia keys Date: Tue, 21 Nov 2017 19:58:24 +0100 Message-ID: <1629929.m6cr89zbSo@natalenko.name> References: <5089742.2pBsoxBtzf@natalenko.name> <1716681.OUoELY8X92@natalenko.name> <201711211936.25184@pali> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from vulcan.natalenko.name ([104.207.131.136]:10434 "EHLO vulcan.natalenko.name" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751281AbdKUS61 (ORCPT ); Tue, 21 Nov 2017 13:58:27 -0500 In-Reply-To: <201711211936.25184@pali> Sender: platform-driver-x86-owner@vger.kernel.org List-ID: To: Pali =?ISO-8859-1?Q?Roh=E1r?= Cc: Mario Limonciello , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Matthew Garrett , Darren Hart , Andy Shevchenko , Dmitry Torokhov Hi. On =FAter=FD 21. listopadu 2017 19:36:24 CET Pali Roh=E1r wrote: > Ok, if wmi_requires_smbios_request is really doing nothing, then it > should not be used. It enables some QSET feature in Dell SMM mode which > is for 2 laptops. It is also used to filter 0xe025 key code which is generated by 3rd key and= is=20 visible via both atkbd and wmi: =3D=3D=3D 343 if (type =3D=3D 0x0000 && code =3D=3D 0xe025 && !wmi_requires_smbio= s_request) 344 return; =3D=3D=3D (see commit 13f5059ac5a6b) > Looks like that Dell Vostro 3360 have this meaning for multimedia keys: >=20 > first key: Mobility Center > second key: Dell Support Center > third key: Dell Instant Launch Manager >=20 > (same as other Vostro laptops) Likely, yes. At least, for Launch Manager (key "3") there is a record in th= e=20 table: =3D=3D=3D 135 /* Dell Instant Launch key */ 136 { KE_KEY, 0xe025, { KEY_PROG4 } }, =3D=3D=3D As for Mobility Center, relevant key is commented out and has completely=20 different keycode: =3D=3D=3D 150 /* Untested, Windows Mobility Center button on Inspiron 7520 */ 151 /* { KE_IGNORE, 0xe02a, { KEY_RESERVED } }, */ =3D=3D=3D =46or Support Center, it is not commented, but still reserved: =3D=3D=3D 189 /* Dell Support Center key */ 190 { KE_IGNORE, 0xe06e, { KEY_RESERVED } }, =3D=3D=3D > But do not know what KEY_* are used on other Vostro laptops for those > keys. It would be great to use same KEY_*... So, according to what I see above, it looks like KEY_PROG(X) pattern should= be=20 followed. > > Well, I've tried. The problem is that if I even configure this key > > via setkeycodes, it doesn't work. >=20 > Hm... why it does not work? >=20 > CCing Dmitry, can you tell us what needs to be done to "active" key from > AT Keyboard driver which prints following messages to dmesg? Just to note what I did. Here is my custom /etc/udev/hwdb.d/90-dell- vostro-3360.hwdb: =3D=3D=3D evdev:atkbd:dmi:bvnDellInc.:bvrA18:bd09/25/2013:svnDellInc.:pnVostro3360:pv= r:rvnDellInc.:rn0F5DWF:rvrA00:cvnDellInc.:ct8:cvr0.1: KEYBOARD_KEY_60=3Dprog4 =3D=3D=3D Here is how this key press is being detected by evtest via atkbd: =3D=3D=3D Event: time 1511289883.083968, type 4 (EV_MSC), code 4 (MSC_SCAN), value 60 Event: time 1511289883.083968, type 1 (EV_KEY), code 203 (KEY_PROG4), value= 2 Event: time 1511289883.083968, -------------- SYN_REPORT ------------ =3D=3D=3D But xev shows nothing when I press this key. Am I doing something wrong? > In dell-wmi we filter all key events which are also delivered via PS/2 > AT Keyboard driver. So filtering PS/2 keys instead of WMI is anti-design > solution. Well, sounds reasonable... Thanks. Regards, Oleksandr