From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Stuebner Subject: Re: [PATCH v2 4/8] drm/rockchip: dw_hdmi: Allow outputs that don't need output switching Date: Mon, 19 Feb 2018 12:49:17 +0100 Message-ID: <1630677.YWXALm60yB@phil> References: <20180216204158.29839-1-heiko@sntech.de> <20180216204158.29839-5-heiko@sntech.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Robin Murphy Cc: mark.rutland@arm.com, Jose.Abreu@synopsys.com, algea.cao@rock-chips.com, devicetree@vger.kernel.org, airlied@linux.ie, dri-devel@lists.freedesktop.org, kishon@ti.com, robh+dt@kernel.org, Laurent.pinchart@ideasonboard.com, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, zhengyang@rock-chips.com List-Id: linux-rockchip.vger.kernel.org SGkgUm9iaW4sCgpBbSBNb250YWcsIDE5LiBGZWJydWFyIDIwMTgsIDEyOjQzOjExIENFVCBzY2hy aWViIFJvYmluIE11cnBoeToKPiBIaSBIZWlrbywKPiAKPiBPbiAxNi8wMi8xOCAyMDo0MSwgSGVp a28gU3R1ZWJuZXIgd3JvdGU6Cj4gPiBTbyBmYXIgd2UgYWx3YXlzIGVuY291bnRlcmVkIHNvY3Mg d2l0aCAyIG91dHB1dCBjcnRjcyBuZWVkaW5nIHRoZSBkcml2ZXIKPiA+IHRvIHRlbGwgdGhlIGhk bWkgYmxvY2sgd2hpY2ggb3V0cHV0IHRvIGNvbm5lY3QgdG8uIEJ1dCB0aGVyZSBhbHNvIGV4aXN0 Cj4gPiBzb2NzIHdpdGggb25seSBvbmUgY3J0YyBsaWtlIHRoZSByazMyMjgsIHJrMzMyOCBhbmQg cmszMzY4Lgo+ID4gCj4gPiBTbyBhZGFwdCB0aGUgcmVnaXN0ZXIgZmllbGQgdG8gc2ltcGx5IGNh cnJ5IGEgbmVnYXRpdmUgdmFsdWUgdG8gc2lnbmFsCj4gPiB0aGF0IG5vdyBvdXRwdXQtc3dpdGNo aW5nIGlzIG5lY2Vzc2FyeS4KPiAKPiBOaXQ6IHMvbm93L25vLyA/IChIb29yYXkgZm9yIGdyYW1t YXRpY2FsbHktY29ycmVjdCB0eXBvcyB3aGljaCBpbnZlcnQgCj4gdGhlIGVudGlyZSBtZWFuaW5n IG9mIHRoZSBzZW50ZW5jZSEpCgo6LUQKCj4gV2hhdCBhcmUgdGhlIG5lY2Vzc2FyeSBkZXBlbmRl bmNpZXMgZm9yIHRoZXNlIHBhdGNoZXM/IEkgdHJpZWQgYXBwbHlpbmcgCj4gdGhlIHNlcmllcyBv biA0LjE2LXJjMSB0byB0ZXN0LCBidXQgaXQgZmFpbGVkIGF0IHBhdGNoICM2IHdpdGggc29tZSAK PiBtaXNzaW5nIGNvbnRleHQgKEkgdHJpZWQgY2hlY2tpbmcgZHJtLW5leHQgZm9yIHdoZXJlIHJv Y2tjaGlwX2hkbWk6OmhkbWkgCj4gbWlnaHQgaGF2ZSBjb21lIGZyb20sIGJ1dCBkaWRuJ3Qgc2Vl IGFueXRoaW5nIG9idmlvdXMpCgpZb3UnbGwgbmVlZCB0aGUgbW9zdCByZWNlbnQgZHJtLW1pc2Mg Y2hhbmdlcyBbMF0sIGVzcGVjaWFsbHkgdGhlIGR3LWhkbWkKY2hhbmdlcyBmcm9tIEplcm5laiBT a3JhYmVjIHRoYXQgdG91Y2ggc2ltaWxhciBhcmVhcyBhbmQgZXZlbiBpbmNsdWRlZCBhCnNpbWls YXIgcGF0Y2ggdG8gZXhwb3J0IHNvbWUgZ2VuZXJhbCBwaHkgZnVuY3Rpb25zLCB3aGljaCBJIGNv dWxkIGRyb3AKZnJvbSBteSBzZXJpZXMuCgoKSGVpa28KClswXSBodHRwczovL2NnaXQuZnJlZWRl c2t0b3Aub3JnL2RybS9kcm0tbWlzYy9sb2cvCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: heiko@sntech.de (Heiko Stuebner) Date: Mon, 19 Feb 2018 12:49:17 +0100 Subject: [PATCH v2 4/8] drm/rockchip: dw_hdmi: Allow outputs that don't need output switching In-Reply-To: References: <20180216204158.29839-1-heiko@sntech.de> <20180216204158.29839-5-heiko@sntech.de> Message-ID: <1630677.YWXALm60yB@phil> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Robin, Am Montag, 19. Februar 2018, 12:43:11 CET schrieb Robin Murphy: > Hi Heiko, > > On 16/02/18 20:41, Heiko Stuebner wrote: > > So far we always encountered socs with 2 output crtcs needing the driver > > to tell the hdmi block which output to connect to. But there also exist > > socs with only one crtc like the rk3228, rk3328 and rk3368. > > > > So adapt the register field to simply carry a negative value to signal > > that now output-switching is necessary. > > Nit: s/now/no/ ? (Hooray for grammatically-correct typos which invert > the entire meaning of the sentence!) :-D > What are the necessary dependencies for these patches? I tried applying > the series on 4.16-rc1 to test, but it failed at patch #6 with some > missing context (I tried checking drm-next for where rockchip_hdmi::hdmi > might have come from, but didn't see anything obvious) You'll need the most recent drm-misc changes [0], especially the dw-hdmi changes from Jernej Skrabec that touch similar areas and even included a similar patch to export some general phy functions, which I could drop from my series. Heiko [0] https://cgit.freedesktop.org/drm/drm-misc/log/