From: Arnd Bergmann <arnd@arndb.de>
To: Shawn Lin <shawn.lin@rock-chips.com>
Cc: Jaehoon Chung <jh80.chung@samsung.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mmc: dw_mmc: remove repetitive clear interrupt
Date: Mon, 25 Jan 2016 09:55:53 +0100 [thread overview]
Message-ID: <1630713.rPyRx6D05H@wuerfel> (raw)
In-Reply-To: <56A5AAF9.5090002@rock-chips.com>
On Monday 25 January 2016 12:56:25 Shawn Lin wrote:
> On 2016/1/25 12:14, Jaehoon Chung wrote:
> > Hi, Shawn.
> >
> > On 01/25/2016 10:13 AM, Shawn Lin wrote:
> >> This patch remove repetitive clear interrupt while
> >> probing dw_mmc.
> >
> > Could you explain to me more?
>
> yes, it's a trivial improvement.
>
> dw_mci_probe clear interrupt and disable all interrupt firstly.
> Then commit 2da1d7f2 add a new clear-interrupt operation before
> enable some interrupt. I can't see any reason to clear it twice
> here. No any side effect I had found in my test pattern without this
> . May I miss some important case?
>
The explanation should go into the patch description to explain why
it is done. The one sentence "This patch remove repetitive clear
interrupt while probing dw_mmc" that you wrote instead can be
removed, it just repeats the patch subject.
Arnd
next prev parent reply other threads:[~2016-01-25 8:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-25 1:13 [PATCH] mmc: dw_mmc: remove repetitive clear interrupt Shawn Lin
2016-01-25 4:14 ` Jaehoon Chung
2016-01-25 4:56 ` Shawn Lin
2016-01-25 8:55 ` Arnd Bergmann [this message]
2016-01-26 0:40 ` Shawn Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1630713.rPyRx6D05H@wuerfel \
--to=arnd@arndb.de \
--cc=jh80.chung@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=shawn.lin@rock-chips.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.