From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ivan Shapovalov Subject: Re: [RFC] [PATCH 5/7] reiser4: txnmgr: call reiser4_post_write_back_hook() for empty atoms. Date: Sun, 17 Aug 2014 19:59:14 +0400 Message-ID: <1631803.HLYeHrfQdF@intelfx-laptop> References: <1408290206-7427-1-git-send-email-intelfx100@gmail.com> <1408290206-7427-6-git-send-email-intelfx100@gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1639332.vlfMiQ4Gt4"; micalg="pgp-sha256"; protocol="application/pgp-signature" Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-type; bh=8bUS1482INR23iawip14Gwi+P2lGP6FlCmoymgTRmjc=; b=oDvKcJfLU1Mhhq/Uj00qgBfADAgDbu2oHfYk8AjeP6eJmveKeeNZxHlfpK9o0bdAIo sDsRedsQXP0yVgPROMus2IVATAsG17x7YhVn1IN9JRFWjIHGH7oA+GWZd/t9pJIWsuQi PXik3q1b0k79Jthwv79wgBwf/Kigcl2Ee5mYTmYfXctjuUgxWSn8C7HqoraX2hk6wFUB iiSI8O907BcToKpxGpT5drCbedgq2igemkoqtDwO/3XzKacO26tu/SjpRYYe4SwChDGF qou8QUZSNxn7EYtzOr1+C5KA2dtLmZedQmbGv5XuxMd0Ahl45wYnCpK7VSVxzVLYxsDC R7jg== In-Reply-To: <1408290206-7427-6-git-send-email-intelfx100@gmail.com> Sender: reiserfs-devel-owner@vger.kernel.org List-ID: To: reiserfs-devel@vger.kernel.org Cc: edward.shishkin@gmail.com --nextPart1639332.vlfMiQ4Gt4 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="us-ascii" On Sunday 17 August 2014 at 19:43:24, Ivan Shapovalov wrote:=09 > The atoms generated by reiser4_trim_fs(), despite being empty (zero > capture_count), still have non-empty delete sets which have to be > processed. >=20 > Signed-off-by: Ivan Shapovalov > --- > fs/reiser4/txnmgr.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) >=20 > diff --git a/fs/reiser4/txnmgr.c b/fs/reiser4/txnmgr.c > index 2862940..3f44c9c 100644 > --- a/fs/reiser4/txnmgr.c > +++ b/fs/reiser4/txnmgr.c > @@ -1064,8 +1064,13 @@ static int commit_current_atom(long *nr_submit= ted, txn_atom ** atom) > =09=09return RETERR(-E_REPEAT); > =09} > =20 > -=09if ((*atom)->capture_count =3D=3D 0) > +=09if ((*atom)->capture_count =3D=3D 0) { > +=09=09/* Process the atom's delete set. > +=09=09 * Even if the atom has no captured nodes, the delete set may > +=09=09 * still be non-empty (see e. g. reiser4_trim_fs()). */ > +=09=09reiser4_post_writeback_hook(); Oops, a typo. Will resend the series... =2D-=20 Ivan Shapovalov / intelfx / > =09=09goto done; > +=09} > =20 > =09/* Up to this point we have been flushing and after flush is call= ed we > =09 return -E_REPEAT. Now we can commit. We cannot return -E_REP= EAT > --nextPart1639332.vlfMiQ4Gt4 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iF4EABEIAAYFAlPw0VcACgkQxUKljSIMAnDiFQD/c/d/0fApPdiA4iwnZX5yvTIb BsL6rGbEtGdWkXkrTYsA/13BWablZ4xfo7t26PRMypO+kmPWB2HhfHgWp27gBz2o =21ed -----END PGP SIGNATURE----- --nextPart1639332.vlfMiQ4Gt4--