From: Thomas Monjalon <thomas@monjalon.net>
To: Matan Azrad <matan@mellanox.com>
Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>, stable@dpdk.org
Subject: Re: [PATCH] ethdev: fix port accessing after release
Date: Wed, 28 Mar 2018 14:25:43 +0200 [thread overview]
Message-ID: <1634334.By0c0X4AGY@xps> (raw)
In-Reply-To: <1522239030-24489-1-git-send-email-matan@mellanox.com>
28/03/2018 14:10, Matan Azrad:
> rte_eth_dev_pci_release() function wrongly releases an ethdev port and
> then releases internal fields of this port.
> This behavior is problematic, because after the release, the port may
> be reallocated again by another thread or just be invalid for any
> usage.
>
> Move the release operation to the end of the function.
>
> Fixes: dcd5c8112bc3 ("ethdev: add PCI driver helpers")
> Cc: stable@dpdk.org
>
> Suggested-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Signed-off-by: Matan Azrad <matan@mellanox.com>
Acked-by: Thomas Monjalon <thomas@monjalon.net>
next prev parent reply other threads:[~2018-03-28 12:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-28 12:10 [PATCH] ethdev: fix port accessing after release Matan Azrad
2018-03-28 12:25 ` Thomas Monjalon [this message]
2018-03-30 10:40 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1634334.By0c0X4AGY@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=matan@mellanox.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.