From: patchwork-bot+netdevbpf@kernel.org
To: =?utf-8?b?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2VuIDx0b2tlQHJlZGhhdC5jb20+?=@ci.codeaurora.org
Cc: davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org,
edumazet@google.com
Subject: Re: [PATCH net-next v2] fq_codel: generalise ce_threshold marking for subset of traffic
Date: Wed, 20 Oct 2021 23:40:07 +0000 [thread overview]
Message-ID: <163477320724.936.13193734528653690217.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20211019174709.69081-1-toke@redhat.com>
Hello:
This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Tue, 19 Oct 2021 19:47:09 +0200 you wrote:
> The commit in the Fixes tag expanded the ce_threshold feature of FQ-CoDel
> so it can be applied to a subset of the traffic, using the ECT(1) bit of
> the ECN field as the classifier. However, hard-coding ECT(1) as the only
> classifier for this feature seems limiting, so let's expand it to be more
> general.
>
> To this end, change the parameter from a ce_threshold_ect1 boolean, to a
> one-byte selector/mask pair (ce_threshold_{selector,mask}) which is applied
> to the whole diffserv/ECN field in the IP header. This makes it possible to
> classify packets by any value in either the ECN field or the diffserv
> field. In particular, setting a selector of INET_ECN_ECT_1 and a mask of
> INET_ECN_MASK corresponds to the functionality before this patch, and a
> mask of ~INET_ECN_MASK allows using the selector as a straight-forward
> match against a diffserv code point:
>
> [...]
Here is the summary with links:
- [net-next,v2] fq_codel: generalise ce_threshold marking for subset of traffic
https://git.kernel.org/netdev/net-next/c/dfcb63ce1de6
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2021-10-20 23:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-19 17:47 [PATCH net-next v2] fq_codel: generalise ce_threshold marking for subset of traffic Toke Høiland-Jørgensen
2021-10-20 16:20 ` Eric Dumazet
2021-10-20 21:16 ` Toke Høiland-Jørgensen
2021-10-20 21:25 ` Eric Dumazet
2021-10-20 21:46 ` Toke Høiland-Jørgensen
2021-10-20 23:40 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=163477320724.936.13193734528653690217.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc==?utf-8?b?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2VuIDx0b2tlQHJlZGhhdC5jb20+?=@ci.codeaurora.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.