From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from galahad.ideasonboard.com ([185.26.127.97]:39854 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750933AbeAPPqQ (ORCPT ); Tue, 16 Jan 2018 10:46:16 -0500 From: Laurent Pinchart To: Sergei Shtylyov Cc: Laurent Pinchart , dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH v2 2/2] drm: rcar-du: lvds: Fix LVDS startup on R-Car gen2 Date: Tue, 16 Jan 2018 17:46:20 +0200 Message-ID: <1635865.FStOqVGXHX@avalon> In-Reply-To: <38ec7142-1bef-656a-1399-f3642028d460@cogentembedded.com> References: <11845752.a3eY2rs97p@avalon> <20180112231002.26213-1-laurent.pinchart+renesas@ideasonboard.com> <38ec7142-1bef-656a-1399-f3642028d460@cogentembedded.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Sergei, On Saturday, 13 January 2018 11:33:55 EET Sergei Shtylyov wrote: > On 1/13/2018 2:10 AM, Laurent Pinchart wrote: > > From: Sergei Shtylyov > > > > According to the latest revision 2.00 of the R-Car gen2 manual, the LVDS > > must be enabled and the bias crcuit enabled after the LVDS I/O pins are > > enabled, not before. Fix the gen2 LVDS startup sequence accordingly. > > > > While at it, also fix the comment preceding the first LVDCR0 write that > > still talks about hardcoding the LVDS mode 0. > > Please do this in a separate commit then... The reason I added it here is that I think we don't need patch 1/2 from this series, and I found a bit overkill to split a comment fix to a separate patch when we have a patch that touches the code around the comment. > > Fixes: 90374b5c25c9 ("drm/rcar-du: Add internal LVDS encoder support") > > You forgot to specify the other commit this one fixes -- I mean the comment > fix. Do we need to for a comment update ? It doesn't affect fix the behaviour of the driver or device, and I'd thus prefer to avoid giving the wrong impression that this patch fixes an bug introduced in a previous commit, otherwise it might end up being backported unnecessarily. > > Signed-off-by: Sergei Shtylyov > > Reviewed-by: Laurent Pinchart > > [Set the mode and input at the same time as the BEN and LVEN bits] > > Tested-by: Laurent Pinchart > > Signed-off-by: Laurent Pinchart > > > > --- > > > > drivers/gpu/drm/rcar-du/rcar_du_lvdsenc.c | 14 +++++++------- > > 1 file changed, 7 insertions(+), 7 deletions(-) > > > > Hi Sergei, > > > > For your convenience (and if you agree with bundling mode setup with the > > first write as explained in my review of patch 1/2), here's the updated > > version of patch 2/2 that I have taken in my development branch. If > > you're fine with it I'll keep it, otherwise we can continue the review > > discussion. > > As I said, I don't know how to interpret the note 3 in either manual. As explained in my latest reply to patch 1/2, my understanding is that the parameters can be programmed at any time before step 6. The fact that the current code works seems to confirm that interpretation. We could ask Renesas for a confirmation if you want. -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v2 2/2] drm: rcar-du: lvds: Fix LVDS startup on R-Car gen2 Date: Tue, 16 Jan 2018 17:46:20 +0200 Message-ID: <1635865.FStOqVGXHX@avalon> References: <11845752.a3eY2rs97p@avalon> <20180112231002.26213-1-laurent.pinchart+renesas@ideasonboard.com> <38ec7142-1bef-656a-1399-f3642028d460@cogentembedded.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from galahad.ideasonboard.com (galahad.ideasonboard.com [185.26.127.97]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3369C6E296 for ; Tue, 16 Jan 2018 15:46:17 +0000 (UTC) In-Reply-To: <38ec7142-1bef-656a-1399-f3642028d460@cogentembedded.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Sergei Shtylyov Cc: linux-renesas-soc@vger.kernel.org, Laurent Pinchart , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGkgU2VyZ2VpLAoKT24gU2F0dXJkYXksIDEzIEphbnVhcnkgMjAxOCAxMTozMzo1NSBFRVQgU2Vy Z2VpIFNodHlseW92IHdyb3RlOgo+IE9uIDEvMTMvMjAxOCAyOjEwIEFNLCBMYXVyZW50IFBpbmNo YXJ0IHdyb3RlOgo+ID4gRnJvbTogU2VyZ2VpIFNodHlseW92IDxzZXJnZWkuc2h0eWx5b3ZAY29n ZW50ZW1iZWRkZWQuY29tPgo+ID4gCj4gPiBBY2NvcmRpbmcgdG8gdGhlIGxhdGVzdCByZXZpc2lv biAyLjAwIG9mIHRoZSBSLUNhciBnZW4yIG1hbnVhbCwgdGhlIExWRFMKPiA+IG11c3QgYmUgZW5h YmxlZCBhbmQgdGhlIGJpYXMgY3JjdWl0IGVuYWJsZWQgYWZ0ZXIgdGhlIExWRFMgSS9PIHBpbnMg YXJlCj4gPiBlbmFibGVkLCBub3QgYmVmb3JlLiBGaXggdGhlIGdlbjIgTFZEUyBzdGFydHVwIHNl cXVlbmNlIGFjY29yZGluZ2x5Lgo+ID4gCj4gPiBXaGlsZSBhdCBpdCwgYWxzbyBmaXggdGhlIGNv bW1lbnQgcHJlY2VkaW5nIHRoZSBmaXJzdCBMVkRDUjAgd3JpdGUgdGhhdAo+ID4gc3RpbGwgdGFs a3MgYWJvdXQgaGFyZGNvZGluZyB0aGUgTFZEUyBtb2RlIDAuCj4gCj4gUGxlYXNlIGRvIHRoaXMg aW4gYSBzZXBhcmF0ZSBjb21taXQgdGhlbi4uLgoKVGhlIHJlYXNvbiBJIGFkZGVkIGl0IGhlcmUg aXMgdGhhdCBJIHRoaW5rIHdlIGRvbid0IG5lZWQgcGF0Y2ggMS8yIGZyb20gdGhpcyAKc2VyaWVz LCBhbmQgSSBmb3VuZCBhIGJpdCBvdmVya2lsbCB0byBzcGxpdCBhIGNvbW1lbnQgZml4IHRvIGEg c2VwYXJhdGUgcGF0Y2ggCndoZW4gd2UgaGF2ZSBhIHBhdGNoIHRoYXQgdG91Y2hlcyB0aGUgY29k ZSBhcm91bmQgdGhlIGNvbW1lbnQuCgo+ID4gRml4ZXM6IDkwMzc0YjVjMjVjOSAoImRybS9yY2Fy LWR1OiBBZGQgaW50ZXJuYWwgTFZEUyBlbmNvZGVyIHN1cHBvcnQiKQo+IAo+IFlvdSBmb3Jnb3Qg dG8gc3BlY2lmeSB0aGUgb3RoZXIgY29tbWl0IHRoaXMgb25lIGZpeGVzIC0tIEkgbWVhbiB0aGUg Y29tbWVudAo+IGZpeC4KCkRvIHdlIG5lZWQgdG8gZm9yIGEgY29tbWVudCB1cGRhdGUgPyBJdCBk b2Vzbid0IGFmZmVjdCBmaXggdGhlIGJlaGF2aW91ciBvZiAKdGhlIGRyaXZlciBvciBkZXZpY2Us IGFuZCBJJ2QgdGh1cyBwcmVmZXIgdG8gYXZvaWQgZ2l2aW5nIHRoZSB3cm9uZyBpbXByZXNzaW9u IAp0aGF0IHRoaXMgcGF0Y2ggZml4ZXMgYW4gYnVnIGludHJvZHVjZWQgaW4gYSBwcmV2aW91cyBj b21taXQsIG90aGVyd2lzZSBpdCAKbWlnaHQgZW5kIHVwIGJlaW5nIGJhY2twb3J0ZWQgdW5uZWNl c3NhcmlseS4KCj4gPiBTaWduZWQtb2ZmLWJ5OiBTZXJnZWkgU2h0eWx5b3YgPHNlcmdlaS5zaHR5 bHlvdkBjb2dlbnRlbWJlZGRlZC5jb20+Cj4gPiBSZXZpZXdlZC1ieTogTGF1cmVudCBQaW5jaGFy dCA8bGF1cmVudC5waW5jaGFydCtyZW5lc2FzQGlkZWFzb25ib2FyZC5jb20+Cj4gPiBbU2V0IHRo ZSBtb2RlIGFuZCBpbnB1dCBhdCB0aGUgc2FtZSB0aW1lIGFzIHRoZSBCRU4gYW5kIExWRU4gYml0 c10KPiA+IFRlc3RlZC1ieTogTGF1cmVudCBQaW5jaGFydCA8bGF1cmVudC5waW5jaGFydCtyZW5l c2FzQGlkZWFzb25ib2FyZC5jb20+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBMYXVyZW50IFBpbmNoYXJ0 Cj4gPiA8bGF1cmVudC5waW5jaGFydCtyZW5lc2FzQGlkZWFzb25ib2FyZC5jb20+Cj4gPiAtLS0K PiA+IAo+ID4gICBkcml2ZXJzL2dwdS9kcm0vcmNhci1kdS9yY2FyX2R1X2x2ZHNlbmMuYyB8IDE0 ICsrKysrKystLS0tLS0tCj4gPiAgIDEgZmlsZSBjaGFuZ2VkLCA3IGluc2VydGlvbnMoKyksIDcg ZGVsZXRpb25zKC0pCj4gPiAKPiA+IEhpIFNlcmdlaSwKPiA+IAo+ID4gRm9yIHlvdXIgY29udmVu aWVuY2UgKGFuZCBpZiB5b3UgYWdyZWUgd2l0aCBidW5kbGluZyBtb2RlIHNldHVwIHdpdGggdGhl Cj4gPiBmaXJzdCB3cml0ZSBhcyBleHBsYWluZWQgaW4gbXkgcmV2aWV3IG9mIHBhdGNoIDEvMiks IGhlcmUncyB0aGUgdXBkYXRlZAo+ID4gdmVyc2lvbiBvZiBwYXRjaCAyLzIgdGhhdCBJIGhhdmUg dGFrZW4gaW4gbXkgZGV2ZWxvcG1lbnQgYnJhbmNoLiBJZgo+ID4geW91J3JlIGZpbmUgd2l0aCBp dCBJJ2xsIGtlZXAgaXQsIG90aGVyd2lzZSB3ZSBjYW4gY29udGludWUgdGhlIHJldmlldwo+ID4g ZGlzY3Vzc2lvbi4KPiAKPiBBcyBJIHNhaWQsIEkgZG9uJ3Qga25vdyBob3cgdG8gaW50ZXJwcmV0 IHRoZSBub3RlIDMgaW4gZWl0aGVyIG1hbnVhbC4KCkFzIGV4cGxhaW5lZCBpbiBteSBsYXRlc3Qg cmVwbHkgdG8gcGF0Y2ggMS8yLCBteSB1bmRlcnN0YW5kaW5nIGlzIHRoYXQgdGhlIApwYXJhbWV0 ZXJzIGNhbiBiZSBwcm9ncmFtbWVkIGF0IGFueSB0aW1lIGJlZm9yZSBzdGVwIDYuIFRoZSBmYWN0 IHRoYXQgdGhlIApjdXJyZW50IGNvZGUgd29ya3Mgc2VlbXMgdG8gY29uZmlybSB0aGF0IGludGVy cHJldGF0aW9uLiBXZSBjb3VsZCBhc2sgUmVuZXNhcyAKZm9yIGEgY29uZmlybWF0aW9uIGlmIHlv dSB3YW50LgoKLS0gClJlZ2FyZHMsCgpMYXVyZW50IFBpbmNoYXJ0CgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRy aS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK