From: Thomas Monjalon <thomas@monjalon.net>
To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH] eventdev: fix missing includes
Date: Fri, 04 Aug 2017 12:44:32 +0200 [thread overview]
Message-ID: <1636294.pvSmynGaLT@xps> (raw)
In-Reply-To: <20170804103521.GA5144@jerin>
04/08/2017 12:35, Jerin Jacob:
> -----Original Message-----
> > Date: Fri, 4 Aug 2017 12:20:35 +0200
> > From: Thomas Monjalon <thomas@monjalon.net>
> > To: jerin.jacob@caviumnetworks.com
> > Cc: dev@dpdk.org
> > Subject: [PATCH] eventdev: fix missing includes
> > X-Mailer: git-send-email 2.13.2
> >
> > The PCI helper file depends on some EAL definitions.
> > Spotted with devtools/check-includes.sh:
> > error: implicit declaration of function ‘rte_eal_process_type’
> > error: ‘RTE_PROC_PRIMARY’ undeclared
> > error: implicit declaration of function ‘rte_socket_id’
> >
> > There was also this error because the inline keyword was missing:
> > error: ‘rte_event_pmd_pci_probe’ defined but not used
> >
> > Fixes: 9a8269d56942 ("eventdev: make PCI probe and remove functions optional")
> >
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > ---
> > lib/Makefile | 2 +-
> > lib/librte_eventdev/rte_eventdev_pmd_pci.h | 4 +++-
> > 2 files changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/lib/Makefile b/lib/Makefile
> > index 86caba17b..22962910d 100644
> > --- a/lib/Makefile
> > +++ b/lib/Makefile
> > @@ -69,7 +69,7 @@ DIRS-$(CONFIG_RTE_LIBRTE_IP_FRAG) += librte_ip_frag
> > DEPDIRS-librte_ip_frag := librte_eal librte_mempool librte_mbuf librte_ether
> > DEPDIRS-librte_ip_frag += librte_hash
> > DIRS-$(CONFIG_RTE_LIBRTE_GRO) += librte_gro
> > -DEPDIRS-librte_gro := librte_eal librte_mbuf librte_ether librte_net
> > +DEPDIRS-librte_gro := librte_eal librte_mbuf
>
> Looks like unrelated change. Right?
Yes you're right.
I wanted to remove this wrong part of the patch and forgot.
Will send a v2, thanks
next prev parent reply other threads:[~2017-08-04 10:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-04 10:20 [PATCH] eventdev: fix missing includes Thomas Monjalon
2017-08-04 10:35 ` Jerin Jacob
2017-08-04 10:44 ` Thomas Monjalon [this message]
2017-08-04 10:47 ` [PATCH v2] " Thomas Monjalon
2017-08-04 12:32 ` [PATCH] " Mcnamara, John
2017-08-04 23:18 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1636294.pvSmynGaLT@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=jerin.jacob@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.