From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1B01C433F5 for ; Thu, 25 Nov 2021 21:28:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244626AbhKYVbV (ORCPT ); Thu, 25 Nov 2021 16:31:21 -0500 Received: from mail-ot1-f53.google.com ([209.85.210.53]:38481 "EHLO mail-ot1-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236079AbhKYV3U (ORCPT ); Thu, 25 Nov 2021 16:29:20 -0500 Received: by mail-ot1-f53.google.com with SMTP id n104-20020a9d2071000000b005799790cf0bso11188494ota.5; Thu, 25 Nov 2021 13:26:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:in-reply-to:references:subject:date :message-id; bh=lUnyMTneWGU7NFF/n4I3ZqSOv0nJuV1tmx8TUG2ODpA=; b=xtmvXvs3NSNg33CiAO5o4bYwxaGwIuGbRkNJIaAxmZGgsXgPjd8FwzddLrE+iEbdj1 ziSfQiWFnCTPENFBe9BZKeg/+snT+P81zjq6qRZZ0kLNr2PcOdGepW749/9jaHqhIySa VclNvz2fiTSp06gB/EtBVNzz2f95mff/75t1JOrN/gjI9x5NmrHbBRV1wKjKJe572XcD 536R2dgJcDh/dzEzjemK3KOY225djIIAjZ9mPw+k1yAzSNvRoBIZlQcK+i5Df7lTe1qY A2a5EH+0MK4Vf4zUcIVY7h5X4CyauQspNyw1K1sHkuDMXFgGB4hD4xj7kgstM0rn88TA SpNA== X-Gm-Message-State: AOAM533+C4Su6yPXZyi/GHJ3v/efGM0ctGpWIbCc5qwtsvnnb2wziMdC gO0FGyILoC/MTI9jnE2ncg== X-Google-Smtp-Source: ABdhPJy/992h9axX9rH2fCCB+RWkGA9fZZ39JA97KxQsE/4xWFvJLOpkTwRr2V1SomuUtwM8AuoEZA== X-Received: by 2002:a9d:7e84:: with SMTP id m4mr23853157otp.102.1637875568579; Thu, 25 Nov 2021 13:26:08 -0800 (PST) Received: from robh.at.kernel.org ([64.188.179.248]) by smtp.gmail.com with ESMTPSA id o14sm681509ote.41.2021.11.25.13.26.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Nov 2021 13:26:07 -0800 (PST) Received: (nullmailer pid 2858313 invoked by uid 1000); Thu, 25 Nov 2021 21:26:02 -0000 From: Rob Herring To: =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= Cc: Rob Herring , =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= , Florian Fainelli , Linus Walleij , Tony Lindgren , Andy Shevchenko , devicetree@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org In-Reply-To: <20211124230439.17531-3-zajec5@gmail.com> References: <20211124230439.17531-1-zajec5@gmail.com> <20211124230439.17531-3-zajec5@gmail.com> Subject: Re: [PATCH V2 2/6] dt-bindings: pinctrl: brcm,ns-pinmux: extend example Date: Thu, 25 Nov 2021 14:26:02 -0700 Message-Id: <1637875562.296357.2858312.nullmailer@robh.at.kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Thu, 25 Nov 2021 00:04:35 +0100, Rafał Miłecki wrote: > From: Rafał Miłecki > > pinctrl bindings allow specifying pins, groups & functions now. Put some > entries in binding example to help writing DTS files. > > Specify pins, groups & functions in the example. > > Signed-off-by: Rafał Miłecki > --- > V2: Update "pins" to match new binding > --- > .../bindings/pinctrl/brcm,ns-pinmux.yaml | 24 ++++++++++++++++++- > 1 file changed, 23 insertions(+), 1 deletion(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: schemas/pinctrl/brcm,ns-pinmux.yaml: ignoring, error in schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/brcm,ns-pinmux.yaml: 'additionalProperties' is a required property hint: A schema without a "$ref" to another schema must define all properties and use "additionalProperties" from schema $id: http://devicetree.org/meta-schemas/base.yaml# /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/brcm,ns-pinmux.yaml: ignoring, error in schema: warning: no schema found in file: ./Documentation/devicetree/bindings/pinctrl/brcm,ns-pinmux.yaml make[1]: *** Deleting file 'Documentation/devicetree/bindings/mfd/brcm,cru.example.dt.yaml' schemas/pinctrl/brcm,ns-pinmux.yaml: ignoring, error in schema: Traceback (most recent call last): File "/usr/local/bin/dt-validate", line 170, in sg.check_trees(filename, testtree) File "/usr/local/bin/dt-validate", line 119, in check_trees self.check_subtree(dt, subtree, False, "/", "/", filename) File "/usr/local/bin/dt-validate", line 110, in check_subtree self.check_subtree(tree, value, disabled, name, fullname + name, filename) File "/usr/local/bin/dt-validate", line 110, in check_subtree self.check_subtree(tree, value, disabled, name, fullname + name, filename) File "/usr/local/bin/dt-validate", line 105, in check_subtree self.check_node(tree, subtree, disabled, nodename, fullname, filename) File "/usr/local/bin/dt-validate", line 49, in check_node errors = sorted(dtschema.DTValidator(schema).iter_errors(node), key=lambda e: e.linecol) File "/usr/local/lib/python3.8/dist-packages/dtschema/lib.py", line 766, in iter_errors for error in super().iter_errors(instance, _schema): File "/usr/local/lib/python3.8/dist-packages/jsonschema/validators.py", line 224, in iter_errors for error in errors: File "/usr/local/lib/python3.8/dist-packages/jsonschema/_validators.py", line 25, in patternProperties yield from validator.descend( File "/usr/local/lib/python3.8/dist-packages/jsonschema/validators.py", line 240, in descend for error in self.evolve(schema=schema).iter_errors(instance): File "/usr/local/lib/python3.8/dist-packages/dtschema/lib.py", line 766, in iter_errors for error in super().iter_errors(instance, _schema): File "/usr/local/lib/python3.8/dist-packages/jsonschema/validators.py", line 224, in iter_errors for error in errors: File "/usr/local/lib/python3.8/dist-packages/jsonschema/_validators.py", line 298, in ref yield from validator.descend(instance, resolved) File "/usr/local/lib/python3.8/dist-packages/jsonschema/validators.py", line 240, in descend for error in self.evolve(schema=schema).iter_errors(instance): File "/usr/local/lib/python3.8/dist-packages/dtschema/lib.py", line 766, in iter_errors for error in super().iter_errors(instance, _schema): File "/usr/local/lib/python3.8/dist-packages/jsonschema/validators.py", line 214, in iter_errors scope = id_of(_schema) File "/usr/local/lib/python3.8/dist-packages/jsonschema/validators.py", line 90, in _id_of return schema.get("$id", "") AttributeError: 'NoneType' object has no attribute 'get' make[1]: *** [scripts/Makefile.lib:373: Documentation/devicetree/bindings/mfd/brcm,cru.example.dt.yaml] Error 1 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:1413: dt_binding_check] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/1559467 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9F4F2C433F5 for ; Thu, 25 Nov 2021 21:28:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: MIME-Version:List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe :List-Id:Message-Id:Date:Subject:References:In-Reply-To:Cc:To:From:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=L2vFYIiFiLsv5KMIk/XUI7GemPZ9IwseLeRvWFjulmQ=; b=G8bdXHHwQNCHpKy4ouQwIr113f Y7q0BOJBMz3BlWG3f7U8gBBReKb5mmLf1YA+b0hglcXF5qVCq6YnvRHuXzXtxlfnzA6yP6FrpPmWN vlKgMkwWER1T0WZI33KVYj1j8Abb9rYlqYiBnPla3gD5yTbJzKix096RtXcL1LawTXLaOQqZWhYVK BzJcX7r0n2TuhNOSKMnjg3D/Xjo6dp9F9Ey8rX/E8G3fkm3Npjsz7Rt8ghfis0BmKgKWYr28tslR5 t4yIhmsrTz1qRR342Ihi0GowzAB70VIFPy+foxzoAcO3SjPxGpDOvFVyLNr8tSvltQVq1WBQKkW2z ft0VIj1g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mqMG9-008jUF-9o; Thu, 25 Nov 2021 21:26:27 +0000 Received: from mail-ot1-f47.google.com ([209.85.210.47]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mqMFu-008jSM-8F for linux-arm-kernel@lists.infradead.org; Thu, 25 Nov 2021 21:26:12 +0000 Received: by mail-ot1-f47.google.com with SMTP id h19-20020a9d3e53000000b0056547b797b2so11175766otg.4 for ; Thu, 25 Nov 2021 13:26:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:in-reply-to:references:subject:date :message-id; bh=lUnyMTneWGU7NFF/n4I3ZqSOv0nJuV1tmx8TUG2ODpA=; b=Nr5rInfgkIm5diwmHf8QANzGfGc6FT+nUaT4JeCHcWl/GjL0pGAs4mTS+Xout25U1e SmzFODlCYaezej8C+rkY+UZlL+50Vf8a/BpduZMEetwoDmKzWy+v0I7UZLr37Eg8PyR6 QR6SDZ9a7vnlPCKNq5Zh0g/SBGQ8XbPQ9+AipvQnUMJ5xqmfDktewQtSDSufdBx5OZYz 0lKu8g4bDSww5LbGstGJ0M76k7IRrySBx80qr01HHFcBnYcycudVZTlS6Xa6YfEYG1Cp u89D24E/EaUCgTnoklykz6gnB6KqFpK0PhBP3NM66YO3TPM57UoEfOj4WI8ThHy6rvBl wrDQ== X-Gm-Message-State: AOAM532sQ7/31+AXysa7JtijpWQjKoa6onUmmMvnF78wZn3C4nhkaFxj /5fjN4rYG/BC0/zCwwD33A== X-Google-Smtp-Source: ABdhPJy/992h9axX9rH2fCCB+RWkGA9fZZ39JA97KxQsE/4xWFvJLOpkTwRr2V1SomuUtwM8AuoEZA== X-Received: by 2002:a9d:7e84:: with SMTP id m4mr23853157otp.102.1637875568579; Thu, 25 Nov 2021 13:26:08 -0800 (PST) Received: from robh.at.kernel.org ([64.188.179.248]) by smtp.gmail.com with ESMTPSA id o14sm681509ote.41.2021.11.25.13.26.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Nov 2021 13:26:07 -0800 (PST) Received: (nullmailer pid 2858313 invoked by uid 1000); Thu, 25 Nov 2021 21:26:02 -0000 From: Rob Herring To: =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= Cc: Rob Herring , =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= , Florian Fainelli , Linus Walleij , Tony Lindgren , Andy Shevchenko , devicetree@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org In-Reply-To: <20211124230439.17531-3-zajec5@gmail.com> References: <20211124230439.17531-1-zajec5@gmail.com> <20211124230439.17531-3-zajec5@gmail.com> Subject: Re: [PATCH V2 2/6] dt-bindings: pinctrl: brcm, ns-pinmux: extend example Date: Thu, 25 Nov 2021 14:26:02 -0700 Message-Id: <1637875562.296357.2858312.nullmailer@robh.at.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211125_132610_341015_7DE36F75 X-CRM114-Status: GOOD ( 15.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5577064507837761476==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============5577064507837761476== Content-Type: text/plain On Thu, 25 Nov 2021 00:04:35 +0100, Rafał Miłecki wrote: > From: Rafał Miłecki > > pinctrl bindings allow specifying pins, groups & functions now. Put some > entries in binding example to help writing DTS files. > > Specify pins, groups & functions in the example. > > Signed-off-by: Rafał Miłecki > --- > V2: Update "pins" to match new binding > --- > .../bindings/pinctrl/brcm,ns-pinmux.yaml | 24 ++++++++++++++++++- > 1 file changed, 23 insertions(+), 1 deletion(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: schemas/pinctrl/brcm,ns-pinmux.yaml: ignoring, error in schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/brcm,ns-pinmux.yaml: 'additionalProperties' is a required property hint: A schema without a "$ref" to another schema must define all properties and use "additionalProperties" from schema $id: http://devicetree.org/meta-schemas/base.yaml# /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/brcm,ns-pinmux.yaml: ignoring, error in schema: warning: no schema found in file: ./Documentation/devicetree/bindings/pinctrl/brcm,ns-pinmux.yaml make[1]: *** Deleting file 'Documentation/devicetree/bindings/mfd/brcm,cru.example.dt.yaml' schemas/pinctrl/brcm,ns-pinmux.yaml: ignoring, error in schema: Traceback (most recent call last): File "/usr/local/bin/dt-validate", line 170, in sg.check_trees(filename, testtree) File "/usr/local/bin/dt-validate", line 119, in check_trees self.check_subtree(dt, subtree, False, "/", "/", filename) File "/usr/local/bin/dt-validate", line 110, in check_subtree self.check_subtree(tree, value, disabled, name, fullname + name, filename) File "/usr/local/bin/dt-validate", line 110, in check_subtree self.check_subtree(tree, value, disabled, name, fullname + name, filename) File "/usr/local/bin/dt-validate", line 105, in check_subtree self.check_node(tree, subtree, disabled, nodename, fullname, filename) File "/usr/local/bin/dt-validate", line 49, in check_node errors = sorted(dtschema.DTValidator(schema).iter_errors(node), key=lambda e: e.linecol) File "/usr/local/lib/python3.8/dist-packages/dtschema/lib.py", line 766, in iter_errors for error in super().iter_errors(instance, _schema): File "/usr/local/lib/python3.8/dist-packages/jsonschema/validators.py", line 224, in iter_errors for error in errors: File "/usr/local/lib/python3.8/dist-packages/jsonschema/_validators.py", line 25, in patternProperties yield from validator.descend( File "/usr/local/lib/python3.8/dist-packages/jsonschema/validators.py", line 240, in descend for error in self.evolve(schema=schema).iter_errors(instance): File "/usr/local/lib/python3.8/dist-packages/dtschema/lib.py", line 766, in iter_errors for error in super().iter_errors(instance, _schema): File "/usr/local/lib/python3.8/dist-packages/jsonschema/validators.py", line 224, in iter_errors for error in errors: File "/usr/local/lib/python3.8/dist-packages/jsonschema/_validators.py", line 298, in ref yield from validator.descend(instance, resolved) File "/usr/local/lib/python3.8/dist-packages/jsonschema/validators.py", line 240, in descend for error in self.evolve(schema=schema).iter_errors(instance): File "/usr/local/lib/python3.8/dist-packages/dtschema/lib.py", line 766, in iter_errors for error in super().iter_errors(instance, _schema): File "/usr/local/lib/python3.8/dist-packages/jsonschema/validators.py", line 214, in iter_errors scope = id_of(_schema) File "/usr/local/lib/python3.8/dist-packages/jsonschema/validators.py", line 90, in _id_of return schema.get("$id", "") AttributeError: 'NoneType' object has no attribute 'get' make[1]: *** [scripts/Makefile.lib:373: Documentation/devicetree/bindings/mfd/brcm,cru.example.dt.yaml] Error 1 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:1413: dt_binding_check] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/1559467 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit. --===============5577064507837761476== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============5577064507837761476==--