From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BC2F4C433EF for ; Sun, 28 Nov 2021 13:15:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-Reply-To: Date:From:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=bvof8DIQ0Jh4zGlNW/4yJe3F/wgp4P3a3575hz0Tk9w=; b=vQ3opfNVCmGYWE 1T6xNXMreTuhNS17OPcwm6b3jHmAVU4FDUzu3Wfk8WtgrKGL5UQwwZ96OHq13VtnDu62YAGEHoLLQ OAlZahoe/0si862e7l4vlhpy6ewvXi+D8zMXktU0/obxKg1cVy5guEdWPNuy8t55Eh1uXsO178KcJ /6KBdj6L2DpiVX8SzagKiwbKdmY9VRGerFbD4PRRsFrqam5PRyz24tNTDnvtisQRFxZ8AytM8mhm7 W+sw+AzWvDzz5I0Qt4nSGeysyDEKy2FCjQIbwslF7AGE4ZKJonDvBkcJArNUj3t+ZVrIbTfXpFylk 3TVMmACny1npQkmRmDcQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mrK0Z-00FmKF-Ie; Sun, 28 Nov 2021 13:14:19 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mrK0U-00FmJU-Od for linux-arm-kernel@lists.infradead.org; Sun, 28 Nov 2021 13:14:16 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 5C182B80CDA; Sun, 28 Nov 2021 13:14:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 903A7C004E1; Sun, 28 Nov 2021 13:14:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1638105252; bh=1xC3yYqfQvT9UkAF/V4TC1w8ryQm3puedJHVA2CUcRE=; h=Subject:To:Cc:From:Date:In-Reply-To:From; b=RkFDQi7pjA7goesyHwGJDVz/G/Ej0TH7zv5JzjYtzIHv3VIpAICS8NkCrJlry5YJY hO5NuICBArZxBwlh15y+ygapqxZD517YQPzgH+jSManfbbpmf4BVZqMbOHUw07rVBN D9uXkTr/F6nmEb2Gjyjr2P+3oNCD4RvbJI3UrvuA= Subject: Patch "PCI: aardvark: Fix a leaked reference by adding missing of_node_put()" has been added to the 4.19-stable tree To: bhelgaas@google.com, gregkh@linuxfoundation.org, kabel@kernel.org, linux-arm-kernel@lists.infradead.org, lorenzo.pieralisi@arm.com, pali@kernel.org, sashal@kernel.org, thomas.petazzoni@bootlin.com, wen.yang99@zte.com.cn Cc: From: Date: Sun, 28 Nov 2021 14:13:46 +0100 In-Reply-To: <20211124230500.27109-2-kabel@kernel.org> Message-ID: <163810522615468@kroah.com> MIME-Version: 1.0 X-stable: commit X-Patchwork-Hint: ignore X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211128_051415_144131_2A4D36FC X-CRM114-Status: GOOD ( 18.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This is a note to let you know that I've just added the patch titled PCI: aardvark: Fix a leaked reference by adding missing of_node_put() to the 4.19-stable tree which can be found at: http://www.kernel.org/git/?p=3Dlinux/kernel/git/stable/stable-queue.git= ;a=3Dsummary The filename of the patch is: pci-aardvark-fix-a-leaked-reference-by-adding-missing-of_node_put.patch and it can be found in the queue-4.19 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. >From foo@baz Sun Nov 28 02:10:56 PM CET 2021 From: "Marek Beh=FAn" Date: Thu, 25 Nov 2021 00:04:41 +0100 Subject: PCI: aardvark: Fix a leaked reference by adding missing of_node_pu= t() To: Greg Kroah-Hartman , Sasha Levin Cc: pali@kernel.org, stable@vger.kernel.org, "Wen Yang" , "Lorenzo Pieralisi" , "Thomas Petazzoni" <= thomas.petazzoni@bootlin.com>, "Bjorn Helgaas" , linux= -pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vg= er.kernel.org, "Marek Beh=FAn" Message-ID: <20211124230500.27109-2-kabel@kernel.org> From: Wen Yang commit 3842f5166bf1ef286fe7a39f262b5c9581308366 upstream. The call to of_get_next_child() returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage. irq_domain_add_linear() also calls of_node_get() to increase refcount, so irq_domain will not be affected when it is released. Detected by coccinelle with the following warnings: ./drivers/pci/controller/pci-aardvark.c:826:1-7: ERROR: missing of_node_p= ut; acquired a node pointer with refcount incremented on line 798, but with= out a corresponding object release within this function. Signed-off-by: Wen Yang Signed-off-by: Lorenzo Pieralisi Cc: Thomas Petazzoni Cc: Lorenzo Pieralisi Cc: Bjorn Helgaas Cc: linux-pci@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Marek Beh=C3=BAn Signed-off-by: Greg Kroah-Hartman --- drivers/pci/controller/pci-aardvark.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) --- a/drivers/pci/controller/pci-aardvark.c +++ b/drivers/pci/controller/pci-aardvark.c @@ -754,6 +754,7 @@ static int advk_pcie_init_irq_domain(str struct device_node *node =3D dev->of_node; struct device_node *pcie_intc_node; struct irq_chip *irq_chip; + int ret =3D 0; = raw_spin_lock_init(&pcie->irq_lock); = @@ -768,8 +769,8 @@ static int advk_pcie_init_irq_domain(str irq_chip->name =3D devm_kasprintf(dev, GFP_KERNEL, "%s-irq", dev_name(dev)); if (!irq_chip->name) { - of_node_put(pcie_intc_node); - return -ENOMEM; + ret =3D -ENOMEM; + goto out_put_node; } = irq_chip->irq_mask =3D advk_pcie_irq_mask; @@ -781,11 +782,13 @@ static int advk_pcie_init_irq_domain(str &advk_pcie_irq_domain_ops, pcie); if (!pcie->irq_domain) { dev_err(dev, "Failed to get a INTx IRQ domain\n"); - of_node_put(pcie_intc_node); - return -ENOMEM; + ret =3D -ENOMEM; + goto out_put_node; } = - return 0; +out_put_node: + of_node_put(pcie_intc_node); + return ret; } = static void advk_pcie_remove_irq_domain(struct advk_pcie *pcie) Patches currently in stable-queue which might be from kabel@kernel.org are queue-4.19/pci-aardvark-move-pcie-reset-card-code-to-advk_pcie_train_link.p= atch queue-4.19/pci-aardvark-update-comment-about-disabling-link-training.patch queue-4.19/pci-aardvark-train-link-immediately-after-enabling-training.patch queue-4.19/arm64-dts-marvell-armada-37xx-declare-pcie-reset-pin.patch queue-4.19/pci-aardvark-replace-custom-macros-by-standard-linux-pci_regs.h-= macros.patch queue-4.19/pci-aardvark-fix-a-leaked-reference-by-adding-missing-of_node_pu= t.patch queue-4.19/pci-aardvark-fix-pcie-max-payload-size-setting.patch queue-4.19/pinctrl-armada-37xx-correct-pwm-pins-definitions.patch queue-4.19/arm64-dts-marvell-armada-37xx-set-pcie_reset_pin-to-gpio-functio= n.patch queue-4.19/pci-aardvark-configure-pcie-resources-from-ranges-dt-property.pa= tch queue-4.19/pci-aardvark-improve-link-training.patch queue-4.19/pci-aardvark-fix-link-training.patch queue-4.19/pci-aardvark-fix-checking-for-link-up-via-ltssm-state.patch queue-4.19/pci-aardvark-issue-perst-via-gpio.patch queue-4.19/pinctrl-armada-37xx-correct-mpp-definitions.patch queue-4.19/pci-aardvark-wait-for-endpoint-to-be-ready-before-training-link.= patch queue-4.19/pinctrl-armada-37xx-add-missing-pin-pcie1-wakeup.patch queue-4.19/pci-aardvark-fix-compilation-on-s390.patch queue-4.19/pci-aardvark-don-t-touch-pcie-registers-if-no-card-connected.pat= ch queue-4.19/pci-aardvark-indicate-error-in-val-when-config-read-fails.patch _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel