From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B88EAC433F5 for ; Mon, 29 Nov 2021 12:50:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-Reply-To: Date:From:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Owner; bh=6uS/HE4tjdbJOaqdVk5uzN7zzGSNK6V9uWRffLMJ/Fs=; b=Qvp6ActpC1AOC8 AZn32/t4xKUcBzTBtLLiW/pOw3WQAbo3t9k5Veu9aUAs/AeqleN5rbzVgov1xhH2oPGYtlE1ye5s1 szeyTnoVdRFLyBVHEQfsWL0ZlEy48Rswnwgw/azzP6S/EEPlvqWDr++fpWy0MAKfvdbOGuSJcK49T EsarbSDctNw4om2tsUHRyw2GZiRggO+IiYki/CAbEdjUZ5SidyhWoQ+65EvjoPxTDv74l2bxPx7Ii PKH4tx+Tp/jLq0lGbo1PyJfpAe/n4u9QkuHY6ETxO5PRgTG8Xzsmcha9QcGxGEDcFiITdmWw+qK0a M4chdU7FR2YwyBgXZT1Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mrg5j-000jp7-1L; Mon, 29 Nov 2021 12:49:07 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mrg5e-000joe-Ro for linux-arm-kernel@lists.infradead.org; Mon, 29 Nov 2021 12:49:04 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 68E61611E1; Mon, 29 Nov 2021 12:49:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 50B24C004E1; Mon, 29 Nov 2021 12:49:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1638190141; bh=rZsrlMmCKljmh90zaWSKFc++mI4+ArCAnz16R9pkN+I=; h=Subject:To:Cc:From:Date:In-Reply-To:From; b=JLwCGzEySQhq5LESjwHrH7E2Gw0qcOKYAPAv9uozIXPGWphZRWaCIwq1ylSMvcRLr qmsVAINVHsHP873oc8mXqXo9i9ppu23pQWwfnTJpcAMy7xRGP9FyR/r+3Zk828U0p3 cZT2Ofc0JOGnzcJIsonlym9/hRQAl6evC78tZ8RM= Subject: Patch "PCI: aardvark: Fix a leaked reference by adding missing of_node_put()" has been added to the 4.14-stable tree To: bhelgaas@google.com, gregkh@linuxfoundation.org, kabel@kernel.org, linux-arm-kernel@lists.infradead.org, lorenzo.pieralisi@arm.com, pali@kernel.org, sashal@kernel.org, thomas.petazzoni@bootlin.com, wen.yang99@zte.com.cn Cc: From: Date: Mon, 29 Nov 2021 13:48:48 +0100 In-Reply-To: <20211124224933.24275-3-kabel@kernel.org> Message-ID: <1638190128158212@kroah.com> MIME-Version: 1.0 X-stable: commit X-Patchwork-Hint: ignore X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211129_044903_019318_A4A292B7 X-CRM114-Status: GOOD ( 18.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This is a note to let you know that I've just added the patch titled PCI: aardvark: Fix a leaked reference by adding missing of_node_put() to the 4.14-stable tree which can be found at: http://www.kernel.org/git/?p=3Dlinux/kernel/git/stable/stable-queue.git= ;a=3Dsummary The filename of the patch is: pci-aardvark-fix-a-leaked-reference-by-adding-missing-of_node_put.patch and it can be found in the queue-4.14 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. >From foo@baz Mon Nov 29 01:32:04 PM CET 2021 From: "Marek Beh=FAn" Date: Wed, 24 Nov 2021 23:49:11 +0100 Subject: PCI: aardvark: Fix a leaked reference by adding missing of_node_pu= t() To: Greg Kroah-Hartman , Sasha Levin Cc: pali@kernel.org, stable@vger.kernel.org, "Wen Yang" , "Lorenzo Pieralisi" , "Thomas Petazzoni" <= thomas.petazzoni@bootlin.com>, "Bjorn Helgaas" , linux= -pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vg= er.kernel.org, "Marek Beh=FAn" Message-ID: <20211124224933.24275-3-kabel@kernel.org> From: Wen Yang commit 3842f5166bf1ef286fe7a39f262b5c9581308366 upstream. The call to of_get_next_child() returns a node pointer with refcount incremented thus it must be explicitly decremented after the last usage. irq_domain_add_linear() also calls of_node_get() to increase refcount, so irq_domain will not be affected when it is released. Detected by coccinelle with the following warnings: ./drivers/pci/controller/pci-aardvark.c:826:1-7: ERROR: missing of_node_p= ut; acquired a node pointer with refcount incremented on line 798, but with= out a corresponding object release within this function. Signed-off-by: Wen Yang Signed-off-by: Lorenzo Pieralisi Cc: Thomas Petazzoni Cc: Lorenzo Pieralisi Cc: Bjorn Helgaas Cc: linux-pci@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Marek Beh=C3=BAn Signed-off-by: Greg Kroah-Hartman --- drivers/pci/host/pci-aardvark.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) --- a/drivers/pci/host/pci-aardvark.c +++ b/drivers/pci/host/pci-aardvark.c @@ -789,6 +789,7 @@ static int advk_pcie_init_irq_domain(str struct device_node *node =3D dev->of_node; struct device_node *pcie_intc_node; struct irq_chip *irq_chip; + int ret =3D 0; = raw_spin_lock_init(&pcie->irq_lock); = @@ -803,8 +804,8 @@ static int advk_pcie_init_irq_domain(str irq_chip->name =3D devm_kasprintf(dev, GFP_KERNEL, "%s-irq", dev_name(dev)); if (!irq_chip->name) { - of_node_put(pcie_intc_node); - return -ENOMEM; + ret =3D -ENOMEM; + goto out_put_node; } = irq_chip->irq_mask =3D advk_pcie_irq_mask; @@ -816,11 +817,13 @@ static int advk_pcie_init_irq_domain(str &advk_pcie_irq_domain_ops, pcie); if (!pcie->irq_domain) { dev_err(dev, "Failed to get a INTx IRQ domain\n"); - of_node_put(pcie_intc_node); - return -ENOMEM; + ret =3D -ENOMEM; + goto out_put_node; } = - return 0; +out_put_node: + of_node_put(pcie_intc_node); + return ret; } = static void advk_pcie_remove_irq_domain(struct advk_pcie *pcie) Patches currently in stable-queue which might be from kabel@kernel.org are queue-4.14/pci-aardvark-move-pcie-reset-card-code-to-advk_pcie_train_link.p= atch queue-4.14/pci-aardvark-introduce-an-advk_pcie_valid_device-helper.patch queue-4.14/pci-aardvark-update-comment-about-disabling-link-training.patch queue-4.14/pci-aardvark-train-link-immediately-after-enabling-training.patch queue-4.14/arm64-dts-marvell-armada-37xx-declare-pcie-reset-pin.patch queue-4.14/pci-aardvark-replace-custom-macros-by-standard-linux-pci_regs.h-= macros.patch queue-4.14/pci-aardvark-fix-a-leaked-reference-by-adding-missing-of_node_pu= t.patch queue-4.14/pci-aardvark-fix-pcie-max-payload-size-setting.patch queue-4.14/pinctrl-armada-37xx-correct-pwm-pins-definitions.patch queue-4.14/arm64-dts-marvell-armada-37xx-set-pcie_reset_pin-to-gpio-functio= n.patch queue-4.14/pci-aardvark-configure-pcie-resources-from-ranges-dt-property.pa= tch queue-4.14/pci-aardvark-improve-link-training.patch queue-4.14/pci-aardvark-fix-link-training.patch queue-4.14/pci-aardvark-fix-checking-for-link-up-via-ltssm-state.patch queue-4.14/pci-aardvark-issue-perst-via-gpio.patch queue-4.14/pinctrl-armada-37xx-correct-mpp-definitions.patch queue-4.14/pci-add-pci_exp_lnkctl2_tls-macros.patch queue-4.14/pci-aardvark-wait-for-endpoint-to-be-ready-before-training-link.= patch queue-4.14/pinctrl-armada-37xx-add-missing-pin-pcie1-wakeup.patch queue-4.14/pci-aardvark-fix-compilation-on-s390.patch queue-4.14/pci-aardvark-fix-i-o-space-page-leak.patch queue-4.14/pci-aardvark-don-t-touch-pcie-registers-if-no-card-connected.pat= ch queue-4.14/pci-aardvark-remove-pcie-outbound-window-configuration.patch queue-4.14/pci-aardvark-indicate-error-in-val-when-config-read-fails.patch _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel