All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Harman Kalra <hkalra@marvell.com>
Cc: dev@dpdk.org, John McNamara <john.mcnamara@intel.com>,
	Marko Kovacevic <marko.kovacevic@intel.com>,
	Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [dpdk-dev] [PATCH] mk: add support for UBSAN
Date: Mon, 11 Nov 2019 08:07:00 +0100	[thread overview]
Message-ID: <1638210.PZqRnmcaYt@xps> (raw)
In-Reply-To: <1566222457-17342-1-git-send-email-hkalra@marvell.com>

Hi,

Sorry for the very late review.
I hope someone else would try it.

I tried this:
devtools/test-build.sh -v x86_64-native-linux-clang+shared+UBSAN+SANITIZE_ALL
and it triggers some link errors:
/usr/bin/ld: rte_kvargs.c:(.text+0xc65): undefined reference to `__ubsan_handle_pointer_overflow'


19/08/2019 15:48, Harman Kalra:
> UndefinedBehaviorSanitizer (UBSan) is a fast undefined behavior
> detector. UBSan modifies the program at compile-time to catch
> various kinds of undefined behavior during program execution.
> 
> This patch implements support for UBSan to the DPDK.
> 
> See: doc/guides/prog_guide/ubsan.rst for more information.
> 
> Signed-off-by: Harman Kalra <hkalra@marvell.com>
> ---
> +ifeq ($(CONFIG_RTE_UBSAN),y)
> +ifeq ($(UBSAN_ENABLE),y)

This can be replaced with an oneline:

ifeq ($(CONFIG_RTE_UBSAN)$(UBSAN_ENABLE),yy)




  parent reply	other threads:[~2019-11-11  7:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-19 13:48 [dpdk-dev] [PATCH] mk: add support for UBSAN Harman Kalra
2019-09-13 11:40 ` Harman Kalra
2019-10-09 14:25   ` Harman Kalra
2019-10-28 10:50     ` Harman Kalra
2019-11-11  7:07 ` Thomas Monjalon [this message]
2019-11-15 14:46   ` [dpdk-dev] [EXT] " Harman Kalra
2019-11-15 14:54     ` [dpdk-dev] [PATCH v2] " Harman Kalra
2019-11-15 15:34       ` [dpdk-dev] [PATCH v3] " Harman Kalra
2019-11-27 14:23         ` Aaron Conole
2019-11-16  8:31     ` [dpdk-dev] [EXT] Re: [PATCH] " Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1638210.PZqRnmcaYt@xps \
    --to=thomas@monjalon.net \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=hkalra@marvell.com \
    --cc=john.mcnamara@intel.com \
    --cc=marko.kovacevic@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.